Commit Graph

527 Commits

Author SHA1 Message Date
Li Lin 6e718cffb1 Merge "Show Growth Framework nudge driven by nudge payload." into main 2025-04-28 17:01:20 -07:00
Li Lin 0f82810cdb Show Growth Framework nudge driven by nudge payload.
Current implementation of the nudge will show at default position
(bottom left corner) and may extended to other position in the future.
More detail at: go/al-growth-framework-nudge

Bug: 398033012
Test: NudgeControllerTest.*
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: Idff9d62a5b1b26aa1cfbef5817f5425f8e94b7c9
2025-04-28 13:59:30 -07:00
Shamali P fd57876c7c Move app timer in the taskContentView behind a refactor flag.
Bug: 405359383
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: Screenshot tests
Change-Id: Ib1cf21aabc8d01a14c0dedbfa770e9f0bba52268
2025-04-23 09:44:00 -07:00
Shamali P 3519785d79 Change task content view to be a constraint layout.
This is for child cl to be able to place dwb inline in it.

Bug: 405359383
Flag: com.android.launcher3.enable_refactor_task_content_view
Test: Screenshot tests
Change-Id: Id3252fff5776c199ae2a0c7e89d96c423241478c
2025-04-23 09:43:48 -07:00
Saumya Prakash 178b49beb3 Merge "Remove the skip button from the gesture tutorial" into main 2025-04-15 15:29:37 -07:00
Saumya Prakash ebfcad524b Remove the skip button from the gesture tutorial
This change removes the legacy skip button from the gesture tutorial. It
is not needed in the current version of the gesture tutorial.

Bug: 400485351
Test: Run tutorial and observe no change as this was for the legacy
tutorial that is no longer in use.
Flag: EXEMPT bugfix

Change-Id: Ice384a0b5811fdc0d09da58ade68539aa146d84d
2025-04-14 23:35:10 +00:00
Brandon Dayauon b570514ee0 Merge "Add nudgeView to Taskbar.xml" into main 2025-04-11 16:28:59 -07:00
Brandon Dayauon 1fc6f916d3 Add nudgeView to Taskbar.xml
Aiai will send a broadcast to Launcher and will animate the stashHandleView and nudgeView accordingly.
Verified on large screen device that transient taskbar is not affected as its not in scope at the moment.

bug:409121556
Test: manual - video in bug
Flag: com.android.launcher3.nudge_pill

Change-Id: I740e5d81dd008a230aa089f311d38bac665fc227
2025-04-11 13:24:22 -07:00
samcackett 2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Jordan Silva f99a50c2e4 Update Overview buttons styles and layout
This CL update the style of Overview Buttons to support Wallpaper Blur feature.
- Overview action button background, padding and spacing updated.
- Clear all button style updated to match action buttons.
- Select button drawable updated.

Bug: 404479758
Fix: 407665072
Flag: com.android.launcher3.enable_overview_desktop_tile_wallpaper_background
Test: OverviewImageTest
Change-Id: I89b781928c4b49155df9dfb5af5e81775ab5b87b
2025-04-02 11:59:25 -07:00
Jordan Silva 612aac88cb Update marquee to show only when chip is expanded
- Introduced title and titleCollapsed to change the text when expanded and collapsed using only 2 dots for truncate the text, similar to ellipsize="marquee".

- Removed ellipsize="marquee" from the XML to prevent chip relayout when entering in Overview. See b/406969521.

Fix: 406969521
Fix: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ia95eb8b7ec6d22b9d576defe7c66a4950ee1dca3
2025-03-28 14:28:54 -07:00
Jordan Silva 41992efa95 Merge "Center Task Menu icons and text vertically" into main 2025-03-26 08:40:16 -07:00
Jordan Silva 20dd848b29 Center Task Menu icons and text vertically
Bug: 403193877
Flag: EXEMPT bug fix
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: OverviewActionsMenuHoverImageTest
Change-Id: Idba732b64260e7e3e00d4742d2ea6ccd9228ab01
2025-03-26 05:23:31 -07:00
Jordan Silva f4b5725ef0 Merge "Add marquee for AppChip and simplify text view handling in IconAppChipView" into main 2025-03-26 04:28:26 -07:00
Li Lin 4a947f8209 Growth Framework nudge resource changes.
These resources changes will be used in a follow up CL that implement
the nudge view.

Note that most of the values and layout are temporarily placeholder and  subject
to change in follow up CL as the mock is being finalized.

Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
2025-03-25 19:58:52 -07:00
Jordan Silva 7e676c6a40 Add marquee for AppChip and simplify text view handling in IconAppChipView
- Consolidates the two TextViews (collapsed and expanded) in `IconAppChipView` into a single `appTitle` TextView.
- Updates the app name's width based on the current chip status (expanded/collapsed)
- Removes the `icon_text_collapsed` and `icon_text_expanded` from layout and uses only `icon_title`.
- Adds marquee support to handle text ellipsis in the collapsed state.
- Refactors text width calculation for collapsed state to take into account maximum available width.
- Updates text animations to use the new `appTitle`.
- Updates the maximum width to not be set to less than the min width.

Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ic82790d0a79b65adb7ba14dad7848748cd568f62
2025-03-25 20:31:28 +00:00
Shamali Patwa 15fa804ddf Merge "Add ViewStubs for DWB layouts to avoid duplicate views in refactor" into main 2025-03-25 06:38:42 -07:00
Shamali P 4ec89fbc63 Add ViewStubs for DWB layouts to avoid duplicate views in refactor
This CL just moves existing code to use view stubs. The refactor CLs
will use the flag to conditionally inflate these views.

Bug: 405359346
Fix: 405359346
Flag: EXEMPT refactor
Test: Existing screenshot tests and manual demo
Change-Id: Ib023d5f3538a0959a5965704a4ff18d769f8aa94
2025-03-21 16:26:07 -07:00
Alex Chau 77ddc254cc Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
This reverts commit e0cc96df62.

Reason for revert: b/403826044, b/402277471

Flag: EXEMPT revert

Change-Id: I0c6e507753bf47be4f74b6056de75d981f0c2848
2025-03-20 04:45:52 -07:00
Alex Chau 7034889756 Revert "Remove redundant FrameLayout from task_header_view.xml"
Revert submission 32215257-b/401469907-remove-redundant-headerview-layout

Reason for revert: b/403826044, b/402277471

Reverted changes: /q/submissionid:32215257-b/401469907-remove-redundant-headerview-layout

Change-Id: I5c619179c849f8b65484937ed0c37623612316f8
2025-03-20 11:11:00 +00:00
Priyanka Advani (xWF) 92aef0d99a Revert^3 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bca368924c.

Reason for revert: Droidmonitor created revert due to b/404894013. Will be verifying through ABTD before submission.

Change-Id: If43e23bca9f7e62f26ee3c977cac643fcda3e3e6
2025-03-19 12:56:55 -07:00
Sam Cackett bca368924c Revert^2 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit 1048b2711c.

Reason for revert: Reland CL with fix

Original message:
Inflate TaskThumbnailViewDeprecated as TaskContentView

If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Bug: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug

Change-Id: Ib43331023d99316c7b0c9de2ab81e379db58bb50
2025-03-19 10:05:25 -07:00
Treehugger Robot 6fcd77c19a Merge "Update KQS task view borders" into main 2025-03-12 12:21:08 -07:00
Treehugger Robot f0e0e8b7ec Merge "Remove redundant FrameLayout from task_header_view.xml" into main 2025-03-12 11:31:52 -07:00
Jordan Silva 99eefc9055 Add keyboard navigation for App Chip and Chip Menu
Bug: 400410772
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB.
Change-Id: I75f80b5c6f366ecfc27596519a721cc6ace18d45
2025-03-12 07:55:04 -07:00
Toni Barzic 94db320a84 Update KQS task view borders
Updates border color to have more contrast to the background, and adds
2dp padding between the border and the task content view - done by
updating BorderAnimator not to assume the border width and stroke are
the same.

Adding padding between the border and task view content exopsed an issue
where the second thumbnail in a split task's borders were not clipped
correctly when adding a border (it looked like the clip rect was not
properly scaled down). This is addressed by moving the tack view
background (and the outline) from the root KeyboardQuickSwitchTaskViews
to the content views (i.e. moving the outline to the view that does not
get scaled when adding a border, and having the second thumbnail end
edge of the clip rectangle match the clip rectangle of the clipped
ancestor view).

Bug: 398770098
Test: Manual
Flag: EXEMPT (a11y) bug fix

Change-Id: Ie058c932411a6b47815b0abf756f739c55b8342f
2025-03-11 22:00:59 +00:00
Jordan Silva afff31deb3 Merge "Add hover and pressed states for app chip and menu items" into main 2025-03-11 10:27:51 -07:00
samcackett d88fb62c4d Remove redundant FrameLayout from task_header_view.xml
Move feature flag logic to the state mapper

Fix: 401469907
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest
Change-Id: Ic6ee5bef438ae2782816f526b003e1fb91992065
2025-03-11 16:49:52 +00:00
Jordan Silva 38af4f71c7 Add hover and pressed states for app chip and menu items
Fix: 356830855
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewActionsMenuHoverImageTest
Change-Id: I3a244a4eea07192a622c57d28618dabbb107a088
2025-03-11 05:37:43 -07:00
Toni Barzic 394d5e0010 Improve KQS accessibility
Adds accessible pane name, and content description for keyboard quick
switch view. Improves content description for task views, by having it
provide the task position in the task list. Also, sets a task content
description immediately when it gets associated with a task, even if the
task description is not available at the time. Accessibility focus for a
task may be requested as the KQS view is shown, so the task view should
have a meaningful content description from the start.

While here, update KQS to focus first task  by default when opened from
taskbar.

Bug: 399032757
Test: Manual, with Talkback enabled - open KQS via taskbar overflow view,
      and Alt+Tab, and verify Talkback announcements are informative
      (e.g. no "Pixel launcher" utterance).
      Also atest NexusLauncherTests:TaplTestsKeyboardQuickSwitch
Flag: EXEMPT bug fix

Change-Id: I3688954ab383035c1db35c5eb7a0ddf9a39a123f
2025-03-10 17:35:04 +00:00
Treehugger Robot 6b9b5b54c4 Merge "Fix gesture nav tutorial done button focus issue" into main 2025-03-07 09:45:42 -08:00
Jordan Silva 75395e3425 Merge "Fix TaskMenuView bottom row divider and translation." into main 2025-03-07 06:12:57 -08:00
Jordan Silva 65aff4c6bb Fix TaskMenuView bottom row divider and translation.
Adjusts the positioning logic for the task menu when displayed for tasks on the bottom row of the grid. The changes ensure the menu is visible and does not overlap with other UI elements, such as the taskbar. It defines min and max bounds of the menu when it's opened on bottom row. It also moves the menu on top of the taskbar.

A follow-up CL will manage the max height to make the bottom row menu scrollable.

Fix: 322953749
Bug: 326952853
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I44fb70d8537c0b52af4314e818d02ccfcd35d8d3
2025-03-07 11:31:20 +00:00
Schneider Victor-Tulias aeb8831239 Fix gesture nav tutorial done button focus issue
Flag: EXEMPT bug fix
Fixes: 400888489
Test: launches and completed tutorial with and without talkback
Change-Id: I5ec1fc6b812667c79136e82a8553e4b857200cdb
2025-03-06 15:16:42 -05:00
Treehugger Robot 872ef49247 Merge "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" into main 2025-03-06 03:37:25 -08:00
Saumya Prakash f979f6518b Merge "Remove the step indicator for the gesture tutorial" into main 2025-03-04 09:32:41 -08:00
Treehugger Robot 51a3a87b14 Merge "Arrows to scroll recent tasks in KQS" into main 2025-03-03 16:44:25 -08:00
Saumya Prakash 6a32cf392b Remove the step indicator for the gesture tutorial
This change removes the pill indicator for the legacy gesture navigation
tutorial. It causes accessibility issues and is not needed for the current version
of the gesture tutorial.

Fix: 378415116
Bug: 400485351
Test: Run tutorial and observe no more indicator for the steps
Flag: EXEMPT bugfix
Change-Id: I33c3d7131752c2118ef03bf7d76389e855b836f4
2025-03-03 23:10:29 +00:00
Toni Barzic 8ca3eaa345 Arrows to scroll recent tasks in KQS
Bug: 397878339
Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: Enter taskbar overflow, and open the overflow view.
    Verify that arrow buttons are present; tapping them scrolls in the
    correct direction; when fully scrolled in a direction, the
    associated arrow button is disabled; verify arrow buttons have hover
    effects.
    Open Alt+Tab view, verify no buttons are present if the view cannot
    be scrolled (and present if the view can be scrolled).

Change-Id: Id1c37a2967a629aeb4b3cc2dc5ff7efb21c90cbe
2025-02-28 19:49:50 +00:00
Sam Cackett e0cc96df62 Add TaskContentView parent to TaskThumbnailViewHeader and TTV
- Add TaskContentView parent view
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

Bug: 397889146
Flag: EXEMPT. Refactor
Test: Refactoring CL. Existing unit tests still pass.

Change-Id: Ie31f35c6617aab272f984a6beb3e4cb8f58e3ce9
2025-02-28 12:19:26 +00:00
Saumya Prakash a368becdfb Merge "Ensure Talkback announces text correctly in Gesture tutorial" into main 2025-02-26 11:21:39 -08:00
Saumya Prakash 3fe4e7d90f Ensure Talkback announces text correctly in Gesture tutorial
This change modifies how Talkback announces the title and the subtitle
in the gesture navigation tutorial. It no longer shifts the focus to the
subtitle, but instead makes the whole window focusable.

Fix: 386884587
Test: Open the gesture tutorial with talkback and ensure the text is
announced without change of focus. Ensure the Done button doesn't get
announced
Flag: EXEMPT bugfix

Change-Id: Id28382acbebe763f2f64f4e49eb00d6ea61e0553
2025-02-26 05:47:34 +00:00
Schneider Victor-tulias 6040a652a6 Merge "Respect accessibility animation guidelines in AllSetActivity" into main 2025-02-24 13:30:10 -08:00
Schneider Victor-Tulias de841f6092 Respect accessibility animation guidelines in AllSetActivity
- Disabling the background animation if the user has opted out
- Allow the user to pause/resume the animation

Flag: EXEMPT bug fix
Fixes: 386743741
Test: launched AllSetActivity with animations on/off; tapped screen in both cases
Change-Id: I2bdbef24d6c582b4229441149fffcb67ba488882
2025-02-24 10:00:32 -08:00
Xiaoqian Dai 6aca9bedd5 desktop-exploded-view: Implement the close button and its behavior
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual + newly added tapl tests in a following CL
Bug: 353965691

Change-Id: Iba4603b84928885b1d50f5551adbacbd31e98cc3
2025-02-21 22:23:41 +00:00
Jordan Silva 7c1e78acef Fix cropping app chip text with largest display and font size
Bug: 313648249
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Change-Id: I724c09647694214d59713d57269dc9378c01dc96
2025-02-19 16:16:20 +00:00
Saumya Prakash e6036ab358 Update Taskbar edu with new font style
This change applies the new expressive font style if the expressive
theme is enabled. Screenshots are available in the bug

Fix: 393610004
Test: Check that the fonts change when the expresssive theme is enabled
Flag: com.android.launcher3.expressive_theme_in_taskbar_and_navigation
Change-Id: I5fa34ab08486c7fdeb37ccd9afeda77b577a9404
2025-02-14 23:32:36 +00:00
Schneider Victor-Tulias 0ae28ca5d0 Update KQS text font family to match new specs
Flag: com.android.launcher3.expressive_theme_in_taskbar_and_navigation
Fixes: 393615634
Test: opened KQS, be before/after in bug
Change-Id: Ia953e2b927b6e69c0c150df01925436b6247d751
2025-02-14 10:49:30 -05:00
minch b39d3015f8 Make AddDesktopButton can be navigated to through keys
Add the focus outline to the button as well.
Same color, ripple effect as the ClearAllButton is applied.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug:391875235
Test: TaskGridNavHelperTest
Change-Id: If93f86a1dce4df8ee6b1c50dfc44092dad2eafab
2025-02-07 18:33:23 +00:00
minch fb2e514de8 Initial implementation of the AddDesktopButton
Add the AddDesktopButton to the view hierarchy behind the flags.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug: 382057498
Test: Manual
Change-Id: I5748d8c18d8f5204fa1fb0717c4a8098bfde1537
2025-01-15 18:42:18 +00:00