Commit Graph

16358 Commits

Author SHA1 Message Date
Jeremy Sim 6e0f34cc0a Merge "App Pairs (behind flag): Add new ItemInfo types and DB save functionality" into udc-dev 2023-04-22 03:21:17 +00:00
Jeremy Sim 7cf0dd9e03 App Pairs (behind flag): Add new ItemInfo types and DB save functionality
This is the second of several patches implementing the App Pairs feature behind a flag.

This patch includes:
- AppPairsController, a new controller that will handle creation, launching, and deletion of app pairs
- ITEM_TYPE_APP_PAIR is a new type of FolderInfo (FolderInfo now can be either a folder or an app pair, and should probably be renamed to CollectionInfo or something more generic in future)
- Necessary plumbing for these new types
- Database code that handles saving a new app pair to the database with the correct schema

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: Not included in this CL, but will follow
Change-Id: Ie3aefd4eb9171f471789f54876de742849d3013b
2023-04-21 14:23:54 -07:00
Fengjiang Li 5068718fe8 Merge "Check build version before using predicitve back API" into udc-dev 2023-04-21 20:22:09 +00:00
Holly Jiuyu Sun 7c836923b9 Merge "Override INTERPOLATOR_WITHIN_ALL_APPS when app restarts." into udc-dev 2023-04-21 17:13:03 +00:00
Fengjiang Li d0c2359a49 Check build version before using predicitve back API
Test: build and run app
Fix: 278798546
Change-Id: I4a7b226b1d710cc84ef40b59a33f50a84aca84bb
2023-04-21 09:38:59 -07:00
Jagrut Desai 64b79a9fad Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev 2023-04-21 16:15:07 +00:00
Jagrut Desai c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
Presubmit Automerger Backend cc471ee2ee [automerge] Clear Accessibility Focus from icon after Shorcut Menu invoked 2p: cb582591b3 am: 5ab41346d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: I16a861cfa872f928c5e4414a9f0ecdceacf1f325
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 03:57:05 +00:00
Andrew Cole 0d775d3508 Merge "Unit testing ButtonDropTarget" into udc-dev 2023-04-20 23:35:49 +00:00
Presubmit Automerger Backend 5ab41346d8 [automerge] Clear Accessibility Focus from icon after Shorcut Menu invoked 2p: cb582591b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: Ib5981d226c7cabe8e302c108b198c3fb657f3812
2023-04-20 23:21:40 +00:00
Jon Miranda cb582591b3 Clear Accessibility Focus from icon after Shorcut Menu invoked
Similar to I2726504094af2abacf1c41089c7bcd4efb588099

Fixes: 267695526
Test: have talkback on
      open all apps
      open long press menu
      ensure focus stays on pop up menu

Change-Id: I38f78df3855495c53a5ae8966e9a996e4679e95b
2023-04-20 16:21:02 -07:00
Andrew Cole 44898c3db4 Unit testing ButtonDropTarget
Originally there was a bug in a method (isTextClippedVertically) in ButtonDropTarget. While attempting to write a unit test it became necessary to refactor ButtonDropTarget and DeleteDropTarget to decouple them from their dependency on launcher in order to allow for a unit test to be written

The pattern we are introducing here is to decouple Launcher from a controller, in order to facilitate easier testing.
Instead of calling Launcher.getLauncher() we call the method through ActivityContext, which has a testing wrapper already defined. Here is a diagram that explains the old and new pattern

Design Pattern: https://screenshot.googleplex.com/7apiE2DaGDrFzy9.png

Test: isTextClippedVerticallyTest
Bug: b/274402490

Change-Id: I1f3003d0b62dddbceb6e492b15aa5d7352d3a293
2023-04-20 11:22:27 -07:00
Schneider Victor-tulias 1f587dec84 Merge "Sort FeatureFlags by assigne LDAP" into udc-dev 2023-04-20 17:30:46 +00:00
Brandon Dayauon e16a595626 Merge "Fix two line item of app-title only in A-Z list and not predicted app row" into udc-dev 2023-04-20 16:59:10 +00:00
Brandon Dayauon 7d67331c72 Fix two line item of app-title only in A-Z list and not predicted app row
Create protected method that would be overidden if two lines should be supported

bug: 274686392
test: manual
Change-Id: I34bbd9980aee70397ee75744bedfa61c340a2741
2023-04-19 15:15:16 -07:00
Schneider Victor-tulias ecaba5abf1 Sort FeatureFlags by assigne LDAP
Sorted FeatureFlgags by assigne LDAP to help prevent future merge conflicts.

Flag: not needed
Bug: 278771275
Test: ran launcher
Change-Id: Ib7f5276e8b943cf50c438c49e019cd31deea6674
2023-04-19 10:02:30 -07:00
Vinit Nayak b642666e72 Merge "Add logs for work tab missing" into udc-dev 2023-04-19 03:34:39 +00:00
Vinit Nayak f89438718f Add logs for work tab missing
* Start tracing where launcher goes after
it gets the broadcast for new work profile user
unlocked

Bug: 243688989
Flag: None
Change-Id: I53ccab743ac5dd2aee6b7ff6e440bcf731387119
2023-04-18 13:57:33 -07:00
Jagrut Desai 52a7798bbe Merge "Refactoring instance variable for ArrowPopup.java" into udc-dev 2023-04-18 16:03:33 +00:00
Federico Baron b167b59697 Merge "Fix progress and plate width for download app" into udc-dev 2023-04-17 23:23:03 +00:00
Sunny Goyal c3cca79545 Merge "Moving ModelDbController from LauncehrProvider to LauncherModel" into udc-dev 2023-04-17 22:11:28 +00:00
Pat Manning ffff442ed5 Merge "Add feature flag for cursor hover states in Launcher." into udc-dev 2023-04-17 21:45:55 +00:00
fbaron 28ad76fb64 Fix progress and plate width for download app
It looks like the plate width wasn't quite right as it's supposed to be half the width of the progress bar width. This should fix that.

Bug: 267272201
Test: Verify that the download app ux matches spec in bug
Change-Id: Ifbcb1e2d31cd8d9c20a69e8c64104198563f7cf9
2023-04-15 04:34:34 +00:00
Jagrut Desai 282f093533 Refactoring instance variable for ArrowPopup.java
refactoring naming for instance variables to be more in sync with java codestyle

Test: presubmit
Bug: 278291850
Flag: not needed
Change-Id: I24eb1433941b44404871b305acf0d2d145662080
2023-04-14 16:08:52 -07:00
Sunny Goyal ce953a36ec Moving ModelDbController from LauncehrProvider to LauncherModel
Migrating some of the class to use the controller directly, will
update the remaining calls in follow up cls

Bug: 277345535
Test: Presubmit
Change-Id: I8edc7c43665f94702ac64bd92932d6c94cb544a4
2023-04-14 14:13:17 -07:00
Federico Baron 087bf95bb6 Merge changes Ic4c5cd96,I2cc2417f into udc-dev
* changes:
  Turn on flag for download app ux V3
  Improve color, contrast, and dimensions to match new spec for download icon
2023-04-14 18:14:49 +00:00
Sunny Goyal 348e518b2c Merge "Using a runtime generated layout for tests instead of defining xml" into udc-dev 2023-04-14 18:12:57 +00:00
Pat Manning 56df78ab1a Add feature flag for cursor hover states in Launcher.
Bug: 243191650
Test: manual.
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ibf8e62c3f3e03b9391a87af4f18f3843252c57bf
2023-04-14 14:14:22 +01:00
fbaron ff8b89cea4 Turn on flag for download app ux V3
Bug: 267272201
Test: Verify that when the flag is on the new app download animation is visible
Change-Id: Ic4c5cd9678d6eb5dd9d66114e82eb9d93d48fd46
2023-04-13 23:53:20 +00:00
Federico Baron 4ba9c11568 Improve color, contrast, and dimensions to match new spec for download icon
Here we update the values to the correct HCT values according to the specs, as well as the size of the icon

Bug: 267272201
Test: Turn on flag ENABLE_DOWNLOAD_APP_UX_V3 and download an app to see the changes.
Change-Id: I2cc2417f7500c4c08c41056bfeef3c33f4eab174
2023-04-13 23:53:20 +00:00
Stefan Andonian 4c28cd49ca Merge "Make all debug feature flags boot aware." into udc-dev 2023-04-13 22:05:36 +00:00
Sunny Goyal 94a8a8aa06 Merge "Removing remaining code around ENABLE_DATABASE_RESTORE" into udc-dev 2023-04-13 19:51:04 +00:00
Fengjiang Li d4c5fe8543 Merge "Add COLD_DEVICE_REBOOTING LatencyType" into udc-dev 2023-04-13 18:18:27 +00:00
Fengjiang Li 435f1e2e08 Add COLD_DEVICE_REBOOTING LatencyType
Since launcher COLD startup latency is drastically different when device is rebooting vs not, we will add COLD_DEVICE_REBOOTING LatencyType

See "Add Startup Latency Type" section in go/launcher-startup-latency

Bug: b/277962421
Test: app build
Change-Id: I4d0a22c105417b5bcdbae9ed9fc72aa927f9adc9
2023-04-13 09:19:04 -07:00
Fengjiang Li 5d4207814e Merge "Gracefully handle exception when processing widget loads event while device is locked." into udc-dev 2023-04-13 16:01:37 +00:00
Brian Isganitis 804107b058 Merge "Define type set for taskbar overlays." into udc-dev 2023-04-13 14:21:37 +00:00
Sunny Goyal ab2f808196 Using a runtime generated layout for tests instead of defining xml
This allows support for easily setting up default layouts

Bug: 277345535
Test: Presubmit
Flag: N/A
Change-Id: I1c089d60ac3f8add8d7e1060d343e04d30afe094
2023-04-12 22:54:14 +00:00
Sunny Goyal eb27546cc3 Removing remaining code around ENABLE_DATABASE_RESTORE
ENABLE_DATABASE_RESTORE feature is already removed
Also migrating some tests from BackupRestoreTest to RestoreDbTaskTest

Bug: 270392706
Test: Presubmit
Flag: N/A
Change-Id: I71822bbc2232008b3d2b4b9fbed0db5d889591e4
2023-04-12 15:52:35 -07:00
Fengjiang Li e82b3fa8df Gracefully handle exception when processing widget loads event while device is locked.
Bug: 277189566
Test: test starting launcher and editing widgets
Change-Id: Id15da3f3471374b02f1e2bf2e0a45dc801957241
2023-04-12 14:46:47 -07:00
Federico Baron 65795b090e Merge "Add entry point for home gardening" into udc-dev 2023-04-12 21:24:48 +00:00
Stefan Andonian 85f1024f44 Make all debug feature flags boot aware.
Bug: 276090194
Test: FeatureFlags worked on device.
Change-Id: I710801d63e6f4283bf15daea2b5be5874de21cc8
2023-04-12 21:02:13 +00:00
Sunny Goyal bfb24c7706 Merge "Moving all DB management logic from LauncherProvider into a separate class" into udc-dev 2023-04-12 20:19:54 +00:00
Brian Isganitis e41faf5f48 Define type set for taskbar overlays.
Test: Manual
Bug: 216683257
Change-Id: Iabb997ec4eba0fa105b8518c8c31285ae9c35450
2023-04-12 14:16:25 -04:00
fbaron 6847c9f113 Add entry point for home gardening
Bug: 277817921
Test: Turn on flag MULTI_SELECT_EDIT_MODE and verify that a new button shows up that says "Edit Home Screen"
Change-Id: Ic8027ab80604faf5bdc63a44319ecffc047a495c
2023-04-12 09:31:28 -07:00
Andy Wickham ea3a3619bf Merge "Fix single frame flicker for views reacting to keyboard insets." into udc-dev 2023-04-12 00:08:06 +00:00
Federico Baron d9a38b8d0e Merge "Remove unused code for old mult select design" into udc-dev 2023-04-11 21:20:55 +00:00
Federico Baron b326859f27 Merge "Prevent two pane widget picker code from reaching foldables" into udc-dev 2023-04-11 21:10:56 +00:00
Andy Wickham 21d857a21f Fix single frame flicker for views reacting to keyboard insets.
This includes Folders, bottom apps searchbar, work apps button.

The issue is that the view was being drawn between onStart and
onProgress. Before onStart is called, the final keyboard insets
are dispatched to determine the view's final state, so this draw
captured this otherwise invisible state. Normally, onProgress
would be called first, effectively resetting the view; but for
example, the transition from closing the apps drawer forces a
draw prematurely.

Fix: 265830720
Test: Manual
Flag: N/A, but improves the ENABLE_FLOATING_SEARCH_BAR flag.
Change-Id: I818cb75628dec6dcc69e5f4b8ae554c2245dceca
2023-04-11 12:27:17 -07:00
Sunny Goyal 1ae46ca868 Moving all DB management logic from LauncherProvider into a separate class
This would make it easier to move the controller to LauncherModel

Bug: 277345535
Test: Presubmit
Flag: N/A
Change-Id: I4d044cf41361f400968ef65e18de5d3976fcdec7
2023-04-11 11:46:40 -07:00
fbaron e74256bba8 Remove unused code for old mult select design
We previously made a few CL's guarded under flags for the multi select feature. We ended up having to halt progress on this, and now that we're starting again, the design is different and we are using a new flag. Here we get rid of the unused code and flags

Bug: 277617038
Test: Verify everything still works normally, everything was guarded under flags that were off so there shouldn't be any changes
Change-Id: I2f57d1f67aa2a8cf83287f6f3df9fa6c46dbf0ab
2023-04-10 14:55:41 -07:00