Now we base it on the current tappableElement insets, which will only be
> 0 for the unstashed, persistent taskbar which draws rounded corners.
This inset also stays stable during temporary stash transitions such as
when the IME is showing.
Flag: ENABLE_TRANSIENT_TASKBAR=true, ENABLE_TASKBAR_PINNING=true
Test: in split screen for both transient and pinned (persistent)
taskbar, ensure split screen divider bottom is drawn appropriately
Fixes: 278028503
Change-Id: Iab56c5dc8f9fc81c34aa01f41b5212dd5c6fd7f0
This is the second of several patches implementing the App Pairs feature behind a flag.
This patch includes:
- AppPairsController, a new controller that will handle creation, launching, and deletion of app pairs
- ITEM_TYPE_APP_PAIR is a new type of FolderInfo (FolderInfo now can be either a folder or an app pair, and should probably be renamed to CollectionInfo or something more generic in future)
- Necessary plumbing for these new types
- Database code that handles saving a new app pair to the database with the correct schema
Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: Not included in this CL, but will follow
Change-Id: Ie3aefd4eb9171f471789f54876de742849d3013b
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.
Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
Similar to I2726504094af2abacf1c41089c7bcd4efb588099
Fixes: 267695526
Test: have talkback on
open all apps
open long press menu
ensure focus stays on pop up menu
Change-Id: I38f78df3855495c53a5ae8966e9a996e4679e95b
This help to find a test which bugreport may still contain a recent crash in SysUI. This is the tests that prints "for the first time = true"
Test: presubmit
Bug: 187761685
Change-Id: Ic24a1d6f4ba36e117df2166c57bbc0a1d021cc7d
Originally there was a bug in a method (isTextClippedVertically) in ButtonDropTarget. While attempting to write a unit test it became necessary to refactor ButtonDropTarget and DeleteDropTarget to decouple them from their dependency on launcher in order to allow for a unit test to be written
The pattern we are introducing here is to decouple Launcher from a controller, in order to facilitate easier testing.
Instead of calling Launcher.getLauncher() we call the method through ActivityContext, which has a testing wrapper already defined. Here is a diagram that explains the old and new pattern
Design Pattern: https://screenshot.googleplex.com/7apiE2DaGDrFzy9.png
Test: isTextClippedVerticallyTest
Bug: b/274402490
Change-Id: I1f3003d0b62dddbceb6e492b15aa5d7352d3a293
Since there is nothing async about it's implementation.
Test: Since it's a name change compilation is the only test needed.
Bug: 278976890
Change-Id: I0057be3c25c3ec80054d3830fe706ec8f9995ea7
Showing the animation leash of appearedTaskTargets if there need to
play the reveal animation behind splash screen view.
Pausing applyDepthAndBlur while playing splash screen exit animation
from launcher side, otherwise the app window would be blurred.
Bug: 277704255
Test: manual, do quickswitch to start the app behind splash screen
view, verify no flicker or blur happen when playing reveal animation.
Change-Id: I83604ceeaeb54ab2100fdabf45a1624644b85e37
Fixes: 270211015
Test: 3-finger swipe down to bring down notifications. 3-finger swipe up to go home / to Overview
Change-Id: Id0f8ad95d9a4a1f8ecf1632ea28efb0c790c291b
- If launcher repeatedly starts the recents animation, we try to finish
the existing animation before starting the new one, but due to some
ordering issues (see b/275561141) the subsequent starts can orphan
the previous animation runner, which can result in no animation callbacks
for either the previous animation (to cancel) or the new animation
(to start).
This change only attempts to reduce the likelihood of a second no-op
transition by synchronously finishing the existing recents animation
on the launcher side prior to starting the next animation.
There is one case this doesn't handle, where if the previous
onAnimationStart() has not been called back, then we can't directly
call the controller to finish, and need to rely on the no-op handling
on the shell transition side to handle the gesture.
Bug: 275561141
Test: Quickswitch and swipe up repeatedly
Change-Id: I820e26dc20fb1851ee0102ed8c114ce998d44999
Create protected method that would be overidden if two lines should be supported
bug: 274686392
test: manual
Change-Id: I34bbd9980aee70397ee75744bedfa61c340a2741
Sorted FeatureFlgags by assigne LDAP to help prevent future merge conflicts.
Flag: not needed
Bug: 278771275
Test: ran launcher
Change-Id: Ib7f5276e8b943cf50c438c49e019cd31deea6674
Tony Wickham
Jagrut Desai
Bill Yi
Liana Kazanova
Vinit Nayak
Jeremy Sim
Fengjiang Li
Vadim Tryshev
Andrew Cole
Holly Jiuyu Sun
Kateryna Ivanova
Andreas Agvard
Wei Sheng Shih
Jon Miranda
Presubmit Automerger Backend
Tracy Zhou
Schneider Victor-tulias
Brandon Dayauon
Winson Chung
Sebastián Franco
Federico Baron
