Commit Graph

1593 Commits

Author SHA1 Message Date
Tony Wickham 3cfada0a00 Simplify/correct Taskbar insetsRoundedCornerFrame calculation
Now we base it on the current tappableElement insets, which will only be
> 0 for the unstashed, persistent taskbar which draws rounded corners.
This inset also stays stable during temporary stash transitions such as
when the IME is showing.

Flag: ENABLE_TRANSIENT_TASKBAR=true, ENABLE_TASKBAR_PINNING=true
Test: in split screen for both transient and pinned (persistent)
taskbar, ensure split screen divider bottom is drawn appropriately
Fixes: 278028503

Change-Id: Iab56c5dc8f9fc81c34aa01f41b5212dd5c6fd7f0
2023-04-28 23:51:41 +00:00
Liana Kazanova a6a0867b65 Merge "Revert "Introduce library for public animation APIs"" into udc-dev 2023-04-24 17:58:45 +00:00
Liana Kazanova af289a1cd1 Revert "Introduce library for public animation APIs"
Revert submission 22740447-animation-library

Reason for revert: b/279195827

Reverted changes: /q/submissionid:22740447-animation-library

Change-Id: Ie2ef34f8bdb3076a015d91742be041c7c9ade8a2
2023-04-21 19:14:23 +00:00
Jagrut Desai 64b79a9fad Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev 2023-04-21 16:15:07 +00:00
Kateryna Ivanova 2d6a8e3a87 Introduce library for public animation APIs
* Add a public library
* Pull Interpolators implementation from systemui animation library
* migrate existing usages of Interpolators

Test: n/a
Bug: 271850966
Change-Id: I3f941423b76f555b2c1e7205e23d5ff9ad95d413
2023-04-21 08:06:47 +00:00
Jagrut Desai c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
Schneider Victor-tulias 7da60438a3 Merge "Update the BorderAnimator" into udc-dev 2023-04-20 19:59:44 +00:00
Jon Miranda 5c18fa35b2 Merge "Remove ActivityInfo.CONFIG_SCREEN_SIZE if orientation is still the same." into udc-dev 2023-04-19 18:04:27 +00:00
Mady Mellor 98add1c524 Merge "Creates BubbleStashController & BubbleStashedHandleViewController" into udc-dev 2023-04-19 16:31:37 +00:00
Brian Isganitis 91b0e2d6d1 Merge "Properly compute scroll for Taskbar All Apps." into udc-dev 2023-04-19 14:36:21 +00:00
Mady Mellor 14e53a6b2e Creates BubbleStashController & BubbleStashedHandleViewController
Adds two controllers to manage and animate the stash / unstash state
of the bubble bar. Adds them to BubbleControllers.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I1a67da888384b1ae0fe3f79a25ea6a2c1b7eef87
2023-04-18 16:46:02 -07:00
Mady Mellor 3e3d3e78a0 Merge "Creates BubbleBarView & BubbleBarViewController & friends" into udc-dev 2023-04-18 20:35:17 +00:00
Schneider Victor-tulias 394c114d15 Merge "Update the All set page lottie animation to use dynamic colors" into udc-dev 2023-04-18 20:14:09 +00:00
Schneider Victor-tulias 5e68914621 Update the BorderAnimator
Updated the BorderAnimator to allow it to animate the border outside the view's bounds. This makes it match the specs and makes it more compatible with other animations.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Test: tried keyboard quick switching on a handheld, foldable and tablet
Fixes: 276336349
Change-Id: I025f8b0f431e78bcb5c7b4b3859a7d6dde5da600
2023-04-18 20:12:59 +00:00
Jon Miranda 59d1214798 Remove ActivityInfo.CONFIG_SCREEN_SIZE if orientation is still the same.
Avoid NPE to unblock development while we investigate root cause.

Bug: 274394837
Test: see repo steps in bug comment #11
Change-Id: Ib18aa9da1d2827ae03037215ff9e34d27493995b
Flag: ENABLE_TRANSIENT_TASKBAR true
2023-04-18 19:38:53 +00:00
Vinit Nayak b0f1da28fe Merge "Prevent taskbar on phone from crashing" into udc-dev 2023-04-18 00:49:48 +00:00
Mady Mellor 55913d53c6 Creates BubbleBarView & BubbleBarViewController & friends
BubbleBarView shows BubbleViews in a bar similar to transient
taskbar. BubbleBarView can be collapsed (bubbles in a stack) or
expanded (bubbles all visible). When expanded, WMShell will be
notified to show the appropriate expanded bubble view (not part of
this CL).

Also creates BubbleControllers which contains BubbleBarViewController
and will eventually contain other controllers related to stashing
for the bubble bar.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I990ab3da6614db90ffff8c40281dc7f16b3957f6
2023-04-17 16:36:28 -07:00
Brian Isganitis 5bf0806768 Merge "Update notification dots in Taskbar All Apps." into udc-dev 2023-04-17 21:22:29 +00:00
Brian Isganitis 01be7eeb57 Properly compute scroll for Taskbar All Apps.
It was hooked up to Launcher All Apps scroll, which is a separate
instance from Taskbar.

Test: atest WMShellFlickerTests
Fix: 270770472
Change-Id: I14b11c8b5f1143886dd5976a12bba9e4ee66aa96
2023-04-17 18:19:54 +00:00
Schneider Victor-tulias 5285763d99 Update the All set page lottie animation to use dynamic colors
Flag: not needed
Fixes: 263088674
Test: Launched the All set page on handheld, foldable and tablet
Change-Id: I5c742985c3fcce32742553f0ab5d237c1a77f991
2023-04-17 09:45:52 -07:00
Tiger Huang e67092ee1b Merge "Always suppress scrim for taskbar" into udc-dev 2023-04-14 10:34:09 +00:00
Mike Schneider 45894db9d5 Merge "Revert ag/22195243 and solve the initialization issue it was supposed to fix differently" into udc-dev 2023-04-14 06:35:57 +00:00
Vinit Nayak f00760ac23 Prevent taskbar on phone from crashing
* Update code behind flag to work with transient taskbar
* We explicitly set the mDestroyed flag to false in
TaskbarActivityContext because it gets set to true when
the flag is on, but nothing resets it unless it gets
recreated normally.

Bug: 274517647
Flag: persist.wm.debug.hide_navbar_window
Test: Enable flag and verify no crash
Change-Id: I9a149ffb47a10efedfc9dff8399d12d4c1a31553
2023-04-13 14:33:17 -07:00
Jon Miranda e60bea51e3 Merge changes from topics "presubmit-am-0ed6d9a2502540239b46d7d3573bd44e", "presubmit-am-7a77b5bffdb04bf38bcec9ec17d4d6ee" into tm-qpr-dev am: f583786984 am: d6fe892f4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22603500

Change-Id: I25422fb8cfd3ec7b992186477cf6b9fc6c2d028f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-13 20:25:49 +00:00
Jon Miranda d6fe892f4c Merge changes from topics "presubmit-am-0ed6d9a2502540239b46d7d3573bd44e", "presubmit-am-7a77b5bffdb04bf38bcec9ec17d4d6ee" into tm-qpr-dev am: f583786984
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22603500

Change-Id: Iea9d0c287c3acd640467f4cd0430dbad031e39df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-13 20:11:52 +00:00
Jon Miranda 8cf1e75ab8 Merge changes from topic "presubmit-am-7a77b5bffdb04bf38bcec9ec17d4d6ee" into tm-qpr-dev-plus-aosp am: 5523175f13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22598537

Change-Id: I651b3a3fb06e9e4ee96266b0c1345b79cf958892
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-13 20:10:08 +00:00
Tiger 5624523835 Always suppress scrim for taskbar
Taskbar never needs a semi-transparent scrim drawn by the decor view at
the insets area, because taskbar has the background color on its own if
needed.

Bug: 197615177
Test: SystemUIGoogleBiometricsScreenshotTests
Change-Id: Ic49c8af3ecbefcc83d1bd987812625c7e2f37157
2023-04-13 12:32:02 +00:00
Mike Schneider 593ff77267 Revert ag/22195243 and solve the initialization issue it was supposed to fix differently
The fix caused a flicker tests to fail, but that is specific to the persistent taskbar used in tests only.

Bug: 277470898
Bug: 277003116
Fixed: 277470898
Fixed: 277003116

Test: Flicker tests passes
Test: Manual (http://shortn/_kiAZykhZsp)
Test: Tapl presubmit tests
Change-Id: Ib9daebf3b06af2f1a4a3b7461acf91f204ff281b
2023-04-13 11:37:39 +00:00
Jon Miranda c9a4c1ceae Revert "Allow user gesture to take priority over taskbar translation reset animnatiuon."
This reverts commit 41b580bc63.

Bug: 277942460
Test: tablet/foldable device
      check taskbar animation b/w states and during drag
Change-Id: Ib8b362102d08d155d3153b652db47364feb5df0a
2023-04-12 13:31:41 -07:00
Presubmit Automerger Backend 8fa4d62079 [automerge] Revert "Fix bug where taskbar is translated during hotseat handoff." 2p: fa8cc97e5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22598537

Bug: 277942460
Change-Id: Ic7f1dc9e7c76e0028dd7d85729882bc277e5b50a
2023-04-12 20:29:15 +00:00
Jon Miranda fa8cc97e5f Revert "Fix bug where taskbar is translated during hotseat handoff."
This reverts commit ecb55ef471.

Bug: 277942460
Test: tablet/foldable device
      check taskbar animation b/w states and during drag

Change-Id: I48e37d58afa6e168a683e1b9c73ae15432920030
2023-04-12 13:24:19 -07:00
Brian Isganitis 44935cf678 Update notification dots in Taskbar All Apps.
AllAppsStore already has the business logic for this, we just were not
piping along to it.

Test: Dismiss notification from tray while All Apps is open, and dot
should go away in All Apps.
Fix: 277925243

Change-Id: I29c5723fd77d22f683f5518bd6e2e3206ddee999
2023-04-12 14:00:54 -04:00
Jon Miranda c88f04c83d Fix bug where taskbar is translated during hotseat handoff. am: ecb55ef471 am: 0400e2ba46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22531977

Change-Id: I3d67bdb37964935e565c10fba06c5c172b3575ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-10 23:49:39 +00:00
Jon Miranda 0400e2ba46 Fix bug where taskbar is translated during hotseat handoff. am: ecb55ef471
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22531977

Change-Id: If9624d1b602edd615e19ae135e963723537ce574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-10 23:19:59 +00:00
Brian Isganitis 3ef917a4e3 Cleanup ENABLE_TASKBAR_EDU_TOOLTIP: remove EDU sheet.
Test: Manual
Fix: 270396268
Change-Id: I3cebdb6646060cf6793e5ffc638213dde41338c0
2023-04-10 12:55:18 -04:00
Jon Miranda ecb55ef471 Fix bug where taskbar is translated during hotseat handoff.
Fixes: 277271088
Test: be in app
      swipe up from bottom to top of screen without pausing then release
      observe taskbar -> hotseat handoff
      observe no jump

Change-Id: I2bb9d93d39215ca3653e2e4353391b50b7ab6417
2023-04-07 11:44:33 -07:00
Sunny Goyal 7b74a5c53f Merge "Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""" into udc-dev 2023-04-07 01:02:09 +00:00
Treehugger Robot 5f41d0d759 Merge "Close system dialogs on Taskbar home button tap" into tm-qpr-dev am: 199b08efc8 am: 549615f627
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22513962

Change-Id: Id05c00f0fe5932727d935ae1b4c28e3aff5a45eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 22:50:38 +00:00
Sunny Goyal 5cd1b198b0 Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""
This reverts commit 7025765c72.

Reason for revert: 274169859

Change-Id: I86a114bf2c713fea6ec7095f68816820ba5f7495
2023-04-06 22:33:11 +00:00
Winson Chung 8bf8e01550 Merge "Always provide mandatory bottom gesture insets" into tm-qpr-dev am: 4b5b50be80
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22511939

Change-Id: I53cbb4a63c0cea6fcb12ce4ee82522e599ad5b9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 22:10:05 +00:00
Treehugger Robot 549615f627 Merge "Close system dialogs on Taskbar home button tap" into tm-qpr-dev am: 199b08efc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22513962

Change-Id: Ie7f9d86590630d12d4ce61c6109f8bdc1bab51cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 22:09:16 +00:00
Winson Chung 4b5b50be80 Merge "Always provide mandatory bottom gesture insets" into tm-qpr-dev 2023-04-06 21:40:06 +00:00
Treehugger Robot 199b08efc8 Merge "Close system dialogs on Taskbar home button tap" into tm-qpr-dev 2023-04-06 21:30:51 +00:00
TreeHugger Robot a47bd20ce4 Merge "Cleanup ENABLE_TASKBAR_POPUP_MENU" into udc-dev 2023-04-06 20:30:30 +00:00
Jeremy Sim a2d9d1de48 Merge "Fix bug with split screen not recognizing user differences" into tm-qpr-dev am: 4bce4f6193
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22463688

Change-Id: I6a9d3d87d27ee922d7aed85a4e4d3369902bef8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 19:30:44 +00:00
Vinit Nayak 5bda089e2b Close system dialogs on Taskbar home button tap
Fixes: 255879258
Test: Able to go home w/ shade down in app and
in overview

Change-Id: Ia706148b4437e18b16b711bda572c4ba28958718
2023-04-06 12:09:35 -07:00
Winson Chung 48e6b4ccd9 Always provide mandatory bottom gesture insets
Bug: 265614886
Bug: 277185135
Test: atest WindowInsetsPolicyTest
Change-Id: I0cf4d5b72e54caf7c671a5d52a93d2066a79ed65
Merged-In: I964e0b759170c127cb05615ce5bf6fa827621187
2023-04-06 19:08:26 +00:00
Jeremy Sim 4bce4f6193 Merge "Fix bug with split screen not recognizing user differences" into tm-qpr-dev 2023-04-06 19:02:50 +00:00
Winson Chung 3d03a208ac Always provide mandatory bottom gesture insets
Bug: 265614886
Bug: 277185135
Test: atest WindowInsetsPolicyTest
Change-Id: I964e0b759170c127cb05615ce5bf6fa827621187
2023-04-06 16:43:16 +00:00
Mike Schneider 5bd3864c79 Merge "Fade navbar-handle in/out during TRANSITION_HANDLE_FADE" into tm-qpr-dev am: 2a20958f4b am: 0264036b64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22433065

Change-Id: I779cae347ca106349f0567cb1660a7f1165b3e5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 16:01:27 +00:00