Commit Graph

38478 Commits

Author SHA1 Message Date
Alex Chau 3bf362fe30 Merge "Recognizing Launcher builds consisting only of digits" into sc-v2-dev am: 90a9982b36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16285317

Change-Id: Id1503027367fdc2c4e4f20fcf12de9863e012667
2021-11-18 10:33:48 +00:00
Alex Chau 90a9982b36 Merge "Recognizing Launcher builds consisting only of digits" into sc-v2-dev 2021-11-18 09:59:59 +00:00
TreeHugger Robot d5bb753fb0 Merge "Use split thumbnail width/height directly" into sc-v2-dev am: 5394db834f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16290750

Change-Id: I4a95e767af6bc7b8c88b341b5b3a23e3400e6442
2021-11-18 05:00:26 +00:00
TreeHugger Robot 5394db834f Merge "Use split thumbnail width/height directly" into sc-v2-dev 2021-11-18 04:42:27 +00:00
Vinit Nayak be7ce023de Use split thumbnail width/height directly
* When swiping to QS from home, the
bounds for the rect on screen are incorrect
because it's technically off-screen when
it's being queried

Fixes: 206155441
Change-Id: Ibb17f2ac291f867b6de06041c980e434ce92cf27
2021-11-17 19:05:29 -08:00
TreeHugger Robot 61795cd45a Merge "Add animated background to the suw all set page." into sc-v2-dev am: 010faef3a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16223698

Change-Id: I9cadb5c6909ad68ca3ba1cadc9c72ba1b7a1716d
2021-11-18 00:23:49 +00:00
TreeHugger Robot 21ab217bf9 Merge "Use TOUCHABLE_INSETS_REGION when IME is visible" into sc-v2-dev am: ec2bd55047
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16286558

Change-Id: Ida331373a19c9c49013346dde8187f139eff4ed8
2021-11-18 00:11:43 +00:00
TreeHugger Robot 010faef3a5 Merge "Add animated background to the suw all set page." into sc-v2-dev 2021-11-18 00:07:35 +00:00
TreeHugger Robot ec2bd55047 Merge "Use TOUCHABLE_INSETS_REGION when IME is visible" into sc-v2-dev 2021-11-17 23:57:56 +00:00
Tony Wickham e60d5d4f6d Merge changes I36871463,I691a5cbb,I62105c1c into sc-v2-dev am: 49da26f636
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16192239

Change-Id: I7ad5455303a3aaddff6edc60d1d565e1464213e6
2021-11-17 22:19:42 +00:00
Tony Wickham 49da26f636 Merge changes I36871463,I691a5cbb,I62105c1c into sc-v2-dev
* changes:
  Update reorder and folder creation radii
  Fix misaligned folder creation drag over target
  Update CellLayout.DEBUG_VISUALIZE_OCCUPIED to include drag over targets
2021-11-17 22:08:28 +00:00
Tony Wickham bf4a91b0f1 Use TOUCHABLE_INSETS_REGION when IME is visible
This ensures the dismiss button is fully clickable even if taskbar is stashed.

Test: Stash taskbar, can dismiss keyboard by tapping anywhere on the back button
(Same with taskbar unstashed)
Fixes: 206851484

Change-Id: I06f86191e36b596a928c8db8d67a012be033daba
2021-11-17 14:04:25 -08:00
Alex Chau 4cb9af12e9 Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev am: 7c9055fc6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261572

Change-Id: I1bff143ada51bc1de8d8981120fac8384980c4cc
2021-11-17 21:21:14 +00:00
Alex Chau 7c9055fc6b Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev 2021-11-17 21:02:16 +00:00
Tracy Zhou aba6c9296e Merge "Refine when to move live tile app below recents view" into sc-v2-dev am: a37f8baa1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16280383

Change-Id: I2d30f89603216b27354668d28bb178127c483dce
2021-11-17 19:54:47 +00:00
Winson Chung b73106e5b3 Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev am: 0e1cd933ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16282083

Change-Id: I64b43cfa8d18266d7d58a3aff53450569a09df45
2021-11-17 19:53:53 +00:00
Tracy Zhou a37f8baa1d Merge "Refine when to move live tile app below recents view" into sc-v2-dev 2021-11-17 19:53:14 +00:00
Winson Chung 0e1cd933ba Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev 2021-11-17 19:42:53 +00:00
vadimt 60ba2ac084 Recognizing Launcher builds consisting only of digits
Bug: 206687633
Test: online regex tools
Change-Id: Ia6155f22fb9a0eba3beb6edb607f44f901629330
2021-11-17 19:07:20 +00:00
Fedor Kudasov 228f1ef97b Merge "Add some more @Nullable annotations" into sc-v2-dev am: e65c47e60f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16279499

Change-Id: I2c201837c2ff2bb9938103f5d5a3243e3c501aab
2021-11-17 18:58:04 +00:00
Fedor Kudasov e65c47e60f Merge "Add some more @Nullable annotations" into sc-v2-dev 2021-11-17 18:42:53 +00:00
TreeHugger Robot 54dd53876c Merge "Revert "Add feature flag to control two panel home in portrait"" into sc-v2-dev am: 42f111dc27
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16279502

Change-Id: I69f25262f5ae58304c8b1c0615cf9510221f6ef3
2021-11-17 18:07:05 +00:00
TreeHugger Robot 42f111dc27 Merge "Revert "Add feature flag to control two panel home in portrait"" into sc-v2-dev 2021-11-17 17:47:16 +00:00
Winson Chung 9304879387 Fix issue with grouped task rects being calculated slightly off
- This was causing bleed through between split tasks and perhaps
  some rounded corners to be calculated incorrectly
- Also reset the translation after it is adjusted for dismissing
  in case the dismiss gesture is canceled.  This doesn't fix the
  issue with bleed through between the task views (to be fixed
  separately), but makes sure it isn't permanently set on the task

Bug: 206739664
Test: Split tasks, swipe up and check the bounds

Change-Id: I34430e958ca7a75f48621bc27a281e93fdf97179
2021-11-17 17:40:58 +00:00
Alex Chau 9012582ef7 Revert "Add feature flag to control two panel home in portrait"
This reverts commit b1c36ce938.

Reason for revert: experiment no longer requried
Bug: 197723099

Change-Id: I585fa4364ab5326a19b099a80a1a02a66370d84f
2021-11-17 14:16:58 +00:00
Fedor Kudasov 3256e1e744 Add some more @Nullable annotations
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I6d2f269c4ec5f6cdee31ad68545c2720fbf1d8fc
(cherry picked from commit 9385170c1b)
2021-11-17 08:40:17 +00:00
Tracy Zhou a4edc07ec8 Refine when to move live tile app below recents view
- We will still need to figure out why, but currently the overview scrim blocks the cut out during transition. To go around this, we need to move live tile app after the overview transition animation is over
- Some of the logic in RecentsView is no longer necessary since we are no longer reusing live tile params and simulator, but assign new targets each time

Fixes: 205587164
Test: manual
Change-Id: Icadf26182112bba544a4103b626effa37d4028b5
2021-11-16 21:17:19 -08:00
TreeHugger Robot a4157b6afe Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev am: b797ca77b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16275817

Change-Id: Ia3cb4b2db5a8dc0bd5cef901259fab01aa2cee34
2021-11-16 21:55:37 +00:00
TreeHugger Robot b797ca77b2 Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev 2021-11-16 21:34:52 +00:00
TreeHugger Robot 38b671d602 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev am: 36705e6039
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16273821

Change-Id: I07a1681b8d5ba1a5699537e4f6e5f981ae09718b
2021-11-16 20:39:18 +00:00
TreeHugger Robot 36705e6039 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev 2021-11-16 20:25:06 +00:00
Tracy Zhou 1fdea66f16 Fix memory leak in TaskbarLauncherStateController
mIconAlphaForHome.setConsumer(null) in onDestroy()

Test: Run BinderTests#testSwitchToOverview locally
Bug: 206633573
Change-Id: I912cd66097b113ee84197f23a5862e333d7e63f2
2021-11-16 11:31:15 -08:00
TreeHugger Robot 506927514d Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev am: 82fc85f9b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16064580

Change-Id: I8f25b31835fc64a7f76ae7267e7bcb2a6a4d8434
2021-11-16 19:15:25 +00:00
TreeHugger Robot 82fc85f9b8 Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev 2021-11-16 19:00:47 +00:00
Alex Chau 0f38629826 Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev am: 1c4871298e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16166972

Change-Id: Icf8e6992c6b76fddca4ae25c81a66f6424d9554e
2021-11-16 18:57:56 +00:00
Alex Chau 04309940c0 If hometask is last task to be dismissed, show empty recents instead of home screen
- http://ag/16221737 ensure homescren stub is always added if tasks hasn't been loaded in RecentsView. This introduced an edge case that after dismissing home task view, no task remains in overview and it get dismissed
- The fix is to show empty recents instead of home screen if last task dismissed is a home task (showing empty recents isn't always correct, as there might be unloaded tasks, but it's better than dismissing overview)
- Also tuned the timing of when mLoadPlanEverApplied is set

Fix: 206462357
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I0f395639f57a1a57fddf750623a8a74b8ede8555
2021-11-16 18:48:28 +00:00
Alex Chau 1c4871298e Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev 2021-11-16 18:40:31 +00:00
TreeHugger Robot 49584c3412 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev am: d8a1b5c366
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214589

Change-Id: I8b3a32fd3c115a4f4276add4450a7f07081a1336
2021-11-16 17:03:44 +00:00
TreeHugger Robot d8a1b5c366 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev 2021-11-16 16:48:14 +00:00
Alex Chau b7abf7e96d Fix launch animation from bottom row and end of grid
- Apply gridTranslationY when calculating taskRect so it's used to calculate RecnetsView pivot
- Moved recentsViewScroll to RecentsView group and applied after recentsViewScale
- Before: http://dr/file/d/1-Nrqa80J4FRbjcdZ3GZSeKwfQF8fN9a1/view?resourcekey=0-gYT9z1HA0YksW5Ujbzsmeg
- After: http://dr/file/d/1-DpZrg5_nFeUKS-8APnLvG8SJVvke9BU/view?resourcekey=0-p59hm-abzpU7Y7tqWyneTQ

Fix: 200813202
Test: Launch task from grid from top/bottom/left/right/focus
Test: Launch task from left/middle/right in small screen
Change-Id: I814512c02611f59a5a6d1f53411d42cf4f0f26b3
2021-11-16 13:55:38 +00:00
TreeHugger Robot a8a8c75bd7 Merge "Revert "Add ScreenRecord to methods affected by a flaky problem"" into sc-v2-dev am: a6c4b66b7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16272580

Change-Id: Ic3f37f1c1803ac4fe19dc048932d77772e0d3105
2021-11-16 13:13:34 +00:00
TreeHugger Robot a6c4b66b7f Merge "Revert "Add ScreenRecord to methods affected by a flaky problem"" into sc-v2-dev 2021-11-16 13:03:33 +00:00
Alex Chau 033f2afe38 Revert "Add ScreenRecord to methods affected by a flaky problem"
This reverts commit ea6ee1c824.

Reason for revert: Seems to increase the severity of the flaky problem
Bug: 204807156

Change-Id: I7b87f2abf45c9da21981f9361e320163bd7834bd
2021-11-16 11:19:09 +00:00
Fedor Kudasov b807d92aa7 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev am: 72c8e71e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261398

Change-Id: Ic382d5886aa2df5c1bb8f981cbe626f031fd9c51
2021-11-16 10:44:07 +00:00
Fedor Kudasov 72c8e71e06 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev 2021-11-16 10:26:23 +00:00
Tracy Zhou 022c66327b Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781

Change-Id: Ie9ca6ecdd77ac76b5b93461b6c5d7d6e670b71a6
2021-11-16 09:57:38 +00:00
Tracy Zhou 0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
TreeHugger Robot ce57748e66 Merge "Add ScreenRecord to methods affected by a flaky problem" into sc-v2-dev am: fffea98399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261407

Change-Id: Iad0bec3854b6ccd77c4ab223b2476c619e123098
2021-11-15 21:45:24 +00:00
TreeHugger Robot fffea98399 Merge "Add ScreenRecord to methods affected by a flaky problem" into sc-v2-dev 2021-11-15 21:32:58 +00:00
Fedor Kudasov acf07f338e Simplify getTaskViewAt call am: 9d6fb64f45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16249427

Change-Id: If52c26a38fab17d294b08a34a3e41fd5f88cef27
2021-11-15 20:50:06 +00:00