Commit Graph

35058 Commits

Author SHA1 Message Date
TreeHugger Robot 3bd6b8bf81 Merge "Make sure distinct widgets items are used when mapping widget component names to widget items." into sc-v2-dev 2021-10-26 18:01:48 +00:00
Tony Wickham add188f339 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev 2021-10-26 02:56:47 +00:00
TreeHugger Robot 8935b22cd7 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev 2021-10-26 00:06:37 +00:00
Alex Chau 4941b84717 Merge "Avoid calling getIconResult if recycle is called after request is queued" into sc-v2-dev 2021-10-25 23:30:32 +00:00
TreeHugger Robot c6649763a7 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev 2021-10-25 23:20:47 +00:00
Sebastian Franco 63d1a181e5 Fix the remove button icon not centered when the home screen is in landscape.
To fix it I put the bounds of the Icon/drawable when the text is not visible.

Fix: 202811811
Test: Manually Tested.
Change-Id: Ieff54a73e819c4b3a61e28fd76faf93a84b67666
2021-10-25 17:34:11 -05:00
Tony Wickham 232e9a4631 Hide taskbar background when notification shade is expanded
- In 3 button mode, don't hide the background but do ensure nav buttons are translated down when swiping to notificaitons from the home screen

Test: swipe down notifications, background hides in 0 button mode but not in 3 button mode
Fixes: 199163951
Change-Id: Ic70adc7d67b2ab7c92a2d5d846b9b259d1bd7bfc
2021-10-25 13:44:09 -07:00
Alex Chau 53c7ed5084 Avoid calling getIconResult if recycle is called after request is queued
Fix: 203582251
Test: atest -c NexusLauncherTests:com.android.launcher3.memory.MemoryTests
Change-Id: Ice1e981e1813df516008be578aa89ee17fb79fab
2021-10-25 21:06:27 +01:00
Alina Zaidi fa37c6742e Make sure distinct widgets items are used when mapping widget component
names to widget items.

This is to prevent a crash on duplicate key when creating map.

Bug: 204065759
Test: Enabled flag and got no crash
Change-Id: Ice9f93af76c02eeba53c934687358ed806c60b60
2021-10-25 16:10:45 +01:00
Alex Chau 39da1f78da Fix TaskView jumping caused by split select
- Never apply split select translation to grid overview, instead use dismiss translation to make space to split placeholder to minimize motion and avoid janky double movement
- Ensures snapping to last task for end of grid split cases
- Adjust mCurrentPageScrollDiff due to coordinate shift
- Use longGridRowWidthDiff to shift all task to make space for split placeholder
- Also fixed a bug that split translation isn't reset if entering overview immediately after exit

Bug: 200537815
Test: manual
Change-Id: Ie1b57c34ce4bb079f898ba5b7c3464a714021847
2021-10-25 15:38:34 +01:00
TreeHugger Robot 85da1db1aa Merge changes from topic "presubmit-am-cb4679fd6eb1414cb720168b20bbb591" into sc-qpr1-dev am: f409849bc4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I67aaa34d281376260aa4bd8e5cc4fcef49402932
2021-10-22 01:27:31 +00:00
Bill Yi 7bb30c848f [automerger skipped] [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: f2e186c6df am: a72c102031 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I62b04a7d14e92ab68cfa04d179314b9b63334c3c
2021-10-22 01:27:30 +00:00
Bill Yi a69d7317fc [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: dda2a04183 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097528

Change-Id: If248f35638fae7d66b6e281b20418946a837698b
2021-10-22 01:27:21 +00:00
TreeHugger Robot f409849bc4 Merge changes from topic "presubmit-am-cb4679fd6eb1414cb720168b20bbb591" into sc-qpr1-dev
* changes:
  [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: f2e186c6df
  Import translations. DO NOT MERGE ANYWHERE
2021-10-22 01:13:07 +00:00
TreeHugger Robot 7c15035bfd Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-10-22 00:54:20 +00:00
TreeHugger Robot 92203abe18 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-10-22 00:52:12 +00:00
Alex Chau 385a6b9caa Ignore testOverviewForTablet until root cause of cuttlefish failure is found.
Test: TaplTestQuickstep.java
Bug: 203781041
Change-Id: I9b6f658ab8f55beafaf784d7a374e2780a591089
Merged-In: I9b6f658ab8f55beafaf784d7a374e2780a591089
2021-10-21 21:30:23 +00:00
Makoto Onuki 1b5e2679a4 Merge "Revert "Ignore testOverviewForTablet until root cause of cuttlefish failure is found."" into sc-v2-dev 2021-10-21 20:49:20 +00:00
Makoto Onuki da65dc3dd3 Revert "Ignore testOverviewForTablet until root cause of cuttlefish failure is found."
This reverts commit 8893098446.

Reason for revert: b/203806263

Change-Id: I5e1644e0163ef07d0bec4a70b9dea799ab69f1b5
2021-10-21 20:48:01 +00:00
TreeHugger Robot d4df41b78f Merge "Bugfix where the widget handles appear even when you can't resize it." into sc-v2-dev 2021-10-21 20:46:37 +00:00
TreeHugger Robot a293a864a6 Merge "Fixing wrong text spacing bounds" into sc-v2-dev 2021-10-21 20:16:37 +00:00
TreeHugger Robot b4ce5c1b36 Merge changes Id9fdcd71,Ic4d69d73 into sc-v2-dev
* changes:
  Stash taskbar in fallback recents
  Add FallbackTaskbarUIController
2021-10-21 19:56:38 +00:00
TreeHugger Robot 7ca12edf54 Merge "Ignore testOverviewForTablet until root cause of cuttlefish failure is found." into sc-v2-dev 2021-10-21 18:53:31 +00:00
Sunny Goyal 486adb03a0 Fixing wrong text spacing bounds
Bug: 203740844
Test: Manual
Change-Id: I68fcab489643acf80759f90736f806ae2852e648
2021-10-21 11:30:18 -07:00
Tony Wickham 3f6e3f0650 Stash taskbar in fallback recents
Test: Swipe to Overview with 3P launcher as default, watch taskbar stash
Fixes: 188790554
Change-Id: Id9fdcd715fc50872e3a96f102053a9a99859b482
2021-10-21 10:53:48 -07:00
Tony Wickham 8791e7de11 Add FallbackTaskbarUIController
- Refactor TaskbarManager to accept StatefulActivity instead of BaseQuickstepLauncher
- Update the new StatefulActivity in onOverviewTargetChange()
- Cleanup LauncherTaskbarUIController a bit to avoid initializing TaskbarActivityContext, TaskbarDragLayer, and TaskbarViewController in the constructor, and instead get these from mControllers after init()

Test: No change in behavior
Bug: 188790554
Change-Id: Ic4d69d73deb6dada416876eb265db57803c3adfd
2021-10-21 10:53:46 -07:00
Sebastian Franco 4067f5d4ae Bugfix where the widget handles appear even when you can't resize it.
To fix it I added the following logic condition: if the minimum size of
the widget (`mMinVSpan` vertically) is equal to the maximum size of the
widget (`mMaxVSpan` vertically), then you can't change the size and the
handles shouldn't appear, I did this for both the horizontal handles as
well as the vertical handles.

Fix: 202004006
Change-Id: Ide05231f5712a736129ac6cb2fee358f7c70e371
Test: Manully veryfied.
2021-10-21 17:32:31 +00:00
Pat Manning 8893098446 Ignore testOverviewForTablet until root cause of cuttlefish failure is found.
Test: TaplTestQuickstep.java
Bug: 203781041
Change-Id: Iffd7031f303822fe77c02052eb07499e8644243b
2021-10-21 18:09:15 +01:00
TreeHugger Robot d238074c39 Merge "Update TaskView corner radius as RecentsView scale changes" into sc-v2-dev 2021-10-21 15:12:16 +00:00
Alex Chau 3c6795e355 Update TaskView corner radius as RecentsView scale changes
Fix: 192253697
Test: manual
Change-Id: I45825c955b759163792d704408e348c198830fc8
2021-10-21 14:23:11 +01:00
Nick Chameyev 8523412470 Merge "Do not animate statusbar unfold when in portrait orientation" into sc-v2-dev 2021-10-21 10:02:00 +00:00
Bill Yi d49bfff510 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I15420c8897a61074aa67984386f5b92d68b658bd
2021-10-21 04:26:01 +00:00
Bill Yi dda2a04183 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If7e1d701d4b0359590495c962c25ee59f21662bc
2021-10-21 04:25:21 +00:00
Bill Yi a72c102031 [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: f2e186c6df
Blank merge reason: commit message contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I6825fa2e024a1ec19d7c1e80150e39e0fb3a58fb
2021-10-21 04:24:48 +00:00
Bill Yi f2e186c6df Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibb8212b4736009180e475a3ae443caafd0ebc937
2021-10-21 04:24:42 +00:00
Bill Yi 74016ae10e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib93913a6e2542bc96b74cf0d3bdd042a82af7ed1
2021-10-21 04:22:26 +00:00
TreeHugger Robot 6409130f29 Merge "Cache TISBinder for multiple onBind() calls" into sc-v2-dev 2021-10-20 23:34:49 +00:00
Vinit Nayak 45fbe5b563 Cache TISBinder for multiple onBind() calls
Bug: 202986128
Change-Id: I29a0963ff2880c9970859bc1437c7624bc7f0aea
2021-10-20 13:51:40 -07:00
TreeHugger Robot ea38519fa4 Merge "Fix bug with resize frame in Launcher3." into sc-v2-dev 2021-10-20 20:50:17 +00:00
Schneider Victor-tulias e9bd364390 Merge "Generalize the icon popup menu types." into sc-v2-dev 2021-10-20 18:32:56 +00:00
Yogisha Dixit 7b1d25b251 Fix bug with resize frame in Launcher3.
Also updated the tests to check that the resize frame is shown.

Bug: 192655785
Test: AddWidgetTest, AddConfigWidgetTest, manual
Change-Id: Id348f39cec1bebc8ec9ea9f3068f4bda2159eac4
2021-10-20 19:03:14 +01:00
Pat Manning 3c647ff30a Merge "Add new quickstep test for many tasks open at once." into sc-v2-dev 2021-10-20 15:20:26 +00:00
Pat Manning ccec1de6ae Add new quickstep test for many tasks open at once.
This test is needed for testing overview-grid-related functionality.
- Opening non-focused tasks
- Dismissing a non-focused task from the grid
- Grid rows rebalancing after dismissal, which only happens when enough
apps are open to be off-screen.
- Grid tasks do not scroll after dismissal.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ic907db4643cdc2eb9e4610dab917347e234e470c
2021-10-20 14:40:32 +01:00
Samuel Fufa f0f2b75ada Merge "[Search] [Race condition] Fix wrong titles showing on BubbleTextHolder" into sc-v2-dev 2021-10-20 03:15:25 +00:00
sfufa@google.com d7bdd97ac6 [Search] [Race condition] Fix wrong titles showing on BubbleTextHolder
No need to remove the listener on BubbleTextView#reset as BubbleTextView's parent should never change and always listen for ItemInfo updates.

Bug: 203506475
Test: Manual
Change-Id: Ie00b293495c79d36c9eb08408754389ab4b80839
2021-10-19 17:15:06 -07:00
Schneider Victor-tulias 16e04e29d2 Generalize the icon popup menu types.
Generalized popup menu types and logic to allow wider uses outside of launcher.

Bug: 198438631
Test: long pressed launcher icons and pressed menu options
Change-Id: Iadcbb1796496c0061dcee362784e426ff55dc94a
2021-10-19 16:06:16 -07:00
Sunny Goyal 37a237b2cd Merge "Adding support for dynamic letter spacing for icon labels" into sc-v2-dev 2021-10-19 22:56:16 +00:00
Samuel Fufa c46c83c8c8 Merge "[Work Profile] Fix NPE on WorkModeSwitch" into sc-v2-dev 2021-10-19 22:01:25 +00:00
TreeHugger Robot bc9dd92220 Merge "Delaying taskbar loading until user setup completed" into sc-v2-dev 2021-10-19 21:49:02 +00:00
Sunny Goyal 0d69cb6ef7 Adding support for dynamic letter spacing for icon labels
Bug: 201697936
Test: Manual
Change-Id: I0ab81291c40afcac30c5caf7b5638889908775f8
2021-10-19 13:09:58 -07:00