Commit Graph

76740 Commits

Author SHA1 Message Date
Hongwei Wang 3b1ebed232 Disable gesture nav while PiP anim is running
To prevent the Recents transition that may conflict with PiP

Flag: EXEMPT bug fix
Bug: 340724371
Test: Swipe to show TaskBar while expanding PiP to FS mode
Change-Id: I87bb660c37f47dd67f7593a52eda99b167a233a9
2024-06-27 12:40:19 -07:00
Mady Mellor 4d1c6e55d5 Merge "Only return that bubbles are on home if we actually have bubbles" into main 2024-06-25 18:47:25 +00:00
Brandon Dayauon cc6d5007b7 Merge "Fix NPE when locking private space in taskbar allapps." into main 2024-06-25 17:55:16 +00:00
Brandon Dayauon e770f10d2a Fix NPE when locking private space in taskbar allapps.
We can just remove the check since isSearchSupported has been launched.

bug: 345648701
Test manually video -
before: https://drive.google.com/file/d/1EwwRXrASusmqVixGWuKGnOQQyiDLE6Yy/view?usp=sharing
after: https://drive.google.com/file/d/1OCvtxzbhRJrBMMM2JH_cOurQ-_BaALSA/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38
2024-06-25 16:00:09 +00:00
Schneider Victor-tulias 21d4a9cdbc Merge "Finish the recents animation when an unhandled task appears" into main 2024-06-25 14:02:46 +00:00
Jordan Silva 33e35cabee [automerger skipped] Fix digital wellbeing banner position in portrait mode am: 497729f781 -s ours
am skip reason: Merged-In I0544b4a8eb85b00196373c8a4368e680abab222b with SHA-1 3d088e3899 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28011186

Change-Id: I4e104d0732b4c001d417432a9483e4a340580ed4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-25 01:22:47 +00:00
Tracy Zhou 30e0597a36 Merge "Do not tint task/nav bar icons in folded state when task bar on phones is enabled" into main 2024-06-24 23:14:29 +00:00
Mady Mellor 6d09b0cd1e Only return that bubbles are on home if we actually have bubbles
This causes an issue in the touch inset calculations resulting in
taskbar items being not touchable causing some tests to fail (thank
you tests for catching this!)

Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Bug: 349174989
Change-Id: I8cad22be92f219e0e9d3ec0f551764681f281844
2024-06-24 15:35:55 -07:00
Fengjiang Li 94de34ce2f Merge "[Launcher Jank] Avoid SimpleBroadcastReceiver making binder calls on main thread" into main 2024-06-24 21:00:41 +00:00
Hongwei Wang 4f35222eb6 Merge "Offset display cutous on foldables" into main 2024-06-24 20:29:39 +00:00
Hongwei Wang 99b3406380 Merge "Add myself to launcher OWNERS" into main 2024-06-24 20:28:58 +00:00
Tracy Zhou 42cfe214cf Do not tint task/nav bar icons in folded state when task bar on phones is enabled
This logic will be handled by TaskbarTransitions instead.

Bug: 349155860
Test: Make sure the buttons don't dim after going to an app in folded, when taskbarOnPhones is enabled.
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ie8efa5c096123935458eb3bb451ace35e8914a30
2024-06-24 13:17:37 -07:00
Brian Isganitis 5ee679dbb8 Merge "Introduce TestRule for setting Taskbar mode." into main 2024-06-24 20:17:24 +00:00
Hongwei Wang 34e34a9228 Add myself to launcher OWNERS
Flag: NONE OWNERS file update
Bug: N/A
Test: N/A
Change-Id: Ib676c85392637ba9de3930c824d123a01c1ee78a
2024-06-24 13:17:22 -07:00
Jagrut Desai a7ec8fe852 Merge "Fix taskbar background alpha" into main 2024-06-24 20:14:28 +00:00
Jagrut Desai eba5d919ef Fix taskbar background alpha
Test: Manual
Bug: 345018985
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: Ic675285724bcf64b7bd03f918703defb4dc12a47
2024-06-24 13:11:51 -07:00
Brian Isganitis cbc07b4282 Introduce TestRule for setting Taskbar mode.
This rule is separate from TaskbarUnitTestRule, because mode isn't
relevant to all Taskbar controllers.

To keep MainThreadInitializedObject behavior consistent across
Robolectric and Instrumented environments, context needs to be a SandboxContext.

Test: TaskbarModeRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: Iae2e3627b9002e13ee6da135113e7b8bcc4e7d47
2024-06-24 14:34:45 -04:00
Schneider Victor-tulias 882c83300e Finish the recents animation when an unhandled task appears
Flag: NONE bug fix
Fixes: 339738998
Test: forced error condition programmatically and checked logs
Change-Id: I791a5252c244eaefab041c283b70acf1faad6486
2024-06-24 13:15:54 -04:00
Alex Chau 20a077029c Merge "Disable Select mode from Menu in fake landscape" into main 2024-06-24 14:35:43 +00:00
Alex Chau 2026c80016 Disable Select mode from Menu in fake landscape
Fix: 349072279
Test: Verify that Select mode is only available from Menu in grid only Overview on tablets
Flag: EXEMPT bugfix
Change-Id: Icd0d8303547b45d3653696812c51ce2c2bfd410b
2024-06-24 13:41:37 +01:00
Jordan Silva 497729f781 Fix digital wellbeing banner position in portrait mode
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded.

Fix: 348200661
Bug: 345789862
Flag: EXEMPT bugfix
Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d088e3899cfca516dfa8ae9699691ece2b914d9)
Merged-In: I0544b4a8eb85b00196373c8a4368e680abab222b
Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
2024-06-24 09:55:17 +00:00
Treehugger Robot c1391754ff Merge "Enable currently functional multivalent tests" into main 2024-06-24 01:17:40 +00:00
Uwais Ashraf c902df4e41 Enable currently functional multivalent tests
Flag: EXEMPT test-only
Bug: 325088619
Bug: 325088638
Bug: 325088328
Test: Presubmit
Test: Gradle robolectric run
Change-Id: I20e77a401ed98c97168bf9c752eacc93c3c545dd
2024-06-22 22:14:30 +00:00
Liran Binyamin 9b3d882c34 Merge "Fix hotseat icon translation issue" into main 2024-06-22 01:35:49 +00:00
Treehugger Robot 0abbc4af14 Merge "Add scrim to TaskThumbnailView" into main 2024-06-22 01:22:31 +00:00
Treehugger Robot f53b40e1a9 Merge "[Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread" into main 2024-06-21 23:36:22 +00:00
Jon Miranda f044d12fcc Merge "Fix taskbar bg delay for the case when user is going home." into main 2024-06-21 23:16:11 +00:00
Tracy Zhou 170092ef5d Merge "Enable taskbar on phones when the flag is turned on" into main 2024-06-21 22:47:13 +00:00
Treehugger Robot b938fa20b2 Merge "Close floating views before fake rotation" into main 2024-06-21 22:46:03 +00:00
Fengjiang Li 1f87d94e59 [Launcher Jank] Avoid SimpleBroadcastReceiver making binder calls on main thread
Fix: 348649441
Flag: NONE - jank fix
Test: manual - presubmit
Change-Id: Ie97713f3f0b1f117662d49c6d6a65651c593d424
2024-06-21 14:37:51 -07:00
Jon Miranda 09aa46b88e Fix taskbar bg delay for the case when user is going home.
The default value was not set. I decided to flip the variable to make
it more readable.

Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
      swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I7fb4bbdce45a14312e42abcf71f7f0643376ddc6
2024-06-21 14:27:01 -07:00
Tony Wickham 74fc385999 Merge "Load and draw Recent/Running tasks that aren't in Hotseat" into main 2024-06-21 21:01:41 +00:00
Tony Wickham a79bc15cd0 Merge changes from topic "taskbar-running-minimized" into main
* changes:
  Maintain Running Tasks order in Desktop mode
  Change running apps section to use GroupTask instead of AppInfo
2024-06-21 21:00:01 +00:00
Tony Wickham 59e8952fc9 Merge "Handle running task launch properly in desktop mode" into main 2024-06-21 20:57:38 +00:00
Treehugger Robot f4934108bb Merge "Fix bubble bar bounce animation issue" into main 2024-06-21 20:44:10 +00:00
Liran Binyamin 891e9e3c4b Fix hotseat icon translation issue
The current behavior that adjusts hotseat icons to make room for the
bubble bar uses the index of the hotseat icon to calculate translation x.

The problem is that if icons are reordered, the index of the icon may be
different than the actual cell number it belongs to.

This change updates the logic to use the cell rather than the index.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345686425
Test: manual - on tablet in portrait
       - show bubble bar
       - observe hotseat icons adjust
       - drag an icon from the home screen into hotseat
       - observe icons are shown correctly
       - rotate the device to landscape and back to portrait
Change-Id: I8628892234d1b31205b93ba3089c6dbf2820ea04
2024-06-21 16:33:45 -04:00
Hongwei Wang 87b4060106 Offset display cutous on foldables
When entering PiP on foldables, especically in unfolded mode, offset the
display cutouts even if it's from ROTATION_0 (which is always the case
in unfolded state).

Flag: NONE bug fix
Before: http://recall/-/aaaaaabFQoRHlzixHdtY/eIR7VykaHpYeOigkuZVTp
After: http://recall/-/aaaaaabFQoRHlzixHdtY/cP7NticbA68I4eev2MyZgc
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Test: see also the videos
Change-Id: I62e8d3f361644ca0ca78ef20b3d3b5441d7f26c8
2024-06-21 12:06:52 -07:00
Fengjiang Li c5005171a6 [Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread
Added comments

Fix: 348668521
Test: presubmit
Flag: NONE - add comment
Change-Id: I0b3cfb4ee7d05c3b3d2f2857542f1a76a5af7e1f
2024-06-21 12:04:04 -07:00
Brian Isganitis d3d2607a10 Merge "Extract RoboApplication object caching to Launcher3 interface." into main 2024-06-21 18:37:14 +00:00
Alex Chau bde639236f Close floating views before fake rotation
- We do the same in Launcher for real rotation

Fix: 348113790
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
2024-06-21 18:37:21 +01:00
Uwais Ashraf 0d9b547471 Add scrim to TaskThumbnailView
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Fix: 334832108
Fix: 348195366
Test: Manual - checked scrim in un/folded
Change-Id: I758a26e9b4498dac509b75afbe059784557b3f8c
2024-06-21 16:27:01 +00:00
Mady Mellor a2146c8f10 Merge "Update bubble bar overflow to have a unique resId" into main 2024-06-21 15:55:04 +00:00
Hongwei Wang a648d13ea8 Merge "Position PiP animation based on actual coordinates" into main 2024-06-21 02:51:37 +00:00
Liran Binyamin cdc3e4d8b4 Fix bubble bar bounce animation issue
The bubble bar bounce animation was assuming that the initial translation
of the bubble bar is also the translation the bubble bar should have at
the end of the animation. This is normally correct except when the
bubble bar is initially hidden. What happens in that case is that the
translation is 0 so the bubble bar gets animated incorrectly.

This change gets the target animation from stash controller.

ABTD 100 runs: https://android-build.corp.google.com/abtd/run/L26900030004638356/

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347856510
Test: atest BubbleBarTest#selectDifferentBubble
Change-Id: I661bf006c6f23ff871c221f8d9da74d79a2dff11
2024-06-20 18:03:52 -04:00
Xin Li da3f972261 [automerger skipped] Merge 24Q3 (ab/11976889) to aosp-main-future am: 020c6204dd -s ours
am skip reason: Merged-In I5059553cb9b6c02810e9638bfaf29dde9ab6140f with SHA-1 263932e729 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27907054

Change-Id: Icbb39fe46616eb1eee1c7d468f006b728cb243d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-20 21:46:13 +00:00
Liran Binyamin 8af78f19a3 Merge "Animate bubble removal from the bar" into main 2024-06-20 20:57:34 +00:00
Hongwei Wang cd6172911e Position PiP animation based on actual coordinates
In the previous patchset, we assumed the left/top to be 0/0 which is not
always the case. This could break, for instance, in ActivityEmbedding
setup, where the pip-ing app is on the left side.

Flag: NONE test fix
Bug: 345327260
Test: Verify with apps support auto-enter PiP such as YouTube
Change-Id: Ic2f3289cf0663d0687d5ccd7f4d0250066cb3f67
2024-06-20 13:24:18 -07:00
Liran Binyamin 7b426af15f Animate bubble removal from the bar
This change creates a BubbleAnimator class that handles animating
both new bubbles in and removed bubbles out.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dMHGANplWjGC5HZT6MXyA4

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345687290
Test: atest BubbleAnimatorTest
Test: see demo

Change-Id: Ie060495f4b1421d1c8af48a861cd3e12dd0adbe8
2024-06-20 14:57:03 -04:00
Jordan Silva c9ec536f07 Merge "Fix recents button not navigating to Overview" into main 2024-06-20 16:42:16 +00:00
Luca Zuccarini 11fa93f25d Merge "Fix widget jump at the end of the new home animation." into main 2024-06-20 15:58:55 +00:00