Commit Graph
4286 Commits
Author SHA1 Message Date
Treehugger RobotandAndroid (Google) Code Review bda5d70e03 Merge "Revert "Adding screen record for the bug where we can't find a folder after dragging"" into main 2024-11-13 00:53:04 +00:00
Vadim TryshevandAndroid (Google) Code Review e238685c0d Revert "Adding screen record for the bug where we can't find a folder after dragging"
This reverts commit 243650e2cb.

Reason for revert: Bug stopped to repro

Change-Id: Idebb704546146018c6a365143ff84efb04be9c27
2024-11-12 23:09:38 +00:00
Shamali P 290fa07cc0 Update tapl test to consider the show all button
TAPL tests seem to be using system image with old PCC app and enables
airplane mode. So, it is likely filters won't load doesn't show, but
tried to create a cuttlefish image to test cover both cases, so that
if it shows, test knows how to handle it.

tapl demo:
http://screencast/cast/NTQ5ODkyNjUxNjkyODUxMnxlZmMyNzNjZS1hYQ

Bug: 356127021
Test: Manual and tapl test
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Change-Id: I19b121e3ce27221cb5195a2e55f686635d775590
2024-11-12 22:33:39 +00:00
Charlie AndersonandAndroid (Google) Code Review 90892a56b7 Merge "Revert "Update test activities with a non-default icon."" into main 2024-11-12 17:39:44 +00:00
Federico BaronandAndroid (Google) Code Review bad6326145 Merge "Add device profile dump flag guarding for OneGrid" into main 2024-11-12 07:39:56 +00:00
fbaron 9b2f38fa26 Add device profile dump flag guarding for OneGrid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I8bee69a051e81e7a1f7ed0d4e20196e2379a8ed0
2024-11-12 04:30:41 +00:00
Treehugger RobotandAndroid (Google) Code Review 287b90278f Merge "Moving some tests off TAPL" into main 2024-11-12 00:35:53 +00:00
Charlie Anderson 3e7d28e1c7 Revert "Update test activities with a non-default icon."
Revert submission 29570743-fix-default-app-icons

Reason for revert: possible culprit of b/371183869

Reverted changes: /q/submissionid:29570743-fix-default-app-icons

Change-Id: I6be362d03791893f94d3393bf9c9ffc4d9e83ec9
2024-11-11 22:04:33 +00:00
Sunny Goyal 50eeb4c161 Investigating test failure in all-apps
Bug: 378167329
Test: atest KeyboardFocusTest
Flag: EXEMPT test fix
Change-Id: I2f9b9dad3dabf0dc25bb3751ba82a9dc03ccdae2
2024-11-11 10:15:46 -08:00
Sunny Goyal 4631b2eb2c Moving some tests off TAPL
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I390fcfd1ad698ba8858891b72e61e3b6792cf718
2024-11-08 14:55:56 -08:00
Sunny Goyal 5ad2d9f53c Moving some tests off TAPL
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I679ae043d617b74a61a682d802c38cc904d2d0c5
2024-11-08 11:09:59 -08:00
Federico BaronandAndroid (Google) Code Review b986ac5398 Merge "Resolve issue where incorrect grid migration logic was used when migrating to strictly taller new grid" into main 2024-11-08 16:42:03 +00:00
Sebastián FrancoandAndroid (Google) Code Review 8bd76f5b06 Merge "Adding Launcher Mode settings to Launcher settings" into main 2024-11-08 08:55:34 +00:00
fbaron 3c8a6c6914 Resolve issue where incorrect grid migration logic was used when migrating to strictly taller new grid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I615c2ada4a2275899c08f8b40589c53c9e1dff84
2024-11-07 22:22:35 -08:00
Sebastian Franco 9e4c99befd Adding Launcher Mode settings to Launcher settings
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iab688ebdb8449f9258b61f59a0afe97875f82a81
2024-11-07 21:17:10 -08:00
Sunny Goyal 8bbe47c31b Moving Wait to kotlin
Making LauncherInstrumentation optional and removing some reduntant constants.
This allows less dependency on AbstractLauncherUITest

Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I7cf78d6acc5fef0359dee141a06fd51ff9d4f5a8
2024-11-07 13:51:27 -08:00
Uwais AshrafandAndroid (Google) Code Review 3e630a5d4b Merge "Make the test wait for Main Thread execution." into main 2024-11-07 11:33:19 +00:00
Sunny GoyalandAndroid (Google) Code Review 0d3bac3a11 Merge "Updating IconCacheUpdateHandlerTest also fixing cached shortcut info getting invalidated on every reboot" into main 2024-11-07 00:08:04 +00:00
Sunny Goyal 7ab3c7f744 Updating IconCacheUpdateHandlerTest
also fixing cached shortcut info getting invalidated on every reboot

Bug: 373085333
Test: atest IconCacheUpdateHandlerTest
Flag: EXEMPT bugfix
Change-Id: I8cdfe9e2d4a5b0b35ea71da4b3c18ebc9327016c
2024-11-07 00:07:54 +00:00
Brandon DayauonandAndroid (Google) Code Review 270e1c3dc4 Merge changes from topic "implementWorkSchedulerViewAndUpdateColorsOfFab" into main
* changes:
  Make sure work button is collapsed when keyboard is up upon going to app drawer
  Implement the work scheduler view and update colors of FAB
2024-11-06 19:57:26 +00:00
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Jordan Silva f048c99de4 Add OverviewDesktop test to verify carousel behavior on swipe up
This CL updates a test to verify the behaviour while swiping up from a fullscreen app to Overview and checking if that TaskView is between DesktopTasks (right side) and Grid Tasks (left side).
The test adds the following validations:
- Launches adjacent task while DesktopTask is at the center of the screen
- Swipe up from a fullscreen app to Overview to validate whether the task is between other tasks and desktop tasks.
- Fling back to DesktopTask to dismiss the adjacent focused task

Fix: 353948167
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Iaa15d4061c3b6ba8fc0d03416b4721cdf3f047c3
2024-11-06 13:58:41 +00:00
Anushree Ganjam 3b87d5c97a Make the test wait for Main Thread execution.
Bug: 377444474
Test: Manual
Flag: TEST_ONLY

Change-Id: Ia560dd1cd658947af6b1c4e0b57f3e92faa1afce
2024-11-05 15:17:53 -08:00
Shamali PatwaandAndroid (Google) Code Review 20cde49b4c Merge "Add a resource override for providing default widgets filter." into main 2024-11-05 01:01:00 +00:00
Shamali P ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Anushree GanjamandAndroid (Google) Code Review 2f73d60b30 Merge "Make VibratorWrapper injected by dagger (14/n)" into main 2024-11-04 21:36:19 +00:00
Anushree Ganjam 87ea411e97 Make VibratorWrapper injected by dagger (14/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: I57047122b35731d83674a5607e1ac980b86aebca
2024-11-04 11:33:34 -08:00
Treehugger RobotandAndroid (Google) Code Review 9cafa2f8e2 Merge "Revert "Revert "Don't allow Desktop tasks to go outside Overview..."" into main 2024-11-04 15:34:43 +00:00
Sam Cackett 1ecdc2d712 Revert "Revert "Don't allow Desktop tasks to go outside Overview..."
Reland submission "Don't allow Desktop tasks to go outside Overview task bounds"

Reverted changes: /q/submissionid:30210454-revert-30114356-desktop-task-view-corner-clipping-KXYKHZHSWL

Change-Id: Ia263edcc876f9f72ca7f70733e96b0823dbd750e
Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest, TaplTestsOverviewDesktop
2024-11-04 10:40:57 +00:00
fbaron ebc10c9ecc OneGrid Grid Option Updates
Bug: 330900048
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I919195dbc7ac78c3be42f0f9d7620193a24d7e99
2024-10-30 11:38:09 -07:00
Toshiki KikuchiandAndroid (Google) Code Review c6b29e374c Merge "Handle display windowing mode change in onConfigChanged" into main 2024-10-30 01:25:23 +00:00
Federico BaronandAndroid (Google) Code Review 43cc25b64b Merge "Fix grid migration tests with grid migration refactor flag on" into main 2024-10-29 07:01:16 +00:00
Charlie AndersonandAndroid (Google) Code Review b021c32c89 Merge "Fix flagging for LoaderTask broadcast tests and add more coverage" into main 2024-10-28 18:55:43 +00:00
fbaron 22029f6517 Fix grid migration tests with grid migration refactor flag on
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationDBControllerTest, ValidGridMigrationUnitTest
Change-Id: I2dceb5f9756da7ee7e7ef2d5ec29b3550a51e965
2024-10-28 10:46:17 -07:00
Treehugger RobotandAndroid (Google) Code Review 4a3c23a902 Merge changes I83746510,Ie2aa28cd into main
* changes:
  Fix TAPL OverviewTask to use correct resource to measure height
  Add TAPL test for dismiss DesktopTaskView
2024-10-28 17:18:36 +00:00
Charlie Anderson 7df6af5831 Fix flagging for LoaderTask broadcast tests and add more coverage
Flag: EXEMPT just tests
Bug: 375674876
Bug: 375704692
Test: LoaderTaskTest and presubmit
Change-Id: Ied00f9282f48ee88949697e5d684c489013e8aeb
2024-10-28 13:15:27 -04:00
Jordan Silva a244c0b70e Fix TAPL OverviewTask to use correct resource to measure height
The background in DesktopTaskView wasn't added for accessibility, so it couldn't be retrieved from the view hierarchy during e2e tests. This view is necessary to calculate the correct size of the DesktopTaskView.

The changes in this cl:
- Add backgroundView to DesktopTaskView's children for accessibility
- Use the correct snapshot resource for desktop mode in OverviewTask

Bug: 353948500
Change-Id: I83746510849e4013d623d49cbaccebd81daba96d
Flag: EXEMPT bugfix
Test: TaplTestsOverviewDesktop
2024-10-28 12:25:25 +00:00
Jordan Silva 7054095b16 Add TAPL test for dismiss DesktopTaskView
This CL adds 2 new E2E Tapl tests for checking dismiss DesktopTaskView.
- dismissFocusedTask_thenDesktopIsCentered validates the following scenarios:
  - Scenario: When Focused Task is in the center of the screen, with 1 other task in the grid and 1 desktop task.
  - When focused task is dismissed, the next task in the grid takes its place to be the next focused task at the center of the screen.
  - When the last focused task is dismissed, the desktop task takes its place at the center of the screen.

- dismissDesktopTask_thenFocusedTaskIsCentred validates the following scenarios:
  - Scenario: When Desktop Task is in the center of the screen, with 1 focused task and 1 task in the grid.
  - When focused task is dismissed, the next task in the grid takes its place, adjacent to desktop task.
  - When desktop task is dismissed, the focused task takes its place at the center of the screen.

Fix: 353948500
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Ie2aa28cd2b30a2bf10e877721416399bcf47acf6
2024-10-28 12:25:25 +00:00
Toshiki Kikuchi b00c260669 Handle display windowing mode change in onConfigChanged
This CL allows onConfigChanged to handle the changes of
showLockedTaskbarOnHome().
The return value of showLockedTaskbarOnHome() depends on the display
windowing mode. And onConfigChanged() is triggered when the display
windowing mode changes (e.g. by adb shell wm set-display-windowing
mode).

Bug: 375321881
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual
Change-Id: I1932f460735b9517cc68170c01cd45ca9bacfeb0
2024-10-28 08:47:26 +09:00
Anushree GanjamandAndroid (Google) Code Review ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Anushree Ganjam ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
fbaron a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
Shamali PatwaandAndroid (Google) Code Review d6f39e3f45 Merge "Enforce system radius instead of separate value for widgets in launcher" into main 2024-10-23 00:04:50 +00:00
Treehugger RobotandAndroid (Google) Code Review 08007068d4 Merge "Generalize ActivityTracker to support RecentsWindowManager" into main 2024-10-22 21:26:58 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
Shamali Patwa 2fc32dc2d8 Enforce system radius instead of separate value for widgets in launcher
The change is behind a flag. This is to get to the stage of having
consistent corner radius across rectangular widgets.

Bug: 373351337
Test: Unit test and manual
Flag: com.android.launcher3.enforce_system_radius_for_app_widgets
Change-Id: I23d8d3bb2561b4fc3f780fc4ddce62e8b9293192
2024-10-22 18:03:07 +00:00
Sunny Goyal 0b7f4cf1e2 Fixing deadlock in dagger singletons
Bug: 373557167
Flag: EXEMPT dagger
Test: atest DaggerSingletonDeadlockTest

Change-Id: I2304237bfd818c99b82bbfceea8a81ddb136b5a1
2024-10-21 18:09:37 +00:00
Sunny GoyalandAndroid (Google) Code Review 4eaf3df1fe Merge "Moving PluginManager to dagger" into main 2024-10-17 21:47:28 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review 892ad69191 Merge "Improve test isolation in AbstractLauncherUiTests" into main 2024-10-17 19:22:37 +00:00
Sunny Goyal 9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00