This reverts commit 5a01f588be.
Reason for revert: We don't want this behavior anymore
Bug: 343882478
Fix: 373319262
Change-Id: I7b16a229cbe303191591ff695f78a2acb831a3e8
TAPL tests seem to be using system image with old PCC app and enables
airplane mode. So, it is likely filters won't load doesn't show, but
tried to create a cuttlefish image to test cover both cases, so that
if it shows, test knows how to handle it.
tapl demo:
http://screencast/cast/NTQ5ODkyNjUxNjkyODUxMnxlZmMyNzNjZS1hYQ
Bug: 356127021
Test: Manual and tapl test
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Change-Id: I19b121e3ce27221cb5195a2e55f686635d775590
When the flag is enabled, allow the BubbleTextView to draw a background
pill behind the app title. Also change the color of the text to properly
ensure contrast. The contrast pill is only enabled for workpace apps,
so attempt draw the pill only for DoubleShadowBubbleTextView elements.
Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Idce27bd8dfca4b525c762fcd0873562f31b45b8f
OnDestroy is called in this scenario and mContainer is set to null. When I added this code I assumed this will be non null always.
Test: Manual : open maps->start navigation-> overview->split
Fix: 376409147
Flag: EXEMPT bugfix
Change-Id: I96a47b24beb5b3d343aae0e715c0b3efabdebe08
Revert submission 30126328-material-token-sync
Reason for revert: <Potential culprit for b/378661448 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>
Reverted changes: /q/submissionid:30126328-material-token-sync
Change-Id: Ifd0490a876081f3e50f674abc504bf5ba9be2df9
In other CLs we pass specific RemoteTransitions to Shell for app
launches and unminimize actions. Those CLs cover Launcher actions like
the keyboard alt-tab shortcut, or launching an app from Taskbar.
This CL covers launches that don't originate from Launcher, e.g.
launches through intents.
Test: DesktopAppLaunchTransitionManagerTest
Bug: 369966416
Flag: com.android.window.flags.enable_desktop_app_launch_transitions
Change-Id: I82fd72f870c1e38efe5a8ce533a60f282c10203c
When device is rotated, taskbar goes through recreate flow.
LauncherTaskbarUIController restores the state for taskbar in-app
display multiprop.
Ensure that bubble bar is positioned within the taskbar bounds.
The multiprop values in LauncherTaskbarUIController for taskbar in-app
display progress can be restored from shared state when the device
rotates. But this means when we receive updates to various indexes, the
progress for that index may not match what is the actual value of the
multiprop. As it relies on the max function.
Make sure we pass along the actual value for in-app display progress
when updating bubble bar and not the value for the index that got
updated.
Also make sure bubble bar translation always updates when updates are
received as this is the only path for bubble bar to receive updates.
Make sure that when we do override bubble bar translation using in-app
display progress, any existing animation for bubble bar translation y is
cancelled. Otherwise the unlock animation was animating the bubble bar
to the incorrect position after unlock.
Bug: 377621110
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest PersistentBubbleStashControllerTest
Test: manual, have bubble bar with 3 button nav, swipe to -1 and rotate
the device, observe that bubble bar is in the correct position
Test: manual, repeat same test with all apps open, observe that bubble
bar has correct position after rotation
Test: manual, with gesture navigation, observe that bubble bar has
correct position on home screen, -1 and all apps after rotation
Change-Id: I66138e003c4b371299e40558fdadc142fbdbbcd5
Change logic to updated bubble properties even we do not have any
bubbles.
Fixes: 376141825
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Set 3 button navigation mode, rotate the device.
Change-Id: Ide6df73b3b24c628a0f9e6db6582d4e2ddadfc04
Revert submission 29570743-fix-default-app-icons
Reason for revert: possible culprit of b/371183869
Reverted changes: /q/submissionid:29570743-fix-default-app-icons
Change-Id: I6be362d03791893f94d3393bf9c9ffc4d9e83ec9
When taskbar is in pinned mode with bubble bar expanded, in some
scenarios, we hide taskbar contents (i.e. when bubbles overlaps with
taskbar) and the scrim still shows.
One of the existing tests in TaskbarScrimViewController checks that
the scrim would be 0 when taskbar is not visible, however, in the
bubble bar case this isn't always true... I think there probably are
cases where taskbar isn't visible for other reasons (e.g. shade is
pulled down, but there are other tests specific to that). I'm
setting this test to only run when bubble bar isn't running, because
in that case bubbles never impacts taskbar visibility.
I added a test case to ensure scrim is hidden when pinned BUT bubble
bar is on home -- in this case we shouldn't show the scrim.
When adding the enableFlag/disableFlag I saw some NPEs in onDestroy
methods of some controllers so I protect against those as well.
Flag: EXEMPT test change
Test: atest NexusLauncherTest:TaskbarScrimViewControllerTest
atest NexusLauncherRoboTest:TaskbarScrimViewControllerTest
Bug: 377764181
Change-Id: I71001222aa8a4393b341dd2b43a4b2e46e617a70
- Extract newClearAllShortTotalWidthTranslation out from the last grid task visible case, to use it to predict new clearAllShortTotalWidthTranslation after focus task is staged, then use newClearAllShortTotalWidthTranslation to compensate getScrollForPage of grid tasks not on top-right corner for tasks close to clearAllButton
- Applied ag/28945919's fix to dismiss animation as well
- Fixed next focused task translation using wrong sign in RTL
Fix: 378403770
Test: With LTR/RTL, test focused task staging / dismiss with 1-6 tasks, dismiss grid end tasks with 1-6 tasks
Flag: EXEMPT BUG_FIX
Change-Id: Ie5b597c4318c5de84377fde50090491e78581af9
When modalness is >0, the user is in select mode and the icon menu is
hidden, therefore Talkback shouldn't pick it up.
Fix: 320203664
Flag: NONE bugfix
Test: Manual. Turn Talkback on, navigate to Overview, enter select mode,
select the whole TaskView, Talkback shouldn't have any accessibility
actions to execute.
Change-Id: I83dffce60f42cc32d83c499dfb08ddf97888f527
Olivier Nshimiye
Treehugger Robot
Vinay Joglekar
Alex Chau
Mykola Podolian
Shamali Patwa
Vadim Tryshev
Ana Salazar Maldonado
Schneider Victor-tulias
Ats Jenk
Charlie Anderson
ELIYAZ MOMIN (xWF)
Gustav Sennton
Federico Baron
Liran Binyamin
Bill Yi
Sunny Goyal
Michele Fan
Mady Mellor
Juan Sebastian Martinez
Marcelo Arteiro
Uwais Ashraf
samcackett
Johannes Gallmann