Commit Graph

22796 Commits

Author SHA1 Message Date
Vinit Nayak 39cc356a53 Merge "Start quickswitch on task switch instead of touch down" into ub-launcher3-rvc-dev 2020-06-01 20:32:14 +00:00
TreeHugger Robot 0e1cbf56aa Merge "Reset Overview layout after swiping to home" into ub-launcher3-rvc-dev 2020-06-01 19:24:54 +00:00
Vinit Nayak acd2f58693 Start quickswitch on task switch instead of touch down
Previously we would enter a quickswitch session state
whenever user tapped on navbar and sent flags to
sysui to only enable edge gesture for the current rotation.
Now we only do that on a new task resulting from the gesture
or when going into recents to show nav bar in the
orientation user would expect it (only if they never
quickswitched).

Fixes: 155844780
Test: Tested swiping back from quickswitching
into apps of different orientations.
Note that back is still broken when you
quickswitch and then rotate the foreground app.

Change-Id: I935e7c66489d46e59156414d64653c846ae4c5d8
2020-06-01 12:06:47 -07:00
Hyunyoung Song 2911c56a80 Merge "Migrate launcher home settings button tap/longpress logging to WW" into ub-launcher3-rvc-dev 2020-06-01 18:08:39 +00:00
Vinit Nayak 90b006dbe5 Reset Overview layout after swiping to home
Reset overview when user does a swipe to home
gesture. Preivously we only rest when user
first when to over, and then swiped to home.

Fixes: 156053957
Change-Id: I5a157f9e2229aba4b36851bd46d704a39d647110
2020-06-01 10:40:05 -07:00
TreeHugger Robot 6d9e0c4a55 Merge "More logging for pause non-detection" into ub-launcher3-rvc-dev 2020-06-01 17:27:10 +00:00
TreeHugger Robot 7149a7e0c5 Merge "Removes unused constant" into ub-launcher3-rvc-dev 2020-06-01 16:50:30 +00:00
Jon Miranda 10a6ed86eb More logging for pause non-detection
Bug: 156044202
Change-Id: I68d6febf4c201c2fea41c7e24600dcc2c54a680a
2020-06-01 09:39:13 -07:00
TreeHugger Robot 291f393b17 Merge "More logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-30 03:20:50 +00:00
Jon Miranda 77d8903f4a More logging for pause non-detection
Bug: 156044202
Change-Id: I0831735aa743360c16e1f940c30875f32432fec5
2020-05-29 19:43:52 -07:00
TreeHugger Robot ac38ec99c8 Merge "When tap on empty string edittext, and suggestion is made, select all the string" into ub-launcher3-rvc-dev 2020-05-30 01:51:24 +00:00
TreeHugger Robot 8a3be8cb53 Merge "Don't defer finish, only defer disableInputProxy" into ub-launcher3-rvc-dev 2020-05-30 00:41:06 +00:00
Hyunyoung Song 75dedacfc4 When tap on empty string edittext, and suggestion is made, select all the string
Bug: 157771174
Change-Id: I4a274333d897693bc214d50edcea30cf012ce859
2020-05-29 17:36:40 -07:00
Tony Wickham cc558e86fb Don't defer finish, only defer disableInputProxy
We should always finish the controller when requested, to ensure
everything is cleaned up immediately. But if touch is in progress,
we should keep input proxy enabled until touch up/cancel.

Test: swipe up to launcher and interact with it during the transition
- Swipe to recents and scroll it or dismiss the current task
- Swipe to home and open another app or swipe again on the nav bar

Bug: 157771305
Change-Id: Ida53289e4ecbd5e5d16933fcc79bbebdf1f8d898
2020-05-29 19:04:48 -05:00
Hyunyoung Song b117a9221c Migrate launcher home settings button tap/longpress logging to WW
Bug: 157777128
Change-Id: Ic88811efc9aef8f38a0e7e5ae79e3b35236c6663
2020-05-29 17:03:22 -07:00
Jonathan Miranda 02f0f82883 Merge "Fix depth jumping around during transitions." into ub-launcher3-rvc-dev 2020-05-29 22:31:54 +00:00
TreeHugger Robot 0e3572b953 Merge "[Overview actions] Remove unused duration variable." into ub-launcher3-rvc-dev 2020-05-29 22:00:42 +00:00
TreeHugger Robot 7fab619676 Merge "Animates a fake TaskView in Home gesture tutorial." into ub-launcher3-rvc-dev 2020-05-29 21:50:43 +00:00
TreeHugger Robot bc374cf7f2 Merge "Fix all apps alpha applying twice" into ub-launcher3-rvc-dev 2020-05-29 21:25:54 +00:00
Zak Cohen 0c8e20eea7 [Overview actions] Remove unused duration variable.
Test: local build
Change-Id: I2f18e77273753f491c6d802aa3b4406fefce6ad7
2020-05-29 14:15:09 -07:00
Andy Wickham f8a8117676 Animates a fake TaskView in Home gesture tutorial.
The "TaskView" morphs as you drag up from the
nav bar, and transforms into a "home icon" or
final "TaskView" when you release your finger.

If you cancel the gesture (e.g. drag back down),
the view simply fades out and provides a hint
to swipe straight up.

Demo: https://drive.google.com/open?id=1NXlO1W6IhLoX0k2K6b-QZ5IXp0o7OYqO

Bug: 148542211
Change-Id: I3d5e9a45fcadc6a498941ea17813b9487720a504
2020-05-29 14:06:36 -07:00
Andy Wickham 7e78e63d50 Removes unused constant
Change-Id: Ic3d96ae3791ba75c5ce6c1c00203bf9d21469fe5
2020-05-29 13:49:09 -07:00
Jon Miranda 84f6e0182e Fix depth jumping around during transitions.
This is caused because we use mDepth for depth comparisons, but there are
cases where we set mDepth but we do not pass that value to WallpaperManager
(ie. surface is null or not valid) and that leads us into
inconsistent states.

Bug: 155780358
Change-Id: I3faf14416d5783ad472892425eb0bd37dd469a46
2020-05-29 13:06:55 -07:00
Tracy Zhou 625bd51fe3 Merge "Delete PreviewSurfaceRendered (launcher3 fork)" into ub-launcher3-rvc-dev 2020-05-29 20:00:45 +00:00
TreeHugger Robot aaac3f1519 Merge "Fixing incorrect taskView size in multiwindow-landscape" into ub-launcher3-rvc-dev 2020-05-29 20:00:31 +00:00
Samuel Fufa dbb212e939 Merge "Remove dependency on Launcher notification for hotseat edu" into ub-launcher3-rvc-dev 2020-05-29 19:39:28 +00:00
Tracy Zhou 0a0255812b Delete PreviewSurfaceRendered (launcher3 fork)
We had this class when we used SysUI to pipe through surface rendering, but this is no longer used after we swtiched to public API.

Bug: 152003916
Test: N/A
Change-Id: I21459c254c1e200ad1a193536e826dae9be2561d
2020-05-29 12:08:18 -07:00
Tracy Zhou c577bb8425 Merge "Support predicted icons in preview" into ub-launcher3-rvc-dev 2020-05-29 18:06:23 +00:00
Tracy Zhou bc305fc7fe Support predicted icons in preview
Fixes: 152789575
Test: https://screenshot.googleplex.com/r3AtHp3TAh0
Change-Id: I22f7ee2a69f2df12ade16f50bf455651dbfce597
2020-05-29 09:58:01 -07:00
Tony Wickham 244e173a68 Fix all apps alpha applying twice
Test: quick switch from home, ensure QSB fades out at the same
rate as the workspace/hotsea

Change-Id: I59ecd0c65a6abf3e24ea1c2bfba3c84f6a88e653
2020-05-29 11:10:10 -05:00
TreeHugger Robot fd522fe13e Merge "Using unstable client for fetching test info for oop tests" into ub-launcher3-rvc-dev 2020-05-29 05:26:46 +00:00
Winson Chung bc849d6159 Using unstable client for fetching test info for oop tests
Bug: 157661745
Change-Id: Ifbb211f9bbaa444df682145a0a9e82c5d0f24bdf
2020-05-28 20:14:54 -07:00
TreeHugger Robot 172ea18639 Merge "Fix actions view showing up when it shouldn't in a couple spots" into ub-launcher3-rvc-dev 2020-05-29 01:16:31 +00:00
TreeHugger Robot 06fcfe1f5f Merge "Remove overview share to match spec" into ub-launcher3-rvc-dev 2020-05-29 00:40:20 +00:00
Tony Wickham 1fbf3c76f6 Fix actions view showing up when it shouldn't in a couple spots
- Replace HIDDEN_FULLSCREEN_PROGRESS with INDEX_FULLSCREEN_ALPHA
- When animating actions in after swiping to overview from an app,
  start at alpha 0 (since we setState(OVERVIEW) without animation
  when we settle, meaning alpha would already be 1).
- Fade in actions at the same duration as the icon scale when
  entering overview from an app
- Hide actions during quick switch from home

Tests:
- Start quick switch from home and swipe up back to home
- Start quick switch from home and swipe up to overview
- Go to overview from home
- Go to overview from an app
Verify actions don't appear on the first, and fade in
for the rest.

Bug: 157597385
Change-Id: I43a0be702066f91e13ce2a720278aae27160c557
2020-05-28 19:10:38 -05:00
Sreyas ae23746fa0 Remove overview share to match spec
Bug: 157174391
Change-Id: Iabfeb34b77abcb885b1518d348cac45e71dc92a9
2020-05-28 17:04:42 -07:00
Samuel Fufa f8613c67ba Merge "Flush pending logs before sending hotseat feedback" into ub-launcher3-rvc-dev 2020-05-28 23:57:04 +00:00
Samuel Fufa f0dc0b6ae0 Remove dependency on Launcher notification for hotseat edu
Doc: go/hybrid-hotseat-tips

Allow launcher to show hotseat education with intent action "launcher.show_hotseat_edu"

Bug: 157683315
Test: Manual
Change-Id: I62c79b821b79cf1adb831e2f79f6f0f02166ca42
2020-05-28 16:40:46 -07:00
TreeHugger Robot f8273b949f Merge "Fix QSB animating separately from workspace during stagger anim" into ub-launcher3-rvc-dev 2020-05-28 22:43:50 +00:00
Tony Wickham 5d4e8541d0 Fix QSB animating separately from workspace during stagger anim
- Don't play any state animation if animComponents == 0
- StaggeredWorkspaceAnim handles depth controller

Bug: 157596833
Change-Id: I6ae4c5da2e837c61b57349e708b7499af8e14aaa
2020-05-28 16:42:45 -05:00
TreeHugger Robot 065c84cbeb Merge "Putting Overview Share button behind flag" into ub-launcher3-rvc-dev 2020-05-28 20:38:46 +00:00
Sreyas dbedb91ad8 Putting Overview Share button behind flag
https://drive.google.com/file/d/1Io5N-LyXoRa9LHQjJNd1BAgBkVuBvnhr/view?usp=sharing
https://drive.google.com/file/d/15HhNvNoUn5qX1GhkjDaifA3G05PLoIwO/view?usp=sharing
Bug: 157174391

Change-Id: I8314d5aa309fe020a4121753d4e76ca10370c626
2020-05-28 12:03:12 -07:00
Sunny Goyal b46703d538 Fixing incorrect taskView size in multiwindow-landscape
RecentsView uses deviceProfile to calculate the padding.
Device profile had incorrect sizes in multiwindow mode as it
was not considering the insets.

Bug: 155816922
Change-Id: Iaa5b939624b4128ed634e6de1abf8453e2ae852b
2020-05-28 11:49:31 -07:00
Samuel Fufa a319f15f78 Flush pending logs before sending hotseat feedback
Test: Manual
Bug: 142753423
Change-Id: I0a5d8e4d50610d2681a707231319c38d3d7191ab
2020-05-28 10:41:47 -07:00
Tony Wickham b4d75d2931 Merge "Don't run finish callback until we actually finish" into ub-launcher3-rvc-dev 2020-05-28 17:18:09 +00:00
TreeHugger Robot ef7184c8a7 Merge "Logging to debug Overview Actions not working." into ub-launcher3-rvc-dev 2020-05-28 17:02:15 +00:00
TreeHugger Robot 938fccd3da Merge "Move content resolver call to constructor and cache" into ub-launcher3-rvc-dev 2020-05-28 05:55:42 +00:00
thiruram 62c7b5c8f7 Adds WW logging for QSB search results & all-apps predicted row.
SearchResultContainer represents apps rows displayed within QSB search results for both default scenario(without search term) and actual search result(with search term).

SearchResultContainer is used for both homescreen QSB and all-apps QSB.

Follow up CLs will add searchOrigin and queryLength in SearchResultContainer

Bug: 152978018
Change-Id: Id5f96490686c4141e3e6b2516907ac0505a777e6
2020-05-27 20:29:40 -07:00
Hyunyoung Song db8c1381d3 Merge "AllAppsSearch interface change Version 3" into ub-launcher3-rvc-dev 2020-05-28 02:06:26 +00:00
Tony Wickham 5cf9edc1f2 Don't run finish callback until we actually finish
This fixes the issue where the app re-appears on top if you touch
the nav bar during the animation to home.

The sequence of events leading to this behavior is pretty long,
but actually always should have happened, it was just masked
until the ag/11172732 fix went in.

Here's an abbreviated version of what was happening
on the touch down during the animation to home:
1 Set mRecentsAnimationController#mTouchInProgress = true
2 Cancel the running animation to home
3 onSettledOnEndTarget(HOME) (this is what was missing before)
4 finishCurrentTransitionToHome(), which, due to #1, doesn't
  actually finish the controller, but does run the callback
5 Invalidate the handler due to #4, leading to TIS#reset()
6 Create a new handler (still from the original touch down),
  which is mResetGestureInputConsumer
7 mResetGestureInputConsumer handles touch down to finish
  the controller the app

This change addresses #4. Instead of calling the callback
immediately, we defer it to when we actually finish the
controller, which ensures there's no longer premature
cleanup that leads to the rest of the sequence.

Bug: 157407284
Change-Id: I0b2ff57bfa77a25c2bf1aece4b0ae7f943637ce6
2020-05-27 19:26:16 -05:00