Commit Graph

38443 Commits

Author SHA1 Message Date
TreeHugger Robot 38b671d602 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev am: 36705e6039
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16273821

Change-Id: I07a1681b8d5ba1a5699537e4f6e5f981ae09718b
2021-11-16 20:39:18 +00:00
TreeHugger Robot 36705e6039 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev 2021-11-16 20:25:06 +00:00
TreeHugger Robot 506927514d Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev am: 82fc85f9b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16064580

Change-Id: I8f25b31835fc64a7f76ae7267e7bcb2a6a4d8434
2021-11-16 19:15:25 +00:00
TreeHugger Robot 82fc85f9b8 Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev 2021-11-16 19:00:47 +00:00
Alex Chau 0f38629826 Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev am: 1c4871298e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16166972

Change-Id: Icf8e6992c6b76fddca4ae25c81a66f6424d9554e
2021-11-16 18:57:56 +00:00
Alex Chau 04309940c0 If hometask is last task to be dismissed, show empty recents instead of home screen
- http://ag/16221737 ensure homescren stub is always added if tasks hasn't been loaded in RecentsView. This introduced an edge case that after dismissing home task view, no task remains in overview and it get dismissed
- The fix is to show empty recents instead of home screen if last task dismissed is a home task (showing empty recents isn't always correct, as there might be unloaded tasks, but it's better than dismissing overview)
- Also tuned the timing of when mLoadPlanEverApplied is set

Fix: 206462357
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I0f395639f57a1a57fddf750623a8a74b8ede8555
2021-11-16 18:48:28 +00:00
Alex Chau 1c4871298e Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev 2021-11-16 18:40:31 +00:00
TreeHugger Robot 49584c3412 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev am: d8a1b5c366
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214589

Change-Id: I8b3a32fd3c115a4f4276add4450a7f07081a1336
2021-11-16 17:03:44 +00:00
TreeHugger Robot d8a1b5c366 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev 2021-11-16 16:48:14 +00:00
TreeHugger Robot a8a8c75bd7 Merge "Revert "Add ScreenRecord to methods affected by a flaky problem"" into sc-v2-dev am: a6c4b66b7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16272580

Change-Id: Ic3f37f1c1803ac4fe19dc048932d77772e0d3105
2021-11-16 13:13:34 +00:00
TreeHugger Robot a6c4b66b7f Merge "Revert "Add ScreenRecord to methods affected by a flaky problem"" into sc-v2-dev 2021-11-16 13:03:33 +00:00
Alex Chau 033f2afe38 Revert "Add ScreenRecord to methods affected by a flaky problem"
This reverts commit ea6ee1c824.

Reason for revert: Seems to increase the severity of the flaky problem
Bug: 204807156

Change-Id: I7b87f2abf45c9da21981f9361e320163bd7834bd
2021-11-16 11:19:09 +00:00
Fedor Kudasov b807d92aa7 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev am: 72c8e71e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261398

Change-Id: Ic382d5886aa2df5c1bb8f981cbe626f031fd9c51
2021-11-16 10:44:07 +00:00
Fedor Kudasov 72c8e71e06 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev 2021-11-16 10:26:23 +00:00
Tracy Zhou 022c66327b Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781

Change-Id: Ie9ca6ecdd77ac76b5b93461b6c5d7d6e670b71a6
2021-11-16 09:57:38 +00:00
Tracy Zhou 0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
TreeHugger Robot ce57748e66 Merge "Add ScreenRecord to methods affected by a flaky problem" into sc-v2-dev am: fffea98399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261407

Change-Id: Iad0bec3854b6ccd77c4ab223b2476c619e123098
2021-11-15 21:45:24 +00:00
TreeHugger Robot fffea98399 Merge "Add ScreenRecord to methods affected by a flaky problem" into sc-v2-dev 2021-11-15 21:32:58 +00:00
Fedor Kudasov acf07f338e Simplify getTaskViewAt call am: 9d6fb64f45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16249427

Change-Id: If52c26a38fab17d294b08a34a3e41fd5f88cef27
2021-11-15 20:50:06 +00:00
Fedor Kudasov 3a0f8a90bd Annotate RecentsView with @Nullable
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I44a4f7ce4258e54d43ca2c5a3937c81a4a686f80
(cherry picked from commit ac9cee5a7c)
2021-11-15 20:39:07 +00:00
Fedor Kudasov 9d6fb64f45 Simplify getTaskViewAt call
RecentsView getTaskViewAt method is nullable and is safe
to call for an out of bound index.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I7709d63ad4490fd756a50caaf42ba70c4fad4d06
(cherry picked from commit 41edede1ee)
2021-11-15 20:37:12 +00:00
Alex Chau ea6ee1c824 Add ScreenRecord to methods affected by a flaky problem
Bug: 204807156
Test: none
Change-Id: I554c032b2ea43b8ee813f694d9c995f4ebc4a90f
2021-11-15 15:48:54 +00:00
Fedor Kudasov 913c8aee24 Merge "Add @Nullable annotations for simple cases" into sc-v2-dev am: ba47b591c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16246987

Change-Id: I4fe20700452492680e0ea1e30577ed04ecda0e4f
2021-11-13 09:17:31 +00:00
Fedor Kudasov ba47b591c4 Merge "Add @Nullable annotations for simple cases" into sc-v2-dev 2021-11-13 09:00:32 +00:00
TreeHugger Robot 239d9dfb4a Merge "Removing a dead test" into sc-v2-dev am: d5884f1c7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16249737

Change-Id: I730a4f5e8ead0daf32b257f1810e1aba32ef1380
2021-11-13 03:39:28 +00:00
TreeHugger Robot d5884f1c7b Merge "Removing a dead test" into sc-v2-dev 2021-11-13 03:26:11 +00:00
TreeHugger Robot 2bf1f507d4 Merge "Deletes old feature flags." into sc-v2-dev am: 3d7084863a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15507535

Change-Id: I6b0dd220f9beba2e8c9e40dd38a084a3a44f0d5d
2021-11-13 00:57:18 +00:00
TreeHugger Robot 3d7084863a Merge "Deletes old feature flags." into sc-v2-dev 2021-11-13 00:38:07 +00:00
Winson Chung 16d6010418 Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev am: ea77e49524
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16245857

Change-Id: Icad379bd6b9302e1dd2903e3e7f8d468f8d87718
2021-11-12 21:08:27 +00:00
Winson Chung ea77e49524 Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev 2021-11-12 20:51:15 +00:00
vadimt 581fbae506 Removing a dead test
Test: presubmit
Bug: 147235759
Change-Id: I1412360316c87813d309cfbc1deefad00e7dd2ce
2021-11-12 20:15:24 +00:00
Andras Kloczl 953eb8041e Fix LauncherProvider newScreenId issue
Remove maxScreenId from LauncherProvider and whenever we need
a new screenId, query the database to calculate a new screenId.
Also converted and refactored AddWorkspaceItemsTaskTest
and added some extra test cases.

Test: manual & AddWorkspaceItemsTaskTest.kt
Bug: 199160559
Change-Id: I185f6823fed171d778af0130497f5ffaf89c0a70
2021-11-12 19:56:07 +00:00
Alex Chau 45bb7b48ec Fix launch animation from grid am: f75725830a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240053

Change-Id: I6815036c3d3916a4378340c089a35339a52206d4
2021-11-12 18:13:10 +00:00
Alex Chau f75725830a Fix launch animation from grid
- Fixed calculateGridTaskSize to algin to taskRect instead of gridRect
- Extracted end of grid's scroll diff calculation to getOffsetFromScrollPosition to accurately calculate end of grid task's offset between its scroll and visual position (End of grid task's scroll is all the same at the position where ClearAllButton is just invisible)
- Extracted isGridTask in TaskView so TaskViewSimualtor can use the correct task size depedning if it's grid task or not

Bug: 200813202
Test: manual
Change-Id: I11a980345aee2680abf1c2563baadd9718a40192
2021-11-12 16:13:47 +00:00
Fedor Kudasov 2ca545c387 Add @Nullable annotations for simple cases
Add @Nullable annotations for the fields that are expected
to be null at arbitrary lifecycle time and are their usage
is protected by null checks.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I9c31e1dc0d01cdd68dfff0a005ba1f40c257f8ea
(cherry picked from commit 920dc2f28f)
2021-11-12 10:01:33 +00:00
Fedor Kudasov 820f8b6da4 Merge "Annotate AttributeSet with @Nullable" into sc-v2-dev am: 6c7c91fe86
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16233502

Change-Id: I44b3c235304572fc034a38584324a7f275fd24d9
2021-11-12 08:32:14 +00:00
Fedor Kudasov 6c7c91fe86 Merge "Annotate AttributeSet with @Nullable" into sc-v2-dev 2021-11-12 08:17:55 +00:00
Hyunyoung Song 9dfc2ba0a3 Merge "Address AppEventProducer to correctly send search-result location on AppTargetEvent" into sc-v2-dev am: 664f685336
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16235837

Change-Id: I015c3a22684a74c93241287dbcd27651fdf36ac3
2021-11-12 08:03:20 +00:00
Hyunyoung Song 664f685336 Merge "Address AppEventProducer to correctly send search-result location on AppTargetEvent" into sc-v2-dev 2021-11-12 07:46:23 +00:00
Winson Chung d0e6c8b2e7 Freeze task list if requested when launching split tasks
Bug: 206000278
Test: Quickswitch from app pair and back
Change-Id: I76af1396145e121e7f66f9e6b97f21a85c075e8e
2021-11-12 06:27:26 +00:00
Hyunyoung Song 1e5b621a50 Address AppEventProducer to correctly send search-result location on AppTargetEvent
Bug: 191362091
Test: logcat printout

11-10 20:27:02.290 32215 32237 D QuickstepModelDelegate: notifyAppTargetEvent action=1launchLocation=search-results

Change-Id: I16ef7679116e397a8a108cc291f5741febf2e453
2021-11-11 21:27:01 -08:00
Hyunyoung Song 5401d47b53 Merge "Add FeatureFlag to enable two line label inside all apps" into sc-v2-dev am: 3f14c80d4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16224885

Change-Id: I9f25d2fa72e5b6bc1ff4fff8de74ba92937583ab
2021-11-11 21:44:09 +00:00
Hyunyoung Song 3f14c80d4c Merge "Add FeatureFlag to enable two line label inside all apps" into sc-v2-dev 2021-11-11 21:29:30 +00:00
TreeHugger Robot 215a79a150 Merge "Update corner radius of both snapshot in app pair" into sc-v2-dev am: 916873e7ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240047

Change-Id: I20fb777687eb54d7710c59f875951946501b0350
2021-11-11 21:18:00 +00:00
TreeHugger Robot 3181cf0b1d Merge "Update Split Overview menu strings" into sc-v2-dev am: 39c22aa9ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240901

Change-Id: Ia2639bc3a0b7a1d8b1384518cfbc121c35679f22
2021-11-11 21:17:43 +00:00
TreeHugger Robot 916873e7ab Merge "Update corner radius of both snapshot in app pair" into sc-v2-dev 2021-11-11 21:15:18 +00:00
TreeHugger Robot 39c22aa9ad Merge "Update Split Overview menu strings" into sc-v2-dev 2021-11-11 21:07:37 +00:00
Alex Chau 80836f637f Update corner radius of both snapshot in app pair
Fix: 206002609
Test: manual
Change-Id: I6af28c6948769eac53326d61e84ac39196bd840f
2021-11-11 19:40:42 +00:00
Vinit Nayak 14ed91fb5b Update Split Overview menu strings
Bug: 181704764
Change-Id: Icaf51a702d529e20a0e65c4708fc7bc833e5eeeb
2021-11-11 11:20:04 -08:00
Samuel Fufa a9c199c6c8 Merge "[Search] Introduce notifyEvent api in OneSearch plugin" into sc-v2-dev am: 8727c4f78b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16223393

Change-Id: Ibe1305c72fb507d3c15d32cc4e962f7cf6ea16cc
2021-11-11 17:53:20 +00:00