Commit Graph

18858 Commits

Author SHA1 Message Date
Alex Chau 2db50a8545 Merge "Avoid adding unnecessary topMargin to TaskThumbnails in DesktopTaskView" into main 2024-04-25 14:45:59 +00:00
Alex Chau 191f4de96e Merge "Use BaseContainerInterface.getTaskDimension for windowSize in DesktopTaskView" into main 2024-04-25 10:09:58 +00:00
Alex Chau fa402d1da9 Avoid adding unnecessary topMargin to TaskThumbnails in DesktopTaskView
- TaskThumbnails in DesktopTaskView already take into account topMarign during onMeasure, we should avoid adding double margin
- mTaskThumbnailViewDeprecated's visibility is always GONE, so no need to set margin either

Fix: 336968808
Test: manual, image test to follow-up
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I6a7cb128ead0b042974b95199ab720cafc3bcc18
2024-04-25 10:57:30 +01:00
Holly Jiuyu Sun 96d8b02cf9 Merge "[omni] Read haptic bit from AGSA." into main 2024-04-25 06:09:03 +00:00
Jagrut Desai 52442466e8 Merge "Promote TaplTestsPersistentTaskbar to Presubmit" into main 2024-04-25 00:55:07 +00:00
Jagrut Desai 884dbdac37 Promote TaplTestsPersistentTaskbar to Presubmit
Test: Presubmit
Bug: 320490387
Flag: NONE
Change-Id: Ib09ac5d3e909864b9ef2c20a6dda79e4ed857227
2024-04-24 16:12:56 -07:00
Treehugger Robot f484664590 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-04-24 21:24:35 +00:00
Bill Yi e0d81cb351 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iec1f86e7d253eef8d040c6e257d1704b9b1dbc19
2024-04-24 09:50:58 -07:00
Holly Sun 430fdee946 [omni] Read haptic bit from AGSA.
Bug: 335475048
Flag: legacy OVERRIDE_LPNH_LPH_THRESHOLDS disabled
Test: manual
Change-Id: I8e4ebd9f7faecc236763db367be63cc47e7c0e31
2024-04-24 09:43:58 -07:00
Alex Chau 944a7a61ec Use BaseContainerInterface.getTaskDimension for windowSize in DesktopTaskView
- Instead of using widthPx/heightPx, use BaseContainerInterface.getTaskDimension that takes into account of whether Taskbar is persistent or pinned

Fix: 336788597
Test: Swipe up from Desktop; press recents button from Desktop
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I04d3b5bbc577ea650f8a9dc45cc6d01bca3f6466
2024-04-24 17:33:45 +01:00
Saumya Prakash 8245ac04e3 Merge "Only run search edu when enabled, also make code more generic." into main 2024-04-24 16:13:43 +00:00
Alex Chau de68b73d16 Merge "Avoid unnecessarily add stub task for Desktop task" into main 2024-04-24 13:28:27 +00:00
Jordan Silva d889ee37c9 Merge "Add a refactored TaskThumbnailView" into main 2024-04-24 11:53:17 +00:00
Alex Chau 576d6ba60e Avoid unnecessarily add stub task for Desktop task
- ag/27016210 caused a regression for DesktopTaskView, where shouldAddStubTaskView returns false whenever DesktopTaskView have multiple tasks
- This is because for an unknown reason, runningTasks for Desktop task is always a single element array. This will be further investigated in b/249371338
- For now, shouldAddStubTaskView will still match DesktopTaskView if any runningTasks matches any of the tasks

Bug: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Test: Swipe up from desktop
Flag: NONE
Change-Id: I40cff473595a21ad1619bcdbde30bb8bfd600e15
2024-04-24 12:25:03 +01:00
Treehugger Robot f87a1ec91e Merge "Add permanent TaskView logs to track taskIds being launched" into main 2024-04-24 10:14:44 +00:00
Himanshu Gupta 6fc5e7a010 Merge "Adding Tapl tests for User Installed App in PS." into main 2024-04-24 09:25:28 +00:00
Alex Chau aa10f54ace Add permanent TaskView logs to track taskIds being launched
Sample logs:
```
04-24 09:26:08.713 12608 12608 D TaskView: launchTaskInternal - launchExistingSplitPair: [1078, 925]
04-24 09:26:11.092 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [1078, 925]
04-24 09:26:13.940 12608 12608 D TaskView: launchTaskAnimated - startActivityFromRecents: [933, -1]
04-24 09:26:16.254 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [933, -1]
```

Bug: 310064698
Test: manual
Flag: None
Change-Id: Ic190bc9ea749ba4c8324832be8bc86112947b9ba
2024-04-24 09:26:20 +01:00
Alex Chau 0e5a4bb4bd Merge "Add stub task when matching TaskView is grouped while runningTasks is not grouped" into main 2024-04-24 07:07:50 +00:00
Julie Pan f3296f800d Merge "Remove mateuszc@google.com from quickstep/tests/OWNERS" into main am: 2eadab3702 am: f18ee90f03
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3038502

Change-Id: I47a7f594de62981ca4252c524e218597002d29b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 22:38:21 +00:00
Daniel Akinola a0ce634e2c Merge "Force calculator to launch in fullscreen for quickswitch tests" into main 2024-04-23 22:33:50 +00:00
Uwais Ashraf e21525da40 Add a refactored TaskThumbnailView
- Live Tile, swipe (left+right) and dismiss working
- Tests of ViewModel state transitions
- Deprecate the old TaskThumbnailView
- Renaming TaskThumbnailView to TaskThumbnailViewDeprecated

Fix: 335440878
Fix: 331754672
Bug: 331753115
Test: TaskThumbnailViewModelTest
Test: Attached video on bug
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: I063b957fe6e56960970dcaadc641848fbd73251c
2024-04-23 23:05:14 +01:00
Saumya Prakash 17cd6ca62a Only run search edu when enabled, also make code more generic.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.

Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
2024-04-23 22:02:15 +00:00
Alex Chau 492965326e Add stub task when matching TaskView is grouped while runningTasks is not grouped
- Completely rewrote shouldAddStubTaskView to simplify the logic

Fix: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Flag: None
Change-Id: I2f33f91956d485957cedf43ccd684f16d42803be
2024-04-23 20:37:44 +01:00
Winson Chung a9ccb34d1c Merge "Migrate PackageManagerHelper to MainThreadInitializedObject" into main 2024-04-23 18:10:56 +00:00
Sunny Goyal edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Fengjiang Li 02ff0add09 Merge "[Launcher Jank] Schedule LauncherApps#getAppUsageLimit on single bg thread" into main 2024-04-23 17:46:26 +00:00
dakinola 41fcfc1f72 Force calculator to launch in fullscreen for quickswitch tests
Follow on to ag/27050655 to fix last flaking test suite, while investigating proper fix

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsKeyboardQuickSwitch
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: I28df139779af49b7bc8da567cfe67e5d43b224e9
2024-04-23 16:49:23 +00:00
Himanshu Gupta 102b723d63 Adding Tapl tests for User Installed App in PS.
This test verifies that a user installed app
is shown above the sys apps divider, within the
Private Space container.

Bug: 322882655
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest
Flag: NA
Change-Id: Id85105339ae45c263d9ef52a3bb55784587e887d
2024-04-23 15:22:43 +01:00
Gustav Sennton 568e0bff90 Merge "Show running apps in Taskbar when in Desktop Mode" into main 2024-04-23 14:02:11 +00:00
Gustav Sennton 0b33b172fb Show running apps in Taskbar when in Desktop Mode
In Desktop Mode: show currently running (Desktop) apps in Taskbar

Bug: 332504528
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT

Change-Id: I10dec022f4b16562e81d7cbd5f9ce835474e9d20
2024-04-23 10:43:27 +00:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
dakinola 8771dfe3dd Force calculator to launch in fullscreen for taskbar tests
Taskbar tests are flaking when desktop windowing is enabled due to calculator app being launched in splitscreen unexpectedly during test setup (due to unexpected effect of DesktopModeLaunchParamsModifier on activity launch.) While looking into root cause, this temporary fix to address the test failures ensures that calculator app is always launched in fullscreen, by enforcing it with ActivityOptions.

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: If12e8490214aa1dd5de89ff8535495c2a0c1fe82
2024-04-22 21:42:09 +00:00
Liran Binyamin 5905d55a9d Merge "Only animate bubbles when in app" into main 2024-04-22 21:38:39 +00:00
Federico Baron e419495cc9 Merge "Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent" into main 2024-04-22 21:05:47 +00:00
Bill Yi 4c104aa40b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-04-22 20:43:11 +00:00
Federico Baron 9a5bdb3b3f Merge "Add screenrecord to test with "Only System UI views are visible" message" into main 2024-04-22 20:28:27 +00:00
Liran Binyamin 3232d8a5e7 Only animate bubbles when in app
We currently animate bubbles on home but the animation hasn't been implemented properly yet, so ensure we don't play the animation on home.

This also deflakes some tests that fail because we're not yet handling interruptions while animations are playing.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Fixes: 333796110
Fixes: 333910495
Fixes: 336086185
Test: https://android-build.corp.google.com/builds/tests/view?invocationId=I78600010269170812&testResultId=TR95029270629703599&redirect=http://fusion2/ac10ec72-4e02-4573-86be-59ecb823ecd1
Change-Id: I99de02cbaebeb6c930a1368ea65562aa178f6762
2024-04-22 19:11:25 +00:00
fbaron 3f58b471af Add screenrecord to test with "Only System UI views are visible" message
Flag: none
Test: TaplTestsTrackpad#switchToOverview
Bug: 335674307
Change-Id: Icabc13814163deaecaa14dd12bbd41f62074b4d5
2024-04-22 11:28:25 -07:00
Fengjiang Li 7686997079 [Launcher Jank] Schedule LauncherApps#getAppUsageLimit on single bg thread
b/336326937 shows that getAppUsageLimit is being called a lot and it's scheduled on a thread pool, which is causing quite a lot of contention and should be scheduled on a single thread

Fix: 336326937
Flag: NONE
Test: presubmit
Change-Id: Ie041e72f2bff9f5d2dbfa4ce3c63a4bb2e5b08d4
2024-04-22 11:24:04 -07:00
Schneider Victor-tulias 77d3524b1b Merge "Remove debug tracing for b/332386996" into main 2024-04-22 18:01:57 +00:00
fbaron 4f836430a7 Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent
Bug: 334946529
Test: TaplPrivateSpaceTest#testPrivateContainerIsPresent
Flag: none
Change-Id: I8f2d97c4d29d91389c3d20558ea6e3977deb322c
2024-04-22 09:58:53 -07:00
Treehugger Robot 774d05e970 Merge "Remove debug tracing for b/321775748" into main 2024-04-22 16:35:32 +00:00
Schneider Victor-tulias abf9f308a5 Remove debug tracing for b/332386996
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
2024-04-22 16:16:42 +00:00
Mykola Podolian 1f40fa0e7f Merge "Updated pointer to match visual specification." into main 2024-04-22 16:06:39 +00:00
Schneider Victor-tulias 3f8eea99e3 Remove debug tracing for b/321775748
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
2024-04-22 09:55:49 -04:00
Winson Chung bb32b7e0de Migrate PackageManagerHelper to MainThreadInitializedObject
- This is in preparation for other things that can be loaded with
  PMH initialization and prevents duplicate temporary helpers from
  loading this many times.
- Most calls in PMH can use the app context, but one call requires
  starting activities/showing toasts so that one needs to take the
  context and can be made static instead.

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: Id11c780955880cf49c022cbf2744c41e1b696355
2024-04-22 12:35:03 +00:00
Bill Yi e0968bbe1e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I21d47a6b4bbec3abb9688b88caff2b99fb58f4f1
2024-04-21 18:46:43 -07:00
Schneider Victor-tulias 1ebeb1d1ae Merge "Update KQS to better support desktop tasks" into main 2024-04-22 01:37:39 +00:00
Bill Yi e0105a648a Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-04-20 00:45:08 +00:00
Eghosa Ewansiha-Vlachavas 0c338f3055 Merge "Check RecentsView is not null before use in AbsSwipeUpHandler" into main 2024-04-19 20:25:21 +00:00