Commit Graph

16310 Commits

Author SHA1 Message Date
Sunny Goyal 36b2fca3bd Merge "Reset the vertical progress when the discovery bounce is closed" into ub-launcher3-edmonton 2018-05-22 22:20:54 +00:00
TreeHugger Robot 085cebc741 Merge "Skip processing fallback icons as they are already badged and have shadow" into ub-launcher3-edmonton 2018-05-22 22:00:05 +00:00
TreeHugger Robot d1134a0295 Merge "Making overview panel accessible via Tab" into ub-launcher3-edmonton 2018-05-22 22:00:02 +00:00
Vadim Tryshev f1507a6a64 Making overview panel accessible via Tab
Keyboard navigation of AllAppsContainerView is broken in TOT; disabling
focusing there is necessary for Recents.

Bug: 72222505
Test: Manual
Change-Id: I85d544f7c8dbdaf12e49de51c6626bbc3dc32917
2018-05-22 14:47:44 -07:00
TreeHugger Robot c7ffd730a5 Merge "Tighten up loading of visible task data" into ub-launcher3-edmonton 2018-05-22 21:41:47 +00:00
Winson Chung 15067109b1 Tighten up loading of visible task data
- Certain animations can run after the launcher state has changed,
  triggering loading of task data even when the overview state is not
  visible. Only allow re/loading of this data when we are in the overview
  state.

Bug: 76162466
Change-Id: Ie1f492ef712ea4aa2db6f2e1bc7ba4390742875b
2018-05-22 14:05:22 -07:00
Tony Wickham dcae7e2b24 Merge "Cleanup how we set back button alpha" into ub-launcher3-edmonton 2018-05-22 19:06:02 +00:00
Sunny Goyal 0bd0244a73 Reset the vertical progress when the discovery bounce is closed
Since discovery bounce runs on absolute values, it can sometime leave the vertical progress
at an old value, if it is closed after the state change.
Also simplifying discovery bounce animation to use xml everytime.

Bug: 80099242
Change-Id: Iebc249dd02f474cbed85b695eeeb8c2bf60b935d
2018-05-22 11:40:58 -07:00
Vadim Tryshev 783cd3cf21 Making clear-all action accessible on a fallback Overview.
Bug: 72222505
Test: Manual
Change-Id: I063081b4fa009882e50852e107490fddae0f86b7
2018-05-22 11:06:36 -07:00
Tony Wickham 4e21c1b552 Cleanup how we set back button alpha
Add BackButtonAlphaHandler to set back button alpha, instead of setting
it from multiple places.

Also force back button alpha to be 1 if swipe up is disabled (b/80091187)

Change-Id: I49b63a0e6b033a3a947a847669a398f1b9ff0564
2018-05-22 11:05:01 -07:00
Tony Wickham 8417a7b514 Bound recents content alpha to 0 and 1
Now that we use OvershootInterpolator for the atomic recents animation,
it's possible to get alpha > 1. The drawable and text paint used in the
empty recents state doesn't handle this well, causing alpha to jump to 0
in this case. Instead, we'll just force it to clamp to 1 ourselves.

Bug: 80004542
Change-Id: Id0177caf63cd349f6f27c9dfaf0e8995447e70fc
2018-05-21 17:11:24 -07:00
TreeHugger Robot 52cb0a73a4 Merge "Go back to previous state when hitting back from discovery bounce" into ub-launcher3-edmonton 2018-05-21 23:11:56 +00:00
Tony Wickham 52c1b66f46 Go back to previous state when hitting back from discovery bounce
Normally when you hit back, we just close the floating view if there
is one. This makes less sense for DiscoveryBounce, since it doesn't
feel like a different state even though it's technically a floating
view. So in that case, don't consume the back press; let launcher
handle it to go to the previous state.

Bug: 80075741
Change-Id: I7270b61be70509cb2101400a12929478a5d082aa
2018-05-21 16:01:49 -07:00
Hyunyoung Song bd6fba9f58 onResume event should be logged (not twice but once)
Bug: 79541772

Change-Id: I5fe1271007e4579e1ec95d51c215ef48d0c6eedd
2018-05-21 12:27:46 -07:00
TreeHugger Robot 7b19b16f09 Merge "Never setting accessibility focus manually" into ub-launcher3-edmonton 2018-05-21 19:21:47 +00:00
Vadim Tryshev 00e0b91917 Never setting accessibility focus manually
This will result in the focus going to the second from the right task
upon opening Recents. This will be mitigated by implementing in near
future announcements like Task 6 out of 7.

Besides this, due to (presumably) problems external to Launcher, the
focus may stay on Home button or completely disappear upon opening
Recents.

Bug: 72222505
Change-Id: I0e5ac62bfa0e1c0db2d17a6014e61f82cfccf252
Testing: Manual
2018-05-21 19:04:05 +00:00
Tony Wickham e542e91191 Merge "Cleanup UserManagerCompatVP to not use reflection" into ub-launcher3-edmonton 2018-05-21 18:18:47 +00:00
Tony Wickham a9cc397673 Cleanup UserManagerCompatVP to not use reflection
Change-Id: I1e4afc9c36f9d8641799b70e83f6b9801aec2e3d
2018-05-21 10:54:09 -07:00
Tony Wickham e2116daa88 Merge "Don't prevent animations in power save mode" into ub-launcher3-edmonton 2018-05-21 17:51:35 +00:00
Vadim Tryshev 98913d0c95 Remove code duplication
Bug: 72222505
Test: Manual
Change-Id: I6ae6ac7474b44c16bd765635e32d2e843bc02cac
2018-05-18 18:41:34 -07:00
Vadim Tryshev b05b489f04 Merge "Hide clear-all button from accessibility" into ub-launcher3-edmonton 2018-05-19 01:11:00 +00:00
Vadim Tryshev 4ae69dea49 Merge "Fixing reverted order of accessibility scrolling in Recents" into ub-launcher3-edmonton 2018-05-19 00:54:37 +00:00
Vadim Tryshev bad1c73e73 Hide clear-all button from accessibility
This solves muliple navigation problems in Overview.

Bug: 79165501
Change-Id: I2ae99fe3ad24194c9516bb2a99344289ef7408e8
Testing: Manual
2018-05-18 17:28:19 -07:00
Tony Wickham 8155fa2aa5 Don't prevent animations in power save mode
Now that batter saver mode doesn't get rid of animations in P, we
shouldn't use custom logic to prevent them either.

Also updated ATLEAST_P to use version code.

Bug: 79990054
Change-Id: If17cf369035c976f3d9d81f35432a045f1956ce5
2018-05-18 17:18:49 -07:00
TreeHugger Robot 3bdb81868d Merge "Making sure the task open animation runs for the correct user tile" into ub-launcher3-edmonton 2018-05-18 22:26:35 +00:00
Sunny Goyal 2bf60f406c Merge "Preventing activity restoart on mnc/mcc changes" into ub-launcher3-edmonton 2018-05-18 21:35:51 +00:00
Sunny Goyal 0751929ec2 Making sure the task open animation runs for the correct user tile
Bug: 79995913
Change-Id: I3223f25e3870bac526f8960ed3d00949650bca3b
2018-05-18 14:33:36 -07:00
TreeHugger Robot 5322e62f81 Merge "Some quick scrub fixes" into ub-launcher3-edmonton 2018-05-18 21:29:11 +00:00
Sunny Goyal 32359e6b85 Some quick scrub fixes
> Skipping quick scrub, if its already in progress, or is waiting on previous task launch
> Restoring to proper state is the task animation is cancelled before launcher gets onStop
> Crash when using quickscrub before last list has loaded

Bug: 77289180
Bug: 77856587
Bug: 79919440
Change-Id: I8db127bf9539cfc8f47c1e86c5030637845749d4
2018-05-18 14:10:41 -07:00
Sunny Goyal f5c5d04b3b Preventing activity restoart on mnc/mcc changes
Bug: 77651657
Change-Id: I68a6995d57da4b3c43c1ecd78deda40c78934533
2018-05-18 13:46:15 -07:00
Winson Chung 1b74bd652c Use actual quickstep callback to track gesture start
- Better than using the threshold ourselves, we should just use the callback
  from the system.

Bug: 79970627
Change-Id: Ida15cfdaa2463f9fa15e222c55e483eb145c2716
2018-05-18 10:29:30 -07:00
Tony Wickham f9d38098ca Merge "Fix a couple issues with swiping up from home" into ub-launcher3-edmonton 2018-05-18 16:50:47 +00:00
Winson Chung fdf9315b8e Fix thresholds with deferred-start swipe up gestures
- We were previously using the drag threshold (10dp) for both gesture start
  and drag start, when we should be using the touch threshold (24dp) for
  the deferred gesture start to ensure it coincides with the touch threshold
  for the buttons in the nav bar.

Bug: 79970627
Test: Swipe up over the back button, ensure that we don't both start the
      animation and also trigger back press

Change-Id: Ib4b2a3e2492da144485f87be5477eabf3e96e843
2018-05-18 09:13:17 -07:00
TreeHugger Robot f3cc505e86 Merge "Fade back button in and out tied with the overview/shelf (2/3)" into ub-launcher3-edmonton 2018-05-18 00:58:47 +00:00
Matthew Ng 8b92fe336b Fade back button in and out tied with the overview/shelf (2/3)
Back button changes opacity when moving the shelf during swipe up
between home screen and overview. The alpha changes depending on the
progress of the swipe up animation. When going from app to home and vice
versa, the fade animation does not tie with the swipe up progress. The
fade animation also masks the back button drawable when ime visibility
changes.

Change-Id: I51e42930640ba711e81880b385bb722d7ee8ad33
Fixes: 74581837
Fixes: 76900236
Test: swipe up from home screen to overview
2018-05-18 00:48:51 +00:00
Tony Wickham 7de574175b Fix a couple issues with swiping up from home
- Don't update the animation to go from 0 to 1; instead, update the
  interpolator to clamp to the remaining progress (b/79773309)
- Fix NPE that can happen in a race between the atomic animation
  ending and the non-atomic animation canceling/ending

Change-Id: I313251dc5cbd7b931b043fc3e840bb4ab368a790
2018-05-17 16:30:46 -07:00
Sunny Goyal fbf327f9ee Skip processing fallback icons as they are already badged and have shadow
Bug: 79496830
Change-Id: I3e601fda570eefdb277bfd50c846c5a2864f4b3a
2018-05-17 15:29:44 -07:00
TreeHugger Robot f85d083980 Merge "Only remove task if it was uninstalled or removed from the recents list" into ub-launcher3-edmonton 2018-05-17 22:18:12 +00:00
Winson Chung 0e2aa7a264 Only remove task if it was uninstalled or removed from the recents list
- Was missing additional checks and unconditionally removing the task
  whenever the task was removed from the active tasks in AM. Instead, check
  that the app still exists both in the system and in the recents list
  before removing.

Bug: 79698015
Test: a) get incoming call, go to overview, end call and ensure removed
      b) install app, open app, go to overview, uninstall app and ensure removed

Change-Id: I8901cb232ef7ff0759923d6a98f65df4e4adf88b
2018-05-17 14:53:55 -07:00
TreeHugger Robot 48059dc706 Merge "Fixes a crash when turning off workprofile while the workprofile tab is active." into ub-launcher3-edmonton 2018-05-17 15:51:40 +00:00
Mario Bertschler d460c084eb Fixes a crash when turning off workprofile while the workprofile tab is
active.

Bug: 79735930

Change-Id: Iafaddf827e648c9d39df78393a96f90dfc86fcca
2018-05-17 10:12:28 +02:00
Mehdi Alizadeh 64d19820f6 Merge "Use overlay settings for Swipe Up gesture default" into ub-launcher3-edmonton 2018-05-17 00:30:21 +00:00
TreeHugger Robot 8dcdcd9843 Merge "Fixing taskView not centered properly in available width" into ub-launcher3-edmonton 2018-05-16 23:53:20 +00:00
Tony Wickham b2ddf10041 Update interpolators and durations for state animations
When we enter overview (overview appears, workspace disappears):
- Workspace scales down from 1f to .8f with OvershootInterpolator(1.2f) at 200 ms
- Workspace fades from 1f to 0 with OvershootInterpolator(1.2f) at 200 ms
- Overview scales down from 1.33f to 1f with OvershootInterpolator(1.2f) at 200 ms
- Overview fades from 0 to 1f with OvershootInterpolator(1.2f) at 200 ms

When we exit overview (overview disappears, workspace appears):
- Workspace scales up from .92f to .1f with DecelerateInterpolator() at 200 ms
- Workspace fades from 0 to 1f with AccelerateInterpolator() at 200 ms
- Overview scales up from 1f to 1.1f with AccelerateInterpolator() at 180ms
- Overview fades from 1f to 0 with DecelerateInterpolator(1.7f) at 200 ms

Parallax while the finger moves: Workspace translates half the distance as the shelf

Bug: 79776746
Change-Id: I319d982cf202bcd6dbbcd68ffc5c0c7853629c7e
2018-05-16 15:59:31 -07:00
TreeHugger Robot 07b8b0b1f0 Merge "Fix bug where Workspace page alpha stays 0 in SpringLoaded mode." into ub-launcher3-edmonton 2018-05-16 22:51:44 +00:00
Sunny Goyal d62e14e539 Fixing taskView not centered properly in available width
Bug: 79756414
Change-Id: Iec6b22f96f883d61f430599e34ff9ebe91d91924
2018-05-16 15:46:13 -07:00
Mehdi Alizadeh 25a8e6f063 Use overlay settings for Swipe Up gesture default
Implements the following logic:

if config_swipe_up_gesture_setting_available is false, always use the
default value in config_swipe_up_gesture_default and ignore
Settings.Secure

if config_swipe_up_gesture_setting_available is true, use
config_swipe_up_gesture_default as the default value for
Settings.Secure, and respect Settings.Secure if user makes any changes.

Bug: 78641268
Test: Manual test
Change-Id: I586083b6655ccb3c94f08a911ed0de80f4738d62
2018-05-16 15:36:00 -07:00
Jon Miranda 8d994cd6d5 Fix bug where Workspace page alpha stays 0 in SpringLoaded mode.
The page alpha gets set to 0 by updatePageAlphaValues sometime between
Workspace calling goToState(SPRING_LOADED) and onStartStateTransition.

By the time the transition is over, Workspace is no longer in a modal state
and so alpha never gets restored via updatePageAlphaValues.

Bug: 76449277
Change-Id: I95241395594dd9084763cc3bc51bc55319cadb73
2018-05-16 15:32:54 -07:00
Tony Wickham 2c27df5b5d Merge "Set status bar icons to dark at correct all apps progress" into ub-launcher3-edmonton 2018-05-16 22:23:50 +00:00
Vadim Tryshev e628c474ea Fixing Recents sometimes restoring in Clear-all-reveal position.
This happened if a task was added between openings of Recents.

Bug: 72222505
Test: Manual
Change-Id: Id4cc8e7cbdb493973d329466369b62e4ac8ee0b3
2018-05-16 15:00:52 -07:00