- Without this annotation, everytime the PerDisplayRepository is requested, a new PerDisplayRepository is created effectively not functioning as a repositroy.
- This caused RotationTouchHelper to be created whenever get() is called, thus losing its state across the swipe gesture
Fix: 409722063
Fix: 409258907
Test: manual
Flag: EXEMPT bug fix
Change-Id: Ibde4c6ce18b96bafea1c40d8c69a4552f371501a
If recents view is not attached to window when applyLoadPlan is called, then the taskviews will never update until mTaskListChangeId is invalidated. This mainly affects RecentsWindowManager, so added a callback to only initialize after recents view has attached to window.
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/post-submit tests; opened overview several times
Change-Id: Ie430fb5b0b2b6870c12fed1c6a394088cad1ac17
- Also limit usage of displayContext on getWindowCornerRadius only, any other usage causes perf regression
- Note that displayContext does not respond to configuration changes, there might be existing functionality bug already that resources are stale after configuration changes, keeping b/408988616 open to handle it in the future
Bug: 408988616
Fix: 409222870
Fix: 409252967
Test: presubmit and ABTD
Flag: EXEMPT refactor
Change-Id: I024c76326a2deb1ecc035de8319976e31887486b
Bug: 406452076
Test: atest NexusLauncherTests:QuickstepKeyGestureEventsHandlerTest
Test: atest NexusLauncherTests:AllAppsActionManagerTest
Test: atest NexusLauncherOutOfProcTests:com.google.android.apps.nexuslauncher.TaplTestsNexus
Test: Verfiy manually that meta key event triggered all apps if the display focused is the default display.
Flag: com.android.window.flags.enable_key_gesture_handler_for_recents
Change-Id: I654cdf527670fddc0bd6eb4d8cab18a9e1206ec1
Previously snapToPageImmediately was used, but that was the wrong method.
Bug: 408227356
Test: Verified that the animation runs well locally on device.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Iedee458e61de2d3542137615d3ff86cb42bdfb02
setLaunchedFromA11y makes keyboard not to be shown when "swipe to start search" toggle is off and we do launcher.getStateManager().goToState(ALL_APPS)
"All Apps" was added to Menu as part of A11y requirement in b/386737601, so using setLaunchedFromA11y looks right.
Video : https://b.corp.google.com/issues/407947978#comment9
Bug: 407947978
Test: Manual
Flag: EXEMPT Bugfix
Change-Id: I84162940330a74b3433f7835753151adf55857e7
Bug: 407630150
Test: Manual testing, that's why the bug happen in the first place, working on adding tests, for now this fixes the issue.
Flag: EXEMPT bug fix
Change-Id: I98c9d4bb28a3f02ee6e54c66eadb54445c56aeec
- When onPrepareGestureEndAnimation is called, we already know the end target is Overview, loading thumbnail at this point ensure thumbanil is loaded throughout the transition
Fix: 407525135
Flag: com.android.launcher3.enable_grid_only_overview
Test: Home/app to Overview with gesture/3button
Change-Id: Ie91d3989654ff17df94704275523ca097f786293
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
similarly
This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.
Reason for revert: Reland previously reverted CL's with fixes
Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
Also swap surface only when required.
Fix: 404647629
Fix: 408937692
Test: Manual. Enter/Exit overview from home/app
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I1562ed11a14021565ec9b9560b7f0d7d2b1468c6
Bug: 394355070
Test: Attached a screen recording of correct behavior to the bug.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I1e99c4eb9ae79b7d00dadf286689cceb2f0e706e
Snap last grid task to hide clear all during scrolls as well.
Fix: 389081467
Test: TaplTestsSplitscreen
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I153b3dcacdf634358416f0793804c1c4c099a993
- Makes sure view is removed and set to null
- Makes sure draglayer is visible before trying
to copy it to the snapshot. I wasn't able to repo
the ANR, so will need to keep an eye on it once we
re-enable the flag.
Test: open/close shade multiple times
trigger launcher recreate by toggling dark theme
no leak detected in AS
Fixes: 404331867
Bug: 408450275
Flag: com.android.launcher3.enable_taskbar_behind_shade
Change-Id: Ide375943214548b938953230e2140d4df23317df
1. Introduce a `groupTask` property to `TaskView` and let all the
`bind` functions take a type of `GroupTask` as the parameter
instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
`GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
we can avoid the corresponding `deskId` being set to invalid
on `removeViewInLayout` in the main thread, which might happen
before `removeGroupTaskInternal`.
Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
Schneider Victor-tulias
Alex Chau
Sergey Pinkevich
Treehugger Robot
Stefan Andonian
Steven Ng
samcackett
Uwais Ashraf
Ajinkya Chalke
Sebastián Franco
Brian Isganitis
Anushree Ganjam
Perry Wu
Vinay Joglekar
Graciela Putri
Pat Manning
Jagrut Desai
Jon Miranda
minch
Sunny Goyal