Commit Graph

14806 Commits

Author SHA1 Message Date
Sunny Goyal 3277771b47 [automerger] Adding scrim in all-apps scrim am: 81a70e5dc2
Change-Id: I75c0bca2b2b9c70c2e13e236a92dc0f46a4bc252
2017-08-24 22:11:25 +00:00
Sunny Goyal 81a70e5dc2 Adding scrim in all-apps scrim
Bug: 64692527
Change-Id: Ib8262ad0cc3c95cd419eb9fa1dee3bbbc2d25a27
2017-08-24 15:11:18 -07:00
Mario Bertschler fe2893b2a1 Merge changes from topic "am-b7c4122a-a8cc-4b3b-b83c-0c9eba63d2ad" into ub-launcher3-master
* changes:
  [automerger] Adjusting opacity values for all apps. am: f30c63c593
  Adjusting opacity values for all apps.
2017-08-24 17:33:52 +00:00
Mario Bertschler 9b745a82bf Merge "Adjusting opacity values for all apps." into ub-launcher3-dorval-polish2 2017-08-24 17:33:52 +00:00
Hyunyoung Song 67e6d18ee9 Merge "Remove flicker when multiple apps are added/removed/updated on widget tray" into ub-launcher3-dorval-polish2 2017-08-24 07:40:01 +00:00
Hyunyoung Song fe45ead7af [automerger] Remove flicker when multiple apps are added/removed/updated on widget tray am: 8e5464b544
Change-Id: I070a617828dedc19cbacefd6dd6c15337c1b85d6
2017-08-24 01:04:56 +00:00
Hyunyoung Song 8e5464b544 Remove flicker when multiple apps are added/removed/updated on widget tray
Bug: 36718342

1.The flicker was also happening partially because notifyWidgetProviderChanged
callback also made the entire widget list to update in addition to
packageManager update.

2. Now that adapter calls notifyItemInserted, Removed, the recycler
view uses it's internal animation to elegantly move items or insert
them. (added benefit!)

3. Added tests for WidgetsListAdapterTest

$ adb shell am instrument -w -e class com.android.launcher3.widget.WidgetsListAdapterTest com.google.android.apps.nexuslauncher.tests/android.support.test.runner.AndroidJUnitRunner

com.android.launcher3.widget.WidgetsListAdapterTest:.

Time: 0.337

OK (6 test)

Change-Id: I0818d546532631bf889fae560118decff64ec5a4
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2017-08-23 18:04:37 -07:00
Sunny Goyal c9dadbdd88 [automerger] Applying the widget resize changes even when the activity is destroyed in the middle of the resize interaction. am: 988ad27be4
Change-Id: I39f49270679cccc93a84259a90e24925df77d9a3
2017-08-23 21:19:43 +00:00
Sunny Goyal 988ad27be4 Applying the widget resize changes even when the activity is destroyed
in the middle of the resize interaction.

Bug: 64759853
Change-Id: I65ab7df0426f36fe1121bf055e38fc722822b0f4
2017-08-23 21:19:42 +00:00
Jonathan Miranda 4ec0d61ee8 [automerger] Show progress dialog when uninstalling an app in Launcher3Go. am: c56e3ff2ee
Change-Id: I9c9b9d8c3159d9c49e20f277bc17b0608571f134
2017-08-23 19:14:04 +00:00
Jon Miranda c56e3ff2ee Show progress dialog when uninstalling an app in Launcher3Go.
This ensures that the uninstall activity will finish only after
the task is completed.

We initially assumed that this was always the case, but in Android
Go the uninstall activity finishes before the uninstall is completed.

Bug: 64033585
Change-Id: Ic5d8dd99e2fecd0c9cb24093ee66668b4b38cb1a
2017-08-23 12:13:24 -07:00
Tony Wickham b5793403eb Merge changes from topic "am-99d3d54c-2af9-430d-b857-e57c745fb7d9" into ub-launcher3-master
* changes:
  [automerger] Remove notification dots setting for Launcher3Go am: c138515c4e
  Remove notification dots setting for Launcher3Go
2017-08-22 18:43:13 +00:00
Tony Wickham 86ba394ad0 Merge "Remove notification dots setting for Launcher3Go" into ub-launcher3-dorval-polish2 2017-08-22 18:43:13 +00:00
Mario Bertschler 996b1fd84c [automerger] Adjusting reflection api for color addOnColorsChangedListener that caused reflection to break. The new api method is available in both DR and MR1. am: 78356a542e
Change-Id: I6623a6bacab9fc1d409e62f5e1a4c7955a183af5
2017-08-21 22:26:39 +00:00
Mario Bertschler 78356a542e Adjusting reflection api for color addOnColorsChangedListener that
caused reflection to break. The new api method is available in both
DR and MR1.

Bug: 64908004
Bug: 64839046
Change-Id: I812c320e2c817aea8264de8764e33ad218b591c5
2017-08-21 15:25:55 -07:00
Mario Bertschler f3eef05cad [automerger] Adjusting opacity values for all apps. am: f30c63c593
Change-Id: I54c4b571ed3acc68705be497e4e42bcc90d9c241
2017-08-21 19:33:11 +00:00
Mario Bertschler f30c63c593 Adjusting opacity values for all apps.
Bug: 64899571
Change-Id: Ida4ee441d604b18ed3e5a687a85c7836eedd0e94
2017-08-21 12:32:42 -07:00
TreeHugger Robot d722645e7f Merge "Simplifying some package matching code by using common itemInfo mathcher" into ub-launcher3-dorval-polish2 2017-08-21 19:28:39 +00:00
TreeHugger Robot a7a7b63d9e Merge changes from topic "am-17d9128f-860a-478b-b599-8befd413609c" into ub-launcher3-master
* changes:
  [automerger] Simplifying some package matching code by using common itemInfo mathcher am: 6e13dd3aa8
  Simplifying some package matching code by using common itemInfo mathcher
2017-08-21 19:28:39 +00:00
TreeHugger Robot b55b6264ae Merge "Remove LAUNCHER3_ALL_APPS_PULL_UP Bug: 63712253 Verified: all apps transition fully functional Verified: NO_ALL_APPS_ICON = false case also works." into ub-launcher3-dorval-polish2 2017-08-21 19:22:56 +00:00
Hyunyoung Song b189a0e45a [automerger] Remove LAUNCHER3_ALL_APPS_PULL_UP Bug: 63712253 Verified: all apps transition fully functional Verified: NO_ALL_APPS_ICON = false case also works. am: d725f644b7
Change-Id: I455d617765afe5e7ec1dfb29ad019f37407702d7
2017-08-21 19:01:16 +00:00
Hyunyoung Song d725f644b7 Remove LAUNCHER3_ALL_APPS_PULL_UP
Bug: 63712253
Verified: all apps transition fully functional
Verified: NO_ALL_APPS_ICON = false case also works.

Change-Id: I779fb7bd4927c5923da3f85590d912dbbbcdef4d
2017-08-21 11:59:14 -07:00
TreeHugger Robot ee804af749 Merge "Fixing bindAllApplications scheduled with null list." into ub-launcher3-dorval-polish2 2017-08-18 19:14:45 +00:00
Sunny Goyal 5ff7ba7882 [automerger] Fixing bindAllApplications scheduled with null list. am: 49fc3f7aa8
Change-Id: I5f2c97270be0b32275e4049bb34f6fe77c35a884
2017-08-18 19:07:23 +00:00
Sunny Goyal 49fc3f7aa8 Fixing bindAllApplications scheduled with null list.
When deferring bindAllApplications, the same global state was being
used to store the pending state. This global state was being cleared
in one deferred execution after a second execution was scheduled, causing
the second execution to get null/wrong values.

Instead using independent local/anonymous class to maintian states, so that
it does not get cleared by other methods.

Bug: 64789383
Change-Id: I78477a110fe663603b4bdeb7d1fac7c4ce0831a2
2017-08-18 12:07:11 -07:00
TreeHugger Robot 1d2eaa7676 Merge "Fixing wrong intests being sent to DeviceProfile in case of lowRam device Also fixing the navbar to dark theme when a black bar is drawn behind nav bar" into ub-launcher3-dorval-polish2 2017-08-18 18:57:34 +00:00
Sunny Goyal 4384767647 [automerger] Fixing wrong intests being sent to DeviceProfile in case of lowRam device Also fixing the navbar to dark theme when a black bar is drawn behind nav bar am: 906c6b2f6c
Change-Id: I8d222de777a43613ae9ae97287e0102499d307a5
2017-08-18 12:26:00 +00:00
Sunny Goyal 906c6b2f6c Fixing wrong intests being sent to DeviceProfile in case of lowRam device
Also fixing the navbar to dark theme when a black bar is drawn behind nav bar

Fixing left/right margins not getting updated on lowRam device
when they change from non-zero value to 0

Bug: 64363693
Bug: 62547502
Change-Id: I4952ad2f564b71b39318350445f116a0f601a10f
2017-08-18 05:25:44 -07:00
Sunny Goyal bd6a59a018 [automerger] Fixing crashloop due to ag/2750101 am: a9a1a210d3
Change-Id: Iaf4b026c685b4c5e9705b09a23562c26f3272e98
2017-08-18 08:04:05 +00:00
Sunny Goyal a9a1a210d3 Fixing crashloop due to ag/2750101
Change-Id: Idebf6bfad4e56a52780b848fbb09b3a0134ffdc2
2017-08-18 01:03:48 -07:00
Sunny Goyal 94c27d9885 [automerger] Simplifying some package matching code by using common itemInfo mathcher am: 6e13dd3aa8
Change-Id: I1585b0977b6df998de571de1285c4b2b3b0a7550
2017-08-17 18:15:25 +00:00
Sunny Goyal 6e13dd3aa8 Simplifying some package matching code by using common itemInfo mathcher
Change-Id: Ib98d528391e19c0de3fe11304330dfa37710548c
2017-08-17 11:15:12 -07:00
Sunny Goyal eeeeda6a07 [automerger] Fixing duplicate/inconsistent definitions for model and callbacks am: b23980cc0e
Change-Id: If7d19d675472b25fa07715932f47d4ff9966d450
2017-08-17 18:06:08 +00:00
Sunny Goyal b23980cc0e Fixing duplicate/inconsistent definitions for model and callbacks
> 2 implementations for filtering workspace items
> 2 implementations for binding widgets
> duplicate logic for add and update appInfo

Change-Id: Id68a49926af398478deca8ac85ab1f22341a9449
2017-08-17 11:05:56 -07:00
Jonathan Miranda 00429a5e7c [automerger] Fix bug where all apps items fade in. am: 48a4e91c73 am: eeccd38368
Change-Id: I3fb83ad13b3ad89e0ee0c80f486631ede1e6e1fb
2017-08-15 20:50:05 +00:00
Jonathan Miranda eeccd38368 [automerger] Fix bug where all apps items fade in. am: 48a4e91c73
Change-Id: I9ccd034f9d8606d3baae07da3464c659fd405831
2017-08-15 20:50:03 +00:00
Jon Miranda 48a4e91c73 Fix bug where all apps items fade in.
Removes all Add/Change/Move/Remove animations by
clearing the AllAppsRecyclerView ItemAnimator.

Bug: 64675794
Change-Id: I41f975ab6be4bf48c483828ea6f109382a8a9320
(cherry picked from commit 7dfabaa02b)
2017-08-15 20:50:00 +00:00
Sunny Goyal 67b2a21f45 Merge "Simpifying uninstall drop target to check item type instead of class instance" into ub-launcher3-dorval-polish2 2017-08-15 20:45:33 +00:00
Sunny Goyal 8e2b20e476 [automerger] Simpifying uninstall drop target to check item type instead of class instance am: 1fe0c2ca08
Change-Id: I9454d7d5f26e9676c8a2a74a5bc6b0d2a2ba6f1e
2017-08-15 19:55:56 +00:00
Sunny Goyal 1fe0c2ca08 Simpifying uninstall drop target to check item type instead of class instance
Bug: 64719848
Change-Id: I34c13b461e204fbdc2c5b4ed6fa92564ebd5439a
2017-08-15 12:55:16 -07:00
TreeHugger Robot 10fcfb04b0 Merge "Fix bug where all apps items fade in." into ub-launcher3-dorval-polish2 2017-08-15 19:43:27 +00:00
Jonathan Miranda d6f8c358a2 [automerger] Fix bug where all apps items fade in. am: 7dfabaa02b
Change-Id: I31c92ac1080f1ae014194039cb9a4fa45851357e
2017-08-15 17:35:20 +00:00
Jon Miranda 7dfabaa02b Fix bug where all apps items fade in.
Removes all Add/Change/Move/Remove animations by
clearing the AllAppsRecyclerView ItemAnimator.

Bug: 64675794
Change-Id: I41f975ab6be4bf48c483828ea6f109382a8a9320
2017-08-15 10:33:54 -07:00
Rajeev Kumar ad308b9927 [automerger] Get rid of unnecessary int array allocation. am: bf17e50156
Change-Id: I05ef669fdfcae0e419e2bcc497495db5537bcb07
2017-08-14 23:13:39 +00:00
Rajeev Kumar bf17e50156 Get rid of unnecessary int array allocation.
Bug: 64656232
Change-Id: Ifc811c3930b8052d57fa33d35b9d50f11b541c94
Test: Tested manually
2017-08-14 16:12:48 -07:00
Tony Wickham d424b25be4 [automerger] Remove notification dots setting for Launcher3Go am: c138515c4e
Change-Id: I2fdd2f33babf294140a649fafebc68d6e45b86d7
2017-08-14 22:09:39 +00:00
Tony Wickham c138515c4e Remove notification dots setting for Launcher3Go
Also remove BADGE_ICONS flag as it is no longer used or necessary.

Bug: 64561196
Change-Id: Icf9656537459a7dbad3a07830eedbdeec8d8f1ce
2017-08-14 15:09:24 -07:00
Jonathan Miranda 591a538d4a [automerger] Fix bug where all apps scrollbar jumps. am: bb10fa8fc2 am: 492617f4c4
Change-Id: I5d97c5c1f90a655d2cd5a79fda54b6e5a0f5918e
2017-08-14 19:42:27 +00:00
Jonathan Miranda 492617f4c4 [automerger] Fix bug where all apps scrollbar jumps. am: bb10fa8fc2
Change-Id: I656c3482de28f7b50c0526cf10eacb6847e19447
2017-08-14 19:42:24 +00:00
Jon Miranda bb10fa8fc2 Fix bug where all apps scrollbar jumps.
The problem is that rowAppIndex is not being set when we swap in the
new predictions. So when we call AllAppsRecyclerView#getCurrentScrollY,
the "item.rowAppIndex == 0" clause returns true for every predicted app,
which results in a larger than expected value.

Bug: 64628968
Change-Id: I37ca660522b5a99666de2ea0b9c0aa8cd3732aca
2017-08-14 12:35:53 -07:00