Commit Graph

24612 Commits

Author SHA1 Message Date
Samuel Fufa 3116dc918f Resolve search scroll hightlight issue
After getting the index of the first item that should be highlighted, Section decorator should not assume getChildAt(index) will return item at position. Instead use findViewHolderForAdapterPosition.

Bug: 170665892
Change-Id: Id81d021bde8868184013e8d51e49af7842b64125
2020-11-09 16:35:43 -06:00
Samuel Fufa a204de7d12 Merge "Initial setup for widgets in Search" into ub-launcher3-master 2020-11-09 18:33:51 +00:00
Hyunyoung Song 003859cdd0 Show remote action's description in SearchResultIconRow
Validated against Pixel Tips corpus

Change-Id: I3c3f8eb69007a97e55e2ef08e7f4e0b800bfe247
2020-11-09 01:38:20 -08:00
Samuel Fufa 37432444fc Initial setup for widgets in Search
LiveSearchManager creates AppWidgetHost when user starts a new search session and destroys it when user returns to home. In addition, it also manages the creation and caching of PlaceholderSearchWidget which can be used to create AppWidgetHostViews.
Bug: 168321831
Test: Manual

Change-Id: I06a893028e55aa6e0702a4f1cd7a2edbb1f61671
2020-11-07 10:07:33 -06:00
Samuel Fufa 984e0d0a63 Show settings icon at start of settings results
Bug: 170792963
Test: Manual
Screenshot: https://screenshot.googleplex.com/MVBtDZGtQ3aChwU
Change-Id: I16a28a7bd9e3129b40102e020cd7c0111e6fe29b
2020-11-06 10:14:41 -06:00
thiruram d15915f5fd Fixes invalid ids for UiEvents: LAUNCHER_FOLDER_CONVERTED_TO_ICON, LAUNCHER_HOTSEAT_PREDICTION_PINNED
Bug: 169100235

Change-Id: I1cae4e61b97947c5a7e56daeaccac0ece55f021c
2020-11-06 02:09:34 +00:00
Sunny Goyal cff31d8281 Merge "Removing separate Cancel and End callbacks and using AnimationListener instead" into ub-launcher3-master 2020-11-06 01:29:39 +00:00
Sunny Goyal ff9e7d6aa9 Removing separate Cancel and End callbacks and using AnimationListener instead
This removes the additional step of invoking these callbacks separately

Change-Id: I0b60047a44f179ba725f15b1e791e336884869c9
2020-11-05 16:35:11 -08:00
Tracy Zhou 3260bc51cb Merge "Handle the animation when restarting apps" into ub-launcher3-master 2020-11-06 00:05:49 +00:00
TreeHugger Robot b0588f1172 Merge "Using UI_HELPER_THREAD for various activity manager interactions" into ub-launcher3-master 2020-11-05 23:12:37 +00:00
Samuel Fufa 171ad424a7 Merge "Consolidate Hero search result with SearchResultIconRow" into ub-launcher3-master 2020-11-05 18:58:06 +00:00
TreeHugger Robot 2b2c448679 Merge "Add more logs for WorkTabTest flake investigation" into ub-launcher3-master 2020-11-05 18:08:34 +00:00
Samuel Fufa 6e5efb0929 Consolidate Hero search result with SearchResultIconRow
With this, we can now show app title and support drag/drop for shortcut results.

Bug: 172245107
preview: https://drive.google.com/file/d/1A4eKKTDPht-MDbfA2VFI3OuAO36fc3AS/view?usp=sharing
Change-Id: Icf94a2d23b44bfe5527aea71e27178906e5deb3e
2020-11-05 11:57:35 -06:00
Samuel Fufa d91bad956f Add more logs for WorkTabTest flake investigation
Bug: 159671700
Change-Id: I92f64bafa756a65d3e63514474028b82b059e357
2020-11-05 11:14:16 -06:00
Sunny Goyal 8cadc1281f Using UI_HELPER_THREAD for various activity manager interactions
Bug: 170648272
Change-Id: Iec36389be5d747c5dc4d2bb2a8138758d48efa53
2020-11-04 14:29:59 -08:00
Hyunyoung Song feefa117bd [automerger skipped] [DO NOT MERGE] Add WW log for noti shade swipe down from home. am: a87f99a35a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12973872

Change-Id: Id137ba5eb2e26d7df010212c7612fcb3944957f3
2020-11-04 18:34:05 +00:00
TreeHugger Robot 9de08d32ba Merge "Revert "Removing workaround for battery defender"" into ub-launcher3-master 2020-11-04 18:33:42 +00:00
Hyunyoung Song a87f99a35a [DO NOT MERGE] Add WW log for noti shade swipe down from home.
Bug: 171973663
Change-Id: I1e8ff20c62d4f91a05cb1cfc0337e351f2bc8885
2020-11-03 14:13:46 -08:00
Tony Wickham 22a5a68464 Fix a couple notificaiton dot issues
Fixes: 172010602 by adding drawDotIfNecessary() back to BubbleTextView
Fixes: 167272638 by overriding drawDotIfNecessary() to do nothing in
DeepShortcutTextView

Change-Id: I0bfbbc6e27dedac73ae97c5a084412ce1aba11e4
2020-11-02 17:04:58 -08:00
Vadim Tryshev c0ef31e38f Revert "Removing workaround for battery defender"
This reverts commit ff39fd3e14.

Reason for revert: The CL coincided with a start of flakes "phone is locked". Let's revert and see if it fixed that. https://flakes-clusters.corp.google.com/#/?androidAtpBranch=git_master&androidAtpModule=com.google.android.apps.nexuslauncher.out_of_proc_tests&d=30&cid=9fd6b65c-e48c-4bc3-b19b-f5c610a1999a&maxResults=20

Change-Id: I90f8abbb1794c19593ed8a235a82c0e53030c0a2
2020-10-31 01:50:29 +00:00
TreeHugger Robot a1733bceb7 Merge "fix the issue widget id can be wrong after restore" into ub-launcher3-master 2020-10-29 17:30:35 +00:00
Tracy Zhou fbfccf9e2d Handle the animation when restarting apps
Fixes: 170338921
Test: manual

Change-Id: I5a5722cb62fb53a68d140621ad79ed97f4d98571
2020-10-29 10:01:34 -07:00
TreeHugger Robot 90faddeff3 Merge "Quick fix from ag/12914139" into ub-launcher3-master 2020-10-29 06:38:13 +00:00
Tracy Zhou 991e8208cc Quick fix from ag/12914139
Test: N/A
Change-Id: I0b8274f8a912d091cfbbebafdee220b5e46ee74f
2020-10-28 22:34:23 -07:00
Pinyao Ting f39f351a0d fix the issue widget id can be wrong after restore
Bug: 171774227
Test: manual testing
1. randomly add/remove widgets to workspace
2. create a backup (Settings > System > Backup)
3. reset the device
4. restore from the backup
5. verify all of the widgets are restored properly

Change-Id: Id65e474dd9349aca715d7e6b88f8d58bc63066ae
2020-10-28 22:04:35 -07:00
TreeHugger Robot 1e9453f09c Merge "Removing workaround for battery defender" into ub-launcher3-master 2020-10-28 23:36:07 +00:00
TreeHugger Robot a90ddeea57 Merge "Settings/Play/Suggest layout polish" into ub-launcher3-master 2020-10-28 22:12:52 +00:00
TreeHugger Robot 8f48f23039 Merge "IME bounds after DOWN->UP Motion event sequence" into ub-launcher3-master 2020-10-28 21:22:51 +00:00
Hyunyoung Song a34766a176 IME bounds after DOWN->UP Motion event sequence
Bug: 170739594

Change-Id: I1aa8dd2ced7c017e57d3c14c02d5b78900a46caa
2020-10-28 12:49:56 -07:00
TreeHugger Robot 426f6ac276 Merge "Use event time of app side for latency metrics" into ub-launcher3-master 2020-10-28 10:40:27 +00:00
Riddle Hsu b30adcb232 Use event time of app side for latency metrics
There are 2 reasons not to use MotionEvent#getEventTime:
1. There is an existing TouchEventReported metric for touch latency.
2. In instrumentation test, the event time is set when creating
   the motion event for injection. It may cause the results to be
   5 times slower than the real case. That may lead to miss the
   cost from app to system.

Bug: 166614700
Test: Enable statsd log: "adb shell cmd stats print-logs"
      Touch gesture navigation bar or launch app from launcher.
      adb logcat | grep statsd | grep "(48)"
Change-Id: Ica5e7df685fe737bbc3ac60c3ec35bad15466726
2020-10-28 09:13:48 +00:00
Tracy Zhou 55940ecfc7 Render and track live tile position when launching another app from Overview
Fixes: 165394366
Fixes: 170338328
Test: Manual
Change-Id: Idfcd423cbe062af33564eaa9e83ec21fbac0cdf9
2020-10-27 15:45:01 -07:00
TreeHugger Robot ceb8618f09 Merge "Finishing recents task before starting share screenshot flow" into ub-launcher3-master 2020-10-27 20:41:54 +00:00
Andy Wickham aeaa2c92de Merge "Changes COMPILE_SDK to S." into ub-launcher3-master 2020-10-27 20:09:50 +00:00
TreeHugger Robot a48f6efbe1 Merge "Integrating snapshot logging in Launcher" into ub-launcher3-master 2020-10-27 19:08:01 +00:00
Sunny Goyal b694a69f53 Integrating snapshot logging in Launcher
> Workspace snapshot is logged when the workspace loads (at most once a day)
> Removing unnecessary thread jumping when logging folders
> Preference snapshot is logged on process start and whenever something changes

Change-Id: I93767de89b11522d843c0e8300d1f108c78f6d90
2020-10-27 11:25:43 -07:00
Hyunyoung Song 9fc27da5f8 Settings/Play/Suggest layout polish
Bug: 170792963
Bug: 170750779
Change-Id: I69b09f5360e165c3b1b33e259cdd0f390ce6fa60
2020-10-27 16:45:54 +00:00
Andy Wickham 4a97458253 Changes COMPILE_SDK to S.
Change-Id: I5d4d84027904a7d7861e897ace1f7ce9fc04f4a4
2020-10-26 17:00:36 -07:00
Sunny Goyal 54aae4f95d Finishing recents task before starting share screenshot flow
Bug: 170338559
Change-Id: Ieccdc492c7d1a60b47b90c6683e60e8a143ca80d
2020-10-26 16:02:17 -07:00
Tony Wickham 2c956a4651 Merge "Add null check between calling onMotionPauseDetected() and Changed()" into ub-launcher3-master 2020-10-26 22:08:00 +00:00
Schneider Victor-tulias 47dfc3a3ca Merge "Fix All Apps Search plugin shortcut icon redrawing issue." into ub-launcher3-master 2020-10-26 20:57:17 +00:00
Winson Chung 4ff3548d96 Merge changes from topic "enter-pip-gesture-nav-launcher" into ub-launcher3-master
* changes:
  Updating pip transition calls with shared lib
  Improve PIP enter transition w/ gesture nav (3/N)
2020-10-26 19:43:27 +00:00
TreeHugger Robot f9317597ef Merge "Add a feature flag to expand smartspace to three rows" into ub-launcher3-master 2020-10-26 18:37:26 +00:00
Schneider Victor-tulias 3ee7018227 Fix All Apps Search plugin shortcut icon redrawing issue.
BubbleTextViews animate the update from their placeholder icons to their high res icons. Added a field to allow restricting what BubbleTextViews' icon updates should be animated. Updated SearchResultIconRow to store the icon Drawable rather than the resource id to prevent unecessary redrawing.

Fixes: 170966269

Demo: https://drive.google.com/file/d/1FBdEl11mHZk1SpCMRY4XZAGt5TVZ01W4/view?usp=sharing

Change-Id: Ib55dafdf5b5fed00d343af5f95f3dd3f08c4ee8e
2020-10-26 14:25:35 -04:00
Winson Chung 6f4e65f62f Updating pip transition calls with shared lib
Bug: 143965596
Change-Id: I761726ca9666689d4359240b065997e3342eab65
2020-10-25 22:26:55 -07:00
Hongwei Wang 5b5f3c6609 Improve PIP enter transition w/ gesture nav (3/N)
Directly transition Activity to PiP mode in launcher if the Activity
claims auto-pip support. Video is taken by commenting out the
requirement of setting the auto-pip flag.

Note that we need app to actively push up-to-dated
PictureInPictureParams to the framework, otherwise we won't be get
- PictureInPictureParams on first entering
- Staled PictureInPictureParams if the aspect ratio is changed

Video: http://rcll/aaaaaabFQoRHlzixHdtY/abenIxLFI1pZzF2O8t4TbS
Bug: 143965596
Test: see demo videos
Change-Id: Iea9a6ff39a79431ac1afa14aea812c500b3ca3b2
2020-10-25 21:14:10 -07:00
TreeHugger Robot bc3a5d516e Merge "[pixel-search] URGENT: bug fix for teamfood: fix crash when tapping on a screenshot result" into ub-launcher3-master 2020-10-23 23:23:52 +00:00
Hilary Huo 9c43bfa798 [pixel-search] URGENT: bug fix for teamfood: fix crash when tapping on a screenshot result
Bug: b/171596755
Change-Id: I125404dbe5a4e5f8e3bdc233e3a82db3dca48f42
2020-10-23 15:48:12 -07:00
Tony Wickham 3cc1aa960d [automerger skipped] End the attaching animation early when we settle on the end target am: fd54a8e84a -s ours
am skip reason: Change-Id I3f37aecf9c93f2ec63dbdce561e7f5ba11be89cc with SHA-1 1cc12ebc12 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12907696

Change-Id: I5490ccf0af9a8e0a8625d4467e38b9fbe2251826
2020-10-23 20:44:33 +00:00
Tony Wickham fd54a8e84a End the attaching animation early when we settle on the end target
The attaching animation can take longer than the transition to recents
when you let go, and the ADJACENT_PAGE_OFFSET calculation is different
when there's a running task vs not. So after the transition to recents
ended, the calculation of the still playing attaching animation would
change, causing the jump you see in the bug. Now we make sure to end
the attaching animation if it's still running when we settle on an
end target to avoid this issue.

Fixes: 168563692
Change-Id: I3f37aecf9c93f2ec63dbdce561e7f5ba11be89cc
Merged-In: I3f37aecf9c93f2ec63dbdce561e7f5ba11be89cc
(cherry picked from commit 1cc12ebc12)
2020-10-23 19:43:12 +00:00