Commit Graph

10956 Commits

Author SHA1 Message Date
Tony Wickham 2ef6abc091 Merge "Skip to the end of the folder open animation in battery saver mode." into ub-launcher3-burnaby-polish
am: 6e83dc4031

* commit '6e83dc4031b78ac6e65102b2d936e9e769686fec':
  Skip to the end of the folder open animation in battery saver mode.
2015-11-25 00:06:14 +00:00
Tony Wickham 6b14c150f6 Don\'t let folder be replaced with final item twice.
am: 1a690cb785

* commit '1a690cb785a1b1644ad4c97e8b755528b2222cfc':
  Don't let folder be replaced with final item twice.
2015-11-25 00:06:08 +00:00
Tony Wickham 6e83dc4031 Merge "Skip to the end of the folder open animation in battery saver mode." into ub-launcher3-burnaby-polish 2015-11-25 00:02:12 +00:00
Tony Wickham 1a690cb785 Don't let folder be replaced with final item twice.
Bug: 25732317
Change-Id: I77b3ddc8951583bebfb908fda934c9b80ddebce0
2015-11-24 15:34:53 -08:00
Sunny Goyal 0c34443406 resolve merge conflicts of 7bce5f7988 to ub-launcher3-master.
Change-Id: Id352ce219bed7701956bb462ea2dd0a5aebe7317
2015-11-24 13:12:32 -08:00
Sunny Goyal 7bce5f7988 Tying LauncherAppState lifecycle with LauncherProvider
The content provider is the first component started with the main process,
which makes it ideal for initiating LauncherAppState

Change-Id: I03db82a8949ad1376af53a0033592f421dbf0b15
2015-11-24 12:06:42 -08:00
Sunny Goyal ed3563a279 Merge "Setting statusbar and nav bar colors in theme instead of code" into ub-launcher3-burnaby-polish
am: 4ee66259eb

* commit '4ee66259eb7835bfcf3747596e068319e1e3c677':
  Setting statusbar and nav bar colors in theme instead of code
2015-11-23 18:48:37 +00:00
Tony Wickham ebaf95fee7 Merge "Focus doesn\'t leave folders without also closing them." into ub-launcher3-burnaby-polish
am: 298f1c4578

* commit '298f1c4578e45168e74aa4b8561fcd88bfe509fe':
  Focus doesn't leave folders without also closing them.
2015-11-23 18:48:28 +00:00
Sunny Goyal 4ee66259eb Merge "Setting statusbar and nav bar colors in theme instead of code" into ub-launcher3-burnaby-polish 2015-11-23 18:45:41 +00:00
Tony Wickham 298f1c4578 Merge "Focus doesn't leave folders without also closing them." into ub-launcher3-burnaby-polish 2015-11-23 18:43:21 +00:00
Tony Wickham feec2171f8 Focus doesn't leave folders without also closing them.
- Pressing Tab wraps around to the first item from the folder name,
  and vice versa when pressing Shift+Tab.
- When tapping off the folder while editing the text, the folder
  requests focus. We handle the following cases from that state:
    - Pressing an arrow key or Tab gives focus to the first item.
    - Pressing Shift+Tab gives focus to the last item.
- Fix slight corner case where moving from folder name to an item
  didn't update mIsEditingName to false. So when clicking off of
  the folder, it gave focus to the folder (as mentioned above)
  instead of closing the folder like it usually does when icons are
  focused. Not a huge deal, but still worth fixing.
Bug: 25687579
Change-Id: I1bec844c8ccd09529a11b9e3a1d92b3bdf7b2eb3
2015-11-20 15:08:55 -08:00
Tony Wickham 667e4a6ad2 Merge "Stop requesting focus on folder if it was closed without animating." into ub-launcher3-burnaby-polish
am: 55bd16bfdc

* commit '55bd16bfdce57772691519fb894b95c7f088846e':
  Stop requesting focus on folder if it was closed without animating.
2015-11-19 00:47:26 +00:00
Tony Wickham 55bd16bfdc Merge "Stop requesting focus on folder if it was closed without animating." into ub-launcher3-burnaby-polish 2015-11-19 00:36:20 +00:00
Tony Wickham 9c771c3b84 Merge "Handle errors gracefully in WallpaperCropActivity." into ub-launcher3-burnaby-polish
am: 0151ff1683

* commit '0151ff168368883301e84c7d1f790c9f2721e459':
  Handle errors gracefully in WallpaperCropActivity.
2015-11-18 19:59:19 +00:00
Tony Wickham 0151ff1683 Merge "Handle errors gracefully in WallpaperCropActivity." into ub-launcher3-burnaby-polish 2015-11-18 19:51:55 +00:00
Tony Wickham f2bd93c7e0 Handle errors gracefully in WallpaperCropActivity.
(cherry picked from commit c984cde008)
Now instead of crashing, it says "Couldn't load image."

Bug: 25326319
Bug: 25656670
Change-Id: I71471f4b26f7c23dee40b60772ddd798f67b409e
2015-11-18 11:31:26 -08:00
Tony Wickham 30bdd6eb69 Stop requesting focus on folder if it was closed without animating.
Bug: 25092436
Change-Id: Ia6b72ec8c9fa02fc159457b81fef12f6fd394769
2015-11-18 02:08:22 +00:00
Sunny Goyal fb5a4d843e Fixing crash when uninstalling an app destroys the folder
am: b9c29d455e

* commit 'b9c29d455e301d1b31b911a37eb3bec7e0e16865':
  Fixing crash when uninstalling an app destroys the folder
2015-11-16 04:47:01 +00:00
Sunny Goyal b9c29d455e Fixing crash when uninstalling an app destroys the folder
Bug: 25666490
Bug: 25677822
Change-Id: Id71c04df0a5546ba95239ba2e3f7aabb697375a4
2015-11-14 18:09:20 +05:30
Tony Wickham ec73dd97f0 Revert "Revert "Reverting folder cell width on portrait phones.""
am: 6159c242bc

* commit '6159c242bc610f13e4c7550ae8b15f25603f4b23':
  Revert "Revert "Reverting folder cell width on portrait phones.""
2015-11-13 18:10:57 +00:00
Tony Wickham 6159c242bc Revert "Revert "Reverting folder cell width on portrait phones.""
This reverts commit 1974e98f5e.

Change-Id: I7c5d86de187989c085f676933ce3f1cbd57ed8a7
2015-11-13 18:07:18 +00:00
Tony Wickham 0309fbc65f Revert "Reverting folder cell width on portrait phones."
am: 1974e98f5e

* commit '1974e98f5ec4713e50ba64ec32a7607c92ddce9b':
  Revert "Reverting folder cell width on portrait phones."
2015-11-12 23:52:34 +00:00
Tony Wickham 1974e98f5e Revert "Reverting folder cell width on portrait phones."
This reverts commit b25e684a76.

Change-Id: Ie86adc4b35c73ab7ef78d73225b437adc4751172
2015-11-12 23:46:33 +00:00
Tony Wickham 79b4194765 Reverting folder cell width on portrait phones.
am: b25e684a76

* commit 'b25e684a766362422f5693f7a2189910c1275584':
  Reverting folder cell width on portrait phones.
2015-11-12 23:41:06 +00:00
Tony Wickham b25e684a76 Reverting folder cell width on portrait phones.
The extra folder cell space added in ag/790800 looks bad on phones in
portrait mode, so reverting it here. However, we keep the extra space
on tablets or phones in landscape mode, since it provides more room
for long app names (bug 22462641).

Bug: 25662215
Change-Id: I2a37b884458ee557c9b8cff0c3edef16bfc50efb
2015-11-12 15:34:59 -08:00
Tony Wickham 112ac95571 Skip to the end of the folder open animation in battery saver mode.
Bug: 25666809
Change-Id: I867d56a34fc5e0ad6aaabd8b6df47be05ec31966
2015-11-12 12:51:06 -08:00
Tony Wickham 9e163059bb Merge "Handle more cases in FocusHelper#handleHotseatButtonKeyEvent()." into ub-launcher3-burnaby-polish
am: a43f78fc4b

* commit 'a43f78fc4b70bf54b9c90758660b6155ef0257aa':
  Handle more cases in FocusHelper#handleHotseatButtonKeyEvent().
2015-11-11 17:19:53 +00:00
Tony Wickham c908dbaa0a Merge "Play common transition animations from a common method." into ub-launcher3-master 2015-11-11 17:19:07 +00:00
Tony Wickham a43f78fc4b Merge "Handle more cases in FocusHelper#handleHotseatButtonKeyEvent()." into ub-launcher3-burnaby-polish 2015-11-11 17:16:14 +00:00
Tony Wickham 4fc8287c78 Handle more cases in FocusHelper#handleHotseatButtonKeyEvent().
The first of these cases seems like they should already have been
present, and the last couple allow you to switch pages by hitting
arrow keys on the edges of the hotseat.

Bug: 25589939
Change-Id: I9378b209250f7dc376fa97efde979bcee2979537
2015-11-10 16:52:14 -08:00
Tony Wickham a71391a5b1 Don\'t add offset to CellLayout\'s fullscreen children.
am: 26b0142543

* commit '26b01425436277447fe24d01ad50d9e64f82109e':
  Don't add offset to CellLayout's fullscreen children.
2015-11-10 23:38:00 +00:00
Tony Wickham 26b0142543 Don't add offset to CellLayout's fullscreen children.
Bug: 25411084
Change-Id: Ifbcd0a53cf04a7fc29386f4f09aaf7f972e7354a
2015-11-10 14:49:36 -08:00
Tony Wickham 72d4c0673c Added unit tests for b/25434120 regression.
am: 3cfa97d4c1

* commit '3cfa97d4c14fa4af3ee3613e44ba7b7128141e31':
  Added unit tests for b/25434120 regression.
2015-11-07 01:31:18 +00:00
Tony Wickham 3cfa97d4c1 Added unit tests for b/25434120 regression.
Change-Id: I55b10274c4bb63ec6fd3138236e78a04e3eac91a
2015-11-06 17:08:57 -08:00
Tony Wickham 1d21164b9d Merge "Make sure user can always get to next page with keyboard." into ub-launcher3-burnaby-polish
am: 0e2f3849b8

* commit '0e2f3849b84f59ed7c1c4336ca01ac17f096e265':
  Make sure user can always get to next page with keyboard.
2015-11-06 18:11:49 +00:00
Tony Wickham 94fd1bcf05 Merge "Stop explicitly snapping to page when navigating with keyboard." into ub-launcher3-burnaby-polish
am: 0f6f2b181f

* commit '0f6f2b181fcf28887b343226cef3b263a65621cd':
  Stop explicitly snapping to page when navigating with keyboard.
2015-11-06 18:11:43 +00:00
Tony Wickham 0e2f3849b8 Merge "Make sure user can always get to next page with keyboard." into ub-launcher3-burnaby-polish 2015-11-06 18:10:05 +00:00
Tony Wickham 0f6f2b181f Merge "Stop explicitly snapping to page when navigating with keyboard." into ub-launcher3-burnaby-polish 2015-11-06 18:08:44 +00:00
Sunny Goyal 426b2474fb Ignoring DeadObjectException in startListening
am: 1b323794f2

* commit '1b323794f2f6443b9142ee613e5851a096f19fd6':
  Ignoring DeadObjectException in startListening
2015-11-06 02:29:49 +00:00
Tony Wickham c2964cb6cd Make sure user can always get to next page with keyboard.
There's a case where hitting the left/right arrow in the first/last
column wouldn't give focus to an icon on the next page because it is
vertically too far from the first icon to be considered. This makes
for a bad user experience, because there is no way to switch pages
with the keyboard. So now we brute-force search for an appropriate
icon if none was found in this case.

Bug: 25434120
Change-Id: Ifdead0e3b458717ccb33e2f0ec7c15f1fcce4b95
2015-11-05 12:54:17 -08:00
Sunny Goyal 1b323794f2 Ignoring DeadObjectException in startListening
> As of android M, the platform somtimes throws DeadObjectException
instead of TransactionTooLargeException

Bug: 25305031
Change-Id: I3a98db8a5041aef01640d16f9beb71b72bf598f1
2015-11-05 16:10:55 +05:30
Tony Wickham 25189851ac Stop explicitly snapping to page when navigating with keyboard.
When an icon grabs focus, it already snaps to its own page, so
the explicit snapToPage() is redundant. And in the case where no icon
will grab the focus, the explicit call puts us in a weird state
because the page snaps but the focus doesn't change (see bug).

(This happens, for instance, if you are moving from an icon on the
bottom right of page 1 and the only icon on page 2 is in the top
left. In this case, the second icon won't take focus because the
angle is too wide according to FocusLogic#handleDpadHorizontal().)

Bug: 25434120
Change-Id: I17b0ef7d86426a2599bc948bf2313dca7e112364
2015-11-04 17:44:32 -08:00
Tony Wickham c984cde008 Handle OutOfMemoryException gracefully in WallpaperCropActivity.
Now instead of crashing, it says "Couldn't load image."

Bug: 25326319
Change-Id: I6918b7b34e0a9b40036b1405fc449c10c2e1d40a
2015-11-05 00:10:34 +00:00
Tony Wickham 38b1220767 Stop clearing focus when snapping to a new workspace page.
am: 04e2c9ef56

* commit '04e2c9ef5663262fc9dd08ffc4b59fe305a017f3':
  Stop clearing focus when snapping to a new workspace page.
2015-11-03 22:07:57 +00:00
Yohei Yukawa 1bd9a430ed Enable selection action mode for Android M+.
Since I62963d225e6ea5d2ec9d8ebc8a6d73099f5d6c7f, we have disabled
selection action mode in the folder-name editing mode on Launcher,
mainly because it messed up the view on phones.  However that is no
longer the case in Android M and later, where floating action mode
is available.

With this CL, we start relying on the default floating action mode
in Android M and later.

Bug: 22210697
Change-Id: Ie19e7844194acd86cdb013254a1923f0b1d78e11
2015-10-30 18:54:58 -07:00
Tony Wickham 04e2c9ef56 Stop clearing focus when snapping to a new workspace page.
Clearing the focus was causing the first child in the new page to
immediately take focus, which caused FocusIndicatorView jank when
using a keyboard.

Bug: 25256728
Change-Id: I5ab31ebc3fe370d7ac9e9792b30dab3467023738
2015-10-30 18:04:48 -07:00
Tony Wickham d469b7fdc2 Merge "resolve merge conflicts of 4530aca912 to ub-launcher3-master." into ub-launcher3-master 2015-10-30 18:48:11 +00:00
Tony Wickham 5ea422e39e Added Gravity.CENTER_HORIZONTAL to drop target layout params.
I'm not sure if it is strictly necessary, but it is probably good to
be more explicit regardless.

Change-Id: Ib7647dbcb5449e22ef87da8d49b4e7804ba5c17f
2015-10-30 11:22:44 -07:00
Tony Wickham a6631d76a7 resolve merge conflicts of 4530aca912 to ub-launcher3-master.
Change-Id: I55a0cd751cbcce8fcc8efa23a0a88a01ec08522b
2015-10-30 11:09:44 -07:00
Tony Wickham c1ff24c077 resolve merge conflicts of a3c74d10a7 to ub-launcher3-master.
Change-Id: Ibeb2499ac278e4094a2922501cfffad2489e58ed
2015-10-30 10:37:43 -07:00