Commit Graph

73320 Commits

Author SHA1 Message Date
Tony Wickham 2c00a542c2 Merge "Fix layering issue when launching from side TaskView" into main 2023-12-14 01:05:01 +00:00
Anushree Ganjam 8a401e8817 Merge "Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY" into main 2023-12-13 22:57:59 +00:00
Saumya Prakash fc97e5339b Merge "Check that onAttach() is called before onResume() to prevent NPE." into main 2023-12-13 20:57:20 +00:00
Tony Wickham 1e60b1a4c4 Fix layering issue when launching from side TaskView
Fully reverted the change in ag/24840504, and instead make use of
prefixOrderIndex to ensure translucent overlays launch on top of
the underlying task.

Test: Swipe up from an app to Overview (phone), scroll over one
task, click on the live tile you came from; ensure animates well
Test: Open an app, launch a translucent overlay, e.g. Volume
Dialog, swipe up to Overview and relaunch the live tasks; ensure
the overlay stays on top throughout the animation
Fixes: 310765248
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD

Change-Id: I0708bf3c060ba84089722d0bd9480a4f4bd2b8e2
2023-12-13 19:59:08 +00:00
Vadim Tryshev 8fa129e9a8 Merge "Disabling the failing piece of a test in presubmit" into main 2023-12-13 19:53:10 +00:00
Charlie Anderson 797ed83700 Merge "Add wrapper for logging backup & restore metrics from Launcher" into main 2023-12-13 19:33:26 +00:00
Brandon Dayauon 65eecc9352 Merge "Make two line text support only for ENGLISH locale" into main 2023-12-13 19:20:35 +00:00
Vadim Tryshev 122e5b9389 Disabling the failing piece of a test in presubmit
Bug: 315847371
Test: presubmit
Flag: N/A
Change-Id: I9cf9818946de8b53edc8c44cbd9e673f3bea832f
2023-12-13 10:33:20 -08:00
Tracy Zhou f2643521ec Merge "Introduce taskbar_phone_size" into main 2023-12-13 18:04:04 +00:00
Jagrut Desai 113569f446 Merge "Increasing the LOW_TICK intensity of haptic feedback for taskbar invocation" into main 2023-12-13 16:12:43 +00:00
Johannes Gallmann 820460b12a Merge "Fix predictive back to home with pinned taskbar" into main 2023-12-13 15:01:45 +00:00
Tracy Zhou 9ccd5d4257 Introduce taskbar_phone_size
In small screen, we use 48dp for nav bar height, while it's 60dp for task bar.

Bug: 230395757
Test: manual
Change-Id: Ia7083a1b2246981466e1163404c63b645a6bf5b1
2023-12-13 00:38:15 -08:00
Jon @ ea4c701579 Merge "Move taskbar clean up so that it only gets called when user swipes up to go home." into main 2023-12-13 06:52:04 +00:00
Tracy Zhou f441fd67d3 Make sure the task bar stays unstashed upon configuration change
So we recreate task bars when configuration is changed, if ENABLE_TASKBAR_NAVBAR_UNIFICATION = true. In order for unstashed state to propagate, we need to save STASHED_IN_APP_AUTO in TaskbarSharedState.

Fixes: 311429718
Test: Unstash the task bar in app, rotate, make sure the task bar stays unstashed
Change-Id: I7db773725ea89976612e9e91af5b6911d0ec5fc0
2023-12-12 19:33:42 -08:00
Jon Miranda 20fdc7b508 Move taskbar clean up so that it only gets called when user swipes up to go home.
This fixes the bug where the flag gets set when user taps on nav handle, which
results in the taskbar animation playing.

Flag: N/A
Test: open app
      wait for taskbar to finish stashing*
      tap on nav handle
      nothing happens (desired affect)
      * I will address tapping on taskbar while its animating in a separate change
Bug: 292108880
Change-Id: I75870050225bdd951c69224d272d0bd5a3d6d4ea
2023-12-13 02:51:28 +00:00
Federico Baron 4266fa49e2 Merge "Update two pane sheet widget picker to use RelativeLayout since ConstraintLayout was causing test failures" into main 2023-12-13 01:47:21 +00:00
Jordan Silva 7808efbba1 Merge "Fix crash when restoring data from phone to tablet with responsive grid" into main 2023-12-13 00:49:26 +00:00
Vadim Tryshev fd309ca3d0 Merge "Inserting waiting for settling in the Workspace state after "back" from All Apps" into main 2023-12-13 00:27:08 +00:00
Brandon Dayauon 553a2c8775 Merge "Apply the expand animation on Private Space" into main 2023-12-13 00:02:56 +00:00
Brandon Dayauon cc5db6183f Merge "Include a developer option sliding flag to toggle the different amount of apps to show" into main 2023-12-13 00:01:08 +00:00
Brandon Dayauon d7f0ccf52e Merge "Move UnionDecorationHandler to Launcher" into main 2023-12-13 00:00:14 +00:00
fbaron b3b0215cb1 Update two pane sheet widget picker to use RelativeLayout since ConstraintLayout was causing test failures
There are test failures when using ConstraintLayout without a known solution, see https://chat.google.com/room/AAAACwktJi8/2OogGWfbLvI. Switching back to a relativelayout to resolve those issues.

Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I004c2d77ca308d85b29217d4f1e548067126556f
2023-12-12 15:12:40 -08:00
Vadim Tryshev d48279bf1d Merge "Disabling ViewCaptureRule" into main 2023-12-12 23:10:57 +00:00
Vadim Tryshev 9c1df6db6b Inserting waiting for settling in the Workspace state after "back" from All Apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Idd6e3383be21c2040797148817b96105a6f94fe3
2023-12-12 14:03:45 -08:00
Brian Isganitis 59c8b69ef4 Merge "Split AFVs that controller should not intercept from TYPE_ACCESSIBLE." into main 2023-12-12 20:47:46 +00:00
Charlie Anderson 861c2eed78 Merge "Adds more in depth logging of Launcher restore functionality" into main 2023-12-12 20:30:19 +00:00
Jagrut Desai 78d511614c Increasing the LOW_TICK intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ib8f64e3ae51f5468b9086808551aae826636e03c
2023-12-12 10:40:58 -08:00
Vadim Tryshev 1c7bc492fb Merge "Inserting waiting for wallpaper animation into "back" gesture from app to workspace" into main 2023-12-12 18:24:56 +00:00
Jagrut Desai 2be2b93256 Merge "TaskbarPinningController Unit Tests" into main 2023-12-12 16:19:00 +00:00
Charlie Anderson c61288e271 Adds more in depth logging of Launcher restore functionality
Test: locally
Flag: N/A
Bug: 294386159
Change-Id: I810239047480090911c54dbe65a4aad8515f640c
2023-12-12 11:04:52 -05:00
Sergey Pinkevich 2adff1b7c0 Merge "Update secondary grid translation" into main 2023-12-12 13:06:40 +00:00
Jordan Silva ce396d8abf Fix crash when restoring data from phone to tablet with responsive grid
This issue happens when restoring the data from a phone to a tablet or vice-versa. When Launcher is restoring the data, it allows the device to load a disabled or invalid grid temporarly for the migration. This leads to a crash when the responsive grid is enabled.
The hotseat spec has only WIDTH or HEIGHT specs in a certain posture. When the user restores the data from a phone to a tablet, the Launcher loads a handheld spec that doesn't have HEIGHT specs for the hotseat in landscape (spec_handheld_hotseat_[grid].xml). However, the tablet, in landscape, tries to retrieve the hotseat HEIGHT spec.

It also prevent crash when responsive grid is used with multi window mode. isVerticalBarLayout becomes false. Then, the responsive grid tries to load a hotseat spec that doesn't exist (using DimensionType.HEIGHT). Phones have hotseat specs only for DimensionType.WIDTH.

Bug: 315548992
Fix: 315069300
Fix: 315377544
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: v2/android-crystalball-eng/health/microbench/systemui/main/systemui-notification-3-jank-suite
Test: atest CtsWindowManagerDeviceDisplay:android.server.wm.display.MultiDisplaySystemDecorationTests#testSendPrimaryHomeIntentActivityOnDisplayWithDecorations -- --abi x86_64
Change-Id: Ibd6537e0528868da9a1b7672c43b5455fa6a8184
2023-12-12 10:46:22 +00:00
Sunny Goyal 6263ac3894 Merge "Adding support for getting task overlay" into main 2023-12-12 08:25:18 +00:00
Jeremy Sim e73146de77 Merge "Fix clipping issue when dragging app pair icons" into main 2023-12-12 01:03:42 +00:00
Jeremy Sim 160225029d Merge "App Pairs: Launch animation" into main 2023-12-12 00:58:49 +00:00
Xin Li 7545bab7ab [automerger skipped] Merge "Merge Android 14 QPR1" into main am: aa168f204e -s ours am: e2d8c0c312 -s ours am: 26fa6bd719 -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I9c2ad64b29aee915aae6ba9784e32fd4f1829ace
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 23:00:17 +00:00
Xin Li b65a2490d4 [automerger skipped] Merge Android 14 QPR1 am: 65e37d77fe -s ours am: 3cbfd5623b -s ours am: c95f995a9e -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I3b541ffd85a0a721b27b873668ee83089c9c0efd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 22:57:27 +00:00
Jagrut Desai 70de8a4823 TaskbarPinningController Unit Tests
Test: Presubmit
Bug: 265439107
Flag: NONE

Change-Id: I5da3558adf88126b07c5d6217ee4fbbcc1e2e348
2023-12-11 14:46:55 -08:00
Brian Isganitis 98057e7451 Merge "Have Taskbar overlay window consume IME insets." into main 2023-12-11 22:21:22 +00:00
Xin Li 26fa6bd719 [automerger skipped] Merge "Merge Android 14 QPR1" into main am: aa168f204e -s ours am: e2d8c0c312 -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I6c44ba248bfcb774dad1066dc999ac5e97b5a43e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 22:05:03 +00:00
Xin Li c95f995a9e [automerger skipped] Merge Android 14 QPR1 am: 65e37d77fe -s ours am: 3cbfd5623b -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I80c12e5f9df2800928e385bb759446fcf5aace28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 22:02:14 +00:00
Charlie Anderson 489f1ada5c Add wrapper for logging backup & restore metrics from Launcher
Bug: 25177913
Flag: ACONFIG com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Test: locally

Change-Id: I220721f705eb7244a1f13ef8997682999d799f51
2023-12-11 17:01:28 -05:00
Tracy Zhou 6c24bf7c8e Merge "Do not set isImmersive in TaskbarDelegate" into main 2023-12-11 22:00:33 +00:00
Tracy Zhou 901b190153 Merge "Pass in navigation bar panel context created by task bar when taskbar navbar unification is on" into main 2023-12-11 21:47:59 +00:00
Sebastián Franco 1b86ab623f Merge "Testing if the test failing is because of an incorrect state" into main 2023-12-11 21:47:24 +00:00
Brian Isganitis 7eae1e6124 Split AFVs that controller should not intercept from TYPE_ACCESSIBLE.
TYPE_ACCESSIBLE no longer works for certain cases (see bug). This also
simplifies TouchControllers that would otherwise add or remove from
TYPE_ACCESSIBLE (such as ALL_APPS_EDU and TASKBAR_OVERLAYS).

Fix: 315507902
Test: Manual
Flag: N/A
Change-Id: I6f5d218dab87a8bcc8e7805d0ced9a6678f09c8e
2023-12-11 21:31:38 +00:00
Xin Li e2d8c0c312 [automerger skipped] Merge "Merge Android 14 QPR1" into main am: aa168f204e -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: Ifecff25b799b50b69594c664bfa4351b2251166e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 21:19:18 +00:00
Xin Li 3cbfd5623b [automerger skipped] Merge Android 14 QPR1 am: 65e37d77fe -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: Ie15a9e1fdafe177270dc6c5102ed1c2f86ab30e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 21:16:25 +00:00
Saumya Prakash ec514d054c Check that onAttach() is called before onResume() to prevent NPE.
Sometimes, the context is null in TutorialController which leads to an
NPE when relying on context specific functions. This change checks that
context is null and if so, defers the context specific functions that are
called until after onAttach() is called.

Fix: 307781152
Test: Set context to null in onResume() and check that the tutorial
continues like normal
Flag: None

Change-Id: I66e345f8361315787534bb88b9c1d12278708d78
2023-12-11 15:59:24 -05:00
Sebastian Franco 08d31d2595 Testing if the test failing is because of an incorrect state
Bug: 315525621
Flag: NA
Test: TaplTestsQuickstep#testPressBack
Change-Id: Iba41abac8e808fadd9e0513d8c0386bbfd63fdd6
2023-12-11 20:39:15 +00:00