Commit Graph

78275 Commits

Author SHA1 Message Date
Mady Mellor 2aedf52b8f Merge "If we're going to overview we might need to unstash" into main 2024-10-03 16:12:09 +00:00
Orhan Uysal 4acf699619 Merge "Fix overview animation after reboot." into main 2024-10-03 14:01:57 +00:00
Shamali Patwa b5c32d4c4f Merge "Add logs in ProxyActivityStarter when it fails to launch an activity" into main 2024-10-03 02:35:54 +00:00
Treehugger Robot 1bbcff3d48 Merge "Fix an issue where bubble bar would collapse when rotating" into main 2024-10-03 02:07:02 +00:00
Shamali P 66b501eae2 Add logs in ProxyActivityStarter when it fails to launch an activity
Apparently, it doesn't log when it fails due to some reason.

In 369422714, we see it being started but the appwidget's config
 activity not being launched. The absorbed exception makes it harder to
  know. There isn't a system log as well.

  At least looking at logs, we think for some reason appwidget's
   configuration activity wasn't launched by launcher.

Bug: 369422714
Test: N/A logging
Flag: EXEMPT BUGFIX

Change-Id: I56294ef37d7ddceb61c4e6d0e10d0f24fde42cb2
2024-10-02 22:33:39 +00:00
Mady Mellor 3e8cc610b3 Fix an issue where bubble bar would collapse when rotating
When the device is rotated, everything gets recreated, in this case,
bubble bar state is typically set to be stashed. However, if taskbar
and bubble bar were unstashed while rotating, bubble bar would be
incorrectly stashed. To fix this, only do the stash if taskbar is
also stashed in this case.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - be in an app, unstash bubbles, rotate device
             => observe that bubble bar is unstashed like taskbar
                after rotation
Bug: 353884121
Change-Id: Ia37397c62a1a6819c1bd42261f8a9955db511da3
2024-10-02 13:55:55 -07:00
Jagrut Desai 831ca957c0 Merge "Remove unused TestProtocol" into main 2024-10-02 20:51:10 +00:00
Sunny Goyal e14af2316b Merge "Converting some caching logic booleans to lookup flags" into main 2024-10-02 20:34:16 +00:00
Shamali Patwa 1667cf561f Merge "Move padding from parent to WidgetPagedView and siblings in 2-pane pkr" into main 2024-10-02 20:31:16 +00:00
Brandon Dayauon 17b246a556 Merge "Don't call onAppsUpdated() when in testHarness" into main 2024-10-02 19:53:36 +00:00
Shamali P adc171b313 Move padding from parent to WidgetPagedView and siblings in 2-pane pkr
WidgetPagedView seems to rely on padding to position it such that
 talkback doesn't focus on it before sticky header.

Bug: 348107507
Test: With talkback
Flag: EXEMPT bugfix

Change-Id: I2fcdc0cbf027a7a8c1bee104f85a61f700faf776
2024-10-02 16:55:59 +00:00
Liran Binyamin 1663bb3004 Merge "Bubble bar flyout polish" into main 2024-10-02 16:15:53 +00:00
Treehugger Robot d8daf184bc Merge "Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into main 2024-10-02 15:55:45 +00:00
Treehugger Robot 3faec179c0 Merge "Add debug memory logs to AbstractLauncherUiTest" into main 2024-10-02 15:39:05 +00:00
Schneider Victor-Tulias 9240b68dd6 Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS
Flag: EXEMPT bug fix
Fixes: 369359244
Test: performance testing
Change-Id: Id70c4b02738fd1abd62027fcddd0fac3c99fe95e
2024-10-02 14:15:56 +00:00
Bill Yi 4f4b2335b9 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-02 05:37:39 +00:00
Bill Yi bf752db081 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-02 05:37:39 +00:00
Treehugger Robot 5c3e15b0e0 Merge "Fix small bug with TaskView tile expansion" into main 2024-10-02 02:13:04 +00:00
Anushree Ganjam 0dc88fece8 Merge "Make InstallSessionHelper injected by Dagger (7/n)" into main 2024-10-02 01:57:48 +00:00
Treehugger Robot b4b2d16bcc Merge "Fix translation when focused task or desktop task is dismissed. (3/4)" into main 2024-10-02 00:38:10 +00:00
Treehugger Robot 6d763a301c Merge "Fix Taskbar unlock transition" into main 2024-10-02 00:14:04 +00:00
Treehugger Robot da290bcacf Merge "Make large task tile snap to position after scrolling" into main 2024-10-01 23:01:37 +00:00
Treehugger Robot ff97ec0d22 Merge "Fix comment in TransientBubbleStashControllerTest" into main 2024-10-01 22:38:17 +00:00
Kevin Lim adac5834e3 Merge "Use context#getDrawable instead of AppCompatResources#getDrawable to fix test failure." into main 2024-10-01 21:21:20 +00:00
Ats Jenk da477af93d Fix comment in TransientBubbleStashControllerTest
Bug: 345488489
Change-Id: Ide38c1e36a0da53e9fcc7a5c6b0c3241eff24add
Test: na
Flag: DOCS_ONLY
2024-10-01 21:06:02 +00:00
Tony Wickham 7519b7c2e6 Fix Taskbar unlock transition
- There are multiple signals that come just after FLAG_DEVICE_LOCKED
  is removed, and those should still be considered part of the unlock
  transition. We already did this for TaskbarStashController so I copied
  it to TaskbarLauncherStateController.
- Also animate when changing SYSUI_STATE_OVERVIEW_DISABLED, since this
  happens when the device is locked/unlocked and changes the visibility
  of TaskbarView icons.

Test: manually unlock over both home screen and in-app, verify clean
transition without jump (e.g. Hotseat is immediately visible as part of
Workspace, and Taskbar fades in during unlock to an app)
Flag: EXEMPT bug fix
Fixes: 364586744

Change-Id: If0497fcc17bb0ec44294c4ea1163104b4d8be459
2024-10-01 20:09:05 +00:00
Anushree Ganjam 29e060408f Make InstallSessionHelper injected by Dagger (7/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration

Change-Id: Ib1833436bfd1079ae78f1d865831c1aa8a7a0c41
2024-10-01 12:45:53 -07:00
Mady Mellor fd6772ab84 If we're going to overview we might need to unstash
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherTests:PersistentBubbleStashControllerTest
Test: atest NexusLauncherTests:TransientBubbleStashControllerTest
Test: manual - swipe up to overview from home & from in an app, ensure
               bubble bar is unstashed
             - switch between home / overview / in app in transient
               and persistent taskbar to make sure things work
Bug: 368364143
Change-Id: I34c22b000d1fcc75489ea6da497f14def9649a20
2024-10-01 11:57:26 -07:00
Ats Jenk da8487eb33 Merge "Update bubble stash test for transient taskbar" into main 2024-10-01 18:53:36 +00:00
Jeremy Sim 21f504e0f1 Fix small bug with TaskView tile expansion
There was a small typo that resulted in the wrong measurement being returned for the remaining TaskView. This CL fixes it.

Fixes: 365476600
Test: Manual
Flag: NONE bugfix
Change-Id: I1abf993abcaa8d06e5475f31c0322017f6e96e6f
2024-10-01 11:50:54 -07:00
Treehugger Robot 62d8cac481 Merge "Override pivot in TaskViewSimulator as well for zoom in launch animation" into main 2024-10-01 18:31:29 +00:00
Schneider Victor-Tulias 63dfd60b23 Add debug memory logs to AbstractLauncherUiTest
Flag: EXEMPT test debug logs
Bug: 365628676
Test: TAPL tests
Change-Id: Ia019bc128b76b9b2d776c54ad93713ae4110b2de
2024-10-01 18:15:13 +00:00
Sunny Goyal e978f6cedb Converting some caching logic booleans to lookup flags
Bug: 366237794
Test: atest IconCacheTest
Flag: EXEMPT refactor

Change-Id: I0d25996181954df22e1cb61596be0a2694ee7068
2024-10-01 17:59:48 +00:00
Bill Yi 9e196da120 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id0277715e43f68ca608c9ecf9629a5aa0c31d6fa
2024-10-01 10:28:37 -07:00
Bill Yi d77f2c1692 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I281ab493777a8d86477c5f5ca1f069cd368af5c3
2024-10-01 10:28:27 -07:00
Brandon Dayauon 32007e05cd Don't call onAppsUpdated() when in testHarness
Suspect that the jump in these flakes where it cannot find the private space container is due to this calculateDiff call when onAppsUpdate() is called

bug: 355466672
Test: tapl presubmit and vid: https://drive.google.com/file/d/1hshI6g7oqvi45EiO92Rl4e-gaXfDVe_b/view?usp=sharing
Flag: NONE trying to fix flake
Change-Id: I0bff416624c5b9e2cb7a4fe32834f9d521507922
2024-10-01 09:32:50 -07:00
Jagrut Desai 85a8898402 Remove unused TestProtocol
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ibe261ec8820f5d6e8415f5085c21a0adfef37462
2024-10-01 09:24:38 -07:00
Liran Binyamin 8bd8feb72d Bubble bar flyout polish
Animate the elevation of the flyout along with the expansion animation.
Also start revealing the triangle as soon as we're past the bubble bar.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Ie7e27240ae3ab86f8e7c3f39aa1c80885cfdc98e
2024-10-01 12:06:36 -04:00
Jagrut Desai 1b1ce734f0 Merge "Two Taskbar Bug" into main 2024-10-01 15:48:22 +00:00
Jordan Silva 0cf067ef47 Fix translation when focused task or desktop task is dismissed. (3/4)
This CL uses the same logic used for handheld dissmiss translation to fix the following cases when large tile is enabled for desktop task:
- When the LAST focused task is dismissed (i.e., no other task in the grid), translate all large tiles from the right side to the left, to occupy the dismissed focused task position.
- When Desktop Task is dismissed, translate focused task and grid from the left to the right side to occupy the dismissed desktop task position.
- When 2 tasks are visible in recents (i.e., 1 focused task, 1 desktop task) and the user dismisses the desktop task while in Clear All Button page (page 2), the focused task translates when no translation should be done, due to snapping to ClearAllButton page on Tablet. To fix this we introduced a logic in getOffsetToDismissedTask to use the previous page for the calculation when the grid snaps to Clear All Button page.

Bug: 353948136
Fix: 353948182
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: If8b06410c26a8f817d84ec6a635a66b2941e3ae9
2024-10-01 15:35:22 +00:00
Alex Chau ded6500848 Make large task tile snap to position after scrolling
- There's an edge case when there are only 2 grid tasks, mNextPage will still be on the grid tasks when they're not fully visible, so the new isAnySmallTaskFullyVisible check can't kick in. This only happens when grid tasks are barely out of screen.

Fix: 370733696
Test: Scroll betwene large tiles, it should always snap after scrolling
Test: Scroll from focus task to grid task, it should only snap if grid tasks aren't fully visible
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I3b0a80ceffb1caae57aa53b1c949c5e51336231a
2024-10-01 16:03:25 +01:00
Alex Chau 89283aa329 Override pivot in TaskViewSimulator as well for zoom in launch animation
- When launching large tiles, we zoom in RecentsView into the task we're launching, override pivot of RecentsView in the process
- This pivot override to be applied to TaskViewSimulator if a live tile is on screen, to avoid live tile animating to wrong position
- Also ensure the live tile draws above RecentsView, to avoid wallpaper blur from applying on the live tile

Fix: 361744056
Test: Launch central/side large tile with different live tile combinations
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I804edb988fb157d939dba34bc596c8b43aac8a45
2024-10-01 15:42:00 +01:00
Treehugger Robot 98f792331a Merge "Listen to display focus state in Launcher" into main 2024-10-01 04:18:35 +00:00
Vinay Joglekar cbe8f8f71d Merge "Fixed split in Desktop windowing" into main 2024-10-01 00:23:55 +00:00
Kazuki Takise 61b22f90ba Listen to display focus state in Launcher
As part of the Connected Display project, some UI features in
Launcher such as Alt-Tab need to be shown only on the focused
display.

This change adds FocusState, which registers to WMShell, and
provides a listener to other components in Launcher so they can
easily consume the display focus state (following the same pattern
of HomeVisibilityState).

Bug: 356109871
Flag: com.android.window.flags.enable_display_focus_in_shell_transitions
Test: Switching focus between displays and confirm signals are sent to Launcher.
Change-Id: I51d51ac0ce3e24afa363607cdfb41728748a4a5f
2024-09-30 23:45:03 +00:00
Kevin Lim 5c6a3e5746 Use context#getDrawable instead of AppCompatResources#getDrawable to
fix test failure.

Bug: b/352775107
Flag: EXEMPT Test crash fix
Test: atest NexusLauncherTests
Change-Id: I2a20fd6d1de3a5398c665d477c1e234d9b890781
2024-09-30 23:35:34 +00:00
Jagrut Desai 7cada7c46b Two Taskbar Bug
This cl fixes two taskbar bug being present when invoking CtS.

Solution: simply measure displacement and compare that with slop to animate taksbar background or not.

Test: Presubmit
Bug: 360116669
Flag: EXEMPT Bug Fix

Change-Id: I7d5a95e1a3729e30e5cf588dcf5b823f3d7de93f
2024-09-30 16:32:47 -07:00
Treehugger Robot 49e27e5257 Merge "Make widget sheet layout container not focusable" into main 2024-09-30 22:44:28 +00:00
Ats Jenk 5464ce0084 Update bubble stash test for transient taskbar
Include unit test to check that view properties are set to expected
values at the end of an unstash animation.
Add tests to check that alpha for bubbles and background changes
separately during unstash and stash animations.

Bug: 345488489
Test: TransientBubbleStashControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ifd10d4524128d42d23fe67c0eff2c4ae16d3b27b
2024-09-30 15:43:15 -07:00
vinayjoglekar 562ab4d188 Fixed split in Desktop windowing
When desktop windowing is enable and split is selected, during second app selection apps' scroll was far off on left. There were several things needed to fix this :
1. Hide DesktopTaskView during split select mode by changing splitAlpha
2. Fix min/max scroll calculation by excluding DesktopTaskView in split select mode
3. Exclude DesktopTaskView in updateGridProperties row length calcualtion

Testing: Manually needed to test multiple scenarios
1. Split focused task.
2. Split Even/Odd tasks in top and bottom rows.
3. Split tasks from home screen
4. Split and rotate screen.
5. Split from app icon chip

Test: SplitSelectStateControllerTest, Manual
BUG: 330342294
FIX: 330342294
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I789873100f42896c9ed3084accb0f6970abcba0c
2024-09-30 15:22:40 -07:00