Commit Graph

60555 Commits

Author SHA1 Message Date
Bill Yi 296fbc0de6 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 986a5c9cfd -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122646

Change-Id: Ic49924c17240f99a2ac33a4d70b9860586cabc7e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 22:11:52 +00:00
Treehugger Robot cf148e6834 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 360b5a301a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122643

Change-Id: I9f210e79f847aad65bf4620a593649ee4856e93e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 22:11:32 +00:00
Bill Yi eb6e26b163 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: cd5558fcd9 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122643

Change-Id: Iaf703db059b6aade3608c3c892c365a3e9391dc7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 22:11:12 +00:00
Treehugger Robot 91ce44e3b6 Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev am: f3fdca59d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23143004

Change-Id: I1db198140b10b11fb79122d63ea830d47db24b96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 22:07:07 +00:00
Treehugger Robot 360b5a301a Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-10 21:55:16 +00:00
Treehugger Robot f3fdca59d2 Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev 2023-05-10 21:40:40 +00:00
Sunny Goyal 64809780ce Revert "Fix null-pointers in SurfaceTransactionApplier constructor."
This reverts commit d86c5657e0.

Reason for revert: b/281294745

Change-Id: Ib2680b60346a9bc5932057707d0ef105441f324d
2023-05-10 19:34:01 +00:00
Jagrut Desai 2e0770af08 Merge "Fixing NPE in TransfromParams.java" into udc-dev am: 4d17468f88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23120958

Change-Id: I33acacb6ffcbcb22801b2ae292e5aacce85e3b20
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 19:13:09 +00:00
Jagrut Desai 4d17468f88 Merge "Fixing NPE in TransfromParams.java" into udc-dev 2023-05-10 18:57:17 +00:00
Bill Yi e764832e63 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6de8754830 -s ours am: 95285f1ed1 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122649

Change-Id: Ic3ea267acd3d306be16a7654a07231ec864ef79b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 18:52:03 +00:00
Bill Yi 95285f1ed1 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6de8754830 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122649

Change-Id: I01f86908b456f5f3db5f58b5ec6dc21eed0c934e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 18:13:48 +00:00
Treehugger Robot c6afe67f50 Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev am: fb085e6393
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23117884

Change-Id: Ic653f205c2c3210f5af7e42cb9af66c6f54355a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 17:47:26 +00:00
Treehugger Robot fb085e6393 Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev 2023-05-10 16:49:09 +00:00
Bill Yi 645ee454a3 [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 6de8754830 2p: e91594aef7
Blank merge reason: parent was merged -s ours

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122649

Change-Id: I0802251a51c1fde8cdde33e9d19e41241613564d
2023-05-10 14:36:33 +00:00
Bill Yi e91594aef7 [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 6de8754830
Blank merge reason: commit message contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122649

Change-Id: I683e2538b4d5549d6e1d5a2c16b466d4d1df3ed3
2023-05-10 14:34:47 +00:00
Thales Lima 2df31e3568 Merge "Add feature flag and attribute for responsive grid" into udc-dev am: 0740b7fb43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22476842

Change-Id: I38fb1b4e7af09d9ad617b1bc40a0a3138f71189e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 10:00:04 +00:00
Thales Lima 0740b7fb43 Merge "Add feature flag and attribute for responsive grid" into udc-dev 2023-05-10 09:44:49 +00:00
Marcello Galhardo 707d8231ef Merge "Move Note Shortcut from Settings to SystemUI" into udc-dev am: 09b42b3d83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23049102

Change-Id: I457b18c7b202e6e21bef1b3e81354ce55bfd7438
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 09:40:30 +00:00
Marcello Galhardo 09b42b3d83 Merge "Move Note Shortcut from Settings to SystemUI" into udc-dev 2023-05-10 09:23:54 +00:00
Bill Yi 6de8754830 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7dd50c73ab58bc08e112cb134653fe68b6fb4a2a
2023-05-09 16:07:31 -07:00
Bill Yi 986a5c9cfd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic3134f388645ce0d7c3af8cf3fc28938682aa78c
2023-05-09 16:05:28 -07:00
Bill Yi cd5558fcd9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If7588e84680dbc8f4fcc616af06914ab7c57d1a7
2023-05-09 16:04:17 -07:00
Xiaowen Lei 06f82f562b Merge "Add Lifecycle and SavedState support in Launcher ActivityContext." into udc-dev am: 7c8aeffa4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22608496

Change-Id: I9394336a7546dcc20ac1b09057a75926d8ebb39d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 23:02:56 +00:00
Xiaowen Lei 7c8aeffa4e Merge "Add Lifecycle and SavedState support in Launcher ActivityContext." into udc-dev 2023-05-09 22:07:40 +00:00
Fengjiang Li 77f1806491 Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev am: d382a4880b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23088599

Change-Id: Ie4234f9196ca701c78bf7393a0072d7a4147c3c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:57:19 +00:00
Jagrut Desai 4aa44e5169 Fixing NPE in TransfromParams.java
- we were not actually using mRecentsSurface so we no longer need to compute that. By removing this we will also fix the NPE.

Test: Pre-Submit
Fixes: 269716918
Flag: not needed
Change-Id: Ief4be341061a1c914456d6740f175662ccebc364
2023-05-09 14:45:17 -07:00
Fengjiang Li d382a4880b Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev 2023-05-09 21:33:36 +00:00
Treehugger Robot 20cee49543 Merge "Removing unused wallpaper-scrim feature" into udc-dev am: 386f9796e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039034

Change-Id: I9d230d90f707a2f3b91b77974ef9cb6840a12acb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:14:12 +00:00
Treehugger Robot 386f9796e3 Merge "Removing unused wallpaper-scrim feature" into udc-dev 2023-05-09 20:57:33 +00:00
Jagrut Desai 05af38cb53 Merge "Un-Split TaplTestsTaskbar" into udc-dev am: 53b4435b7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22821856

Change-Id: I3f369a4c362bc06d26b6f5b52cd6c6c871456c6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:50:54 +00:00
Schneider Victor-tulias 4f9ddc0db4 Merge "Fix tutorial menu layout issues" into udc-dev am: 458971616d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23089641

Change-Id: I6c5a6ae225028f269be2976a57405adeeb7f38aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:50:44 +00:00
Vinit Nayak 1529c40e6a Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev am: 5f475a2f48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22998399

Change-Id: I4b5d6f902fc34967c72db5fd790b0328243b2512
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:50:26 +00:00
Jagrut Desai 53b4435b7e Merge "Un-Split TaplTestsTaskbar" into udc-dev 2023-05-09 20:43:01 +00:00
Liran Binyamin 4e909d07ac Animate the position of the selected bubble arrow in the expanded bubble bar.
Fixes: 280605070
Test: Tested on a physical device
Change-Id: I961254527ba9a26d211c2c348a937a424fa2fb4d
2023-05-09 16:35:30 -04:00
Schneider Victor-tulias 458971616d Merge "Fix tutorial menu layout issues" into udc-dev 2023-05-09 20:18:07 +00:00
Vinit Nayak 5f475a2f48 Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev 2023-05-09 20:15:01 +00:00
Liran Binyamin b4d3315caa Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev am: a72094ad66
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039499

Change-Id: Icb686c04bea438aa9bc5bdf6d741f7336229b142
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 19:44:19 +00:00
Liran Binyamin a72094ad66 Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev 2023-05-09 18:02:53 +00:00
Jagrut Desai 9349dc9e1d Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380

Change-Id: I5b674580376f99dd1eebb8926f7303b098c7e569
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 17:00:51 +00:00
Xiaowen Lei 3c0f30a2bb Add Lifecycle and SavedState support in Launcher ActivityContext.
And call initCompose() in Launcher.java. Therefore there is no behavior
change for BaseActivity, or other ActivityContext subtypes that don't
call initCompose().

This should work for non-activity subtypes of ActivityContext. It's
likely that the Launcher activity will require more complete supoort for
Lifecycle and SavedState.

Note: In order to test the ComposeView, need to build this CL together
with ag/22461463.

1. `ViewTreeLifecycleOwner.set(..., ...);` is necessary to fix the
   following crash:

java.lang.IllegalStateException: ViewTreeLifecycleOwner not found

This error comes from WindowRecomposer.android.kt
  - http://cs/androidx-platform-dev/compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/WindowRecomposer.android.kt;l=351-354;rcl=5673af1441ebe04c776f528193dfc5f85c0c9a66

2. `ViewTreeSavedStateRegistryOwner.set(..., ...);` is necessary to fix
   the following crash:

java.lang.IllegalStateException: Composed into the View which doesn't propagateViewTreeSavedStateRegistryOwner!

This error comes from AndroidComposeView.android.kt.
  - http://cs/androidx-platform-dev/compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt;l=1178-1183;rcl=5673af1441ebe04c776f528193dfc5f85c0c9a66

3. The lifecycle needs to be STARTED. Otherwise the ComposeView doesn't
   show up in its parent (i.e., isn't drawn).
  - In ComponentActivity, `onSaveInstanceState` starts the lifecycle.
  - In ComposeInitializeImpl (from SystemUI),
    ViewLifecycleOwner.updateState() starts the lifecycle when the
    window is visible and in focus.
The implementation in this CL does the same thing as the
ComposeInitializeImpl.

Bug: 275905704
Test: on device, trigger a card such as the timer
Test: RUN_ERROR_PRONE=True m out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-report.xml
Test: RUN_ERROR_PRONE=True m out/soong/.intermediates/vendor/google/gms/packages/SearchLauncher/SearchLauncher/android_common/lint/lint-report.html
Test: Presubmit
Change-Id: Ieced66ad5238916a82ea13c01f69146bbdcf287a
2023-05-09 09:40:03 -07:00
Jagrut Desai 9569ce86a2 Un-Split TaplTestsTaskbar
Before we use TaskbarModeSwitch but had a drawback where we would not know which variant of taskbar the test failed for. So, we split the taskbar tests into transient and persistent for better error logs and debugging.
But, now we can use Parameterized Test Runner to achieve the same and do not have to duplicate test code for testing two different variants of Taskbar.

There can be instances where we only want to test certain taskbar variant only, we have separated files for that.

Test: Presubmit
Bug: 267648422
Flag: not needed
Change-Id: I4322498f13d257a5f1793b008f45b09ac9b9f3ff
2023-05-09 09:36:09 -07:00
Jagrut Desai 75109c7abc Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev 2023-05-09 16:19:44 +00:00
Pat Manning e1a3739ff7 Merge "Exit hover after taskbar unstash to clean up events between tests." into udc-dev am: 266689014e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063340

Change-Id: Ic0b426389412d861c430a5658089940e46385268
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 11:53:30 +00:00
Pat Manning 266689014e Merge "Exit hover after taskbar unstash to clean up events between tests." into udc-dev 2023-05-09 11:11:33 +00:00
patmanning 419cac7ab3 Exit hover after taskbar unstash to clean up events between tests.
Fix: 281068877
Test: TaplTestsTaskbar
Change-Id: I5cbac63cb96788bf84bf5dc0e60a7d5c579c1438
2023-05-09 11:10:46 +00:00
Thales Lima ec5abba93b Add feature flag and attribute for responsive grid
This shouldn't change anything in the grids, only support the creation of responsive grids in the future. For now, to check that the flag works, turn it on and check the dumpsys. There is also a dump test created for this.

Fix: 277064696
Fix: 277064702
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I1bef87043a100234bd661cd6ac00007fdc654116
2023-05-09 12:06:18 +01:00
Vinit Nayak 2a077e73cf Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR am: b33a2e0762
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22958378

Change-Id: Iff36d989bdcaae465b2e9a59e3a0d67588b4da8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 07:12:26 +00:00
Vinit Nayak b33a2e0762 Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Change-Id: I9c58ba50f0269c69a12f548a1873c2d8251f6243
2023-05-08 17:27:03 -07:00
Winson Chung 11ace3672a Merge "Potential fix for end callback not being run in 3-button" into udc-dev am: 606c4bfc59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23019205

Change-Id: Ie5f14a244232f96171e158932f4f4c06740b21de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 00:18:51 +00:00
Jagrut Desai 29fcd9a636 Taskbar All Apps Icon Shortcuts Popup Accesiiblity
Before we were only applying the icon.clearAccessibilityFocus() only on normal popup and not material u popups, since the flag is turned on for udc, we can move it outside.

There seems to be a bug associated with either nested abstract floating views or the accessibility service where upon opening a nested abstract floating view from another the icon get the focus. This change make the bug littl less visible to use but users will still see this bug if they open the shortcut pop agian withought closing taskbar all apps.

The accessibility delegate was always null when using the TaskbarOverlayContext, now we use TaskbarActivityContext Delegate when in TaskbarOverlayContext.

Test: Manual
Bug: 280657266
Flag: not needed
Change-Id: I631e3aa6e54748c4c8ea2ac7daf5473b198e47d6
2023-05-08 16:25:53 -07:00