Commit Graph

76182 Commits

Author SHA1 Message Date
Isak Lilja 29322e82fe Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE
It was not possible to save an app pair if free snap mode was enabled
and the snap position was SNAP_TO_NONE. Just default to 50-50 split if
the current divider snap position is SNAP_TO_NONE.

Cherrypicked from isak.lilja@sony.com's CL at https://partner-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/2835425.

Bug: 343219704
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I62347ac13440f714a493366ac66e893578a2d8d9
2024-05-31 21:52:15 +00:00
Brian Isganitis 92b73a4f09 Merge "Revert "Add flag for Tiny Taskbar"" into main 2024-05-24 19:12:07 +00:00
Brian Isganitis 7317e42b47 Merge changes I340485ed,Iba07382d into main
* changes:
  Disable taskbar EDU for tiny taskbar.
  Initial prototype of tiny taskbar.
2024-05-24 19:11:55 +00:00
Treehugger Robot f02bafdc07 Merge "Remove multivalentTestsForDeviceless symlink and make deviceless default" into main 2024-05-24 19:08:52 +00:00
Winson Chung ff728284b4 [automerger skipped] Merge "Report gesture height for mandatory system gestures" into 24D1-dev am: 6e71bffae7 -s ours
am skip reason: Merged-In Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486 with SHA-1 05682a059f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27504220

Change-Id: I238e022e377a3bbd8f5a9ad1319f7d70c23eeead
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-24 17:09:49 +00:00
Winson Chung 5ad482f208 [automerger skipped] Report gesture height for mandatory system gestures am: 21bb36fa66 -s ours
am skip reason: Merged-In Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486 with SHA-1 05682a059f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27504220

Change-Id: I8e9f000fb4a6d7fb4ee88f17e053f4c42bad82b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-24 17:09:46 +00:00
Winson Chung 6e71bffae7 Merge "Report gesture height for mandatory system gestures" into 24D1-dev 2024-05-24 16:39:11 +00:00
Bill Yi dfa4b82cf1 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: b9487c16ce -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27503405

Change-Id: I20fdc4fa9bdc29c411ce0cbd19773cd84040eee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-24 16:11:06 +00:00
Uwais Ashraf ba4fd32789 Remove multivalentTestsForDeviceless symlink and make deviceless default
Bug: 342146813
Test: Ran tests in studio
Flag: EXEMPT test build files
Change-Id: I0971a5b25a09069157bae51d518ddde502bd4e74
2024-05-24 15:51:04 +00:00
Uwais Ashraf e497456547 Merge "Add TasksRepository" into main 2024-05-24 15:49:46 +00:00
Uwais Ashraf f6f34ca441 Add TasksRepository
Bug: 334825222
Test: TasksRepositoryTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3e08dea7b205df54f8bef456ead6466aa2ce45c6
2024-05-24 12:06:59 +00:00
Pierre Barbier de Reuille 2de842b558 Merge "Update desktop mode to identify minimized tasks" into main 2024-05-24 08:26:48 +00:00
Winson Chung 21bb36fa66 Report gesture height for mandatory system gestures
- We are currently reporting the content insets for the mandatory system
  gestures in taskbar, but for button nav we should actually be
  reporting zero, and for gesture nav we should either report the
  content height if the taskbar is pinned, or the gesture height
  otherwise as the bottom mandatory gesture inset

Fixes: 340134342
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Change-Id: Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486
Merged-In: Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486
(cherry picked from commit 05682a059f)
2024-05-24 07:15:17 +00:00
Winson Chung 0131a2757f Merge "Report gesture height for mandatory system gestures" into main 2024-05-24 04:32:12 +00:00
Bill Yi b9487c16ce Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I621e54f11fe617f515d5a68af4dc0555c4f12236
2024-05-23 20:52:20 -07:00
Liam Lee Pong Lam 1f5e8c6e77 Merge "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard shown" into main 2024-05-23 23:35:36 +00:00
Winson Chung 05682a059f Report gesture height for mandatory system gestures
- We are currently reporting the content insets for the mandatory system
  gestures in taskbar, but for button nav we should actually be
  reporting zero, and for gesture nav we should either report the
  content height if the taskbar is pinned, or the gesture height
  otherwise as the bottom mandatory gesture inset

Bug: 340134342
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Change-Id: Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486
2024-05-23 22:43:02 +00:00
Brian Isganitis 6fd271bb8a Revert "Add flag for Tiny Taskbar"
This reverts commit 1a57e08d84.

Reason for revert: ag/27470277 flag instead
Flag: com.android.wm.shell.enable_tiny_taskbar
Test: None
Bug: 341784466

Change-Id: I1a36c66eabb9c2ddac4595cec6836da222182351
2024-05-23 22:31:07 +00:00
Brian Isganitis 4aa0b3f261 Disable taskbar EDU for tiny taskbar.
The tooltips are generally too large for phone mode, and since this is a
prototype, let's disable them when in tiny mode :)

Flag: com.android.wm.shell.enable_tiny_taskbar
Test: Manual
Bug: 341784466
Change-Id: I340485edf8bedc6b5d9501cb7c74b0864ae79630
2024-05-23 16:49:24 -04:00
Brian Isganitis e1eaefd537 Initial prototype of tiny taskbar.
Introducing isTinyTaskbar and using in a few places to show Taskbar on
phones.

Disabling for three button mode since the buttons will take up most of
the space. Could also prototype adding meta key as a 4th button in
this case if we feel like it.

Flag: com.android.wm.shell.enable_tiny_taskbar
Test: Manual
Bug: 341784466
Change-Id: Iba07382d9bd5d14fc29ef080a390db561f6fd454
2024-05-23 16:40:58 -04:00
Pierre Barbier de Reuille f60dd5471c Update desktop mode to identify minimized tasks
When a task is minimised, it becomes invisible but is still running.
WMShell now signals to the launcher when a task's visibility changes.
The task bar takes the visibility into account to know if a running task
is, in fact, minimised.

Test: atest NexusLauncherTests:DesktopTaskbarRunningAppsControllerTest
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 333872717
Change-Id: Iaff6b1240d354bb3c4de8e4884948acf9bf40112
2024-05-23 20:59:16 +01:00
Alex Chau c228dbd2c1 Reset RecentsView when detached from window
- onDetachedFromWindow is a sign RecentsView or even activity will be destroyed, if we don't reset RecentsAnimationController will be stuck without finsihing, causing live tile to be stuck on screen

Bug: 339747262
Test: Swithcing apps (recents button, quick switch, OVerview) from Maps driving mode, live tile not stuck
Flag: EXEMPT bugfix
Change-Id: I990cfe0fc814c9125dbfbaf8a298f1b871e0194e
2024-05-23 11:34:41 +01:00
Alex Chau ebcd2e5cd5 Merge "Don't call onModalnessUpdated if modalness stays the same" into main 2024-05-23 09:18:59 +00:00
Johannes Gallmann 6b078336fb Merge "Add shanh and gallmann to Launcher owners for predictive back" into main 2024-05-23 06:45:27 +00:00
Johannes Gallmann 364f912da0 Add shanh and gallmann to Launcher owners for predictive back
Bug: NONE
Flag: NONE owners-file only
Test: NONE
Change-Id: I3614b8ca279d9c81a4c3dd3f93c35beff6f6f179
2024-05-23 06:44:57 +00:00
Liam, Lee Pong Lam 883a79db71 [Launcher3] Hide keyboard when fastscroller scrolling down and keyboard
shown

Implement keyboard hiding logic: Hide keyboard when scrolling down (y > mLastY) unless already requested (mRequestedHideKeyboard). Track hide request state to prevent redundant calls.

result video: https://photos.app.goo.gl/e4dYUUiUN3BujNUz9

Bug: 333967597
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I42b9d05dd5368b021577f12541248d434ee22495
2024-05-22 23:17:28 +00:00
Treehugger Robot 014a17ee58 Merge "Animate scrim within open/close PendingAnimation." into main 2024-05-22 23:13:47 +00:00
Winson Chung 1ed3536146 [automerger skipped] Merge "Add multi-instance state to item infos" into 24D1-dev am: f13fa37d0f -s ours
am skip reason: Merged-In I565b4bee4ab5f7040910306b1fd60a4fc3bf9a1c with SHA-1 94e8ad0731 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27445815

Change-Id: I9708ffa9ce3153c701e193d91503f97f0ee4ec83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-22 22:39:46 +00:00
Winson Chung ade6941799 [automerger skipped] Add multi-instance state to item infos am: ab8e999f81 -s ours
am skip reason: Merged-In I565b4bee4ab5f7040910306b1fd60a4fc3bf9a1c with SHA-1 94e8ad0731 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27445815

Change-Id: Ib02fc4f3e6250f536711844a8ded309877caec32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-22 22:39:43 +00:00
Winson Chung f13fa37d0f Merge "Add multi-instance state to item infos" into 24D1-dev 2024-05-22 22:21:24 +00:00
Sihua Ma 26d9b9c696 Merge "Reapply "Move widget picker tests to Robolectric"" into main 2024-05-22 21:56:02 +00:00
Brandon Dayauon bd3eaa898e Merge changes I64e9a228,I300e8513 into main
* changes:
  Update private space divider thickness and padding per spec.
  Update install app icon colors to spec:
2024-05-22 21:22:00 +00:00
Zak Cohen 73fe0b439e Merge "WidgetPicker - Fix sliding scrim on add widget dialog." into main 2024-05-22 21:03:46 +00:00
Zak Cohen 10cf086910 WidgetPicker - Fix sliding scrim on add widget dialog.
Use the system dimming for standalone widget picker activity, as the system
is applying a default transition.


Bug: 342230362
Flag: NONE animation tweak
Test: visual

Change-Id: I278f8bf97acbfbfca652e1e6b616e2d2885ca92a
2024-05-22 13:32:59 -07:00
Andrew Cole 4897f7bcd6 Merge "Removing AdaptiveIconDrawable Checks" into main 2024-05-22 20:25:56 +00:00
Sihua Ma 1159c2546f Reapply "Move widget picker tests to Robolectric"
This reverts commit 97ee134acc.

Reason for revert: Fixed an issue with UI_HELPER_EXECUTOR that caused the flakiness

Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: None Test migration
Fix: 325088642
Fix: 325088805
Fix: 325089116
Fix: 325088960

Change-Id: I2f50c30d2c861e3bba8a8fa3ec547ca2ade6153a
2024-05-22 19:41:11 +00:00
Alex Chau 04b355a2d9 Don't call onModalnessUpdated if modalness stays the same
- Repeatedly calling onModalnessUpdated results in repeated calls of View.setAlpha, which caused regression in Overview loading time

Fix: 341266234
Test: android.platform.test.scenario.messenger.OpenAppFromQuickStepAndOpenQuickStepMicrobenchmark#testOpenQuickStepAndOpenApp
Flag: EXEMPT bugfix
Change-Id: Id756e80f20afafee2bb45e6a3ab861d83ab0b674
2024-05-22 18:52:42 +00:00
Bill Yi 940a9d1838 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-22 18:39:08 +00:00
Bill Yi 3dec8d67c2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-22 18:39:08 +00:00
Bill Yi 59fd8cbfaf [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5a4062bd1f -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27441316

Change-Id: I0ad27df7b9c9cd6ec7bb132ca6074047c3665566
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-22 17:53:06 +00:00
Brian Isganitis d0947bc61c Merge "Add brianji to multitasking-eng owners section." into main 2024-05-22 16:43:34 +00:00
Anushree Ganjam ef9427c709 Merge "Add "Uninstall app" string for private space shortcut." into main 2024-05-22 16:08:31 +00:00
Johannes Gallmann ddeca9746f Merge "Use better heuristic for when to apply statusbar customization during predictive back" into main 2024-05-22 15:26:36 +00:00
Treehugger Robot 656f0e8d13 Merge "Avoid IconView's setModalAlpha interfere with setContentAlpha" into main 2024-05-22 09:40:29 +00:00
Anushree Ganjam 87e875e702 Add "Uninstall app" string for private space shortcut.
Before: https://screenshot.googleplex.com/8RvbiWnJmgAvSYf.png
After: https://screenshot.googleplex.com/4e7N3rr8EAH7k6B.png

Bug: 335451332
Flag: com.android.launcher3.enable_private_space
Flag: EXEMPT resource only update
Test: Manual
Change-Id: I759005f51562683cb6c095abcca27d448acd10f8
2024-05-21 16:36:02 -07:00
Uwais Ashraf fe2107c59d Merge "Revert "Move widget picker tests to Robolectric"" into main 2024-05-21 23:05:12 +00:00
Winson Chung ab8e999f81 Add multi-instance state to item infos
- Add legacy resource for supported multi-instance apps that
  matches the current SystemUI resource of the same name, and will
  be removed as apps migrate to the V manifest property to declare
  multi-instance support
- Load the multi-instance state from PackageManager when the db is
  first loaded or when packages are updated
- The multi-instance check is then used to determine if an app pair
  can be saved (ie. whether the action can be shown)

Bug: 323112914
Test: atest NexusLauncherTests

Merged-In: I565b4bee4ab5f7040910306b1fd60a4fc3bf9a1c
Change-Id: I9658b63672b692c42563c111c11be2433c98d535
2024-05-21 23:01:19 +00:00
Brian Isganitis 74cfea3b12 Add brianji to multitasking-eng owners section.
Bug: N/A
Flag: EXEMPT OWNERS change
Test: N/A
Change-Id: I70eae3d6e1a4c253ec5f7e70af1cf4441e865e06
2024-05-21 18:20:59 -04:00
Uwais Ashraf e21d6b15d5 Merge "Fix some compile errors occurring as a result of robo enablement" into main 2024-05-21 21:18:11 +00:00
Liran Binyamin 821fac010f Merge "Fix flake in BubbleBarViewAnimatorTest" into main 2024-05-21 20:24:45 +00:00