Commit Graph

21420 Commits

Author SHA1 Message Date
Dan Willemsen 26b0938f09 Fix Launcher3Tests SDK version
In a879f9c481, the ub-launcher-aosp-tapl
was switched from current to system_current. Since Launcher3Tests links
against this library, we require it to use the system stubs as well.

But I broke the check in the build system while doing some cleanup, so
we never noticed. I'm fixing the check in:
https://android-review.googlesource.com/c/platform/build/+/1156840

Bug: 143748700
Test: treehugger
Change-Id: Ifcf47b19f7ed8f907e437325b4fd6a599fcca4cf
(cherry picked from commit 981ec8b789)
2019-12-26 22:18:32 +00:00
James O'Leary 027cb32a96 Merge "Compose overscroll gesture updates" into ub-launcher3-master 2019-12-26 17:27:24 +00:00
Automerger Merge Worker cb058bfccc Increase drag distance threshold when drag starts from deep press am: 848696ac1d
Change-Id: Id6d7385cf2942cdbf76e5cbab5059e0d9b91baba
2019-12-24 23:10:27 +00:00
Tony Wickham 848696ac1d Increase drag distance threshold when drag starts from deep press
Also don't update distance dragged until drag actually starts
(otherwise we add a lot of motion before deep press triggers).

Bug: 146146413
Change-Id: I28bd23707a9be53c709d7a4e779e84b9a0be9ce2
(cherry picked from commit a7704c09c7)
2019-12-24 19:00:32 +00:00
Tony Wickham 74b492cc37 Merge "Increase drag distance threshold when drag starts from deep press" into ub-launcher3-master 2019-12-23 23:00:21 +00:00
Tony Wickham a7704c09c7 Increase drag distance threshold when drag starts from deep press
Also don't update distance dragged until drag actually starts
(otherwise we add a lot of motion before deep press triggers).

Bug: 146146413
Change-Id: I28bd23707a9be53c709d7a4e779e84b9a0be9ce2
2019-12-23 13:28:58 -08:00
James O'Leary a9156a05c4 Compose overscroll gesture updates
Two changes for the latest Compose prototype:
1. Pass the identity of the underlying app to the Overscroll plugin.
2. Enable the Compose gesture over an app when there's a Recents extra
card plugin active (otherwise the current app won't count as the
rightmost one).

Some changes to the gesture:
- Angle decreased from 35° to 25° to remove overlap with
Assistant gesture
- Distance increased from 8 to 110 dp. 110 dp is 2x the Assistant
gesture and roughly the same as scrubbing into an app from Home.
- Fling detection added; uses same distance threshold, 110 dp.
- If a touch was recognized as another gesture, the touch will not be
reinterpreted as a Compose gesture, no matter what touch movement occurs
- Fixes issue where Assistant + Compose could both be triggered
- Fixes issue where scrubbing apps to the left, then back to the right,
would bring in Compose. i.e. if a touch down + touch movement starts
bringing in Assistant UI elements, then, the user moves their touch
below the Assistant angle, the Compose gesture will not start
being recognized
- Gesture length required for fling lowered from 110 dp to 40 dp, per
tuning with PM.

Bug: b/146508473
Change-Id: I414573d1a92684d1d992837a5f1df522346ec211
2019-12-23 10:59:30 -05:00
TreeHugger Robot 800aaa0d32 Merge "Not using SIDELOADED_LAUNCHER name" into ub-launcher3-master 2019-12-21 01:45:50 +00:00
TreeHugger Robot 2f285996dd Merge "Collect app usage data for hybrid hotseat feedback" into ub-launcher3-master 2019-12-21 01:35:21 +00:00
Becky Qiu 28a287624f [Overview chips] Turn overview chips off.
Change-Id: Ic200fa5e570abae6c41a12eb22bb3b853d02d504
2019-12-20 13:31:09 -08:00
Zak Cohen 2011efe0bb Merge "Overview actions - Add controller for actions." into ub-launcher3-master 2019-12-20 01:21:30 +00:00
Zak Cohen 1e58d99531 Overview actions - Add controller for actions.
Add the actions to the task overlay to simplify code sharing.

Test: added unit tests for controller

Change-Id: Ie497a717b189903cc1834685f4b7d0cb926a7f52
2019-12-19 15:24:10 -08:00
Samuel Fufa 89d100197a Collect app usage data for hybrid hotseat feedback
Bug:145858435
Test:Manual
Change-Id: Ib9cbe0cb87a152a751e6253db42d58d2d0625c52
2019-12-19 15:08:23 -08:00
TreeHugger Robot c7d601e923 Merge "TAPL: logging incoming intents" into ub-launcher3-master 2019-12-18 02:58:28 +00:00
TreeHugger Robot 9ca5cc76a9 Merge "keep androidx fragment through proguard optimization" into ub-launcher3-master 2019-12-18 01:36:37 +00:00
Andy Wickham b8a56800e9 Fixes keyboard dismissal of current task.
Dismiss current task in Recents view by
pressing the Delete key.

Test: Manual
Change-Id: Ieff6c5e5153efdf1c2a491cdc6e91fb7e50879f8
2019-12-17 16:02:41 -08:00
Pinyao Ting 8b4ed23ef7 keep androidx fragment through proguard optimization
Bug: 146432215
Test: on android master, apply the proguard config, build and flash and
verifies crash no longer occurs

Change-Id: Ie967bcbd33bfbc1b8ec088c55829760145f7b597
2019-12-17 15:54:32 -08:00
Automerger Merge Worker 30f232de4c Fix shortcut componentname in workspace layout logging am: b9ba427576
Change-Id: I6ffef9cc9dabb32e1d6b1a16e7011d3c9b6b9c3b
2019-12-17 23:31:48 +00:00
vadimt 97d7b9024d Fixing typo
Change-Id: Ifba10c3d804f6c009b9ce40732c08ea17ee7b559
2019-12-17 14:58:10 -08:00
Hyunyoung Song b9ba427576 Fix shortcut componentname in workspace layout logging
Bug: 146172747
Test: $ adb shell dumpsys activity provider com.google.android.apps.nexuslauncher/com.android.launcher3.LauncherProvider --proto --debug
SHORTCUT, package=com.android.vending, component=VIEW_MY_DOWNLOADS, grid(3,4), span(1,1), pageIdx=0 user=0


Change-Id: Ic8537d499d66675fbe190f137b50fb693d6c21d5
2019-12-17 05:25:35 +00:00
vadimt baf5fbbe58 TAPL: logging incoming intents
Even though ActivityTaskManager already logs intents, logging this will
simplify flake/error investigations that are considered to be too
time-consuming.

Also, this will make it possible in future to programmatically detect
whether the bug is introduced by the system or Launcher.

Bug: 133010698
Change-Id: I7dcadd95baa23f29bb661d6b42280bd2a2f0e099
2019-12-16 18:56:09 -08:00
TreeHugger Robot 158a0b9059 Merge "Defer resetting the animation controller and targets on cancel" into ub-launcher3-master 2019-12-17 01:15:33 +00:00
TreeHugger Robot c16667032a Merge "Logging state change events when in test to simplify diagnosing" into ub-launcher3-master 2019-12-16 23:40:40 +00:00
TreeHugger Robot 45657afdde Merge "Adding diagnostics for failing click-to-home" into ub-launcher3-master 2019-12-16 22:49:21 +00:00
TreeHugger Robot c9a907bec1 Merge "Removing temporary workarounds to make tests pass on Cuttlefish" into ub-launcher3-master 2019-12-16 22:37:09 +00:00
TreeHugger Robot 0f58b63445 Merge "Diagnosing visible windows' packages for Background mode" into ub-launcher3-master 2019-12-16 22:36:48 +00:00
TreeHugger Robot 7d8901689c Merge "Improving navigation mode switch rule and around" into ub-launcher3-master 2019-12-16 22:36:42 +00:00
vadimt 44e697b0a3 Adding diagnostics for failing click-to-home
Bug: 133010698
Change-Id: Id887543f65812bb5607043a1cfcb2e95cf97ccb5
2019-12-16 13:38:27 -08:00
TreeHugger Robot bdfa251d67 Merge "Add boolean to differentiate icons from workprofile" into ub-launcher3-master 2019-12-16 20:31:33 +00:00
TreeHugger Robot 03b14a6d44 Merge "Generating state-changed-to-home event for Widgets->Home transition" into ub-launcher3-master 2019-12-14 03:21:09 +00:00
vadimt bd28a8ec0c Not using SIDELOADED_LAUNCHER name
It may imply something malicious, while we simply mean a third-party
launcher.

Bug: 79437767
Change-Id: I2e169fda9404ca7a042e40877ed6f4b7d2d723a1
2019-12-13 17:22:48 -08:00
Vadim Tryshev f4b5bcac43 Merge "Starting swipe-to-all-apps outside of areas triggering long-press" into ub-launcher3-master 2019-12-13 18:50:22 +00:00
TreeHugger Robot 3fc7029818 Merge "Recycling accessibility event as the docs require" into ub-launcher3-master 2019-12-13 18:38:16 +00:00
vadimt 08eca2fa2e Removing temporary workarounds to make tests pass on Cuttlefish
Bug: 136278866
Change-Id: Ie537a578bb871921c0cbea1f197261e703de98f5
2019-12-12 18:15:48 -08:00
vadimt 03cd58e575 Diagnosing visible windows' packages for Background mode
Change-Id: I3caeef4cd890500585f033024b1b6c3521b9e39d
2019-12-12 18:07:42 -08:00
vadimt a45ee97074 Recycling accessibility event as the docs require
Change-Id: I94a2ea7ab93690d0216110b5f77f0116177788a7
2019-12-12 17:43:38 -08:00
vadimt f0c80528ab Starting swipe-to-all-apps outside of areas triggering long-press
I suspect that some tests using TAPL run under pressure (mem or CPU,
created either intentionally or as a result of a leak somewhere)
where test process may generate a pause between DOWN and MOVE events
enough to be recognized as a long tap, which opens a context menu
instead of swiping.

While the clean solution is b/140252325, this is a workaround.

Bug: 144853809
Change-Id: I135eaee608270b7e60bb072cb360632763cbe5c5
2019-12-12 16:27:25 -08:00
Peter Kalauskas 36774217a4 Merge "Remove Launcher3GoIconRecents" into ub-launcher3-master 2019-12-12 23:39:11 +00:00
vadimt 2eb48498b4 Improving navigation mode switch rule and around
Logging assertion failures.
Modifying waits for condition to avoid timing out the whole test if the
iteration takes too long in favor of failing with an actionable diag.

Bug: 145985438
Change-Id: Ie32d93e1548ce6ec64c38449eb1be1287ff9cf56
2019-12-12 15:10:52 -08:00
Automerger Merge Worker a11ff18d6b [automerger skipped] perform accessbility focus when the recyclerview doesn't gain focus am: 9c592e210e -s ours
am skip reason: Change-Id I100e646ad2aba0081b48b86ec408ce8e76a80713 with SHA-1 865dc9b3b1 is in history

Change-Id: If0b71cdd5977c6793c9ca44c6729904c77966174
2019-12-12 18:46:00 +00:00
vadimt 526c630500 Simplify diagnosing of the context menu being present when not expected
Change-Id: I3550a724665f908ef70570e2e151c53fc7fa1844
2019-12-11 18:09:39 -08:00
vadimt 5995e60d90 Logging state change events when in test to simplify diagnosing
Change-Id: I48f741802696f7ef1764a5745ae6243c407a19cc
2019-12-11 17:53:03 -08:00
vadimt 9f48a8ec3b Generating state-changed-to-home event for Widgets->Home transition
This event is required by TAPL is is not currently generated by
Launcher3.

Change-Id: Ibf38b6779cc8d0d6a62d415d07c874d00956435a
2019-12-11 17:24:59 -08:00
Winson Chung 72c5f1f58f Defer resetting the animation controller and targets on cancel
- In the case where the recents animation is canceled while the running
  window animation is running, we invalidate the handler, and force end
  the window animation, which results in the end target being calculated
  and transitioned to.  Because the handlers can still reference the
  animation controller at this point (even though the calls will be
  no-ops since it was canceled), we should not reset the vars until the
  state has been updated.

Bug: 145641576

Change-Id: I5a660026fabb5beb0c45dffeeb4cb4feef5dec30
2019-12-11 17:00:06 -08:00
TreeHugger Robot 98833d525c Merge "Updating some non-final static objects" into ub-launcher3-master 2019-12-11 22:07:53 +00:00
TreeHugger Robot 7d2f42d97a Merge "Moving logging Launcher and platform versions before matching" into ub-launcher3-master 2019-12-11 21:30:35 +00:00
TreeHugger Robot 41dd48a718 Merge "Diagnosing the reason for opening context menu" into ub-launcher3-master 2019-12-11 21:29:38 +00:00
Sunny Goyal 73b5a27b14 Updating some non-final static objects
Updating various static objects to use a standard pattern so that
it is easier to track and cleanup those objects

Bug: 141376165
Change-Id: Ia539cbfa338d544dddad771c5027b6748762768b
2019-12-11 13:22:58 -08:00
Peter Kalauskas 0842cf5f9d Remove Launcher3GoIconRecents
Bug: 144129431
Test: Build and check that Launcher3QuickStepGo is used instead
Change-Id: Ib2a30c9e1e78de7792f34c3505372c8af1cb307d
2019-12-11 12:18:52 -08:00
TreeHugger Robot 4f37a5e268 Merge "Removing static instances of UserManagerCompat and AppWidgetManager" into ub-launcher3-master 2019-12-11 18:41:04 +00:00