Commit Graph

73426 Commits

Author SHA1 Message Date
Jeremy Sim 227d3b79f3 Merge "Ignore taskbar launch request if app(s) are already running" into main 2023-12-21 07:00:27 +00:00
Fengjiang Li f63532e610 Merge "Fix small gap between widget resize frame and widget background." into main 2023-12-21 01:34:16 +00:00
Jeremy Sim 9a7b6f972b Ignore taskbar launch request if app(s) are already running
This CL fixes several issues:
- When launching an app pair on top of the exact same app pair, Overview no longer enters a broken state
- When launching another app quickly after launching an app pair, splitscreen no longer breaks

Fixes: 315190686
Test: Launch app pair and then launch same app pair again from Taskbar -- Overview does not break
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I0d474dd89359e1a10a881c5cf8deee64754219c3
2023-12-21 10:13:20 +09:00
Jeremy Sim 0c8a38d181 Merge "Fix crash with app pairs and grid migration" into main 2023-12-21 00:07:47 +00:00
Shamali Patwa 716f982d44 Merge "Add long click listener to the widget picker activity" into main 2023-12-20 22:39:57 +00:00
Fengjiang Li 1e6bbf368b Fix small gap between widget resize frame and widget background.
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.

Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NA
Change-Id: I05143d76c98de7bbcfdca5cfacb21b3ace669861
2023-12-20 14:26:21 -08:00
Brian Isganitis 4227a72c94 Merge "Have meta key toggle Taskbar All Apps in freeform mode." into main 2023-12-20 21:00:01 +00:00
Pat Manning d842f5e573 Merge "Hide taskbar icons for IME when virtual keyboard is present." into main 2023-12-20 20:11:43 +00:00
Brian Isganitis 588b78e174 Have meta key toggle Taskbar All Apps in freeform mode.
Test: Manual
Fix: 315245851
Flag: NA
Change-Id: Ie72f2f48ed21e85fc3b3f707cfd91023ebe79a7c
2023-12-20 19:42:19 +00:00
Jagrut Desai d89b61a487 Merge "Adding Support for Tapl Workspace Tests into PlatformScenario" into main 2023-12-20 19:11:36 +00:00
Pat Manning 559434af5a Hide taskbar icons for IME when virtual keyboard is present.
Unless hardware keyboard is attached and taskbar is pinned.

Fix: 316270741
Bug: 255818649
Test: Manual. Using combinations of transient taskbar, virtual and hardware keyboards.
Flag: NONE
Change-Id: I1fae1655fc16b9fa951510cf834d2a33cb8956d8
2023-12-20 18:55:09 +00:00
Federico Baron 1abb9a47b4 Merge "Align QSB with hotseat and workspace icons" into main 2023-12-20 17:36:12 +00:00
Schneider Victor-tulias a7519cd0c6 Merge "Focus the first task in KQS when it is not currently running" into main 2023-12-20 14:58:18 +00:00
Shamali P 790d599d2a Add long click listener to the widget picker activity
The listener allows us to drag and drop widgets outside the launcher.

Bug: 315209740
Test: atest Launcher3Tests
Flag: NA

Change-Id: Iafc6e8903ea4f32540df30152b35d9eb7e98c6d6
2023-12-20 14:30:44 +00:00
Sergey Pinkevich 4d2515b4e2 Merge "Wrong app chip menu position for RTL layout" into main 2023-12-20 12:21:25 +00:00
Sergey Pinkevich 3030a6d74a Wrong app chip menu position for RTL layout
Bug: 315787393
Test: manual
Flag: icon_app_chip_menu
Change-Id: I26846262ada3704afb0da58748df3dae36da5655
2023-12-20 12:20:42 +00:00
Jeremy Sim ee596789de Fix crash with app pairs and grid migration
This CL makes it so that app pair contents are loaded properly during grid migration, like folder contents.

Fixes: 316052056
Test: Have app pairs on home screen, change home grid (e.g. 4x5 to 5x5), launcher does not crash
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I6a531d0d29d15ed7b8dfe7933690effe5344d941
2023-12-19 22:44:46 -08:00
Priyanka Advani 1a0c6844eb Merge "Revert "Re-promoting some tests to postsubmit"" into main 2023-12-20 01:32:13 +00:00
Priyanka Advani 4c222bfb3c Revert "Re-promoting some tests to postsubmit"
This reverts commit 82a67a1a2d.

Reason for revert:b/317133692

Change-Id: Ibd66d2a113611380876c274d1c6203a7ab777a53
2023-12-20 00:33:25 +00:00
Jagrut Desai 295027d0d1 Adding Support for Tapl Workspace Tests into PlatformScenario
Test: Presubmit, manual
Bug: 303258153
Flag: NONE
Change-Id: Ic7d2cd3dc24bbe4b252ef490c1e6d3cf0e3e217a
2023-12-19 15:37:07 -08:00
Federico Baron c42e7ffddd Merge "Update folder preview dark theme color" into main 2023-12-19 23:22:47 +00:00
Vadim Tryshev 52a4bc76e9 Merge "Wait for RecentsActivity to stop after dismissing all tasks" into main 2023-12-19 22:37:22 +00:00
Vadim Tryshev 57b240ca02 Merge "Re-promoting some tests to postsubmit" into main 2023-12-19 22:20:50 +00:00
Rajeev Kumar 84e5b5c6ba Merge "Use the system component for the nearby sharing action if available." into main 2023-12-19 22:15:40 +00:00
Uwais Ashraf dbf585db73 Merge "Rename Tapl tests that do not match *Test.(kt|java) for easier groups" into main 2023-12-19 22:14:25 +00:00
fbaron e69b6f49f7 Align QSB with hotseat and workspace icons
The QSB was a bit wider becuase icons visible size is a bit smaller than their actual size due to b/235886078 so we add a workaround to adjust QSB size based on the visible icon size

Bug: 281587788
Test: atest HomeScreenImageTest
Flag: NONE
Change-Id: I593ca2d588f08b830be0b2ac389c747b6f558b91
2023-12-19 13:52:45 -08:00
Vadim Tryshev 2152b04520 Wait for RecentsActivity to stop after dismissing all tasks
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I9afc27d4096417acaa1d4fb39de08b2a1ed8712a
2023-12-19 13:09:17 -08:00
Vadim Tryshev 82a67a1a2d Re-promoting some tests to postsubmit
Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: Idf3949b1f04b0ff761ef1216fa41e9e8d11e8cdd
2023-12-19 12:51:14 -08:00
Pat Manning 3e55896814 Merge "Do not process stashed taskbar hover actions when taskbar is not present." into main 2023-12-19 20:14:07 +00:00
fbaron 7bc30906c4 Update folder preview dark theme color
Fix: 314843350
Test: Verify on device
Flag: NONE
Change-Id: I2a4cb62dacb05193412b99aca0d3bfabfb77f959
2023-12-19 19:21:59 +00:00
Jagrut Desai 2d3e5d4e8f Merge "Correcting Logic of touch ouside of container." into main 2023-12-19 17:31:01 +00:00
Helen Cheuk c225b99be2 Merge "Add radius to widget internal focus to fit new focus outline design" into main 2023-12-19 16:59:50 +00:00
Tony Wickham 054d953a0d Merge "Log app launches via taskbar drag and drop" into main 2023-12-19 16:17:21 +00:00
Schneider Victor-tulias 4044669a90 Focus the first task in KQS when it is not currently running
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 316004088
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I8a91ca0dd32c6fc2352d285934a2c4f79ba1bb13
2023-12-19 10:48:40 -05:00
Uwais Ashraf e0a4feb664 Rename Tapl tests that do not match *Test.(kt|java) for easier groups
Test: presubmits passing
Bug: 316551909
Flag: NA
Change-Id: Ib2070d7610927777376acf0ddefcbc90e582e6f6
2023-12-19 11:54:10 +00:00
Himanshu Gupta ce2b013d31 Merge "Adding methods to access LauncherApps APIs." into main 2023-12-19 11:27:09 +00:00
helencheuk 1b3b67d004 Add radius to widget internal focus to fit new focus outline design
Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I9b11e8bf21dbb5045586907f0fc13577e236c8e7
2023-12-19 11:27:04 +00:00
Rajeev Kumar b3c7d2efc5 Use the system component for the nearby sharing action if available.
Bug: 308014458
Fixes: 308014458
Flag: NA
Test: atest com.android.launcher3.AppSharingTest
Change-Id: I41ff4efd7153e4ec7591b7d34695766e5bc9f436
2023-12-19 03:23:33 -08:00
Sergey Pinkevich 102e54ba05 Merge "Split tasks in RTL mode" into main 2023-12-19 10:19:02 +00:00
Jeremy Sim fb7f7c5a6f Merge "Use fade-in launcher for app pair launches from in-app taskbar" into main 2023-12-19 06:20:55 +00:00
Jeremy Sim c2b598434c Use fade-in launcher for app pair launches from in-app taskbar
This CL temporarily patches a crash in this situation:

Inside of an app > Launch an unrelated app pair from Taskbar > Crash

The crash occurs because TaskbarActivityContext can't create a launcher animation (because Launcher isn't running). A different launch animation is needed for this case (similar to single apps), but for now, falling back to the fade-in launch at least allows the user to proceed without a crash.

Bug: 316485863
Test: Enter an app, launch an unrelated app pair, no crash
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I72b2956b5b44616367e24263f2287824ee1e8212
2023-12-19 11:27:04 +09:00
Jeremy Sim 34aa1c5366 Merge "Fixes two bugs with findLastActiveTasksAndRunCallback()" into main 2023-12-19 02:08:54 +00:00
Jagrut Desai 6d34ffdeaa Correcting Logic of touch ouside of container.
Test: presubmit, manual
Bug: 311761184
Flag: NONE
Change-Id: Id014a16d67d06ebeed5e54358472890bb582ae89
2023-12-18 15:32:52 -08:00
Tony Wickham 1a8cf0a9f6 Log app launches via taskbar drag and drop
- This also goes through the app predictions pipeline to update
  hotseat predictions

Fixes: 316940471
Test: Drag apps to split screen, ensure taskbar predictions update
      (also verify by logging AppPredictor#notifyAppTargetEvent)
Flag: None
Change-Id: I844414ecb56b4e36a2c94d913c1fb37abf056593
2023-12-18 23:30:59 +00:00
Jagrut Desai 10473c5950 Merge "Refactoring testDragIcon() test" into main 2023-12-18 22:01:22 +00:00
Vadim Tryshev 014e9cb615 Merge "Adding a rule so that @Stability annotation works presubmit" into main 2023-12-18 19:56:00 +00:00
Himanshu Gupta 6c25654e84 Adding methods to access LauncherApps APIs.
These methods are added to ApiWrapper class
so that Launcher can acess these APIs.

Bug: 308054233
Test: Presubmit
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Change-Id: Ic2e64b38cc8b0d262d3f6e9614e2b3fceb9d82a0
2023-12-18 19:47:13 +00:00
Charlie Anderson 511421c12f Adds logging for Launcher restore metrics in Launcher and LoaderTask
- Adds flag for indicating when we are loading after a restore, separate from the pending restore flag
- Adds many success/failure scenario metrics when loading and binding items

Flag: ACONFIG enable_launcher_br_metrics DEVELOPMENT
Test: locally verified
Bug: 307527314
Change-Id: I9d2660f6d9d7cd5813072201e96b1a64aec4ea4b
2023-12-18 19:32:02 +00:00
Sergey Pinkevich e0ccb4e618 Split tasks in RTL mode
For `translationX` in RTL (right to left layout) mode we should take into account `secondarySnapshotWidth`, not the primary one.

The same for `translationY` for foldable phone in folded mode

Known issue: there is still a wrong position for overview app icon, but it is not related to the task thumbnail, and will be fixed in a dedicated task
(Screenshot of the issue: https://screenshot.googleplex.com/9GHNWxQ5H6vJPn5)
Known issue task: b/315787393

Bug: 309452423
Flag: NONE
Test: manual

Tablet: https://drive.google.com/file/d/1WGUVcFq0sFTJYsAwcjE6E1SHMRe7_TaV/view?usp=sharing
Foldable phone: https://drive.google.com/file/d/1GvDgYg8R9OEoMSDKZaZVXSlsxh_qS-wW/view?usp=sharing

Change-Id: Iefe7fec586592e6a72c0f3be5933307213d92c7f
2023-12-18 18:41:27 +00:00
Vadim Tryshev 4f6602839e Adding a rule so that @Stability annotation works presubmit
Bug: 316588649
Test: presubmit
Flag: N/A
Change-Id: Ic82db1c30c97f2653f8c30fc322a248b2b409695
2023-12-18 10:17:14 -08:00