Commit Graph

27704 Commits

Author SHA1 Message Date
Tracy Zhou 22395f0f02 Merge "Disable grid option feature in ThemePicker" into rvc-dev am: cb2473cf3f am: 15816e2cb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11972631

Change-Id: I498758afe041cc21e2640e85da954bd4e56f485b
2020-06-23 23:40:41 +00:00
Tracy Zhou 15816e2cb3 Merge "Disable grid option feature in ThemePicker" into rvc-dev am: cb2473cf3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11972631

Change-Id: I88bc60255cf86535789046145035ea42645105c1
2020-06-23 23:21:19 +00:00
Tracy Zhou cb2473cf3f Merge "Disable grid option feature in ThemePicker" into rvc-dev 2020-06-23 23:09:09 +00:00
Tracy Zhou 0c88238966 Disable grid option feature in ThemePicker
Fixes: 158790001
Test: manual
Change-Id: I5419738d9b3be996cdcea0a7b5dc2d31ceff0055
2020-06-23 23:07:53 +00:00
Tony Wickham b2676f22d9 Store newGestureState before onConsumerAboutToBeSwitched clears it am: b47a99e3cc am: fa5559ff64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11972618

Change-Id: I3a0fd6a4af4c210a1b91635f438b310a68e7a39d
2020-06-23 21:16:26 +00:00
Tony Wickham fa5559ff64 Store newGestureState before onConsumerAboutToBeSwitched clears it am: b47a99e3cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11972618

Change-Id: I8d0a8f74ee677e5063c6ff84288bc7bd8e7a517c
2020-06-23 21:02:51 +00:00
Tony Wickham b47a99e3cc Store newGestureState before onConsumerAboutToBeSwitched clears it
Bug: 159659393
Change-Id: If98d54b7ca397ef56a5c6d50c0fd92f25a9494b4
(cherry picked from commit efb7e60edc)
2020-06-23 16:45:51 +00:00
TreeHugger Robot 633f0ca00d Merge "Merging from ub-launcher3-rvc-dev @ build 6617269" into rvc-dev am: a271085506 am: 3309850150
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11959982

Change-Id: Ia45c84e7afe144515eee4dc66b6339e0d8e46f96
2020-06-23 07:58:40 +00:00
TreeHugger Robot 3309850150 Merge "Merging from ub-launcher3-rvc-dev @ build 6617269" into rvc-dev am: a271085506
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11959982

Change-Id: I1cb4a775fda0f70b0839398ac0f4b8e224c7880c
2020-06-23 07:47:36 +00:00
TreeHugger Robot a271085506 Merge "Merging from ub-launcher3-rvc-dev @ build 6617269" into rvc-dev 2020-06-23 07:29:27 +00:00
Hyunyoung Song 85d90a16bc Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https://android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_rvc-dev_6617269.html

Change-Id: I7a13230553f9c42d5f67164234c33cf77efa9cf2
Merged-In: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-23 05:11:31 +00:00
Rajeev Kumar 2f269fa9a9 Get rid of unused notification_badging_enabled configuration. am: e941d72380 am: 4a24d3635e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11959139

Change-Id: Id5aabe030df612275a7462da5df71233fc04ffbc
2020-06-22 23:10:37 +00:00
Rajeev Kumar 4a24d3635e Get rid of unused notification_badging_enabled configuration. am: e941d72380
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11959139

Change-Id: I47aa235aae179f63519ede9f741f0560913ca378
2020-06-22 22:52:47 +00:00
Thiru Ramasamy 51ece1847c Merge "Adds additional folder label states (UNLABELED & EMPTY_LABEL)" into ub-launcher3-rvc-dev 2020-06-22 21:04:12 +00:00
TreeHugger Robot ceaad08f06 Merge "Fixing rotation watcher not enabled in landscape" into ub-launcher3-rvc-dev 2020-06-22 21:00:07 +00:00
Vadim Tryshev 21cea8e55c Merge "Changing event check implementation from logcat to TestProtocol" into ub-launcher3-rvc-dev 2020-06-22 20:42:23 +00:00
thiruram ec75cbd85a Adds additional folder label states (UNLABELED & EMPTY_LABEL)
UNLABELED -> title==null and EMPTY_LABEL -> title=="". When adding new items for the folder if the folder is in UNLABELED state, auto-labeling will be enabled.
This change also addresses auto-labeling issue due to false edit from UNLABELED to EMPTY.

Bug: 159164315

Change-Id: Ia17cd27b4afb60420dc15c544f544061fc46ad33
2020-06-22 13:24:07 -07:00
Hyunyoung Song 5c9a1ef5cd Merge "Log Launcher transitions to WW" into ub-launcher3-rvc-dev 2020-06-22 20:21:10 +00:00
Rajeev Kumar e941d72380 Get rid of unused notification_badging_enabled configuration.
Bug: 159637333
Test: Manual tests by building system image and testing launcher app.
Change-Id: I0a7a3048ae6b4ffa52497748f45a6cf366fe0433
2020-06-22 20:16:49 +00:00
Sunny Goyal f67deb8e06 Fixing rotation watcher not enabled in landscape
Bug: 159636793
Change-Id: Ia7e5d90e9d441dfbe9877293957eff1ae7f69877
2020-06-22 13:02:53 -07:00
Hyunyoung Song 801f81fba5 Log Launcher transitions to WW
- ONRESUME / ONSTOP
- HOME_GESTURE
- OVERVIEW_GESTURE
- QUICKSWITCH
- SWIPELEFT/SWIPERIGHT

Bug: 156875719
Bug: 148822714
Bug: 137777105

Debug log: go/launcher-log-parity

Change-Id: I64a0deab4996b5be36320fbe0339f320891c53e0
2020-06-22 12:09:06 -07:00
TreeHugger Robot ce629ff837 Merge "Handling Launcher configuration change between touchDown and Launcher.onStart" into ub-launcher3-rvc-dev 2020-06-22 18:04:14 +00:00
vadimt a17a10cddd Changing event check implementation from logcat to TestProtocol
Bug: 153670015
Change-Id: Id9fc759bd5be68758ef9cf0abbba3cd6fa452796
2020-06-22 11:04:03 -07:00
Samuel Fufa 6dac493218 Merge "Send app launch events from TaskSwitcher" into ub-launcher3-rvc-dev 2020-06-22 17:36:12 +00:00
TreeHugger Robot 845f135d17 Merge "Add depth animation when multiwindow mode changes." into ub-launcher3-rvc-dev 2020-06-22 17:31:35 +00:00
Sunny Goyal 6fe83da57c Handling Launcher configuration change between touchDown and Launcher.onStart
If activity rotation is allowed, Launcher/recents can rotate while swipe animation
is running leading to inconsistencies between deviceProfile and rotation
> Using activity configuration to determine the rotation instead of using display rotation
> Removing rotation watcher when rotation is enabled as it is not used anymore

Bug: 158781568
Change-Id: I107d856cae80af111c0514656fac7ab1fa0c21cb
2020-06-22 10:04:35 -07:00
Tony Wickham 698dfc03cb Merge "Don't reset GestureState when touching outside of swipe region" into ub-launcher3-rvc-dev 2020-06-22 16:20:22 +00:00
TreeHugger Robot b22655f8e1 Merge "Revert "Allow shortcut predictions in hybrid hotseat"" into ub-launcher3-rvc-dev 2020-06-21 07:24:25 +00:00
Winson Chung c46daa9572 Merge "Tweak quickswitch thresholds" into ub-launcher3-rvc-dev 2020-06-21 04:08:09 +00:00
Winson Chung 4941f65d52 Tweak quickswitch thresholds
- Reduce slop for gestural mode (and apply multiplier to slop
  at checktime)
- When quickswitch threshold is passed, reduce the total movement
  check and reduce the velocity needed to fling to the next page
  to accommodate short swipes
- Use touch slop to determine scrolling in paged view, and only
  use paging slop to determine flinging to the next page (when
  easy flings are disabled (which is the default))

Bug: 157165240
Test: Ensure the flings in normal overview/paged views don't change,
      check short flings from quickswitching
Change-Id: Idd04ce23f53c06759e84ac8ad73cf2cc6dff6975
2020-06-20 19:41:32 -07:00
TreeHugger Robot 5ec76de182 Merge "Deleting old cache images before saving new ones." into ub-launcher3-rvc-dev 2020-06-20 20:19:01 +00:00
Tony Wickham 61fa23ab3a Don't reset GestureState when touching outside of swipe region
We were setting mGestureState = DEFAULT_STATE when touching outside
of the swipe region. Instead, we should only set mGestureState when
starting a new gesture, and only set it to DEFAULT_STATE on reset.

This also makes it clearer that mGestureState always refers to the
current gesture state, rather than sometimes being the current
gesture and sometimes being the previous gesture depending on
where it was used. Now previousGestureState is passed when needed.

Bug: 159494933
Change-Id: Ib62278b7c591ca4c6b99b26e058a34772e6cec2a
2020-06-20 12:04:12 -05:00
Samuel Fufa 857c512987 Revert "Allow shortcut predictions in hybrid hotseat"
This reverts commit 2d8e882d2e.

Reason for revert: Moving this to master. 

Change-Id: I46cfbda92d74a1f9fa9f0c091811941fe74ce76b
2020-06-20 16:53:51 +00:00
Jayaprakash Sundararaj d2260a07b8 Merge "Refactor FolderNameInfos." into ub-launcher3-rvc-dev 2020-06-20 06:59:45 +00:00
Hyunyoung Song ac3f71269e Merge "Remove ConcurrentModificationException for snapshot logging Bug: 159282737" into ub-launcher3-rvc-dev 2020-06-20 06:27:01 +00:00
TreeHugger Robot d4b946dbe3 Merge "Workaround for activity manager crashing when trying to start an app It flakes when one of the tests starts calculator while there zero activities in the system." into ub-launcher3-rvc-dev 2020-06-20 06:13:48 +00:00
Jayaprakash Sundararaj 1d96ba03ab Refactor FolderNameInfos.
Bug: 159508969

Change-Id: I984e7a4fc321392d06157c705392c1ba5672f348
2020-06-19 23:12:22 -07:00
Samuel Fufa 9024c85742 Merge "Allow shortcut predictions in hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-20 04:57:02 +00:00
TreeHugger Robot 08e1cde5e1 Merge "Add Elevation to work switch" into ub-launcher3-rvc-dev 2020-06-20 04:12:57 +00:00
Samuel Fufa 2d8e882d2e Allow shortcut predictions in hybrid hotseat
Screenshot: https://screenshot.googleplex.com/TckWKGYWwHW

Note: Shortcut predictions will not be cached.

Bug: 159500320
Test: Manual
Change-Id: Id8ec81544bddb8be87a5e748fd9f9e93aaaf8fea
2020-06-19 18:50:22 -07:00
vadimt 8914c51660 Workaround for activity manager crashing when trying to start an app
It flakes when one of the tests starts calculator while there zero
activities in the system.

Bug: 143488140
Change-Id: Id9d350f0de8a83eb50e35e9efa4226b8d45ca641
2020-06-20 01:12:50 +00:00
thiruram 8bcb48cc1b Log LAUNCHER_FOLDER_AUTO_LABELING_SKIPPED events.
These events will help to understanding recall reduction is due to data coverage vs label coverage.

Bug: 159495871
Change-Id: Ia5e2cbab86f5f2072f9674fbd6abcdbc049929ee
2020-06-19 17:58:55 -07:00
Sreyas ae74a618bd Deleting old cache images before saving new ones.
Change-Id: I5947fe43b0e1bfac35247bf64f08e49560d58cac
2020-06-19 17:28:19 -07:00
thiruram b53764bd4b Fixes folder logging.
Only LAUNCHER_FOLDER_LABEL_UPDATED events will have FromState, ToState
and FolderLabelInfo. Other folder events such as OPEN, DRAG etc will have
basic fields only populated.

Sample Log: https://paste.googleplex.com/5468394805526528
Screencast: http://rcll/hSUQjtQXfQM5i9DjjAQTf2/Zn5FeiVDONaQj0mK1JNjg

Bug: 159164315
Change-Id: I903fc7b62bcee748aa3ef695453be3e14d388712
2020-06-19 17:06:46 -07:00
Jon Miranda 36d1015997 Add depth animation when multiwindow mode changes.
This is a workaround until we can support app transitions when starting
an activity in mw mode.

Bug: 158613217
Change-Id: I843d6669722c543728ab532e1c4fbd4643f6f135
2020-06-19 16:36:57 -07:00
TreeHugger Robot 72ac78189f Merge "Fix RecentsView scroll linking" into ub-launcher3-rvc-dev 2020-06-19 23:28:55 +00:00
TreeHugger Robot f9ae1a838a Merge "Fixing fallback recents not getting proper insets on configuration change" into ub-launcher3-rvc-dev 2020-06-19 23:22:54 +00:00
Hyunyoung Song 5eae3c0a0a Remove ConcurrentModificationException for snapshot logging
Bug: 159282737

Change-Id: I37edcf6aa11272b488a0633716567c48e56e5433
2020-06-19 16:12:43 -07:00
Tony Wickham 94d1b4be17 Fix RecentsView scroll linking
- Reverts change from ag/11900651 that deferred setting
  mRecentsViewScrollLinked = true
- Instead, setCurrentPage(mCurrentPage) after updating layout rotation
  to ensure we recompute page scrolls before using them

Test:
- Auto rotate on, home rotation off, open Calculator in landscape,
  swipe up slowly and ensure it never turns invisible
- Quick switch from Calculator to Clock, start swiping directly up
  immediately after settling on Clock, ensure Calculator window
  remains at its scroll position to the side (b/159461591)

Fixes: 159461591
Change-Id: Iab92963cc6c33df42b77f5ccfa3932382e8f869a
2020-06-19 17:42:18 -05:00
Hyunyoung Song bb8257344c Merge "Fix a potential concurrency issue for loading CDB file Bug: 158919530" into ub-launcher3-rvc-dev 2020-06-19 21:48:30 +00:00