Commit Graph

23162 Commits

Author SHA1 Message Date
Vinit Nayak 2060a4b9e1 Prevent showing TaskMenuView if icon isn't present
Also fixed another bug where the wrong layout
orientation was being applied when overview rotated
when launcher was in fixed portrait orientation.

Fixes: 160182914
Test: Tested w/ PIP, split screen,
w/o split screen w/ and w/o home rotation

Change-Id: Iccffb637ae5c22d07745f2108facd4de716dc8d3
2020-07-10 11:55:06 -07:00
TreeHugger Robot c3c15cc946 Merge "Updating some comments and variables" into ub-launcher3-rvc-qpr-dev 2020-07-10 00:50:36 +00:00
TreeHugger Robot 95c620c38d Merge "Let AllAppsEduView consume touch until animation is done and view is removed." into ub-launcher3-rvc-qpr-dev 2020-07-09 21:45:18 +00:00
TreeHugger Robot 24ddf21cea Merge "Updating gesture tutorial home animation" into ub-launcher3-rvc-qpr-dev 2020-07-09 21:44:51 +00:00
Jon Miranda 58d74c3dd9 Let AllAppsEduView consume touch until animation is done and view is removed.
Bug: 160760115
Bug: 160761752
Change-Id: Ie7ab0b4c6e61dc862cac10fa961b8d1c11c6cb10
2020-07-09 14:11:53 -07:00
Sunny Goyal 29266c9ebe Updating some comments and variables
Change-Id: Ib3223c66e9ce187cebc6ce26a46b228f95787778
2020-07-09 12:31:49 -07:00
TreeHugger Robot 6381d38249 Merge "Adding nullcheck while launching task during quickswitch" into ub-launcher3-rvc-qpr-dev 2020-07-09 18:19:54 +00:00
Sunny Goyal 798b5f481d Adding nullcheck while launching task during quickswitch
Bug: 159758771
Change-Id: I04dd1432a1acc49cbc776c89e95cfb1ee6e88061
2020-07-09 11:05:28 -07:00
TreeHugger Robot fa990331d2 Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-qpr-dev 2020-07-09 16:56:58 +00:00
Bill Yi e821103486 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2c9294537172c3e5482f21f0728d559857d44dc7
2020-07-09 09:32:09 -07:00
Bill Yi 6d76207e37 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I3d133ff2ba4e7c0cf1de39cacfdcbe13a9c2a366
2020-07-09 09:31:47 -07:00
Sunny Goyal 6fd105b69a Updating gesture tutorial home animation
> Using a separate View as icon, instead of the taskView
> Updating swipe animation logic to abstract out FloatingIconView dependency

Change-Id: Ib466262afead11ebe4ca035d589f0382c37e3e97
2020-07-09 07:51:34 -07:00
TreeHugger Robot b82121c006 Merge "Fix bug where non-center page is visibile in HINT_STATE." into ub-launcher3-rvc-qpr-dev 2020-07-09 00:52:54 +00:00
Jon Miranda b59776cd01 Fix all apps edu in landscape.
* Fix bug where All Apps not visible during hint animation.
* Fix bug where All Apps is empty after hint animation.

Bug: 160122854
Change-Id: Id4106a6200df2845b3c041d5aae14fb83c94b4d4
(cherry picked from commit 84b848ad5d)
2020-07-09 00:02:54 +00:00
Jon Miranda 64aefedf7e Fix bug where non-center page is visibile in HINT_STATE.
Bug: 160122854
Change-Id: I3d970e49aa891f5c9ccda60a6d6f4f73dd0a9f03
(cherry picked from commit e38322294b)
2020-07-09 00:02:43 +00:00
Sunny Goyal faea66fe88 Ensuring workspace pages are offset properly in waterfall cutout
Bug: 149224750
Change-Id: I523b09aa4cbe7710e3fd89bc716bacbafd4eadc8
2020-07-08 18:39:42 +00:00
Greg Kaiser 1bab050df2 Go Launcher: Fix icon placement retention
We need dbFile set when MULTI_DB_GRID_MIRATION_ALGO is in
use.  This was set for other launchers, but not the Go launcher.

Bug: 157557047
Test: Built, flashed, moved icons on home screen, rebooted, and confirmed icons retained their position.
Change-Id: Icfcb56e00a8ac2f74e5f7a1957fd46cee5cb8b5b
(cherry picked from commit 8f490e21c9)
2020-07-07 16:32:54 +00:00
TreeHugger Robot 24ce95124e Merge "Fixes NPE with system shortcuts." into ub-launcher3-rvc-dev 2020-06-29 19:40:32 +00:00
TreeHugger Robot fe4d64f4e3 Merge "Disable auto correct/suggest on folder edit text Bug: 160075575" into ub-launcher3-rvc-dev 2020-06-29 19:37:23 +00:00
thiruram 53925ff9c6 Fixes NPE with system shortcuts.
Bug: 160109140
Change-Id: I35c00fc1792fcf11fc61e1876f9184bd5fb309ce
2020-06-29 12:04:32 -07:00
Hyunyoung Song 37bda2bcc9 Disable auto correct/suggest on folder edit text
Bug: 160075575

TL;DR;; displayCompletions still work

Change-Id: I0a7cd06d25ae3976371be0707a2783702b92e8cc
2020-06-29 00:26:14 -07:00
Zak Cohen a3629bd52c Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-28 21:10:07 -07:00
Adam Cohen f6edf98902 Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into ub-launcher3-rvc-dev 2020-06-26 17:10:38 +00:00
TreeHugger Robot f59922d0d7 Merge "Add NPE check for prediction controller" into ub-launcher3-rvc-dev 2020-06-26 07:42:38 +00:00
Adam Cohen 6e7c37a205 During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate
=> regressed in ag/10634216 which attemped to use onHoverListener
=> the problem is that onHoverListener is only triggered when the event is passed to the CellLayout, however, as with all dispatching, these events are handled depth first, and so in cases where a child handled the event, it would never bubble back up to the parent.
=> instead we have to continue to override dispatchHover event to always give presecedence to the delegate when it exists

b/155956518

Change-Id: Ic3ecf1b422c1821456328035a66a2fc1277e6746
2020-06-26 02:34:36 +00:00
thiruram 6ab4da8aa0 Fixes missing folder label after launcher restarts.
Rootcause: FolderInfo was persisted into DB only when folder options are updated. Hence when folder was created (Folder option remains suggested) its title was not persisted into DB.

Fix: Persists folderInfo into DB always whenever title is updated

Bug: 159904890
Change-Id: If0d20b0d7fa6966dd7bb40a2c07bcb22bd0893e0
2020-06-25 23:48:17 +00:00
Tracy Zhou f957ff9123 Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:04:25 +00:00
Samuel Fufa 514df92bcf Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 13:08:55 -07:00
Tony Wickham 9d69370095 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into ub-launcher3-rvc-dev 2020-06-25 02:10:54 +00:00
Andy Wickham fce6be550b Merge "Updates Assistant gesture regions when no longer tracking multiple." into ub-launcher3-rvc-dev 2020-06-24 22:29:45 +00:00
Andy Wickham 4b531b972d Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
2020-06-24 21:23:35 +00:00
Tony Wickham c6a56ef7a2 Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
2020-06-24 11:59:10 -07:00
TreeHugger Robot a0b0d66e20 Merge "Use isolated display context to get display info" into ub-launcher3-rvc-dev 2020-06-24 05:25:33 +00:00
Sreyas 2bbce930cb Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:10:29 +00:00
Riddle Hsu 8995590e44 Use isolated display context to get display info
While display is in landscape, and the launcher is transformed to
portrait, the display rotation from activity or application context
will get the rotation in portrait.

In order to transform the input event when the orientations are
different, the actual device rotation is still needed. By creating
the display context from application context, the resources of
the new context won't be affected by the activity/application level
display info adjustments. That provides the actual device states.

Additionally, DefaultDisplay#INSTANCE should only be used for the
operations related to physical orientation/size because it won't
contain the override information from activity.

Bug: 157456493
Test: Use a device which may switch refresh rate.
      Open Maps and put device in landscape.
      Use gesture navigation to swipe up.
      The direction of movement should be consistent with UI.
Change-Id: I03108b1ab057e28727b6a6db3629d2c1c069e828
2020-06-24 04:00:13 +00:00
TreeHugger Robot 9f3ae7b573 Merge "Remove hotseat edu flag" into ub-launcher3-rvc-dev 2020-06-24 03:23:54 +00:00
TreeHugger Robot f95cf17a13 Merge "Fixing TaskMenu positioning." into ub-launcher3-rvc-dev 2020-06-24 00:03:27 +00:00
Sreyas 7776d30609 Fixing TaskMenu positioning.
Bug: 159728554
Change-Id: I4a666363f092b5416edecd0731a0f448916c8def
2020-06-23 16:17:11 -07:00
TreeHugger Robot 359a28e934 Merge "Prevent premature resetting of quickswitch mode" into ub-launcher3-rvc-dev 2020-06-23 22:42:48 +00:00
TreeHugger Robot d0fcfe2bb7 Merge "Fix hotseat button alignment" into ub-launcher3-rvc-dev 2020-06-23 22:08:42 +00:00
Vinit Nayak f2daafcdf8 Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
2020-06-23 15:07:22 -07:00
vadimt efa3acddba Making LauncherProvider think that clear-db request comes from Launcher
If it comes from the test process, the request won't be honored.

Bug: 159728364
Change-Id: I90029c1198634f1f1e94f61ba8ab9b41609d9ad5
2020-06-23 13:59:11 -07:00
Samuel Fufa 3c2a17b6f6 Remove hotseat edu flag
Launcher should not restrict user migration to a one time event if we want users to migrate their hotseat by enabling hotseat prediction from suggestion settings.

Test: Manual
Bug: 159731272
Change-Id: I0e42dd6b6cf6374928e5b399d121d17fe8024ae1
2020-06-23 12:53:37 -07:00
Samuel Fufa a44c09d6c9 Fix hotseat button alignment
Screenshot: https://screenshot.googleplex.com/Vr9FXe3oN2t
Bug: 159731214
Change-Id: I9e413f5d9bf0144edd413cc5995e7f1fda152f28
2020-06-23 12:46:30 -07:00
Tracy Zhou b1e003c1fb Merge "Support having dup items in folder for migration" into ub-launcher3-rvc-dev 2020-06-23 16:12:25 +00:00
Tracy Zhou 76773cd210 Support having dup items in folder for migration
Fixes: 159312066
Test: Have two dup items in a folder under one grid setting. Migrate. Make sure the folder is migrated correctly to the new grid setting.
Change-Id: Ic5aeb30a1c8acb382bccf744d7553913d8a8a320
2020-06-23 00:29:23 -07:00
TreeHugger Robot 7cb6d738c0 Merge "Eliminating messages that launcher activity is frozen" into ub-launcher3-rvc-dev 2020-06-23 06:09:26 +00:00
TreeHugger Robot ea3edf1247 Merge "Log query_length & parent_container for actions on search results." into ub-launcher3-rvc-dev 2020-06-23 02:16:44 +00:00
TreeHugger Robot 7551b6191f Merge "Store newGestureState before onConsumerAboutToBeSwitched clears it" into ub-launcher3-rvc-dev 2020-06-23 01:33:55 +00:00
thiruram dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00