Commit Graph

22518 Commits

Author SHA1 Message Date
TreeHugger Robot 1c6c8d32ae Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-05-06 07:12:14 +00:00
Bill Yi f05f1c68fd Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2c5cb936e7f4c04e7ad05a7ce758ab9b6afefbfe
2020-05-05 22:51:51 -07:00
Bill Yi 77fe1a7c90 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2a006876dfa9ef67f47ff5e29aa9e2bcd4ef328d
2020-05-05 22:50:24 -07:00
Hyunyoung Song e013da6dae Merge "OWNERS file for AllAppsSearchPlugin for version increment" into ub-launcher3-rvc-dev 2020-05-06 05:47:22 +00:00
Hyunyoung Song 3d57cd68db OWNERS file for AllAppsSearchPlugin for version increment
Change-Id: I1aedc9fac5802b3a6344c9ecd758caf8099e5902
2020-05-05 20:56:54 -07:00
Zak Cohen 51e144ff8f Flag - rename SELECT_MODE to OVERVIEW_SELECTIONS
Better reflects what it is for.

Bug: 155806266
Test: toggled locally
Change-Id: Ied3ba04bce5363696e03741e494a1e1507ce38ce
2020-05-05 14:27:12 -07:00
thiruram 59c5f399a6 Duplicating InstanceId and InstanceIdSequence classes from framework internal package to launcher3.
com.android.internal.logging package is not directly accessible from launcher codebase hence making a duplicate classes until they are moved to common package.

Change-Id: I7c8a9bd89a322fc330b58460e6468ccff933ea44
2020-05-05 21:06:58 +00:00
Thiru Ramasamy 36fb598189 Merge "Implements LAUNCHER_ITEM_DROP_COMPLETED event." into ub-launcher3-rvc-dev 2020-05-05 21:06:04 +00:00
Zak Cohen 224ef0efe7 Merge "OverviewActions - make button ripple workspace text color." into ub-launcher3-rvc-dev 2020-05-05 19:11:21 +00:00
Tony Wickham c0535b23f6 Merge "Fix continueComputingRecentsScrollIfNecessary() running infinitely" into ub-launcher3-rvc-dev 2020-05-05 17:14:03 +00:00
Sunny Goyal cf19a92cde Merge "Not caching TaskView during quickswitch" into ub-launcher3-rvc-dev 2020-05-05 17:05:20 +00:00
Tony Wickham 49b57e955c Fix continueComputingRecentsScrollIfNecessary() running infinitely
When continuing a gesture during quick switch, we cancel the
previous animation but don't invalidate it (since the gesture
isn't fully finished), and the new gesture handler calls
mRecentsView.setOnPageTransitionEndCallback(), so the previous
handler will never get STATE_RECENTS_SCROLLING_FINISHED. Thus,
continueComputingRecentsScrollIfNecessary() will never end.

To fix this, also check !mCanceled, since that is set when
continuing the gesture. Also use postOnAnimation() instead of
post() since that has better guarantees that the next
computation will wait for the next animation frame, rather
than whenever the message queue is available, which might
happen too frequently.

Test: quick switch from A to B and back to A before settling
on B, ensure we stop calling computeScroll().

Bug: 153589287
Change-Id: I6b4389ef2cf5a818438c7ae36d8807b3e41c8501
2020-05-05 02:32:39 -05:00
Winson Chung 7ad937c78d Merge "Account for various launcher states when setting back button alpha" into ub-launcher3-rvc-dev 2020-05-05 04:37:38 +00:00
TreeHugger Robot 43e789ff9b Merge "Fixing max-zoom-scale not taking into account the the fullScreen scale" into ub-launcher3-rvc-dev 2020-05-05 02:01:00 +00:00
Sunny Goyal a88ca7643a Not caching TaskView during quickswitch
RecentsList update case cause the TaskView to get unparented

Bug: 155568411
Change-Id: Ia05de9658ba2154f73311679a359a2eefeb73aec
2020-05-04 18:30:02 -07:00
Sunny Goyal 29e7a58f1a Fixing max-zoom-scale not taking into account the the fullScreen scale
Also fixing the issue where display info is is not correctly initialized

Bug: 155257023
Bug: 155682580
Change-Id: Ib2cc981c1900f3d14f158f4dbb60ae77311f339b
2020-05-04 18:11:15 -07:00
thiruram 740e2ab12e Implements LAUNCHER_ITEM_DROP_COMPLETED event.
Assigns InstanceId to match LAUNCHER_ITEM_DROP_COMPLETED, LAUNCHER_ITEM_DRAG_STARTED events.

Sample Log:
2020-05-01 14:07:53.158 18369-18369/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED(InstanceId:282)
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@c0711fbd
    application {
      component_name: "com.google.android.apps.maps/com.google.android.maps.MapsActivity"
      package_name: "com.google.android.apps.maps"
    }
    container_info {
      workspace {
        grid_x: 2
        grid_y: 1
        page_index: 0
      }
    }
    is_work: false
2020-05-01 14:07:54.308 18369-18369/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DROP_COMPLETED(InstanceId:282)
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@90000206
    application {
      component_name: "com.google.android.apps.maps/com.google.android.maps.MapsActivity"
      package_name: "com.google.android.apps.maps"
    }
    container_info {
      workspace {
        grid_x: 0
        grid_y: 4
        page_index: 0
      }
    }
    is_work: false

Bug: 152978018

Change-Id: Ib4fc860e8080edd407ed15b93f7d55ac31328d11
2020-05-04 18:00:07 -07:00
Becky Qiu 8f3b7e3249 [Overview Actions] Expose task corner radius to use in TaskOverlay.
Test: local
Bug: 153478940

Change-Id: I03d410edb5a55ce5eda5c703752daf0ef5d04500
2020-05-04 17:31:40 -07:00
Zak Cohen b4ee058955 OverviewActions - make button ripple workspace text color.
Uses a theme to set the control highlight color.

Test: local on dark and light wallpaper
Change-Id: Iddb668fcbd3ab760faabd9c296274315d63e044f
2020-05-04 17:17:52 -07:00
TreeHugger Robot fc9ea9b0fc Merge "Speeding up TAPL by calling getVisibleStateMessage() less frequently" into ub-launcher3-rvc-dev 2020-05-04 23:18:04 +00:00
TreeHugger Robot f9ec6f670c Merge "Decouple feature flag and predictions" into ub-launcher3-rvc-dev 2020-05-04 23:12:37 +00:00
TreeHugger Robot 7bb915ba8e Merge "Remove unnecessary waitForIdle calls" into ub-launcher3-rvc-dev 2020-05-04 22:44:21 +00:00
vadimt faf4da386d Speeding up TAPL by calling getVisibleStateMessage() less frequently
The information in the message can be derived from the object dump
printed anyways.

Change-Id: I22ee136568b767c3218eaabc3920c77b3ceaa78f
2020-05-04 15:40:47 -07:00
Samuel Fufa 49d0f64a9d Decouple feature flag and predictions
- Always default to true for ENABLE_HYBRID_HOTSEAT
- Allow launcher to show predictions anytime regardless of notification and on-boarding.
- Remove past beta specific plans
- Migrate if first screen can accommodate hotseat items otherwise show tip

Bug: 142753423
Test: Manual
Change-Id: I142cd95d779964822da07a96e5884a0c82813742
2020-05-04 15:20:39 -07:00
TreeHugger Robot 0dbbd8951d Merge "Use rotation based on PagedOrientationHandler instead of touch" into ub-launcher3-rvc-dev 2020-05-04 20:21:50 +00:00
TreeHugger Robot d60e33de3e Merge "Avoiding cascading "nested events checking" failure after timed-out wait" into ub-launcher3-rvc-dev 2020-05-04 19:41:56 +00:00
Vinit Nayak bb55f9e982 Use rotation based on PagedOrientationHandler instead of touch
Fixes: 154928106
Test: Tested overview w/ and w/o
home rotation enabled.

Change-Id: Ib7e91e51b2181824e5520ad69965ed3379302c27
2020-05-04 11:58:11 -07:00
vadimt 357e5499a2 Remove unnecessary waitForIdle calls
They were added back in times when the
code was very different, and we don't need them now.

Change-Id: Ie96b081a4f2319c7b58d22ffc410f74e9ab56d94
2020-05-04 18:57:52 +00:00
vadimt 55495201e0 Avoiding cascading "nested events checking" failure after timed-out wait
Bug: 155656943
Change-Id: I0f11552349a9f6b3b14bd1bebb37904d5dfa9c55
2020-05-04 10:52:08 -07:00
Vinit Nayak d079aed058 Revert drag factor calculation to pre-vertical overview
Fixes: 149609070
Test: Swiped up in landscape past
where thumbnail would be. Scaled accordingly.

Change-Id: Ib8e64af2d7a9e4ce517d5f56300d50b659217b71
2020-05-03 22:38:20 -07:00
Alex Mang 5c6b320057 Listening to progress of all apps transition.
This will be used to synchronize keyboard popup. Also setting edittext before disabling to allow plugin to perform some cleanup

Change-Id: Ib9b4ab33d4292fe5d827c37f33c546a9fe6cb002
2020-05-01 16:47:22 -07:00
TreeHugger Robot e6843777b0 Merge "[AllAppsSearch] Update AllAppsSearch interface to expose the activity to the plugin" into ub-launcher3-rvc-dev 2020-05-01 23:08:00 +00:00
TreeHugger Robot 122d2d9dbb Merge "Don't do full anomaly check after every gesture" into ub-launcher3-rvc-dev 2020-05-01 21:17:53 +00:00
TreeHugger Robot 4544af1996 Merge "[Overview Actions] Disable touching on the empty area when recent is modal." into ub-launcher3-rvc-dev 2020-05-01 20:43:03 +00:00
TreeHugger Robot c6d8838c33 Merge "Sets icon invisible when alpha 0 (Cannot be tapped while TaskView modal)" into ub-launcher3-rvc-dev 2020-05-01 20:27:40 +00:00
Becky Qiu 2d9f8284ca [Overview Actions] Disable touching on the empty area when recent is modal.
Originally touching on the empty space would bring user back to homescreen. We will disable this for select mode.

Test: local
Bug: 154531538
Change-Id: Iee3780755fc2c32682ea0fa039ca5822a95fce2c
2020-05-01 12:51:07 -07:00
Hyunyoung Song e180641d38 Merge "Force all apps content to be alpha 0 when plugin is in place Bug: 155114822" into ub-launcher3-rvc-dev 2020-05-01 17:55:56 +00:00
TreeHugger Robot 7a87f953a8 Merge changes from topic "widget-logging" into ub-launcher3-rvc-dev
* changes:
  Fixes missing components info when logging Widget item.
  Implement LAUNCHER_ITEM_DRAG_STARTED event.
2020-05-01 07:54:03 +00:00
TreeHugger Robot e041a062a1 Merge "Fixing RecentsView translation is not reset on app-launch animation" into ub-launcher3-rvc-dev 2020-05-01 07:19:32 +00:00
Winson Chung 2a00f81327 Account for various launcher states when setting back button alpha
- Previously we only check for the flag which is always true in the
  normal launcher state, so if the animation starts, we could end up
  writing the back alpha value without accounting for window focus or
  any other states that launcher is in that affects back button
  visibility

Bug: 155129739
Test: Open -1 article and hit back
Change-Id: I42d27a192b23f394f8565a6893ce092603e31654
2020-04-30 23:03:52 -07:00
Jon Miranda b133a52e86 Fix app open/close animation in landscape.
When we refactored ClipIconView, we never init mIsVerticalBarLayout.
Instead we pass it in along with the rest of the info from FloatingIconView.

Bug: 155039118
Change-Id: Iff93105c512a8e6478dc49d8ab9100fd129af48c
2020-04-30 22:50:59 -07:00
Tony Wickham eb885026ed Fix spring overscroll when there's a min scroll
Test: clear app recent apps, open Calculator, open Clock,
quick switch to Calculator and see no jump

Bug: 154815348
Change-Id: I6289d43efe5d850cb2fd807d15115c5ce38c16dd
2020-04-30 23:27:39 -05:00
vadimt 9fd3a943ba Don't do full anomaly check after every gesture
This call is relatively expensive. Perform only cheap launcher crash
test, and do anomaly only if there are problems.

Change-Id: If45567bcedf8d177970739e9de95cbb29add744c
2020-04-30 19:31:21 -07:00
Sunny Goyal 9ae484a6ba Fixing RecentsView translation is not reset on app-launch animation
Bug: 155166631
Change-Id: I25b9783fb1ae0d1e3d477a9d9f5aedf60c3c575d
2020-04-30 17:05:23 -07:00
Winson Chung bd49cea1ca Merge "Bound the thumbnail insets to the launcher insets" into ub-launcher3-rvc-dev 2020-04-30 22:48:44 +00:00
Winson Chung 7f534cf2a8 Merge "Fix issue with quickswitch not updating system bar flags" into ub-launcher3-rvc-dev 2020-04-30 22:48:43 +00:00
TreeHugger Robot 403640c393 Merge "Removing old unused code from PageView" into ub-launcher3-rvc-dev 2020-04-30 22:13:51 +00:00
thiruram 0707f2c702 Fixes missing components info when logging Widget item.
Sample Log:

LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@5c06a6d1
    container_info {
      workspace {
        grid_x: 3
        grid_y: 3
        page_index: 3
      }
    }
    is_work: false
    widget {
      component_name: "com.google.android.deskclock/com.android.alarmclock.DigitalAppWidgetProvider"
      package_name: "com.google.android.deskclock"
      span_x: 2
      span_y: 1
    }

Change-Id: I3d468c77632c694454fcdca24f9d2ccd1c4f918c
2020-04-30 15:03:43 -07:00
thiruram f81e8b002a Implement LAUNCHER_ITEM_DRAG_STARTED event.
* Fixes null component issue when ItemInfo object copiedFrom.
* Fixes missing container when item is dragged from hybrid hotseat.

Sample Logs:
2020-04-30 14:09:45.499 30472-30472/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@260f31f8
    application {
      component_name: "com.android.chrome/com.google.android.apps.chrome.Main"
      package_name: "com.android.chrome"
    }
    container_info {
      workspace {
        grid_x: 2
        grid_y: 2
        page_index: 2
      }
    }
    is_work: false

2020-04-30 14:23:15.230 31320-31320/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@608f101
    application {
      component_name: "com.google.android.gm/.ConversationListActivityGmail"
      package_name: "com.google.android.gm"
    }
    container_info {
      hotseat {
        index: 1
      }
    }
    is_work: false

Bug: 152978018

Change-Id: I3d3ce213fd2fc6eb5ffb239e048ceb7c0fa88b53
2020-04-30 15:03:43 -07:00
Winson Chung a7ac7192c3 Fix issue with quickswitch not updating system bar flags
- Separate the calls to minimize split and to update the flags (we only
  want to minimize in split when swiping up, but we want to update the
  flags when quickswitching as well)

Bug: 155410195
Change-Id: I56308cc0fbaa8a855383012738f129671d72feff
2020-04-30 13:58:22 -07:00