- Don't set current page to running task when applying load plan,
if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
already on it. This was setting mNextPage so the first check
was falsing.
Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
Merged-In: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).
Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen
Before, this caused a flicker, now the last scroll is ignored.
TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling
Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
(cherry picked from commit 2784315f7d)
We change the way we parse the install queue; so this seems to be a rare case
when trying to flush an install queue from an old apk with a launcher apk
with the new parsing changes.
Bug: 140935140
Change-Id: I14db4c3f70ed2e1bc5ad31dec7e6473cd6f8f13c
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.
Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
Merged-In: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
(cherry picked from commit 60bf8c117b)
Test: Manual
Bug:135864059 P4 [Live Tiles] Empty launcher
Bug:139137636 P2 Create memory tests for Launcher
Bug:139281702 P2 [Enterprise - Cloud DO] GSOC and Mobile Utilities launcher icons are in broken state
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Bug:141024521 P2 Tapping nav bar during quick switch causes scroll animation to cancel and not resume
Bug:141184247 P1 Clear all button not present in fallback recents in 3-button mode
Change-Id: I99f4db995a2af5959d5be4182f4e47bb67c9cbc4
The logic to keep mIsBeingDragged when touching down during a scroll
animation was in onInterceptTouchEvent(), which we were bypassing by
using onTouchEvent() directly. Now we update mIsBeingDragged on touch
down in both onInterceptTouchEvent() and in onTouchEvent().
Bug: 141024521
Change-Id: I77abd4c36f3ccee27e160c817dadb3923e6cfc06
Broken by change I03c31bb308fc496b9fc633c2fde23ae4568f8c44.
Bug: 139281702
Test: Ran BindWidgetTest with 8/8 successful.
Change-Id: I6a03744c9cd919316ff27b12c50acc70c91d47fa
We weren't calling onSwipeUpToRecentsComplete(), which meant we kept the
disallowScrollToClearAll from prepareRecentsUi indefinitely.
Also don't update the icon scale if it is supposed to be scaled down, to
avoid it from scaling up and overlapping with the app window.
Fixes: 141184247
Change-Id: I49406764373e7121e289da7477dcbb58d0b98fd5
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.
Test: manual
Fixes: 135864059
Fixes: 140337263
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.
Test: manual
Fixes: 135864059
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
Test: Manual
Bug:121280703 P2 Finish implementation of PortraitLandscape annotation for tests
Bug:135633159 P3 [QPR] Promise icons on home screen
Bug:135638690 P1 [QPR] On-device app search
Bug:137106918 P2 UX: Accidental NGA triggering when hitting Undo actions in apps
Bug:137200188 P3 Home screen app title disappears during animation
Bug:138195597 P2 Wrong icon animated on return to home screen
Bug:138396187 P1 Swipe and hold from an app no longer uses spring to animate adjacent task
Bug:138729157 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : want to fling backwards in widgets, flung back, but the current state is not WIDGETS; Unexpected launcher object visible: workspace
Bug:138729456 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : Can't find an object with selector: BySelector [CLASS='\Qandroid.widget.TextView\E', PKG='\Qcom.google.android.apps.nexuslauncher\E', TEXT='\QShortcut 3\E'] (visible state: Workspace)
Bug:138964490 P1 Support DeviceConfig to drive ToggleableFlags
Bug:139021165 P2 [TEST TRACKER] [QPR] Promise icons on home screen
Bug:139137636 P2 Create memory tests for Launcher
Bug:139551306 P4 [Polish] Reduce shelf paddings in Overview
Bug:139885365 P3 App open animation different between launcher suggested apps and launcher home screen/drawer
Bug:139918680 P2 [a11y] Talkback shouldn't keep focusing on the background item and speak the description of the background item again after entering Widget list.
Bug:140076379 P1 Launcher ub-launcher3-qt-qpr1-dev Branch Build Keeps Crashing due to Exception
Bug:140252951 P2 Add widget launch test.
Bug:140308849 P2 Jank during swipe up to home, especially noticeable after pausing first
Bug:140311911 P2 Flake in Launcher tests: java.lang.AssertionError: Stable state != state: OverviewState, LauncherState
Bug:140405990 P2 [a11y] Unable to add shortcut to Home screen by Voice access or Switch access.
Bug:140819614 P1 If an install session is abandoned for an already installed app, the corresponding icon is removed
Bug:140823188 P1 AppPredictionsUITests failing
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Change-Id: I1efae6216c53b1fee3e105c9356ed43c4bf46c6e
am: 942aeb2c4c -s ours
am skip reason: change_id I157ff596deb419a57eca32a9b8d954d76294f627 with SHA1 ecb37ee845 is in history
Change-Id: Iea5018b78e870b8667b25b79029f928077172d74
Previously we were using OnGlobalLayoutListener, which is only called
when AllAppsContainerView or a child is re-laid out or visibility
changes to or from GONE. Since we no longer relayout when already
scrolled to the top, we need a better hook to check whether all apps has
changed visibility for the purpose of updating predictions.
Bug: 140823188
Change-Id: I7c4a0d94c529eb86b55729c75843c8b0bd673d8c
am: 923156a720 -s ours
am skip reason: change_id I157ff596deb419a57eca32a9b8d954d76294f627 with SHA1 ecb37ee845 is in history
Change-Id: I299877eaa8613b5c246f70fa73d0e9094d911799
- Ensure we only add promise icons for apps that aren't already installed to
our internal list of session ids.
- Ensure we only remove promise icons created from the install session when
that session is abandonded.
Bug: 140819614
Change-Id: I3c93865b5e96a9c7a160154b45a38eb90ac9d183
value, refresh icon cache
Bug: 135638690
Bug: 138964490
Test: manually toggled feature flag UI on/off
$ adb shell device_config put launcher APP_SEARCH_IMPROVEMENTS [true|false]
when launcher is in foreground and also when it is in the background
Afterwards, saw if "bank" would show BofA app or not
Change-Id: I98b62bd07b14a225168217d7eb9bfdfc7f74435d
Fix is already in ub-launcher3-master: I5094b22ddc77c45590cea1a5f5dead0dc7580abf
Bug: 140076379
Change-Id: I01948cf71ef2e058dc1ef8c506f174856ee09e0d
(cherry picked from commit d49fe3130e)
This fixes the bug where the wrong icon is present during the app close
animation.
Bug: 138195597
Change-Id: Ife2c6ad135dde54583f6f2bb2caf3b1e9325e064
Merged-In: Ib3767ec5c2b4eb22b35e5148879e11d2c1b28e3c
Tony Wickham
TreeHugger Robot
Jon Miranda
Sunny Goyal
Tracy Zhou
Vadim Tryshev
Hyunyoung Song
Pinyao Ting
Xin Li
Miranda Kephart