Commit Graph

19019 Commits

Author SHA1 Message Date
Tony Wickham 136cbc54bb Merge "Fix some issues with shelf jumping/duration" into ub-launcher3-qt-dev
am: 9e26fccacc

Change-Id: Ia310ffbe1f39902d2be371fb9467e72cf87002ee
2019-05-22 13:11:23 -07:00
Vadim Tryshev 15e3a436de Merge "TAPL: switching all swipes to model time" into ub-launcher3-qt-dev
am: 07b985b5e5

Change-Id: I2912a111e0129690c0f5aef42399cf01dac96175
2019-05-22 13:10:58 -07:00
Jon Miranda 8fcab4b88c Fix bug where recycled FloatingIconView stays clipped to outline.
am: 4c76bb8b3e

Change-Id: Ibbfb4d78e3b976d87ae64120c379f13ca259e9a0
2019-05-22 13:10:31 -07:00
Tony Wickham 9e26fccacc Merge "Fix some issues with shelf jumping/duration" into ub-launcher3-qt-dev 2019-05-22 19:21:37 +00:00
Vadim Tryshev 07b985b5e5 Merge "TAPL: switching all swipes to model time" into ub-launcher3-qt-dev 2019-05-22 18:26:21 +00:00
Jon Miranda 4c76bb8b3e Fix bug where recycled FloatingIconView stays clipped to outline.
Bug: 123900446
Change-Id: I9507dab86cc0da27626d1b48e0f6a236f2b3f219
2019-05-22 07:33:31 -07:00
Adam Cohen c598c4dfe9 Merge "Fix issue where Assistant could be invoked at the same time as all apps" into ub-launcher3-qt-dev
am: 47f21e8a08

Change-Id: I8d483e89806209161b293fc781ec9c44cccba443
2019-05-21 21:07:59 -07:00
vadimt 13c6c96234 Merge "Adding tracing for a lab-only flake" into ub-launcher3-qt-dev
am: 0ef504aa71

Change-Id: I5cd1ef837a413a4f75c399cfc920a2a659ee5943
2019-05-21 21:07:34 -07:00
Adam Cohen 47f21e8a08 Merge "Fix issue where Assistant could be invoked at the same time as all apps" into ub-launcher3-qt-dev 2019-05-22 03:48:36 +00:00
Tony e246dff69f Fix some issues with shelf jumping/duration
Don't use OvershootParams for 0 button mode, since that interpolator
assumes the shelf is moving in conjunction with recents/app window.
Instead, use OVERSHOOT_1_2 like we do when not flinging.

Also bound the duration when entering recents, since scroller
duration could be 750ms if we are snapping to the current page.
Now we cap at MAX_SWIPE_DURATION (350ms). This case is most likely
to be hit when ending a slow swipe near the final recents scale,
since in that case duration is close to 0 and the scroller duration
is taken instead.

Test:
- Artificially always detect a pause, fling up in 0 button mode;
  ensure shelf doesn't jump
- Either with the above artifical change in 0 button, or 2 button
  mode, end a swipe to recents near its final scale with a slight
  scroll to the right; ensure duration is 350 instead of 750

Bug: 132283018
Bug: 127783075
Change-Id: I8d5fbd0b30af21b9587fba47d141ba90b3b6e778
2019-05-21 20:27:55 -07:00
TreeHugger Robot 0ef504aa71 Merge "Adding tracing for a lab-only flake" into ub-launcher3-qt-dev 2019-05-22 03:12:56 +00:00
vadimt cfc2e02a94 TAPL: switching all swipes to model time
Bug: 133010773
Change-Id: I3334ac4ac434bf1c6470c806bb216eb7bd8e22c2
2019-05-21 18:29:19 -07:00
vadimt e17d1feb79 Adding tracing for a lab-only flake
We had a resolved case in the past where an app's context menu didn't
open on a long click (thanks to app updates), now the menu opens, but
the drag gesture doesn't drag the icon.

Bug: 133009122
Change-Id: I45d104a92fab6556ecd937aef76f0a8147e67f56
2019-05-21 17:19:23 -07:00
Adam Cohen 8f7d2b0dfd Fix issue where Assistant could be invoked at the same time as all apps
issue 132366412

-> First, we shouldn't accept flings when the delegate has intercepted. This prevents any situation
   where both are triggered.

-> Modified the slop to be the standard 8dp. This acts as a standalone fix because
   it means that there are no situations where we cross all apps slop before assistant slop.
   ie. in a purely vertical gesture from the corner, without this change, it's possible to trigger
   all apps instead of Assistant.

Change-Id: I39e3d8a525e165024399d9802d4cc1d7ae329ee6
2019-05-21 15:52:34 -07:00
vadimt 849be414d5 Merge "Not allowing applying dot state to override "disabled" description" into ub-launcher3-qt-dev
am: 4b41793155

Change-Id: I09f30dc4a6cb38ad43ed2424d1b3a66a83e0779a
2019-05-21 15:07:22 -07:00
Miranda Kephart 40b95f105b Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev
am: 49e5d8227b

Change-Id: I47e8826b6e78774da841ee5618d9ab59ab28fcb7
2019-05-21 15:06:31 -07:00
TreeHugger Robot 4b41793155 Merge "Not allowing applying dot state to override "disabled" description" into ub-launcher3-qt-dev 2019-05-21 21:05:03 +00:00
Miranda Kephart 49e5d8227b Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev 2019-05-21 21:05:00 +00:00
Sunny Goyal 4c801fdc2b Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev
am: 32ba3c1125

Change-Id: I38ddb1b877d6bcc348246fb0c76ab70d61cd9461
2019-05-21 13:48:29 -07:00
vadimt b4036410f4 More logging in AllApps + a fix
am: 3479cf80e7

Change-Id: Id09516dd2e2aebacf68588c566f713099fc83389
2019-05-21 13:47:54 -07:00
vadimt def565f768 Searching icons only in apps_list_view
am: a1a417c994

Change-Id: I91e0629e4f7f6c5f56c0d8f14b0add385048ea55
2019-05-21 13:47:31 -07:00
vadimt 484eb7c09a Marking sure the center of icon is not under search box in all apps
am: 1053de165e

Change-Id: Iedd34e33da72f4052d56317cda53f74ec25b0c67
2019-05-21 13:47:09 -07:00
vadimt da6dad5101 Not allowing applying dot state to override "disabled" description
Disabled apps were always accessibility-marked like "Disabled Messenger"

With introduction of dots, this degraded, the the "Disabled" part was
never added.

Restoring the old behavior here.

Bug: 129036789
Change-Id: Icb97ea9a190643449d90f558a78039df30c53cbf
2019-05-21 13:24:23 -07:00
TreeHugger Robot 32ba3c1125 Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev 2019-05-21 19:48:37 +00:00
vadimt 3479cf80e7 More logging in AllApps + a fix
Change-Id: Iebcb336beee36b0aea47404f8c5d31dec14e7383
2019-05-21 12:08:15 -07:00
vadimt a1a417c994 Searching icons only in apps_list_view
This should help avoiding situations when an icon is intermittently
found in the suggested row vs. the recycler.

Change-Id: I71b17caa5f827999f0901d5c4d4348de7e16f053
2019-05-21 11:49:49 -07:00
vadimt 1053de165e Marking sure the center of icon is not under search box in all apps
Change-Id: I9cfc9941be2bed7834d58039fbfc2741fcf50cba
2019-05-21 11:10:03 -07:00
vadimt f071c02207 Making sure that the icon in all apps is not under search box
am: 982ea56122

Change-Id: Ic4a1bcf2a5f815512019286181596d5d87cc0299
2019-05-20 18:56:12 -07:00
vadimt 982ea56122 Making sure that the icon in all apps is not under search box
Bug: 133011252
Bug: 133010447
Change-Id: Ie735ac36fa063d0d9290c59f6ad4af9e05600ddf
2019-05-20 16:53:39 -07:00
Sunny Goyal 878aa33567 Using squared hypot to optimize some comparisions
Change-Id: Ia5b99c2e60eedf02dea26857819f0e13127db4e2
2019-05-20 15:20:47 -07:00
Miranda Kephart b063775eb9 Pass in fling velocity for gesture progress
Calls SystemUIProxy.onGestureCompletion for a completed gesture
(either drag or fling) and passes in the velocity (0 for drags).

Bug: 132356358
Test: manual

Change-Id: I080adc401e19a6141627d1806b425056f7eefcbd
2019-05-20 18:07:44 -04:00
Jon Miranda f8bfb77a64 Merge "Fix bug where FolderIcon stays visible during swipe up to home animation." into ub-launcher3-qt-dev
am: 2445ca0777

Change-Id: I8d76c2a8cc3336d89d3e6920d9187c74ce3dd142
2019-05-20 13:55:54 -07:00
Jon Miranda 6811c7a785 Merge "Swipe up to home into FolderIcon animation bug fixes." into ub-launcher3-qt-dev
am: 692b5a26d9

Change-Id: I4b4b8063cbc97963c82255f8d89432aa19d893b7
2019-05-20 13:55:26 -07:00
Sunny Goyal 6db1474d68 Merge "Fixing inset map in case of display cutouts" into ub-launcher3-qt-dev
am: dea6ee23c6

Change-Id: If44f1c407c10c4de2d041e442af50d6de49d0aeb
2019-05-20 13:54:16 -07:00
Sunny Goyal 4fbcb43af2 Merge "Using different resource size for touch region in landscape" into ub-launcher3-qt-dev
am: 662a14f2de

Change-Id: I1aeced0313a8cd52abb5ec247a813c971cac7c91
2019-05-20 13:53:48 -07:00
Zak Cohen 1416342a3f Adapt the task footer container to be a named container.
am: 418b9bc5fc

Change-Id: Id84934f7133510dd63337793f8660fc912501c6c
2019-05-20 13:52:53 -07:00
TreeHugger Robot 2445ca0777 Merge "Fix bug where FolderIcon stays visible during swipe up to home animation." into ub-launcher3-qt-dev 2019-05-20 20:16:47 +00:00
TreeHugger Robot 692b5a26d9 Merge "Swipe up to home into FolderIcon animation bug fixes." into ub-launcher3-qt-dev 2019-05-20 20:10:18 +00:00
TreeHugger Robot dea6ee23c6 Merge "Fixing inset map in case of display cutouts" into ub-launcher3-qt-dev 2019-05-20 19:11:19 +00:00
Sunny Goyal c79bd21471 Fixing inset map in case of display cutouts
Change-Id: Ia2969688d9ae4c89a2da45eb6361f4476e1877ec
2019-05-20 12:00:17 -07:00
TreeHugger Robot 662a14f2de Merge "Using different resource size for touch region in landscape" into ub-launcher3-qt-dev 2019-05-20 18:57:00 +00:00
Jon Miranda ae975a613d Swipe up to home into FolderIcon animation bug fixes.
- Fixes clipping issues.
- Fixes badge being shifted.

Bug: 124510042
Change-Id: I2520d963fb2041a049650c2b8c12ddb3de7b8d87
2019-05-20 11:10:25 -07:00
Zak Cohen 418b9bc5fc Adapt the task footer container to be a named container.
Bug: 126744445
Test: manual
Change-Id: Id00ffac4581bbbe5dfd73a63b05c4512394745c1
2019-05-20 10:44:20 -07:00
Sunny Goyal 1b40b731b2 Using different resource size for touch region in landscape
Bug: 132917885
Change-Id: Ib702fd17fecff980db2e1d00f05cd055bcc3185a
2019-05-20 10:09:26 -07:00
Jon Miranda e543818bb6 Fix bug where FolderIcon stays visible during swipe up to home animation.
This can happen when opening an app from a folder, and then immediately
swiping up back to home.

This happens because when we swipe up to go home, there's a race condition
where the folder close animation finishes and sets the FolderIcon to VISIBLE
right before FloatingIconView sets it to INVISIBLE.

To fix it, in OverviewState#onStateEnabled we call
AbstractFloatingView#closeAllOpenViews(animate=false). Then we added logic
to cancel any Folder closing animation (which there is,
from WindowTransformSwipeHandler#onLauncherStart) and to just close the
folder right then and there.

Bug: 132588097
Change-Id: I4379431815e7cbddede5ea0213fe9323f001484b
2019-05-20 10:01:15 -07:00
Winson Chung 660cb8cb5d Disable system ui auto scrimming now that we target Q.
am: 0de5939638

Change-Id: I1584e0724613e445b6802318c1cd7984b98e2255
2019-05-18 21:47:39 -07:00
Winson Chung 0de5939638 Disable system ui auto scrimming now that we target Q.
Change-Id: Iff9706d078515a280ae7cf9d8c9dae8d269e1939
2019-05-18 21:19:32 -07:00
Sunny Goyal 571a5d63e0 Merge "Changing target sdk to Q" into ub-launcher3-qt-dev
am: 136805abdc

Change-Id: Ibe9a8ae07cccf2ad46c20c28098f3aab8cf245a7
2019-05-18 00:07:54 -07:00
TreeHugger Robot 136805abdc Merge "Changing target sdk to Q" into ub-launcher3-qt-dev 2019-05-18 06:59:43 +00:00
Sunny Goyal f5577b1117 Changing target sdk to Q
Change-Id: I9c2ac12d81d3b04e1a29f6c2a1f2e32fff76de7f
2019-05-17 23:19:58 -07:00