- Calling TIS.onUserUnlocked() will create a new InputConsumerController
and also call register() on that consumer, which will under the hood
destroy and create the consumer with WM. However, if onUserUnlocked()
is called multiple times (generally not the case), the second call
will trigger the creation of a new InputConsumerController and try
to call destroy with the new consumer's token instead of the old
one, and when it creates a new consumer WM will throw an exception
complaining that there is already a consumer.
We should instead use the same input consumer controller instance
for each registration so that we can destroy with the same token that
was previously used to create the consumer
Fixes: 313284686
Test: Force trigger onUserUnlocked() multiple times and ensure no crash
Change-Id: I67da9a1ca82568770d470fd94f17378fd50c02f4
This fixes the bug where taskbar shows up on home screen.
Fixes: 314790864
Flag: N/A
Test: From overview, tap on app, then immediately swipe to go home
Change-Id: I3aaa8cbe67edefc43ccd6db90ee7647152a862fc
* Previously we assume the split placeholder view shouldn't be
present in any states except launcher split selection, however
with contextual that changes.
* Now we only ensure that view isn't there in all apps when
we are not in split selection.
Test: Test runs and passes locally
Fixes: 323418145
Change-Id: Ida92030f9b139532ebb09c1d2646795bbb940bfc
Also adds a helper in popup data provider to provide categorized
suggestions. Used in follow up CL to update the UI.
Bug: 318410881
Test: WidgetsPredictionUpdateTaskTest and manual with follow up changes
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ie80e8ba7bbe874f7c4b0e579446edf571036555e
Soon they will be used for both launches and returns, so these names
are more accurate.
Bug: 323863002
Flag: NA
Test: still builds (no functionality change)
Change-Id: I618780f0416a466a6672a2e694cb3e3ffd3f1396
This reverts commit 1f0465e9f2.
Reason for revert: Droidmonitor investigation of test suite failure
Bug: 323976612
Change-Id: I07895d5c10984def103c240664755b96b79f1fb5
- Avoid calling resetTaskVisuals when entering Modal state with animation off, it should only be called when leaving Overview, to be consistent with animation on case
- Use a separate property to control alpha for modalness, to avoid being overridden by other transition
Fix: 320314839
Test: presubmit
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I12a35682e25c3a70bc263afdc90a7895d6c56f11
Soon it will be used for both launches and returns, so this name is
more accurate.
Bug: 323863002
Flag: NA
Test: still builds (no functionality change)
Change-Id: Iaff2589401af24c6e9f604b3d7fa11e819fc941a
This CL makes it so that isLeftRightSplit is correctly called instead of isLandscape when animating an app pair launch.
Fixes: 318756992
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: Id766a3f9bd315abc277e36a118fd233156cf3898
* Right now we split from all apps and we stay in all apps with
contextual split.
* We now have 2 paths, if we are in contextual split then we
should select the same app from all apps again
Fixes: 323418145
Change-Id: I3bde59847b9e47951a6acdc93660b600114c3ddd
The current character limit for the taskbar pinning edu subtitle does
not fit many translations. We are increasing the character limit to
enable proper translations.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 323943380
Test: N/A
Change-Id: I56225711c475e617451e5db0b1c226e3603e5c02
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.
Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
Besides finishing the recents animation from fullscreen app, we also need to update the taskbar state
Fixes: 323561157
Test: Go to a fullscreen app, trigger the split shortcut, make sure the hotseat icons are visible on the home screen
Change-Id: I36f47846ed0bc7f7036ae22452a28efc9cb09bc7
Winson Chung
Luca Zuccarini
Jon @
Tracy Zhou
Vadim Tryshev
Vinit Nayak
Helen Cheuk
Jagrut Desai
Fengjiang Li
Shamali Patwa
Sunny Goyal
Alex Chau
Ram Muthiah
Johannes Gallmann
Jeremy Sim
Schneider Victor-tulias
Saumya Prakash
Jordan Silva
Uwais Ashraf
Tony Wickham