Commit Graph

74065 Commits

Author SHA1 Message Date
Android Build Coastguard Worker 0fc1cefed8 Snap for 11426397 from e6bab556a1 to 24Q3-release
Change-Id: I1e2276e6a8f6a1abbf0513deaef92f6e6b6502f3
2024-02-09 00:22:31 +00:00
Sebastián Franco e6bab556a1 Merge "Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments" into main 2024-02-08 19:33:13 +00:00
Winson Chung 7a9923c2c7 Merge "Fix issue with wrong token used for input consumer unregistration" into main 2024-02-08 19:05:44 +00:00
Winson Chung b917c9ef52 Fix issue with wrong token used for input consumer unregistration
- Calling TIS.onUserUnlocked() will create a new InputConsumerController
  and also call register() on that consumer, which will under the hood
  destroy and create the consumer with WM.  However, if onUserUnlocked()
  is called multiple times (generally not the case), the second call
  will trigger the creation of a new InputConsumerController and try
  to call destroy with the new consumer's token instead of the old
  one, and when it creates a new consumer WM will throw an exception
  complaining that there is already a consumer.

  We should instead use the same input consumer controller instance
  for each registration so that we can destroy with the same token that
  was previously used to create the consumer

Fixes: 313284686
Test: Force trigger onUserUnlocked() multiple times and ensure no crash
Change-Id: I67da9a1ca82568770d470fd94f17378fd50c02f4
2024-02-08 19:05:30 +00:00
Sebastián Franco 9a8ecd954e Merge "Investigating test" into main 2024-02-08 19:05:12 +00:00
Federico Baron 1bb90a78f6 Merge "Fix two pane widget picker bugs" into main 2024-02-08 16:58:40 +00:00
Luca Zuccarini 9fd2b31005 Merge "Rename a few more animations classes to cover transitions in general." into main 2024-02-08 16:34:22 +00:00
Jagrut Desai a6bf72fe5b Merge "Making AbstractDeviceProfileTest tnd FakeInvariantDeviceProfileTesto only run on CF_PHONE" into main 2024-02-08 16:31:09 +00:00
Jagrut Desai f584d784f8 Making AbstractDeviceProfileTest tnd FakeInvariantDeviceProfileTesto only run on CF_PHONE
Test: Presubmit
Bug: 315230497
Bug: 322418756
Bug: 321596072
Flag: NONE

Change-Id: I668f87304df0ba1dcace3d802906c8a66912d381
2024-02-08 12:06:44 +00:00
Luca Zuccarini 9ac91ffa63 Merge "Rename ActivityLaunchAnimator to cover transitions in general." into main 2024-02-08 10:15:43 +00:00
Vadim Tryshev e2c07182ed Merge "Removing FilteredLogcat files" into main 2024-02-08 02:16:23 +00:00
Sebastian Franco 3f6194dcaf Investigating test
Flag: NA
Bug: 322823478
Test: waiting for falkes to see results
Change-Id: I447b0f22fe307ade4920e1b12cdc63f375126a5a
2024-02-07 16:33:23 -08:00
Jon @ f670b96e31 Merge "Update state for when task launched in live tile mode gets cancelled." into main 2024-02-08 00:00:21 +00:00
Shamali Patwa e2849a0de0 Merge "Remove the "expand/collapse" actions on the apps list in 2 pane picker." into main 2024-02-07 22:53:34 +00:00
Sebastián Franco 458de20538 Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments
Bug: 324261526
Test: atest TaplDragTest
Flag: NA
Change-Id: I0802d725eea222d19c8d8e60878c2f88be854ddc
2024-02-07 22:48:26 +00:00
fbaron 88676ba7bb Fix two pane widget picker bugs
Here we:
-Move no widgets text outside of the right pane so that we can center it
-setInset and change the clipping of children in the views so that we can fix the padding at the bottom when we have 3 button nav
-create selectedHeader where we keep track of the currently selected header in order to refresh the widgets for the selected header on rotation
-when widgets are bound we check if there are no recommended widgets, and if there aren't we select the first visible header

Fix: 324002996
Fix: 324001940
Fix: 323417968
Fix: 323460545
Fix: 323409306
Test: WidgetPickerImageTest
Flag: NONE
Change-Id: Ibd85cb086bb6c2aede6cf79da0c688a1fdaec4e5
2024-02-07 22:36:59 +00:00
Tracy Zhou e14948d0f6 Merge "Show hotseat instead of stashed taskbar handle after entering stage split from fullscreen app via keyboard shortcut" into main 2024-02-07 22:04:20 +00:00
Himanshu Gupta ebc985850d Merge "Refreshin App Market Intent on Plus Icon Click" into main 2024-02-07 20:44:26 +00:00
Anushree Ganjam faa35a81bb Merge "Add Unit tests for System Shortcut." into main 2024-02-07 19:38:32 +00:00
Jon Miranda 4af3e80cae Update state for when task launched in live tile mode gets cancelled.
This fixes the bug where taskbar shows up on home screen.

Fixes: 314790864
Flag: N/A
Test: From overview, tap on app, then immediately swipe to go home

Change-Id: I3aaa8cbe67edefc43ccd6db90ee7647152a862fc
2024-02-07 11:29:07 -08:00
Vadim Tryshev 6a0c468563 Merge "Revert "Add unit test for StatusBarTouchController.java"" into main 2024-02-07 18:54:43 +00:00
Helen Cheuk 422b9739e4 Merge "Draw focus outline in search app result" into main 2024-02-07 17:19:05 +00:00
Federico Baron 789ab23ce1 Merge "Align workspace and hotseat icons in landscape" into main 2024-02-07 16:16:16 +00:00
helencheuk bbd54b3e32 Draw focus outline in search app result
Before:
https://screenshot.googleplex.com/9qoPoBNZkDY94gy
https://screenshot.googleplex.com/7XVFxwj8d6UqLUs
https://screenshot.googleplex.com/4KtQcma26eSdBnb

After:
https://screenshot.googleplex.com/BxfNAJGqXhyGBbJ
https://screenshot.googleplex.com/8EMKUQW4ubXHdDd
https://screenshot.googleplex.com/32KBfdj4preL8H6

Bug: 319454774
Test: Manual, open all apps, type some word and press enter to search. Navigate to the search result below and outline should appear
Test: will add screenshot test in b/318360469
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I8caef8dd9e590d43e05baa78cebee73d21b84acf
2024-02-07 15:07:43 +00:00
Vinit Nayak 44911450c6 Merge "Update test infra to allow split placeholder view in all apps" into main 2024-02-07 14:57:19 +00:00
Helen Cheuk eece9356e2 Merge "Show taskbar when external keyboard is attached, in 3 button nav mode and desktop windowing mode" into main 2024-02-07 14:30:12 +00:00
Himanshu Gupta 19f7a8a5ed Refreshin App Market Intent on Plus Icon Click
Currently the App Market intent is loaded statically into
Launcher, once during start. Sometimes, this causes the app
market activity start to be blocked, resulting in no action
from button tap.

To fix this, we hot-reload the intent when the plus button is
clicked.

Bug: 323189130
Test: Launcher3 test.
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TRUNKFOOD
Change-Id: I563d29838a43644ba8e0830b39d4f4ef8c60aeb6
2024-02-07 09:26:37 +00:00
Holly Jiuyu Sun e35d5d8cb0 Merge "[PS] Update PS icon." into main 2024-02-07 07:36:02 +00:00
Vinit Nayak fad0709510 Update test infra to allow split placeholder view in all apps
* Previously we assume the split placeholder view shouldn't be
present in any states except launcher split selection, however
with contextual that changes.
* Now we only ensure that view isn't there in all apps when
we are not in split selection.

Test: Test runs and passes locally
Fixes: 323418145
Change-Id: Ida92030f9b139532ebb09c1d2646795bbb940bfc
2024-02-07 03:32:02 +00:00
Vadim Tryshev 1e038e4c16 Removing FilteredLogcat files
We don't use them

Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I236f3c8e8cc7372e371d9a5bc1ff37889e1ab87b
2024-02-06 18:47:36 -08:00
Jagrut Desai 8f4e0d0c83 Merge "Fixing NPE android.platform.test.scenario.launcher.overview testcases" into main 2024-02-06 22:57:09 +00:00
Fengjiang Li 7f827e1527 Merge "[Predictive Back] Replace legacy flag with aconfig flag in launcher" into main 2024-02-06 21:57:34 +00:00
Shamali Patwa efebbb21fe Merge "Update prediction task to provide categorized suggestions." into main 2024-02-06 21:36:14 +00:00
Tracy Zhou b7efb5cb49 Merge "Only hide back button in SUW when ime is rendering it" into main 2024-02-06 20:24:29 +00:00
Sunny Goyal d1176bccf9 Merge "Using system API for rotating DisplayCutout instead of rotating it ourselves" into main 2024-02-06 20:20:47 +00:00
Shamali P 55fded376b Remove the "expand/collapse" actions on the apps list in 2 pane picker.
In a single pane picker, apps list is expandable / collapsable, but,
its not applicable for 2-pane variant. in 2-pane one, it should just
say "double tap to activate".

Also opened b/324073588 to make it clear from a11y perspective that it
is two pane and on click, right pane change should be announced.
(just like it does in settings with talkback).

see screencast/cast/NTQ1Mjk0MjIzOTg1ODY4OHw4OTc5ZjAzNS0wOQ

Bug: 319195592
Flag: None
Test: WidgetsListHeaderAccessibilityTest & manual.
Change-Id: I9ae3fbacc29364bd7459f6e6d85e0a1e919de3f8
2024-02-06 20:07:41 +00:00
Jagrut Desai 77d2e7860a Fixing NPE android.platform.test.scenario.launcher.overview testcases
Test: Presubmit, run staging platinum test on this change
Bug: 303256981
Flag: NONE
Change-Id: I9f807b008bb08909b4a08e750b4357b7d23eba39
2024-02-06 11:41:44 -08:00
Priyanka Advani 26b2e4810e Merge "Revert "Fix widget restore for pre-archived apps"" into main 2024-02-06 19:11:06 +00:00
Priyanka Advani eace95ab94 Revert "Fix widget restore for pre-archived apps"
Revert submission 26049200-widget-restore-fix

Reason for revert: Build breakage in b/324091151

Reverted changes: /q/submissionid:26049200-widget-restore-fix

Change-Id: I8a43650ba3f4590f49f038691d34238231f0747c
2024-02-06 19:00:55 +00:00
Piyush Mehrotra 2e094493c2 Merge "Fix widget restore for pre-archived apps" into main 2024-02-06 18:36:26 +00:00
Sunny Goyal a90500d233 Using system API for rotating DisplayCutout instead of rotating it ourselves
Bug: 321913010
Flag: NONE
Test: Manual
Change-Id: Iebbc8c17dc3b92a73866b7e22dfbde18eb3a52ff
2024-02-06 10:26:18 -08:00
Shamali P 57c1eedbc6 Update prediction task to provide categorized suggestions.
Also adds a helper in popup data provider to provide categorized
suggestions. Used in follow up CL to update the UI.

Bug: 318410881
Test: WidgetsPredictionUpdateTaskTest and manual with follow up changes
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ie80e8ba7bbe874f7c4b0e579446edf571036555e
2024-02-06 18:14:49 +00:00
Federico Baron a5d7ae6c84 Merge "Fix pagination animation when removing a page" into main 2024-02-06 17:52:14 +00:00
Luca Zuccarini a2dd8a2629 Rename a few more animations classes to cover transitions in general.
Soon they will be used for both launches and returns, so these names
are more accurate.

Bug: 323863002
Flag: NA
Test: still builds (no functionality change)
Change-Id: I618780f0416a466a6672a2e694cb3e3ffd3f1396
2024-02-06 17:06:26 +00:00
Alex Chau 1380459097 Merge "Fix Select mode problem with animation off" into main 2024-02-06 16:55:56 +00:00
Ram Muthiah 87b5785548 Revert "Add unit test for StatusBarTouchController.java"
This reverts commit 1f0465e9f2.

Reason for revert: Droidmonitor investigation of test suite failure

Bug: 323976612
Change-Id: I07895d5c10984def103c240664755b96b79f1fb5
2024-02-06 16:50:10 +00:00
Jakob Schneider fb2bb9425c Merge "Add the archiving sysprop check to launcher3." into main 2024-02-06 16:34:53 +00:00
Johannes Gallmann 2441874a75 Merge "Fix crash for predictive back to home fallback animation" into main 2024-02-06 16:13:30 +00:00
Jakob Schneider 328c32235e Add the archiving sysprop check to launcher3.
This system property will be used to test the feature
in DVT. This is required because the new device is built on U QPR3, not V. See
https://docs.google.com/document/d/1h8sLlnnhwGP4uZssglBqTShMoQcEq5dvR7jsJmmp0Cw/edit?resourcekey=0-KTFHkPKTdtMN-5kQYBWJig&tab=t.0#heading=h.x9snb54sjlu9  for more details.

Test: tested manually
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving TEAMFOOD

Change-Id: Ie64a40ba799c81057258dd7de3872a0494cff2d8
2024-02-06 14:29:07 +00:00
Alex Chau 55b8b43fef Fix Select mode problem with animation off
- Avoid calling resetTaskVisuals when entering Modal state with animation off, it should only be called when leaving Overview, to be consistent with animation on case
- Use a separate property to control alpha for modalness, to avoid being overridden by other transition

Fix: 320314839
Test: presubmit
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I12a35682e25c3a70bc263afdc90a7895d6c56f11
2024-02-06 14:16:43 +00:00