Commit Graph

1818 Commits

Author SHA1 Message Date
Brandon Dayauon f2ea399ec6 Fix prediction row title consistency
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."

Instead of changing the number of lines after processing, just set a separate display to the prediction app row

bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN

Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00
Jordan Silva 637f4eb2f3 Update DeviceProfile to calculate responsive grid for folders
It uses the new responsive folder calculations and specs when responsive grid is enabled. The grid has to have folderSpecsId defined to use the new specifications, otherwise it will use the current scalable grid implementation.

Fix: 284155638
Test: DeviceProfileDumpTest
Test: ResponsiveHomeScreenFolderImageTest
Test: HomeScreenFolderImageTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I535cff4bb00e969f782447a898230fe2b2c05cc9
2023-06-21 12:18:58 +01:00
Thales Lima 2759aa345b Decrease icon size by steps
When the icon can't fit the cell size, decrease it by steps defined by UX until it fits or reach a minimum size.

Fix: 283929701
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: IconSizeStepsTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I2875b669c0a24ecd1c4d785a33e2cffb78c9fe76
2023-06-20 20:37:38 +01:00
Thales Lima abfe364629 Implement calculations of Responsive Grid for AllApps
All Apps follow the same sizes as the workspace, so we copy the measurements to AllApps values.

Bug: 284152932
Test: HomeScreenAllAppsImageTest
Test: DeviceProfileDumpTest
Test: HomeScreenResponsiveAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I12743a6ac5ab5f1a8bc911511bdc7e12b2261d86
2023-06-16 10:19:19 +00:00
Lucas Dupin fbe96507dd Merge "Merge "Fixing color mismatch for Launcher3/NexusLauncher" into udc-dev am: d469ce2460 am: e3f46ba90b" into udc-qpr-dev 2023-06-15 20:15:11 +00:00
Marcelo Arteiro d7d49ad4b3 Merge "Fixing color mismatch for Launcher3/NexusLauncher" into udc-dev am: d469ce2460 am: e3f46ba90b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23102625

Change-Id: Iab06fa739fb16e399931ca90ebb2cfdf7afdd738
Merged-In: Iab06fa739fb16e399931ca90ebb2cfdf7afdd738
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-14 22:25:51 +00:00
Thales Lima 196e44baec Create AllApps responsive spec
Copy the parser from WorkspaceSpec and modify to use AllApps attributes.

Bug: 284152932
Test: AllAppsSpecsTest
Test: CalculatedAllAppsSpecTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I9362e126c64cb1a1abdef61894b003f14701b8e3
2023-06-14 15:02:58 +01:00
Jordan Silva 296a9f3389 Merge "Update SizeSpec attributes to accept max size threshold" into udc-qpr-dev 2023-06-14 09:37:42 +00:00
Brian Isganitis cca18d8028 Merge "Support zero-state suggestions in Taskbar All Apps." into udc-qpr-dev 2023-06-13 18:26:36 +00:00
Jordan Silva 1b336110a4 Update SizeSpec attributes to accept max size threshold
Add maxSize attribute to SizeSpec to limit the cell size up to a max size when matchWorkspace is true. The same validation was added when using fixedSize, ofAvailableSpace and ofRemainderSpace, so they could have a maxSize as a threshold.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: SizeSpecTest
Test: WorkspaceSpecsTest
Change-Id: I113657c241e6618eb3e501243412d8c5626fc3d5
2023-06-13 18:09:37 +01:00
Jordan Silva 7ae9e3a6f5 Add FolderSpec for responsive grid support
Adds responsive grid implementation for folders. It follows the same concept as WorkspaceSpecs, so we have a parser similar to WorkspaceSpecs for FolderSpecs.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: FolderSpecsTest
Test: CalculatedFolderSpecsTest
Change-Id: Iea6d7d88ef42d1273aed7cf2ed5b397035518a52
2023-06-13 15:01:39 +01:00
Brian Isganitis d478b1464e Support zero-state suggestions in Taskbar All Apps.
Test: manual
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I016d4e4e6a096ca4f5bd65fcda1bf24a444459f4
2023-06-12 17:19:16 +00:00
Jordan Silva d22a85cd64 Merge "Adding match workspace to SizeSpec for responsive grid support" into udc-qpr-dev 2023-06-09 20:04:54 +00:00
Jordan Silva 2b8556ce1a Adding match workspace to SizeSpec for responsive grid support
Added matchWorkspace property to support responsive grid implementation for AllApps and Folders. This property indicates whether the attribute value will be used from the workspace instead of defining a fixed value in the AllApps and Folders XML. The class was updated to be a data class and added a auxiliar constructor new make it more flexible for testing and to add other initializers to support AllApps and Folders.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: WorkspaceSpecsTest
Test: SizeSpecTest
Change-Id: I65b71e66be7b8236a1dee62b56a487b87881d991
2023-06-09 17:05:22 +00:00
Marcelo Arteiro ecff4b59c0 Fixing color mismatch for Launcher3/NexusLauncher
https://screenshot.googleplex.com/7hpgPtjSdjzYFYh

Bug: 268682423
Bug: 277728851
Test: Manual
Change-Id: I7b92ca18721624ef5ecd4b69ca4158ad2dc600f3
2023-06-08 19:01:29 +00:00
Pat Manning 58b6145feb Refactor ArrowTipView so it can be customized and used in any drag layer.
Allows use in TaskbarDragLayer.

Allows customization of properties like text color, background color, and open/close animations.

Bug: 250092437
Test: manual. (Will test with TaplTestsTaskbar in follow up CL when implemented.)
Change-Id: I056395322e5fef7aa4d9fd7e4c2d73c050eff759
2023-06-06 13:46:31 +01:00
Sunny Goyal db51eeff7c Merge "Updating the top scrim to also use dynamicaly generated bitmap" into udc-qpr-dev 2023-06-05 17:18:28 +00:00
Sunny Goyal 6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
Brian Isganitis 7a5809e47b Add initial support for search session in Taskbar All Apps.
A search session is represented as a stub ResourceBasedOverride that can
be extended for controlling a search session.

Test: Manual (including aosp Quickstep)
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I9cf4b5f84feec5215840d456b601c6a9f7c4c211
2023-06-02 15:55:46 +00:00
Santiago Aboy Solanes ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Sunny Goyal 3e596d3aa4 Updating the top scrim to also use dynamicaly generated bitmap
Bug: 237818532
Test: Verified on device
Flag: N/A
Change-Id: I22ceb470677ab9df53e40fb78f0292b7fd5e2241
2023-06-01 19:20:04 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Brandon Dayauon fe3d513650 Merge "Update work tab colors and fab background color" into udc-dev 2023-05-25 03:07:59 +00:00
Brandon Dayauon adcc16cf56 Update work tab colors and fab background color
Spec: https://screenshot.googleplex.com/6mKVuFNNNQfXpbD

bug: 283120562
test:
manually Launcher3 build var:
worktab lt: https://screenshot.googleplex.com/B8v44jm77o5Jyc7
widgetpicker tab lt: https://screenshot.googleplex.com/48WjAB8fKpZSEQ7
sharesheet tab lt: https://screenshot.googleplex.com/9rfSBeNALXbG7NL
worktab dt: https://screenshot.googleplex.com/332jCxde9vDW7hd
widgetpicker tab dt: https://screenshot.googleplex.com/3PGtrvQ2jLhQD4k
sharesheet tab dt: https://screenshot.googleplex.com/3jr4GPzRc3rzMA6

NexusLauncher:
worktab lt: https://screenshot.googleplex.com/BH2SFMXfQ4dtBeh
sharesheet lt: https://screenshot.googleplex.com/5axg34QgTt87iSL
widget picker tab lt: https://screenshot.googleplex.com/928kWFJ5mTun9py
worktab dt: https://screenshot.googleplex.com/7KWKLH4kt6nJpXT
sharesheet dt: https://screenshot.googleplex.com/778UoyhYrhimSAz
widgetpicker tab dt: https://screenshot.googleplex.com/FFFxBLqsATNXj8v

Change-Id: I78f20b2863a04d23e8a8880fc1d6a3ac0cfeb82a
2023-05-24 09:10:03 -07:00
Jagrut Desai 5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Federico Baron 4b43200910 Merge "Update colors for edit state" into udc-dev 2023-05-18 21:03:19 +00:00
Federico Baron 3eba77ca4b Merge "Update colors for popup menus" into udc-dev 2023-05-18 21:03:19 +00:00
fbaron e8efdc4bd9 Update colors for edit state
Bug: 268521231
Test: Verify that edit state colors match the figma attached in the bug
Flag: no flag
Change-Id: I72e5ffde48ca2e53b876b2c86ac5d92c8ddf79c0
2023-05-17 09:27:08 -07:00
fbaron 1a76d5c72d Update colors for popup menus
Bug: 268521231
Test: Verify that popup menu colors match the figma attached in the bug
Change-Id: I24025576a789775dfcf17694d16c0d5f6ee844fd
2023-05-16 15:07:30 -07:00
fbaron 8463f6a771 Update folder preview and folder colors
Bug: 268521231
Test: Verify that folder preview and folder colors match the figma attached in the bug
Flag: no flag
Change-Id: Ica75cace98fc2643d59ad0c28cbad736b578c51d
2023-05-16 09:34:37 -07:00
Treehugger Robot 21339533b1 Merge "Update notification dot color" into udc-dev 2023-05-15 20:21:45 +00:00
fbaron 1406a0f606 Update notification dot color
Bug: 268521231
Test: Verify that notification dot colors match the figma attached in the bug
Change-Id: Id0cbf9f2447819ae3e6e00e880eca1be3f189826
2023-05-15 11:06:46 -07:00
Thales Lima 0740b7fb43 Merge "Add feature flag and attribute for responsive grid" into udc-dev 2023-05-10 09:44:49 +00:00
Treehugger Robot 386f9796e3 Merge "Removing unused wallpaper-scrim feature" into udc-dev 2023-05-09 20:57:33 +00:00
Thales Lima ec5abba93b Add feature flag and attribute for responsive grid
This shouldn't change anything in the grids, only support the creation of responsive grids in the future. For now, to check that the flag works, turn it on and check the dumpsys. There is also a dump test created for this.

Fix: 277064696
Fix: 277064702
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I1bef87043a100234bd661cd6ac00007fdc654116
2023-05-09 12:06:18 +01:00
Jordan Silva 11167aa1f2 Merge "Fix text sizes and alignment in drop target" into udc-dev 2023-05-05 14:09:23 +00:00
Sunny Goyal db19958b82 Removing unused wallpaper-scrim feature
Bug: 270393604
Test: Presubmit
Flag: N/A
Change-Id: I10df3a96eb26b9871eb1b330ea5b2c0797d0668d
2023-05-04 14:02:41 -07:00
Sunny Goyal 6c304b157d Always insetting the widget by a minimum of 6dp
Removing default widget padding logic. Also widget padding it applied
at ShortcutAndWidgetContainer so that the widgetView always has the
correct size.

Bug: 274826296
Bug: 257589413
Test: Verified using screenshots
Flags: N/A
Change-Id: Id4b5e94db6ec7b2aa3dca87b1e9ccc831b608cac
2023-05-03 12:18:33 -07:00
Jordan Silva 567372fbda Fix text sizes and alignment in drop target
Drop target button texts are being resized incorrectly.
When both buttons are visible, the text is considerably smaller compared
to only one visible button. This happens even for the default display and font scale 1.

Fix: 271279172
Test: manual. test all combinations of display size and font size.
Test: HomeScreenEditStateImageTest
Change-Id: Ib001dcf8b096c65b138946bdad49cf8199fb5b1d
2023-05-02 14:57:49 +02:00
Marcello Galhardo 0745f507a4 Merge "Add custom widget category for Note Taking" into udc-dev 2023-04-26 14:25:33 +00:00
Marcello Galhardo 4b7b7f1cfa Add custom widget category for Note Taking
Test: manual
Flag: not needed

Fixes: b/261853771
Change-Id: I493fd782cf8569ee9efca5134eefb5652a2bf972
2023-04-24 17:09:31 +00:00
Jagrut Desai 64b79a9fad Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev 2023-04-21 16:15:07 +00:00
Jagrut Desai c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
fbaron 328ca3811c Update colors for widget picker
Bug: 278157622
Test: Look at widget picker on tablet and verify that the colors match the new spec, and verify the portrait mode looks good also.
Change-Id: I634d876dfafc086806b233c500f7d8daddfe7b0b
2023-04-18 16:17:24 -07:00
Federico Baron cc79886814 Merge "Fix droptarget button wrong radius on hover" into udc-dev 2023-04-13 23:50:12 +00:00
fbaron 84e19a9bea Fix droptarget button wrong radius on hover
Fix: 277470359
Test: drag app to uninstall or remove on tablet, verify the button shape doesn't change when hovered over
Change-Id: I6b8b2de7357f8d19cdee7632a9957624a3f242a1
2023-04-13 19:27:00 +00:00
fbaron 6847c9f113 Add entry point for home gardening
Bug: 277817921
Test: Turn on flag MULTI_SELECT_EDIT_MODE and verify that a new button shows up that says "Edit Home Screen"
Change-Id: Ic8027ab80604faf5bdc63a44319ecffc047a495c
2023-04-12 09:31:28 -07:00
Sunny Goyal 84b48d8deb Removing support for adding legacy shortcuts.
All existing legacy shortcuts will be migrated one-time to deep shortcuts
This shortcuts are pinned under the Launcher package, with custom badging

Bug: 275875209
Test: Updated unit tests
Flag: N/A
Change-Id: I7da001f724776ad8d6c807517b7e4e259de626c2
2023-04-10 12:28:52 -07:00
Sunny Goyal 7b74a5c53f Merge "Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""" into udc-dev 2023-04-07 01:02:09 +00:00
Sunny Goyal 5cd1b198b0 Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""
This reverts commit 7025765c72.

Reason for revert: 274169859

Change-Id: I86a114bf2c713fea6ec7095f68816820ba5f7495
2023-04-06 22:33:11 +00:00