Commit Graph

64935 Commits

Author SHA1 Message Date
Brian Isganitis 0ea37669bd Merge "Provide AllApps item OnLongClickListener through ActivityContext." into udc-qpr-dev am: ea206bbad5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836392

Change-Id: I4ccee814359e38aae2b552bec4cfbe21b988327a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:27:19 +00:00
Brian Isganitis ea206bbad5 Merge "Provide AllApps item OnLongClickListener through ActivityContext." into udc-qpr-dev 2023-07-07 19:43:01 +00:00
Sunny Goyal 2da6e6d572 Merge "Fixing crash when using multi-window" into udc-qpr-dev am: 229b2efbae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23924146

Change-Id: Ia921e7f93117a091252936429a955704d0c6a754
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 03:19:31 +00:00
Lucas Dupin 0d8883469c Merge "Updating materialColorSurfaceContainerHighest color access" into udc-qpr-dev am: 6a925d0769
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23917471

Change-Id: Ia940de6f17a4ab9a49aad38a8699bfbcfa9fd5cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 03:16:48 +00:00
Sunny Goyal 229b2efbae Merge "Fixing crash when using multi-window" into udc-qpr-dev 2023-07-07 03:16:13 +00:00
Lucas Dupin 6a925d0769 Merge "Updating materialColorSurfaceContainerHighest color access" into udc-qpr-dev 2023-07-07 02:31:27 +00:00
Vinit Nayak fc85ff02fb Merge "Add support for taskbar phone 3 button seascape" into udc-qpr-dev am: ea12af617e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23623277

Change-Id: I884e7f794448ec2f74cceb9e45be7ca12a9e718c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 00:18:29 +00:00
Vinit Nayak ea12af617e Merge "Add support for taskbar phone 3 button seascape" into udc-qpr-dev 2023-07-06 23:18:07 +00:00
Vinit Nayak 3fbee6358c Merge "Reset split selection state when swiping to home" into udc-qpr-dev am: 781077ddff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23848172

Change-Id: Id635fb83f23621542dbd0cb882e3c04870952792
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 22:59:50 +00:00
Sunny Goyal 90bf1f4298 Fixing crash when using multi-window
Bug: 290170868
Test: Verified on device
Flg: N/A
Change-Id: If9129a3a47d651755cc99dfcfc0e9be69c2ca63c
2023-07-06 15:23:06 -07:00
Vinit Nayak 781077ddff Merge "Reset split selection state when swiping to home" into udc-qpr-dev 2023-07-06 22:14:41 +00:00
Brian Isganitis 0acab2532d Provide AllApps item OnLongClickListener through ActivityContext.
This cleans up how alternative AllApps implementations such as Taskbar
and SecondaryDisplay override the default INSTANCE_ALL_APPS listener.
This change will also be helpful for Toast in Taskbar drag-n-drop.

Test: Manual
Bug: 289261756
Flag: n/a
Change-Id: I55eb881bcd1e210852d435a3ea2a6686ce0a9838
2023-07-06 22:12:20 +00:00
Vinit Nayak 5e2a2564e8 Reset split selection state when swiping to home
Bug: 276361926
Fixes: 238651489
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Ic1439561f37b50ebf9dfb99edbeece21520798b1
2023-07-06 15:08:05 -07:00
Vinit Nayak a79fabfed8 Merge "Cleanup WorkProfileTest logs" into udc-qpr-dev am: f619155808
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23907246

Change-Id: I0cb9d11d9576d841eee304ccf67c4532873fab03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 21:30:42 +00:00
Vinit Nayak 15a9feb67f Add support for taskbar phone 3 button seascape
* Ignore orientation check from ag/22709055 for now,
that will be reverted. This causes recreateTaskbar() to
not run when folding the device

Bug: 274517647
Test: Tested 3 button nav in portrait/landscape/seascape
Flag: persist.wm.debug.hide_navbar_window
Change-Id: Ied02ead677d496b465c748257e32b7db5eb9580c
2023-07-06 13:58:30 -07:00
Vinit Nayak f619155808 Merge "Cleanup WorkProfileTest logs" into udc-qpr-dev 2023-07-06 20:44:26 +00:00
Andrew Cole fe0a3b41d8 Updating materialColorSurfaceContainerHighest color access
For any view files applying the WidgetConatinerTheme via widgetsTheme they were incorrectly inheriting themes and skipping the AppTheme provided but only in light mode. In dark mode the WidgetContainerTheme.Dark was correctly inheriting the theme.

To avoid a risky theme update for all widgetsThemes we just modify the color accessor to use @color instead of ?attr as these colors should not be attributes AFAIKT

Bug: b/289305591
Test: Follow repro steps on the bug for smartspace
Change-Id: I26cc3239763f8eac3dfe5f094c6757692f46d1bc
2023-07-06 12:21:21 -07:00
Liran Binyamin b95ce55c7e Merge changes I93c2232d,I00daff83 into udc-qpr-dev am: 7fedde35ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23912479

Change-Id: I9b8a03fb45e1846818b1ae65e48f9d1062607e7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 18:55:37 +00:00
Brian Isganitis 2a180cb65c Merge "Only update local zss cache when Taskbar Toast already active." into udc-qpr-dev am: cdb56ea2e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23847631

Change-Id: Idd4a3a63bc6bf8dc47e43b5210aea2a66caa3559
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 18:54:41 +00:00
Liran Binyamin 7fedde35ad Merge changes I93c2232d,I00daff83 into udc-qpr-dev
* changes:
  Align the bubble bar with the taskbar in overview and app
  Update the bubble bar offset on Home
2023-07-06 18:40:27 +00:00
Brian Isganitis cdb56ea2e0 Merge "Only update local zss cache when Taskbar Toast already active." into udc-qpr-dev 2023-07-06 18:03:55 +00:00
Liran Binyamin d76a9d9240 Align the bubble bar with the taskbar in overview and app
Whenever the bubble bar is unstashed and taskbar is present, the
translationY of the bubble bar is now adjusted so that it is aligned
with the taskbar.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/e3dlacSsSebQfEFTEt10JM

Fixes: 286247080
Test: Manual:
      - Add bubbles to the bubble bar.
      - On home observe the bar is aligned with hotseat
      - Switch to overview and observe the bar is aligned with taskbar
      - Go back to home. Bar aligns with hotseat.
      - Launch an app. Swipe up to load taskbar. Bar is aligned with taskbar.
      - Go back to home. Bar aligns with hotseat.
Change-Id: I93c2232d4862be4c97e36ddb6c9d680b01e555ad
2023-07-06 12:10:27 -04:00
Vinit Nayak 33b4935234 Prevent passing in GroupedTaskView when not animating split launch am: 8082401a83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23910406

Change-Id: I5cba930c740bac29dd12c615510c76130d52938a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 04:43:45 +00:00
Vinit Nayak 8082401a83 Prevent passing in GroupedTaskView when not animating split launch
* With ag/23320818 we started always passing in GroupedTaskView,
which gets used downstream to mean that we are launching an app
from tapping on it in overview
* This caused a bug in the case where we quickswitched to the last
task. Now we pass in null for GroupedTaskView like before

Test: Prior bug (b/274540670) doesn't occur, nor do repro steps
for this one
Fixes: 289163668
Flag: None

Change-Id: I82dd8f26bfc286fefc0995822786cf3980da41d0
2023-07-05 18:21:59 -07:00
Vinit Nayak f6f192853d Cleanup WorkProfileTest logs
Fixes: 243688989
Change-Id: Ic3f143062c1a1383d1e79959dae59c45743547e9
2023-07-05 16:27:11 -07:00
Fengjiang Li 1eb81c658a Merge changes from topic "preinflate-allapps-rv" into udc-qpr-dev am: 1e3d799fe3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23714667

Change-Id: I8f3cfc5a95c39cf5d0bded35fbb094cd5f18dc4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 23:21:21 +00:00
Fengjiang Li 1e3d799fe3 Merge changes from topic "preinflate-allapps-rv" into udc-qpr-dev
* changes:
  Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
  Fix calculation of all apps recyclerview pool size of app icons
2023-07-05 22:44:55 +00:00
Jeremy Sim 5aab73311a Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev am: 66ec0f6a28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23848181

Change-Id: Ie893a904846f1f8387c358ae1d1dac565eee6abe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 22:16:00 +00:00
Jeremy Sim 86cf2ea3c8 Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev am: 3137f65dcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23784840

Change-Id: I490a99f184fdb3d6432b93ea36ac79c0e8a51c66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 22:15:20 +00:00
Liran Binyamin c06c7ff6fa Update the bubble bar offset on Home
This is an initial change that positions the bubble bar aligning it
with the center of the hotseat icons. We still need to center it
with the taskbar when in overview.

This change also fixes the touch issues where sometimes the hotseat
icons don't respond to taps. The fix is twofold:

1. Make sure that taskbar insets are always updated when
   BubbleStashController#setBubblesShowingOnHome is called.
2. Update the touchable region in TaskbarInsetsController to account
   for the Y translation of the bubble bar bounds when the bubble
   bar is visible.

Demo: https://screenshot.googleplex.com/6NRyu2CR7Bjs32x

Bug: 286247080
Test: Manual on a physical device
Change-Id: I00daff8341e4d8f5d141b5e0220726f6c03b437c
2023-07-05 17:29:52 -04:00
Jeremy Sim 66ec0f6a28 Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev 2023-07-05 21:22:22 +00:00
Jeremy Sim 3137f65dcc Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev 2023-07-05 21:22:12 +00:00
Fengjiang Li 1519c168da Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
This CL ensures no inflation of BubbleTextView happens while binding applications, and reduces jank on slow device.

1. Let active/inactive all apps RVs share the same AllAppsRecyclerViewPool
2. Use worker thread to pre-inflate BubbleTextViews and add them to shared view pool on main thread

Bug: 287523421
Test: See before/after screenshot/video/trace attached in bug
Change-Id: I00213407be2c7c2d329997552785d0aa56c4d057
2023-07-05 13:07:26 -07:00
Fengjiang Li 1acda93e26 Fix calculation of all apps recyclerview pool size of app icons
grid.numShownAllAppsColumns is the column size of all apps, whereas mNumAppsPerRow is the column size of workspace, we should use the former one to calculate num of all apps icons

Bug: 287523421
Flag: N/A
Test: Open all apps from launcher and taskbar and scroll it, Expect scorlling works without jank.
Change-Id: Ife488e5853c84f6cc94e1e9e7edae67844275439
2023-07-05 13:07:18 -07:00
Liran Binyamin 3c81efd136 Ensure overflow isn't selected when bar is collapsed am: 16b05e251b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23900933

Change-Id: I19c19e06e387ce56a78d10b8251edf8449ceb989
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 19:15:12 +00:00
Liran Binyamin 16b05e251b Ensure overflow isn't selected when bar is collapsed
After the bubble bar collapsing animation completes, and reordering
is finished, if the bubble overflow is selected, update the selected
bubble to be the first bubble. This ensures that the overflow
is not selected the next time the bubble bar is expanded.

This is done through a callback from the BubbleBarView to the
BubbleBarController with the key of the first bubble. Ideally the view
would just notify that the selected bubble needs to be updated, but
the controller doesn't hold ordering info.

Fixes: 289280431
Test: manual
       - Add 2 bubbles to the bubble bar
       - Expand the bubble bar. The first bubble A should be selected
       - Select the second bubble B
       - Select the overflow
       - Tap on the overflow again to collapse the bubble bar
       - Tap on the bubble bar to expand it
       - Observe that bubble B is first and selected
Change-Id: I0f9c2d628cfaf3a80da55ff634284687425e949a
2023-07-05 12:20:46 -04:00
Tracy Zhou b3f8477b94 Add initial trackpad tapl tests am: 323958007d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23744485

Change-Id: I76bf5d89ac5b141aad398ff62b3483535a0d6fc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-03 20:28:39 +00:00
Tracy Zhou 323958007d Add initial trackpad tapl tests
- go home

Bug: 281732733
Test: presubmit
Change-Id: I538d63bde2bf427a02c2bc355eab71546d667bf9
2023-07-03 10:50:54 -07:00
Jagrut Desai 491eb03668 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 491b0f9028
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I1f51078eb6167d5dde01df2918abd8abdd3a8a45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 00:34:51 +00:00
Jagrut Desai ca6ef7e29a Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: 982dacc7ef am: 4fc44d56a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I18c2abbb984f1ef9c8c649d554116d522e2340a4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 00:30:44 +00:00
Jagrut Desai 9f3a115ab0 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 62dd220b69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I616ad6bb87381eca5b452ddadd460d35f4b71414
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 00:29:18 +00:00
Jagrut Desai 4fc44d56a9 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: 982dacc7ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I686be2553533fbec2b6c45af460fa482580bb500
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:47:47 +00:00
Jagrut Desai 491b0f9028 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I9d438b3edda25a7407d30d702013b385b3fd9195
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:47:37 +00:00
Jagrut Desai 62dd220b69 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I2c06c2637c4d7fefab71ea87af677b210cd2829c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:45:46 +00:00
Jagrut Desai 982dacc7ef Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I5c4b401023efb9cd5fcdbff50819dc95ad6cc4c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:06:12 +00:00
Jagrut Desai d4b4e95bea Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I33a1ec0e54a662878f981bd599abb3f1d5c6f105
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:05:06 +00:00
Jagrut Desai fa2a81844f Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev 2023-06-30 22:29:20 +00:00
Treehugger Robot 5e23c3025d Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 957d46ae52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I61abe7d28129799ee0e39c289c5fa29b92d95e77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:53:19 +00:00
Treehugger Robot e2529cecff Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4264a7d135 am: c44ae73e4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: Ia6526b05a6ab2f57cc44ffa3979c7a8c2a2697fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:30:34 +00:00
Treehugger Robot dd262b4617 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 120c78d24f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I852fc4d1f95af8ef5be6fa02dd1d1d404b8cd92a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:28:58 +00:00