Commit Graph

66867 Commits

Author SHA1 Message Date
Pinyao Ting 0cbaac7071 [automerger skipped] RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut am: 602cb48c72 -s ours am: 3af7bdccdc -s ours am: 295daf7aef -s ours am: 1c9212cf5d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24815763

Change-Id: I42684d8fc64e11a147c6268e330556056976646b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 20:42:21 +00:00
Pinyao Ting ea1f766f39 [automerger skipped] RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut am: 602cb48c72 -s ours am: 3af7bdccdc -s ours am: 1fdcc23b3e -s ours am: 13c1424357 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24815763

Change-Id: I5e166c30de10fd70e5cf4f06cb3701ca65250683
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 20:41:39 +00:00
Pinyao Ting 1c9212cf5d [automerger skipped] RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut am: 602cb48c72 -s ours am: 3af7bdccdc -s ours am: 295daf7aef -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24815763

Change-Id: I887f0204bced3005cdee92c938cb5e0eb8367c1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 19:59:50 +00:00
Pinyao Ting 13c1424357 [automerger skipped] RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut am: 602cb48c72 -s ours am: 3af7bdccdc -s ours am: 1fdcc23b3e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24815763

Change-Id: I840e275aa978c9fd6a248977d4c0985805caa00f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 19:58:44 +00:00
Pinyao Ting 1fdcc23b3e [automerger skipped] RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut am: 602cb48c72 -s ours am: 3af7bdccdc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24815763

Change-Id: I3f079cc77a1cce9c4c280addcf565db40722f026
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 18:59:03 +00:00
Pinyao Ting 295daf7aef [automerger skipped] RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut am: 602cb48c72 -s ours am: 3af7bdccdc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24815763

Change-Id: I351427406e330ec18c4515f598ee6e3b6160b6b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 18:55:17 +00:00
Felix Stern db1028ea85 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev am: 795dc83c72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24834321

Change-Id: Iec4d3327d606cf5d607b8b68d7c640e737199d72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 18:07:44 +00:00
Pinyao Ting 3af7bdccdc [automerger skipped] RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut am: 602cb48c72 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24815763

Change-Id: I4dd589969dfb00163fdfbc7749bcbbf6d2329e69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 17:58:54 +00:00
Felix Stern 795dc83c72 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev 2023-09-22 17:04:19 +00:00
Brandon Dayauon f9a203c586 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: Ibbefedc8e85690aa7a389b0e106476d56d0d768b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 15:25:17 +00:00
Brandon Dayauon 28ae77df37 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev 2023-09-22 14:36:45 +00:00
Cosmin Băieș df2ceac06c Use stashedTaskbarHeight for IME insets override
Previously [1] we removed the explicit insetsSizeOverride from the
Taskbar for the IME window, as we now [2] enable hiding the IME nav bar.
This would now send the normal insets the taskbar reports. When running
on pre/postsubmit, with test harness setup, the non-transient taskbar
would show, which is bigger than the IME's navigation bar height.

Due to the current logic in InsetsSource#calculateInsets, this leads to
the IME window receiving top navigation bar insets instead of bottom.
As the IME nav bar is now treated as a (fixed on bottom) caption bar,
the two would no longer overlap, and thus lead to a double insets
dispatch, and also a (temporarily) bigger IME window, for IMEs that set
their decorView height to WRAP_CONTENT (e.g. MockIME used in testing).

This instead keeps the previous insetsSizeOverride for IME, and uses the
stashedTasbarHeight when in gesture nav, which should account for both
transient and normal taskbars.

 [1]: I86079cb6670a2ae3b6fa883694f8af81df212408
 [2]: I8793db69fb846046300d5a56b3b0060138ef4cd5

Bug: 297000797
Test: atest WindowInsetsControllerTests#testDispatchApplyWindowInsetsCount_ime
Change-Id: I102a8bc1f8869ebbce9f8f1fefa651d49a9538ec
2023-09-22 14:16:03 +00:00
Federico Baron 3918b8c76c Merge "Shortcut crash fix" into udc-qpr-dev am: 9bbb0c7522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24820706

Change-Id: I2c7404aa918938063f248ab9e967a3d50a21258f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 20:28:56 +00:00
Federico Baron 9bbb0c7522 Merge "Shortcut crash fix" into udc-qpr-dev 2023-09-21 19:25:25 +00:00
Uwais Ashraf 8dd54b27f1 Merge "Set taskbar heights to 0 when taskbar is not present." into udc-qpr-dev am: d295e3510a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24759056

Change-Id: I264b4f4cc0ce92f3140759fb6d3305f9018caa6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 16:55:57 +00:00
randypfohl 1c76ccfd6c Setting recentsView orientation to match recents activity orientation am: 03d29305ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I12f07376447009d58ee7519b9cd7433ac544191a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 16:51:04 +00:00
Uwais Ashraf d295e3510a Merge "Set taskbar heights to 0 when taskbar is not present." into udc-qpr-dev 2023-09-21 16:39:10 +00:00
fbaron d87178460c Shortcut crash fix
Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.

Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
2023-09-21 05:53:45 +00:00
randypfohl 03d29305ca Setting recentsView orientation to match recents activity orientation
Test: can no longer repro incorrect orientation when launching apps from all apps
      added logs to verify recents activity -> view were the same while rotating
      turned off auto rotate and verified state matched

Bug: 288984663
Bug: 301024104

Change-Id: I7fc3b47bff0a99756aaf877bf634e2d162838d6f
2023-09-20 15:04:55 -07:00
Pinyao Ting 602cb48c72 RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut
Intent created for Chooser should not be allowed in legacy shortcuts
since it doesn't make sense for user to tap on a shortcut in homescreen
to share, the expected share flow started from ShareSheet.

Bug: 295334906, 295045199
Test: manual
Change-Id: I8d0cbccdc31bd4cb927830e5ecf841147400fdfa
2023-09-20 21:47:17 +00:00
Brandon Dayauon 47000ae6e6 Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW
- Create another icon, "all_apps_predicted_row_icon" that will be the mDisplay for the predicted app row
in AllAppsList

Bug:299171695
Test: video
Before: https://drive.google.com/file/d/1HxNW0015nQHCc7eQiySf-gwsHrLs_JjR/view?usp=sharing
after: https://drive.google.com/file/d/1HyEwKI-yumILTCjglKcqovhTlRVjNGxg/view?usp=sharing - making sure that QL is fine and dragging regular Toast results are normal
Flag: N/a
Change-Id: Ie002cacb168396dbea39f79679bd6a04b80e374b
2023-09-20 14:21:10 -07:00
Sunny Goyal 24d3af52e9 Fixing crash in SettingsCache am: f17b59bb19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804716

Change-Id: Ic0327d55354137aa19f21a74e0eae602419e9f44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-20 02:29:53 +00:00
Pinyao Ting 06dd1ab24d Merge "Disables local color extraction for widgets" into udc-qpr-dev am: ef9125e5cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24777924

Change-Id: If0f783a18c35265e98eb8402f0a3c07b1eb877b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 22:56:52 +00:00
Sunny Goyal f17b59bb19 Fixing crash in SettingsCache
Bug: 301119252
Test: Presubmit
Flag: N/A
Change-Id: I1356e6c6ad693cc53716603a0a2ca5efd6af5ea9
2023-09-19 22:37:51 +00:00
Pinyao Ting ef9125e5cb Merge "Disables local color extraction for widgets" into udc-qpr-dev 2023-09-19 21:48:27 +00:00
Sunny Goyal a6aa1c9466 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread am: 5b86162853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24795935

Change-Id: I9f4d5a9eb2590951fbe4091ff8050ad72f37bbd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 18:36:04 +00:00
Sunny Goyal 5b86162853 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
2023-09-18 23:04:33 +00:00
Tony Wickham e136b6a641 Finish recents animation synchronously on cancel event am: 2316dc4750
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: Ib8bd21048402db34caf681802599517b4a37cb94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-18 16:11:14 +00:00
Tony Wickham 2316dc4750 Finish recents animation synchronously on cancel event
Fixes: 300247322
Test: invoke omnient via long press nav handle
Flag: ENABLE_LONG_PRESS_NAV_HANDLE

Change-Id: I5d7cd1d0a2a50da26a881a6daa203806bf857909
2023-09-18 15:34:29 +00:00
Nicolò Mazzucato 6eb5e0892b Merge "Preload overview after unfold" into udc-qpr-dev am: 3c898a7550
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24771967

Change-Id: Ic4f1ca2b27cd408963ff33ad7972ec4d1fef5a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-18 09:53:20 +00:00
Nicolò Mazzucato 3c898a7550 Merge "Preload overview after unfold" into udc-qpr-dev 2023-09-18 08:37:56 +00:00
Pinyao Ting 88f4f2bf96 Disables local color extraction for widgets
As discovered during investigation of system health issues, doing local
color extraction in widgets (for the purpose of making their color
matches the background during a drag) took many CPU cycle during layout
pass, which may have contributed to animation janks in various scenario.
This CL removes the feature in favors of better performance.

Bug: 266941872
Test: manually verified theme are still honored in widgets.
Change-Id: I63b13bc005907779af2322cd4bedbe141b0f3e27
2023-09-16 00:13:20 +00:00
Uwais Ashraf f8da98a59b Set taskbar heights to 0 when taskbar is not present.
Fix: 289769344
Test: DeviceProfileDumpTest
Change-Id: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
Merged-In: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
2023-09-15 19:37:10 +00:00
Vinit Nayak a6f66eeba7 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev am: 8ad9393213
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24761312

Change-Id: Ib31bfdd11c5f1c62b1ffcfe24bcdd81fd4903633
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 17:24:13 +00:00
Vinit Nayak 8ad9393213 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev 2023-09-15 17:20:43 +00:00
Vinit Nayak 9b3598f154 Provide bgExecutor for RotationButtonController
Bug: 289341065
Test: Unfolded, checked perfetto trace, it
shows up not on UI thread

Change-Id: I9a080c9a5c3c57f38eb6719ed73952dde4f6bba1
2023-09-15 10:46:00 -04:00
Nicolo' Mazzucato f6264d2387 Preload overview after unfold
Before this change, the configChange was processed when launcher becomes visible. However, this happened during animations (e.g. swipe to home after unfold to app).

With this change, the onConfigChange received by TIS (so, it's received also if the activity is not visible), is used to preload overview, moving a ~100ms block to unfold instead of during the animation.

Bug: 294352799
Test: recorded a perfetto trace and checked jank decrease
Change-Id: I35a7036887cc9ea490f27d5ccd47fe423775350b
Merged-In: I35a7036887cc9ea490f27d5ccd47fe423775350b
(cherry picked from commit 11ce5f85c9)
2023-09-15 11:38:46 +00:00
Bill Yi b3debbd3f0 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev am: 025cd855b4 -s ours am: 4c053e5f6b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: Ic430a2f8aeb9c3d4712d63d2cfefaae7bce0d69b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 03:56:42 +00:00
Bill Yi b4aab39bd3 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d4b83ccdd2 -s ours am: 849137d43b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I8d23523326bdda4aa5b01e8630909d01b267e2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 03:56:29 +00:00
Bill Yi 4c053e5f6b [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev am: 025cd855b4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I4b9712ede0f7b27f9aba9aa9e7fca9c053cd7034
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 03:12:42 +00:00
Bill Yi 849137d43b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d4b83ccdd2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I37a09c005c67db3f02413cced6b7cc0bd3a1a450
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 03:12:30 +00:00
Bill Yi ba466befc1 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev am: 025cd855b4 -s ours am: cb209aed15 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: Ib0f9ba11bfb498e600b063bbeed0292426449a59
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 02:54:34 +00:00
Bill Yi c4d895d9dc [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d4b83ccdd2 -s ours am: edc976e7a9 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I0e8f7e5390ffc289f96d238b4beccfe48f73a4d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 02:54:21 +00:00
Bill Yi cb209aed15 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev am: 025cd855b4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I478f01e69efbc3cfd3f08b901bb852d8081a1136
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 02:15:32 +00:00
Bill Yi edc976e7a9 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d4b83ccdd2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I4d901ef158262f7d549cb37225daf4b8f13fae66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 02:15:18 +00:00
Bill Yi 025cd855b4 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-09-15 01:34:34 +00:00
Bill Yi e2e850837c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ff384a5c07 -s ours am: fefc1affdc -s ours am: 19db4a7207 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24743643

Change-Id: I03edc62e449064aa28d629b6bf6b1de8aef0b0df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 01:05:50 +00:00
Bill Yi 6fa872a3b3 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ff384a5c07 -s ours am: fefc1affdc -s ours am: e5e8ed942b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24743643

Change-Id: Ieeb870b6976a5b231fd7d7d2739db0f5a8a8f181
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 00:26:37 +00:00
Bill Yi 19db4a7207 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ff384a5c07 -s ours am: fefc1affdc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24743643

Change-Id: I85594c159e4b48786abeda4931dbefa49332e21d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 00:22:41 +00:00
Bill Yi e5e8ed942b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ff384a5c07 -s ours am: fefc1affdc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24743643

Change-Id: I3462c512d73cc956e2568f7574df8a221d8e4fdd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 00:14:19 +00:00