In RotationButtonController, we show the floating rotation button either when the bar is visible, or when the device is in gesture nav mode, even in an immersive app. The issue here is that mNavMode is not correctly initialized after the device is unfolded.
Fixes: 272164624
Test: Open townhall. Fold and then unfold. Tilt the device and make sure the floating rotation button shows.
Change-Id: I09025132fdca5c764e66d9ac21f29b853741d257
- Breakout CL part 3
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist removal of an option from taskbar divider popup meu which is no longer required and other changes regarding the removal like ripple.
Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Merged-In: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
Change-Id: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
- Breakout CL part 2
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of change to correct the icon layout bound calculation when taksbar divider line is present in taskbar view.
Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I259faf2cc0aa302b83337d104c4820885b925a6a
- Breakout CL part 1
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist refactoring of Taskbar Divider Line to be using IconButtonView.
Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I6719dd568986dce7cf9cdf0f287c3f079fd35ba6
This reverts commit 51a210d787.
Reason for revert: test may have been fixed before this got merged, will merge revert to confirm
Change-Id: Ib26b94af971eceb02e6bf58f39a578ee04eb72e8
This adds support for measure/layout tracing in Launcher (in sysui it has already been enabled in T)
When enabled, traces for each class measure and layout are output in
a perfetto trace. This adds some overhead, so it's disabled by default, but extremely useful for testing and debugging long doFrames.
To enable request layout tracing for a specific class X, the following helper can be used:
trace_class_layouts() {
adb shell setprop persist.debug.trace_request_layout 1
adb shell setprop persist.debug.trace_request_layout_class $1
adb shell am force-stop com.google.android.apps.nexuslauncher
adb shell am force-stop com.android.systemui
}
Then, use `trace_class_layouts X` and record a perfetto trace
e.g. `trace_class_layout BubbleTextView`
To just see class breakdown of measure/layout setting `persist.debug.trace_request_layout` is sufficient.
Test: record a trace after enabling options
Bug: 266090955
Change-Id: I4f621ebaaec6a07cd7c0693aa8876158cc60e208
The PendingAnimation gives us more flexibility than the AnimatorSet.
Test: Manual
Bug: 289290185
Flag: No
Change-Id: I3156a659098c44ce9e6b20e5e79e88742add629a
* Partial revert of ag/24139629
* Taskbar showing up where it shouldn't in gesturenav,
this change isn't behind the flag
Bug: 295047555
Change-Id: Ib36b1fed5e25c667e396291a30a68730e1daa517
Previously we reuse layout params when we switch to a new layout, but not all of the fields we reuse are reset. Due to the variety of fields we update in different layouts and the fact that it's relatively cheap to instantiate a new layout params object, let's start fresh every time.
Fixes: 295057715
Bug: 288311605
Test: put the device to landscape in small screen and then unfold, make sure that the nav buttons show in the task bar
Change-Id: I8e600c2553436f563dd4509a83cc46ce47c0114d
Taskbar All Apps will be chosen over Launcher's when we are in an app or
in overview. Otherwise, we fallback to toggling Launcher All Apps.
Test: Manual, adb shell input keyevent 117
Fix: 282111244
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I68e4cb3a80d42e233f7d9ad33fc3791b5c75d219
This logging helps understanding what's going on in Launcher main thread
during unfold from perfetto traces.
Test: Perfetto trace after unfolding
Bug: 292472402
Change-Id: I7a037d9a129deb4bfe4310fdba664b87164ef2ca
* WM checks that the number of insets don't change for
a given window once it's added. Previously when we changed
nav modes the window was removed and a new one was added, so
changing insets amounts/types didn't matter.
* Now that we use the same window and re-provide the insets,
the number of them provided have to match (insets values themselves
can change as much as needed)
* Fix minor bug when checking bit mask for gravity
Test: Switch between nav modes, no crash; no change in behavior
w/ flag turned off
Bug: 274517647
Flag: persist.wm.debug.hide_navbar_window
Change-Id: I750f843e8210ba1c800b61ac79664265924c054a
Change-Id: Idba4e8e1888fa58bf872c04cb042f77a8b5b0573
This is the third of several patches implementing the App Pairs feature behind a flag.
This patch includes:
- AppPairIcon and associated XML. Actual icon asset is placeholder for now
- Ability to launch split pair on click
- Icon can be moved around, incl. to Taskbar
- App pair can be deleted by dragging to "Remove" drop zone
- Icon persists on Launcher reload
Change-Id: I88aec6fbc814be98f9ef048bbc5af889d0797970
Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274835596
Test: Not included in this CL, but will follow
Vinit Nayak
Treehugger Robot
Tracy Zhou
Sunny Goyal
Mateusz Cicheński
Jagrut Desai
Nicolo' Mazzucato
Brian Isganitis
Matt Sziklay
Randy Pfohl
Andy Wickham
Jeremy Sim
Jon Miranda
Federico Baron