Commit Graph

49358 Commits

Author SHA1 Message Date
Schneider Victor-tulias 0844f2e8ef Return to home when overview command fails.
Returning a runnable list that doesn't get run later causes the overview command to be added to the pending command queue, but never gets removed. This causes following overview (and home on tablets) commands not to respond.

Test: forcefully caused the error condition programmatically; checked the queue is cleared and the user is sent home.
Fixes: 255851262
Change-Id: I9d2f54960c54963b1e7480a597d05911201c152b
2022-11-10 11:56:09 -08:00
Jon Miranda 1d253ac8e0 Merge "Add dark theme bg for transient taskbar." into tm-qpr-dev 2022-11-09 17:56:34 +00:00
TreeHugger Robot eaa5703f75 Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev 2022-11-09 12:27:25 +00:00
Luca Zuccarini 3d69d9bd98 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev 2022-11-09 10:19:30 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda e76c4b1a43 Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev 2022-11-08 23:54:11 +00:00
TreeHugger Robot 9297483eef Merge "Prevent rotating TaskMenuViewWithArrow for large screen" into tm-qpr-dev 2022-11-08 23:08:28 +00:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
Jon Miranda 3153cd9b97 Proposal to move Developer Options to top of Home settings if studio build.
- Increases developer efficiency by avoiding the need to scroll

Bug: 258263867
Test: manual
Change-Id: I6cb46fdd12b51f8c45017f823dd4b2458e21fc72
2022-11-08 20:50:42 +00:00
Jon Miranda 4f56f0a10b Add dark theme bg for transient taskbar.
Bug: 256052691
Test: enable dark theme, view dark taskbar
      disable dark theme, view light taskbar

Change-Id: Icf8b946fd68804a904493336063704a6584d5f0e
2022-11-08 11:19:05 -08:00
TreeHugger Robot 98f400397b Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev 2022-11-08 18:14:55 +00:00
Jon Miranda caa398ed35 Merge "Have responsive taskbar UI during swipe up gesture." into tm-qpr-dev 2022-11-08 17:53:05 +00:00
Luca Zuccarini 81f5cee2cb Fix IME sync flicker with 3-button navigation.
With keyboard sync, the dismissal is handled by the animator. Calling
hideKeyboard() on top of that causes the two signals to conflict with
each other, resulting in the visible flicker and extra delayed hiding
animation.

Fixes: 251185052
Test: manual, see videos in the bug

Change-Id: Ic12ad304ef9e4b6a51279ce18d6c09ba93bd59be
2022-11-08 17:26:46 +00:00
Alex Chau 1feadf7d81 Merge "Improve spaces for folders" into tm-qpr-dev 2022-11-08 16:51:50 +00:00
Jon Miranda 881588bfb5 Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev 2022-11-08 16:13:07 +00:00
Pat Manning e1100b904d Unstash taskbar when transitioning to fallback overview.
Update LauncherInstrumentation taskbar visibility check to include assertions in fallback launcher using OverviewObject instead of LauncherObject.

Fix: 253042501
Test: manual
Change-Id: I9f2aa228e8aa97ef8ca1a4535b7f8fcded8a4572
2022-11-08 15:07:12 +00:00
Jon Miranda 29f7474056 Have responsive taskbar UI during swipe up gesture.
- Makes taskbar threshold an absolute Y threshold
  instead of a distance threshold.
- Moves handle, taskbar view, and taskbar background
  during the swipe up gesture

Next CL will address transforming the nav handle <-> taskbar
and ensuring that there's a clean handoff

Bug: 246631059
Test: swipe up on taskbar, release. see bounce
      swipe up on taskbar to go home, proper icon alignment
      swipe up on taskbar, pause for overview, see bounce
      -> further movement should not move taskbar
      test launcher3

Change-Id: I141236fd72428cda7edd0ff116de1d478d18c722
2022-11-08 14:50:02 +00:00
Jon Miranda 92564539d2 Merge "Stash taskbar if user touch down above the gesture height." into tm-qpr-dev 2022-11-08 01:00:46 +00:00
Jon Miranda d5a6b5f688 Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
  We can address testing this functionality in a separate CL

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
Jon Miranda b0523697c6 Stash taskbar if user touch down above the gesture height.
Bug: 252905206
Test: open taskbar, tap in gesture area, confirm no stash
      open taskbar, tap on taskbar item, confirm no stash
      open taskbar, tap to the side above gesture area, confirm stash

Change-Id: Ide030840440b5f0541d0ccfb055b8a8a7e851657
2022-11-07 10:37:28 -08:00
Thales Lima b35faed6e7 Improve spaces for folders
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
2022-11-07 18:23:48 +00:00
Schneider Victor-tulias cd587212a2 Merge "Refactor recents attached to window animation to keep state handling synchronized." into tm-qpr-dev 2022-11-07 18:21:53 +00:00
Alex Chau 3cf779270b Merge "Change taskbar corner roundness when entering overview" into tm-qpr-dev 2022-11-07 18:08:22 +00:00
Nicolo' Mazzucato 2370406efb Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS
Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while going to recents
Change-Id: If33daaa22f904c928f5d4a561a7ac1a03d82b7eb
2022-11-07 16:52:32 +00:00
Alex Chau 68e7fe6b7d Change taskbar corner roundness when entering overview
- Roundness will be 0 in Launcher, and 1 in an app

Bug: 250645563
Test: With and without taskbar in overview, switch between home/overview/app and observe the round corners above taskbar
Test: Ensure corner above taskbar is correct in overview and in app when chat bubble is active
Change-Id: I1f4911626c8e79fce8d81a76a9bd0d0670d111da
2022-11-07 12:58:47 +00:00
Bill Yi 5b80c9148c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I18ae5aae8fc7d8c16db0729378b6a3921bae9b34
2022-11-06 15:04:26 -08:00
TreeHugger Robot 5602b9e0ad Merge "Waiting for the apps-unfreeze flags instead of enforcing it" into tm-qpr-dev 2022-11-05 05:23:13 +00:00
Schneider Victor-tulias 5bb69206a3 Refactor recents attached to window animation to keep state handling synchronized.
Bug: 244593270
Bug: 243471493
Test: went from from app, launched overview from app/home, started overview, then swiped to home from app/home
Change-Id: If3ce8d5d145941af3fac936be28c0fc59c18932b
2022-11-04 15:14:54 -07:00
Sunny Goyal 679ec33cc7 Waiting for the apps-unfreeze flags instead of enforcing it
Bug: 256898879
Test: Will wait for presubmit flakyness to clear
Change-Id: Ie2341338bbebfd892998e078d07d31f003ab8d43
2022-11-04 14:41:14 -07:00
Schneider Victor-tulias 345ef9ffba Merge "Improve RecentsModel log dump for ease-of-use and readability." into tm-qpr-dev 2022-11-04 18:17:51 +00:00
Ats Jenk 70d8a12c60 Merge "Clean up bubbles home gesture flag" into tm-qpr-dev 2022-11-04 17:56:17 +00:00
Sebastián Franco fda1f3c379 Merge "Making code more readable by removing global variable used for optimizations" into tm-qpr-dev 2022-11-04 17:46:22 +00:00
Sebastián Franco c3cefebab4 Merge "Ensure that the reorder preview and what gets submited uses the same solution." into tm-qpr-dev 2022-11-04 17:45:28 +00:00
Schneider Victor-tulias 0994f74f76 Merge "Update all set page navigations settings button callback" into tm-qpr-dev 2022-11-04 17:16:09 +00:00
Sunny Goyal eeaba0903a Merge "Relying on the controller state instead of animator state for icon alignment" into tm-qpr-dev 2022-11-04 15:40:17 +00:00
Jon Miranda 71370c58eb Merge "Update insets for transient taskbar" into tm-qpr-dev 2022-11-04 15:09:12 +00:00
Sunny Goyal 8d3241b359 Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev 2022-11-04 14:13:12 +00:00
Holly Jiuyu Sun 341cd8589c Merge "Update gBoard icon to Go/Search depending on suggestions." into tm-qpr-dev 2022-11-04 03:58:18 +00:00
Ats Jenk 20ed998a51 Clean up bubbles home gesture flag
Flag is enabled by default. Removing as it is no longer used.

Bug: 256873558
Test: mp launcher
Change-Id: I8cdfde754aec7b683ae9e47aa8861ddc41460a59
2022-11-03 20:22:56 -07:00
TreeHugger Robot 12aec8aa29 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev 2022-11-04 02:04:10 +00:00
Sunny Goyal 17b4e8bbda Merge "Removing unused SplitScreen bounds notification from systemUI" into tm-qpr-dev 2022-11-04 02:03:46 +00:00
Jon Miranda 7e8195081e Update insets for transient taskbar
Bug: 252905206
Test: manual
Change-Id: I03bd493dbe63274c8e90cb5e415127a1dd93e9b8
2022-11-03 17:16:48 -07:00
Holly Jiuyu Sun 15bdce40b0 Merge "Bring up IME and focus on input when scroll to top." into tm-qpr-dev 2022-11-03 23:54:31 +00:00
TreeHugger Robot a30a016191 Merge "Update active gesture error detection" into tm-qpr-dev 2022-11-03 23:29:00 +00:00
Holly Sun b0fb5096ba Update gBoard icon to Go/Search depending on suggestions.
If there is a highlight item, show Go (->) icon. Otherwise, show Search (magnifying glass) icon.

Implement maybeUpdateEnterKeyIcon() in NexusLauncher because it's gBoard specific.

Test: manual. Verify icon changes according to states.
Bug: 183467628
Bug: 210661150
Change-Id: I5dbcb54a37f9d37ae31bf3eaef241ea8a3ede510
2022-11-03 15:59:02 -07:00
Vinit Nayak 7fb1336de7 Merge "Switch to screenshot when finishing recents animation for split select" into tm-qpr-dev 2022-11-03 22:26:36 +00:00
Sunny Goyal 82379187ea Adding support for multiple overlay callbacks
Bug: 193244407
Test: Presubmit
Change-Id: Ic345972056752238e7e46226533fd8f33d664213
2022-11-03 14:37:40 -07:00
Sebastian Franco 5d990eedfd Ensure that the reorder preview and what gets submited uses the same solution.
Design doc: https://docs.google.com/document/d/1RsId9OFGgkcImkkmDwWZBBvITWnGlxKVqniE3cimkqY/edit#heading=h.xzptrog8pyxf

As can be seen in the diagram in b/256770363 on every reorder the
first call in the process is MODE_SHOW_REORDER_HINT so if we make
sure that only then a solution is calculated and we reuse that
solution in the rest of the calls in the same reorder then we would
have more consistency and the animation will always be the same and
the logic state.

Fix: 256770363
Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I93a1d09f5b8cbfbc461043ee3fc41b1cab294fed
2022-11-03 14:11:01 -07:00
Sunny Goyal 774dcd06ae Relying on the controller state instead of animator state for
icon alignment

Bug: 246644619
Test: Presubmit
Change-Id: Iaa4ddd94a6d85acb9f8501263665ea78394815de
2022-11-03 13:42:09 -07:00
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00