Commit Graph

32760 Commits

Author SHA1 Message Date
Jon Spivack 02bbd80ee9 NIU Actions: More specific permissions error codes
The user must enable two different Assistant permissions for the NIU Actions feature to function. Previously, a single error code was sent if either permission was missing. Now a different code is sent depending on which permission is missing, allowing Google Go to better direct the user to the proper setting.

Bug: 191109150
Test: Manual (Pixel 3A)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: Id301ffddf36b992b5722c52ccc6e597e003942dd
2021-06-21 16:49:40 -07:00
Brian Isganitis fe139cdf69 Merge "Revert "Fix home settings landing page"" into sc-dev 2021-06-21 19:27:24 +00:00
Schneider Victor-tulias 689d69572b Merge "Update All set screen icon" into sc-dev 2021-06-21 17:35:15 +00:00
Stevie Kideckel e03784478d Merge "Add spacing between items as decorations instead of margins" into sc-dev 2021-06-21 16:47:30 +00:00
Steven Ng 95c969530c Merge "Copy minSpanX & minSpanY when copying from an existing ItemInfo" into sc-dev 2021-06-21 16:20:39 +00:00
Stevie Kideckel ded80076db Add spacing between items as decorations instead of margins
There are bugs in the accounting for the margins if we manipulate the
view directly, causing the wrong top to be reported and the view to be
shifted when we call scrollToPosition. Item decorations ensure that the
layout system for the recycler view always has the right details about
the spacing.

Fix: 191642682
Test: verified locally
Change-Id: Ie80563757079e885c8178883ab16e314d01c5b32
2021-06-21 15:11:33 +00:00
Steven Ng 7b27e7d061 Copy minSpanX & minSpanY when copying from an existing ItemInfo
Test: Drop Gmail widget to home screen and configure it. Then, drop
      the widget to a home screen that doesn't have sufficient space
      to accommodate it. The gmail widget can't be dropped to that
      home page and is returned to its original position.
Fix: 190582606
Change-Id: I177c09562d059b658e835cbb7fdde0d7bc6565d2
2021-06-21 15:38:26 +01:00
Stevie Kideckel 61bc5c6c93 Merge "Fix bug in equals implementation for search headers" into sc-dev 2021-06-21 12:56:17 +00:00
Stevie Kideckel e99f3c9666 Fix bug in equals implementation for search headers
Fix: 191626327
Test: verified locally
Change-Id: I8103059a2759a8533581ff86cb57b28913cf5731
2021-06-21 10:42:16 +00:00
Jonathan Miranda f9df8f3682 Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev 2021-06-20 22:46:46 +00:00
Bill Yi 5ca92844d5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If4193b7d4f8ad8cd70c3ff2e771e48d51cdfb2b2
2021-06-20 03:57:28 +00:00
TreeHugger Robot aafb391b39 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-06-19 04:44:58 +00:00
Jonathan Miranda 1bfd350ead Merge "Update notification popup UI." into sc-dev 2021-06-19 03:52:23 +00:00
Bill Yi 3010277cd6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I33f33183171d4a849e00627d4cbd747cace04851
2021-06-19 03:16:22 +00:00
Brian Isganitis aefcc5a300 Revert "Fix home settings landing page"
This reverts commit 96cc3c533c.

Reason for revert: Causes back to close sub-settings (b/191257243).

Change-Id: I3aa01bed1d73874176fc2568bac4ca714e9f2df7
Bug: 188565060
2021-06-18 23:46:20 +00:00
Jon Miranda 313b2c2d28 Update notification popup UI.
- Update UI to match specs.
- Only shows one notification (removed footer, animation code)

Bug: 175329686
Bug: 190402054
Test: open popup, dismiss notification from shade,
      open popup, click on notification
      checked RTL

Change-Id: I92672f94233d986ae5b5c54979980967308cb156
2021-06-18 22:42:44 +00:00
Jon Miranda 651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Stevie Kideckel dd19a24769 Merge "Load widget preview images before adding the rows to the adapter" into sc-dev 2021-06-18 22:37:32 +00:00
Schneider Victor-tulias 4ef6bd5a7a Update All set screen icon
Fixes: 191463446
Test: Manual
Change-Id: I746bfb2eab950a01041493bd72d7dda30ac66d7b
2021-06-18 15:36:23 -07:00
Jonathan Miranda 576179199a Merge "Fix bug where ripple extends out of bounds in pop up container." into sc-dev 2021-06-18 22:27:45 +00:00
Jon Miranda f13ddbd333 Fix bug where ripple extends out of bounds in pop up container.
Bug: 186820908
Test: test apps with diff. pop up container arrangements
      test prefs in all apps

Change-Id: I4d3e26871416835ab2a851fcc6fe2c4f70235b62
2021-06-18 20:58:14 +00:00
Stevie Kideckel a093523299 Load widget preview images before adding the rows to the adapter
This allows for smooth animations as the items will have their full
height resolved

Bug: 190892517
Test: verified locally
Test: CachingWidgetPreviewLoaderTest
Change-Id: I86afc6951a4cc82ae45e63795791d259a3bb3cda
2021-06-18 19:18:29 +00:00
Samuel Fufa f44a9ca6f0 Merge "Allow AllApps to restore current selected tab on activity recreate" into sc-dev 2021-06-18 17:57:08 +00:00
TreeHugger Robot 2af9d27116 Merge "Revert "Deduct padding from widget size only if padding has been inset"" into sc-dev 2021-06-18 11:11:20 +00:00
Steven Ng 21780405ac Merge "Log widget dimensions before deleting a widget violating min size" into sc-dev 2021-06-18 10:21:32 +00:00
Steven Ng 54b5424548 Revert "Deduct padding from widget size only if padding has been inset"
This reverts commit 71cefb593f.

Reason for revert: The default padding is added by the framework not the launcher. We really need to subtract padding from the size.

Bug: 190498032
Change-Id: If7f164da34aec3d8e022ef2c752b72292cca0489
2021-06-18 09:37:44 +00:00
Steven Ng be397e85e8 Merge "Use relative bounds for app widget color extraction" into sc-dev 2021-06-18 09:01:25 +00:00
TreeHugger Robot b8ad5cb643 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-06-18 01:32:01 +00:00
TreeHugger Robot 0877cdab7a Merge "Ensure widgets header is out of the gesture region before clicking" into sc-dev 2021-06-18 00:56:52 +00:00
Steven Ng 058308098b Use relative bounds for app widget color extraction
Fix 2 bugs in this CL
1. Before this CL, getBoundsForViewInDragLayer returns absolute bounds
   for widgets. What we want is the bounds of a widget when it is
   visible in the drag layer. ViewGroupFocusHelper#viewToRect has
   taken PagedView into account. This makes it a prefect candidate to
   calculate relative bounds of a widget.
2. requestLayout at the end of endDrag is problematic due to the drop
   animation. If the drop animation is still in progress when onLayout
   is called, the bounds of the widget isn't final. Since the color of
   app widget right before is already the final color. We don't really
   need to update the color extraction.

Test: Set the wallpaper and clock widget according to the bug. Then,
      reboot the device. The clock widget color shown right after
      reboot is the expected color. Long pressing the widget doesn't
      cause a color change.
Fix: 191114337
Change-Id: I466c8102dba0e5b207b3768e0935472cbd523235
2021-06-17 23:25:57 +01:00
Samuel Fufa e79b469986 Allow AllApps to restore current selected tab on activity recreate
This CL also fixes:

- Wrong tab selection on RTL
- Fixes header protection hydraulic scroll issue
- Work toggle button text background contrast

Bug: 186005219
Bug: 191250799
Bug: 191227662
Bug: 191349226
Test: Manual
Change-Id: I3777474c954ed0d542ac38ff552367904be147d3
2021-06-17 16:59:56 -05:00
Bill Yi 5f5b2e2558 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie7cf7ee0a2fc1095e8e59bd41c7ebc5e0fec3678
2021-06-17 21:32:13 +00:00
Vadim Tryshev 26cd946f29 Merge "Improving diagnostics when Launcher dies while in ContentProvider call" into sc-dev 2021-06-17 21:02:24 +00:00
Steven Ng b50d747d20 Log widget dimensions before deleting a widget violating min size
Test: N/A
Bug: 191223844
Change-Id: Id909ee19be1a1c7d70a09643422d9ed62a2d82a9
2021-06-17 21:13:17 +01:00
Samuel Fufa efa5df380c Merge "Refactor FolderInsetAnimationCallback to be used with any view" into sc-dev 2021-06-17 18:48:49 +00:00
Zak Cohen 1d5debd60d Merge "Suppress ViewInflationDuringSwipeUp test." into sc-dev 2021-06-17 18:34:29 +00:00
Tony Wickham d410a2c168 Ensure widgets header is out of the gesture region before clicking
This way, NexusLauncher won't appear during the Launcher3 test.

Test: AddConfigWidgetTest#testConfigCancelled
Bug: 188450580
Change-Id: Iedf0e0e17eab2473ecd2d17a4391cf9db3e80599
2021-06-17 17:49:54 +00:00
Winson Chung caabfa1519 Merge "Do some additional cleanup when switching handlers" into sc-dev 2021-06-17 16:48:42 +00:00
zakcohen 360489ff51 Suppress ViewInflationDuringSwipeUp test.
Test is failing on a subset of devices with a memory leak in an activity.
This is not repoing on other devices so could be a problem with the setup
rather than the code.

Bug: 190618549
Test: Local
Change-Id: I9c6a56432d1b1f59c337bf34e7b8c26befeb2d7d
2021-06-17 09:46:56 -07:00
Stevie Kideckel 10d4edade1 Merge "Refresh widgets in the model when packages change" into sc-dev 2021-06-17 15:04:01 +00:00
Stevie Kideckel 69af278f8a Refresh widgets in the model when packages change
Fix: 191163748
Test: local sample app
Change-Id: Ic09ad11cabf6efa471fb6e685cb255c4a17493ee
2021-06-17 13:08:53 +00:00
Steven Ng 6ce6922c14 Merge "Deduct padding from widget size only if padding has been inset" into sc-dev 2021-06-17 11:00:33 +00:00
Yogisha Dixit 3287dd9fa7 Merge "Center drop target icons in landscape mode." into sc-dev 2021-06-17 09:34:42 +00:00
Steven Ng 1184a03b08 Merge "Modify AT_LEAST_S check to include SDK int" into sc-dev 2021-06-17 09:09:21 +00:00
Steven Ng e8772c1659 Merge "Fix PendingWidgetHostView overlapping UI" into sc-dev 2021-06-17 09:08:15 +00:00
TreeHugger Robot ea95f88361 Merge "Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events." into sc-dev 2021-06-17 06:08:09 +00:00
TreeHugger Robot 4f257655bd Merge "Add logging for tapped on 'Turn on/off work apps' button in all apps" into sc-dev 2021-06-17 05:25:49 +00:00
TreeHugger Robot 3115a4380b Merge "Fix broken app icon on restart during install." into sc-dev 2021-06-17 01:11:53 +00:00
Thiru Ramasamy 95b09f9067 Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events.
Bug: 178562918
Test: Manual
Change-Id: Id32b621c0f506bba4378f6f6b81d7cfece3cb373
2021-06-17 00:05:56 +00:00
Thiru Ramasamy 6f0e75740f Add logging for tapped on 'Turn on/off work apps' button in all apps
Bug: 190050582
Test: Manual
Change-Id: Ib83fba6dc9199ba40a500e0743c0e64cc4d4d0a0
2021-06-16 17:03:49 -07:00