Commit Graph

21017 Commits

Author SHA1 Message Date
Pinyao Ting 01c80d7a00 Revert "fetch and update shortcut icons in background thread"
This reverts commit 4ec390e490.

Reason for revert: the code change introduces significant delay when saving deep shortcut icons in cache.

Bug: 142514365
Change-Id: If7a69844aba7f32690ff347f2db11f0a8041b9e4
2019-10-16 20:51:22 +00:00
Pinyao Ting 4ec390e490 fetch and update shortcut icons in background thread
Bug: 141568904
Test: Manually verified use cases from following call-site (with and
without delay)

LauncherAppsCompatVO
  1. (Custom Shortcut) Long click on google maps -> widgets ->
     drag driving mode to workspace.
  2. Open chrome -> add to home screen -> add -> add automatically.

InstallShortcutReceiver
  Removed the line that trigger above flow for android O and above,
  then open chrome -> add to home screen -> add -> add automatically.

ShortcutDragPreviewProvider
  qdb -> long press on suggested app that has deep shortcut -> drag
  to workspace.

Change-Id: I59a4d004913a8df697af1fcfe0a080b6da01eefd
2019-10-15 09:54:09 -07:00
Pinyao Ting 28dc8de660 Revert "Revert "Revert "Revert "cache shourtcut image""""
This reverts commit 52908c9adc.

Reason for revert: roll-forward and fixes the crash due to access icon cache on main thread

Bug: 141568904
Change-Id: I1274db349c4f508d9cf59735b5f15180bb0ec033
2019-10-15 09:54:09 -07:00
TreeHugger Robot 208f2018fb Merge "Tracing to determine why the model doesn't load" into ub-launcher3-master 2019-10-15 02:21:27 +00:00
vadimt 54e0c9e49c Tracing to determine why the model doesn't load
Bug: 142514365
Change-Id: I30ecaec5a5d0868db10157c61a2a8d7dd12872ca
2019-10-14 18:39:10 -07:00
Andy Wickham 2dd6bea5e6 [automerger skipped] Merge "Fades out Assistant when entering Overview." into ub-launcher3-qt-future-dev
am: bdf1687f57 -s ours
am skip reason: change_id Ia53c2407c82725c776f27b0d6e80a34554b4a303 with SHA1 68e01dda46 is in history

Change-Id: If01f0ac2dd97e86d647520af80996372ee982371
2019-10-14 17:09:11 -07:00
Andy Wickham bdf1687f57 Merge "Fades out Assistant when entering Overview." into ub-launcher3-qt-future-dev 2019-10-14 23:46:32 +00:00
Andy Wickham fb578e4528 Fades out Assistant when entering Overview.
This makes the transition smoother, since
the Assistant goes away at the end of it.

Note this only applies to the transition
while an app other than Launcher is live.

Before: https://drive.google.com/open?id=18SOWTtTUzt19TReAYnofQLIShJ2I-odP
After: https://drive.google.com/open?id=1hqsikXSlCnSvNg0ZQYHxP-OIbS5yt9aW

Bug: 136282913
Change-Id: Ia53c2407c82725c776f27b0d6e80a34554b4a303
Merged-In: Ia53c2407c82725c776f27b0d6e80a34554b4a303
Tested: Manually
2019-10-14 16:04:33 -07:00
TreeHugger Robot 6a3a09940f Merge "Fades out Assistant when entering Overview." into ub-launcher3-master 2019-10-14 22:43:26 +00:00
Andy Wickham 68e01dda46 Fades out Assistant when entering Overview.
This makes the transition smoother, since
the Assistant goes away at the end of it.

Note this only applies to the transition
while an app other than Launcher is live.

Before: https://drive.google.com/open?id=18SOWTtTUzt19TReAYnofQLIShJ2I-odP
After: https://drive.google.com/open?id=1hqsikXSlCnSvNg0ZQYHxP-OIbS5yt9aW

Bug: 136282913
Change-Id: Ia53c2407c82725c776f27b0d6e80a34554b4a303
Tested: Manually
2019-10-14 15:33:59 -07:00
TreeHugger Robot 6c12641bee Merge "Unifying various tracing calls" into ub-launcher3-master 2019-10-14 22:29:59 +00:00
Sunny Goyal 17c72fbb60 Unifying various tracing calls
Change-Id: Iedf6662ad1d7281b850bdc43b3a1e373ce535ac6
2019-10-14 14:23:19 -07:00
Tony Wickham 2f767469ae Merge "Add tests for quick switch from an app and home" into ub-launcher3-qt-future-dev
am: 7a2076e3ab

Change-Id: Id525dae6616757688ccf0e203fefeb9bd6ef08ff
2019-10-14 12:20:37 -07:00
Sreyas Rangaraju 413b0defc0 [automerger skipped] Merge "Create hooks for Recents Card plugin. This adds another card in the Recents Overview space which can show various items." into ub-launcher3-qt-future-dev
am: 65d208211d -s ours
am skip reason: change_id Ifc36639ece8aa6b554bdbd3256f4195b1b220d68 with SHA1 59b148a440 is in history

Change-Id: I67b3ec9b2a9643cadbf5a250aeea7f37c37b07b4
2019-10-14 12:14:49 -07:00
Tony Wickham 7a2076e3ab Merge "Add tests for quick switch from an app and home" into ub-launcher3-qt-future-dev 2019-10-14 19:07:37 +00:00
TreeHugger Robot e1c8f87c46 Merge "Adding tracing for a lab-only flake" into ub-launcher3-master 2019-10-14 18:52:42 +00:00
Tony Wickham 1e73e320b7 Add tests for quick switch from an app and home
Bug: 140252765
Change-Id: I5621b614ae2d8cd3db03cae818cf8b8c1c6cb20f
2019-10-14 11:51:19 -07:00
Sreyas Rangaraju 65d208211d Merge "Create hooks for Recents Card plugin. This adds another card in the Recents Overview space which can show various items." into ub-launcher3-qt-future-dev 2019-10-14 18:41:19 +00:00
vadimt ce25a2bf68 Adding tracing for a lab-only flake
Bug: 142514365
Change-Id: I9c93ecabbcbad6d4683d595587831d8465e62ee8
2019-10-14 11:34:38 -07:00
TreeHugger Robot d2b03972f5 Merge "Suppress ViewInflationDuringSwipeUp test." into ub-launcher3-master 2019-10-14 18:10:34 +00:00
Zak Cohen eb27edffc2 Suppress ViewInflationDuringSwipeUp test.
Test is failing and blocking drop.
Only failing on TH, passing locally.
Tracked in b/141579810

Bug:141579810
Change-Id: Iadf8098cad22835b026984c0a9ea5122054b484b
2019-10-14 10:55:15 -07:00
TreeHugger Robot 4be6169d4e Merge "Fix test bug where launcher throws NPE because it isnt loaded yet." into ub-launcher3-master 2019-10-14 17:49:41 +00:00
TreeHugger Robot 4009493f3c Merge "Wait for the task to be in recents before validation" into ub-launcher3-master 2019-10-12 00:20:10 +00:00
Winson Chung c062580b5a Wait for the task to be in recents before validation
- There are two issues:
  1) Currently the system does not add the task to the task list until
     the activity starting the task has been resumed (to be fixed in a
     follow up platform CL). When the three activities are started in
     sequence, it's possible for one of the activities to not reach the
     resumed state leading to an unexpected number of recent tasks the
     next time it's fetched.
  2) When swiping up, it may take time for getTasks to return and call
     applyLoadPlan, so try and wait until the task views have had a
     chance to be applied before continuing.
  3) Use the launcher activity tracker instead of activity rule since it
     will return the same activity even after the activity is destroyed
- Move the margin handling to the caller instead of the scroll method

Bug: 141580748
Change-Id: I2b7634f5ac6869ba4b369b3bd60e0f63747c0f0b
2019-10-11 17:10:38 -07:00
Sreyas 8e02d17fa2 Create hooks for Recents Card plugin.
This adds another card in the Recents Overview space which can show various items.

Change-Id: Ifc36639ece8aa6b554bdbd3256f4195b1b220d68
Merged-In: Ifc36639ece8aa6b554bdbd3256f4195b1b220d68
2019-10-11 21:05:08 +00:00
Sreyas Rangaraju 9b2ae4c244 Merge "Create hooks for Recents Card plugin. This adds another card in the Recents Overview space which can show various items." into ub-launcher3-master 2019-10-11 21:03:31 +00:00
Jon Miranda 4d6038e63a Merge "Wait until listeners/end runnable is created before checking icon result." into ub-launcher3-qt-future-dev
am: 3d97fdcfdf

Change-Id: I22b11d50b86da3e50726dada351797a5774f3b3f
2019-10-11 11:53:30 -07:00
Sreyas 59b148a440 Create hooks for Recents Card plugin.
This adds another card in the Recents Overview space which can show various items.

Change-Id: Ifc36639ece8aa6b554bdbd3256f4195b1b220d68
2019-10-11 11:48:22 -07:00
TreeHugger Robot 3d97fdcfdf Merge "Wait until listeners/end runnable is created before checking icon result." into ub-launcher3-qt-future-dev 2019-10-11 18:37:59 +00:00
Bill Yi a55d0e79b4 [automerger skipped] Import translations. DO NOT MERGE am: 76b2775eee -s ours am: 3b4c152218 -s ours
am: 31bb57db5b -s ours
am skip reason: subject contains skip directive

Change-Id: Ibd43c74b6da117af92ab6c208d6d3f9adb94bbd9
2019-10-11 11:17:47 -07:00
Bill Yi c131d69bde [automerger skipped] Import translations. DO NOT MERGE am: e72b993b91 -s ours
am: bb9d555305 -s ours
am skip reason: subject contains skip directive

Change-Id: Ibc5eac1dcc31f89424644f8ce3bcf57481313d1e
2019-10-11 11:17:24 -07:00
Bill Yi 31bb57db5b [automerger skipped] Import translations. DO NOT MERGE am: 76b2775eee -s ours
am: 3b4c152218 -s ours
am skip reason: subject contains skip directive

Change-Id: I2d99bb4269806a217a23c9c212888c725ba75c39
2019-10-11 11:12:45 -07:00
Bill Yi bb9d555305 [automerger skipped] Import translations. DO NOT MERGE
am: e72b993b91 -s ours
am skip reason: subject contains skip directive

Change-Id: I3a5a43d20969a1cef2170edc3be725aa9efb9a4d
2019-10-11 11:12:23 -07:00
Bill Yi 3b4c152218 [automerger skipped] Import translations. DO NOT MERGE
am: 76b2775eee -s ours
am skip reason: subject contains skip directive

Change-Id: If89a18a90a0f7a869340890b22410c25286baf81
2019-10-11 11:10:21 -07:00
Jon Miranda 1dd2e48190 Wait until listeners/end runnable is created before checking icon result.
This prevents the case where original icon is in hidden state, then the
view gets recycled and since there is no listener/end runnable the original
icon is left in the hidden state.

Bug: 142120338
Change-Id: I5f5bfa2a7c70d10869f51edf5c40bbaab1ef93bc
2019-10-11 11:03:26 -07:00
Bill Yi 20ae6826e8 [automerger skipped] Import translations. DO NOT MERGE
am: e2c21704eb -s ours
am skip reason: subject contains skip directive

Change-Id: I314f9f020aa0aadaaee6560083ec807f323d02ba
2019-10-11 10:52:21 -07:00
Bill Yi e2c21704eb Import translations. DO NOT MERGE
Change-Id: I2ce1448b6a7ee5cb455a2fc044336c37e03093aa
Auto-generated-cl: translation import
2019-10-11 08:19:31 -07:00
Bill Yi e72b993b91 Import translations. DO NOT MERGE
Change-Id: Ie268b67529ed9728f79745402d430d007f0f3286
Auto-generated-cl: translation import
2019-10-11 08:15:45 -07:00
Bill Yi 76b2775eee Import translations. DO NOT MERGE
Change-Id: I9dc5e28b5460a89b6b43f114aa4462f65f834d50
Auto-generated-cl: translation import
2019-10-11 08:11:57 -07:00
Winson Chung c039634c25 Workaround for failing test & fix scrolling in tests
- Workaround issue where instrumentation will fail to finish an activity
  causing the activity to linger longer than expected (leading to issues
  with ordering of static resources like the app widget host registration)
- Fix calculation for scrolling the screen, the previous calculation
  would result in the gesture starting at the left gesture margin due
  to rounding which can trigger a back action instead of the desired
  scroll

Bug: 142351228
Change-Id: I34bdb471030518d2b983cac2badd4d8b0e7d571b
2019-10-10 17:31:38 -07:00
TreeHugger Robot 012fbc78b4 Merge "Using SpringAnimationBuilder instead of SpringObjectAnimator in StaggeredWorkspaceAnim" into ub-launcher3-master 2019-10-08 22:53:50 +00:00
Winson Chung d7269bf8b6 8/ Rename ActivityControlHelper
- ActivityControlHelper -> BaseActivityInterface
  LauncherActivityControlHelper -> LauncherActivityInterface
  FallbackActivityControlHelper -> FallbackActivityInterface
  QuickCaptureTouchConsumer -> QuickCaptureInputConsumer
- Move gestures to use the activity interface from the gesture state

Bug: 141886704
Change-Id: I6f12daeb03d564143404767dfe4576e3e5da2a1d
2019-10-08 13:39:13 -07:00
Winson Chung d3da92ac66 7/ Rename RecentsAnimationWrapper
- Move the recents animation classes out of util into base quickstep pkg
- Clean up some local var names

Bug: 141886704
Change-Id: I1556179e203cbb43b77ea58e6fe520aa9944099b
2019-10-08 13:30:27 -07:00
Sunny Goyal d7b9db7bda Using SpringAnimationBuilder instead of SpringObjectAnimator in StaggeredWorkspaceAnim
Change-Id: I3a7b38e3f866c95a92fbb314f0a79b0735f38c9d
2019-10-08 13:21:03 -07:00
Winson Chung 9e876a34ee 6/ Update recents animation classes to have their respective responsibilities
- RecentsAnimationTargets: manages information about the targets only
  RecentsAnimationCallbacks: manages callbacks from WM about the animation
  RecentsAnimationWrapper: manages calls into WM to update the animation
                           (to be renamed accordingly in a follow up CL)
- Create the Callbacks as a part of starting the recents animation, and
  have the callbacks create the controller wrapper and the targets, which
  are both notified to the listeners through the callbacks.
- Instead of passing through a callback for recents animation finished,
  have it be a part of the recents animation callbacks.

Bug: 141886704

Change-Id: I4ff26a175654e82efe059fa74d1f310e93961dc9
2019-10-08 13:15:15 -07:00
Winson Chung bfcee430fe 5/ Remove OverviewInteractionState
- We can move the background call to UiThreadHelper, the last sysui flags
  and back button alpha to SystemUiProxy (and dedupe values there as well)

Bug: 141886704

Change-Id: I22183608700c6d71355597c7a08eefa19f4381fd
2019-10-08 13:15:15 -07:00
Winson Chung 8ff53f7e65 4/ Move SystemUiProxy to its own singleton instead of routing through the model
Bug: 141886704
Change-Id: I415b9ef7b57b525407e3a341b946e3ca66125102
2019-10-08 13:15:13 -07:00
Winson Chung 629c87283f 3/ Move touch interaction log to its own class
Bug: 141886704
Change-Id: I5f27faf83ccacc2d2eb2914f15e860d07628c37c
2019-10-08 12:16:48 -07:00
James O'Leary 8d46a3dc00 Merge "Add feature flag + leftward swipe for Compose access." into ub-launcher3-master 2019-10-08 19:03:04 +00:00
TreeHugger Robot f31dab5e02 Merge "Removing static instance of LauncherAppsCompat and unnecessary wrapper classes" into ub-launcher3-master 2019-10-08 18:49:36 +00:00