From fa402d1da9fa892069571fbe2b5c02c74f8d957d Mon Sep 17 00:00:00 2001 From: Alex Chau Date: Thu, 25 Apr 2024 10:57:01 +0100 Subject: [PATCH] Avoid adding unnecessary topMargin to TaskThumbnails in DesktopTaskView - TaskThumbnails in DesktopTaskView already take into account topMarign during onMeasure, we should avoid adding double margin - mTaskThumbnailViewDeprecated's visibility is always GONE, so no need to set margin either Fix: 336968808 Test: manual, image test to follow-up Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT Change-Id: I6a7cb128ead0b042974b95199ab720cafc3bcc18 --- .../com/android/quickstep/views/DesktopTaskView.java | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/quickstep/src/com/android/quickstep/views/DesktopTaskView.java b/quickstep/src/com/android/quickstep/views/DesktopTaskView.java index 964f531df9..2a1b0c0b8b 100644 --- a/quickstep/src/com/android/quickstep/views/DesktopTaskView.java +++ b/quickstep/src/com/android/quickstep/views/DesktopTaskView.java @@ -38,7 +38,6 @@ import android.widget.FrameLayout; import androidx.annotation.NonNull; import androidx.annotation.Nullable; -import com.android.launcher3.DeviceProfile; import com.android.launcher3.R; import com.android.launcher3.Utilities; import com.android.launcher3.desktop.DesktopRecentsTransitionController; @@ -305,16 +304,7 @@ public class DesktopTaskView extends TaskView { @Override protected void setThumbnailOrientation(RecentsOrientedState orientationState) { - DeviceProfile deviceProfile = mContainer.getDeviceProfile(); - int thumbnailTopMargin = deviceProfile.overviewTaskThumbnailTopMarginPx; - - LayoutParams snapshotParams = (LayoutParams) mTaskThumbnailViewDeprecated.getLayoutParams(); - snapshotParams.topMargin = thumbnailTopMargin; - - for (int i = 0; i < mSnapshotViewMap.size(); i++) { - TaskThumbnailViewDeprecated thumbnailView = mSnapshotViewMap.valueAt(i); - thumbnailView.setLayoutParams(snapshotParams); - } + // no-op } @Override