fix: windows PATH setting for python configuration (#476)

fixes #474

appveyor.yml

@@ -6,7 +6,7 @@ environment:
   GITHUB_TOKEN:
     secure: 3wuEGJsppSKFvdwhp3jprUA9Zkc3WINlc/9oFXjhAR6J05lYMXP7Fl7lXTKpkGZx
 install:
-  - ps: Install-Product node 6
+  - ps: Install-Product node 8
   - yarn
 build: off
 test: off

package.json

@@ -2,7 +2,7 @@
   "name": "nexe",
   "description": "Create a single executable out of your Node.js application",
   "license": "MIT",
-  "version": "2.0.0-rc.25",
+  "version": "2.0.0-rc.27",
   "contributors": [
     "Craig Condon <craig.j.condon@gmail.com> (http://crcn.io)",
     "Jared Allard <jaredallard@outlook.com>",
@@ -46,8 +46,9 @@
     "minimist": "^1.2.0",
     "mkdirp": "^0.5.1",
     "ora": "^1.2.0",
-    "pifi": "1.0.0",
+    "pify": "^3.0.0",
     "rimraf": "^2.6.1",
+    "uglify-es": "^3.3.9",
     "uglify-js": "3.0.28"
   },
   "devDependencies": {

src/compiler.ts

@@ -31,7 +31,7 @@ interface NexeHeader {
 
 export class NexeCompiler<T extends NexeOptions = NexeOptions> {
   private start = Date.now()
-  private env = { ...process.env }
+  private env: any
   private compileStep: LogStep
   public log = new Logger(this.options.loglevel)
   public src: string
@@ -58,8 +58,13 @@ export class NexeCompiler<T extends NexeOptions = NexeOptions> {
     this.log.step('nexe ' + version, 'info')
     if (python) {
       if (isWindows) {
-        this.env.PATH = '"' + dequote(normalize(python)) + '";' + this.env.PATH
+        // Do a little shuffling to correctly set the PATH regardless of property name case sensitivity
+        const originalPath = process.env.PATH
+        process.env.PATH = dequote(normalize(python)) + ';' + originalPath
+        this.env = { ...process.env }
+        process.env.PATH = originalPath
       } else {
+        this.env = { ...process.env }
         this.env.PYTHON = python
       }
     }

src/patches/snapshot.ts

@@ -11,8 +11,9 @@ export default async function snapshot(compiler: NexeCompiler, next: () => Promi
   await compiler.replaceInFileAsync(
     'configure',
     'def configure_v8(o):',
-    `def configure_v8(o):\n  o['variables']['embed_script'] = '${snapshotFile}'\n  o['variables']['warmup_script'] = '${warmupScript ||
-      snapshotFile}'`
+    `def configure_v8(o):\n  o['variables']['embed_script'] = '${
+      snapshotFile
+    }'\n  o['variables']['warmup_script'] = '${warmupScript || snapshotFile}'`
   )
 
   return next()

tasks/ci.ts

@@ -5,9 +5,9 @@ const { env } = process
 
 export function triggerMacBuild(release: NexeTarget, branch: string) {
   assert.ok(env.CIRCLE_TOKEN)
-  const circle = `https://circleci.com/api/v1.1/project/github/nexe/nexe/tree/${branch}?circle-token=${
-    env.CIRCLE_TOKEN
-  }`
+  const circle = `https://circleci.com/api/v1.1/project/github/nexe/nexe/tree/${
+    branch
+  }?circle-token=${env.CIRCLE_TOKEN}`
   return got(circle, {
     json: true,
     body: {

yarn.lock

@@ -509,6 +509,10 @@ commander@~2.11.0:
   version "2.11.0"
   resolved "https://registry.yarnpkg.com/commander/-/commander-2.11.0.tgz#157152fd1e7a6c8d98a5b715cf376df928004563"
 
+commander@~2.13.0:
+  version "2.13.0"
+  resolved "https://registry.yarnpkg.com/commander/-/commander-2.13.0.tgz#6964bca67685df7c1f1430c584f07d7597885b9c"
+
 commander@~2.8.1:
   version "2.8.1"
   resolved "https://registry.yarnpkg.com/commander/-/commander-2.8.1.tgz#06be367febfda0c330aa1e2a072d3dc9762425d4"
@@ -2165,10 +2169,6 @@ performance-now@^2.1.0:
   version "2.1.0"
   resolved "https://registry.yarnpkg.com/performance-now/-/performance-now-2.1.0.tgz#6309f4e0e5fa913ec1c69307ae364b4b377c9e7b"
 
-pifi@1.0.0:
-  version "1.0.0"
-  resolved "https://registry.yarnpkg.com/pifi/-/pifi-1.0.0.tgz#158f770bb5f62724dd612b92fc2c2c59a53d7e2f"
-
 pify@^2.0.0, pify@^2.3.0:
   version "2.3.0"
   resolved "https://registry.yarnpkg.com/pify/-/pify-2.3.0.tgz#ed141a6ac043a849ea588498e7dca8b15330e90c"
@@ -2634,7 +2634,7 @@ source-map@0.5.x, source-map@^0.5.6, source-map@~0.5.1, source-map@~0.5.6:
   version "0.5.7"
   resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc"
 
-source-map@^0.6.1:
+source-map@^0.6.1, source-map@~0.6.1:
   version "0.6.1"
   resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263"
 
@@ -2872,6 +2872,13 @@ ua-parser-js@^0.7.9:
   version "0.7.17"
   resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.17.tgz#e9ec5f9498b9ec910e7ae3ac626a805c4d09ecac"
 
+uglify-es@^3.3.9:
+  version "3.3.9"
+  resolved "https://registry.yarnpkg.com/uglify-es/-/uglify-es-3.3.9.tgz#0c1c4f0700bed8dbc124cdb304d2592ca203e677"
+  dependencies:
+    commander "~2.13.0"
+    source-map "~0.6.1"
+
 uglify-js@3.0.28:
   version "3.0.28"
   resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.0.28.tgz#96b8495f0272944787b5843a1679aa326640d5f7"