We don't need to terminate them manually after the call. Remove all that paranoid code, which in some cases was even wrong. While at it, let's do a few more things: - Use sizeof(buf) for the size of the buffer. I found that a few cases were passing one less byte (probably because the last one was manually zeroed later). This caused a double NUL. snprintf(3) wants the size of the entire buffer to properly terminate it. Passing the exact value hardcoded is brittle, so use sizeof(). - Align and improve style of variable declarations. This makes them appear in this diff, which will help review the patch. Signed-off-by: Alejandro Colomar <alx@kernel.org>
shadow-utils
Introduction
The shadow-utils package includes the necessary programs for converting UNIX password files to the shadow password format, plus programs for managing user and group accounts. The pwconv command converts passwords to the shadow password format. The pwunconv command unconverts shadow passwords and generates a passwd file (a standard UNIX password file). The pwck command checks the integrity of password and shadow files. The lastlog command prints out the last login times for all users. The useradd, userdel, and usermod commands are used for managing user accounts. The groupadd, groupdel, and groupmod commands are used for managing group accounts.
Sites
Code
The main development branch is at https://github.com/shadow-maint/shadow.git
See STABLE.md for a list of supported stable branches.
Contacts
There are several ways to contact us:
- the general discussion mailing list
- the #shadow IRC channel on libera.chat:
- irc://irc.libera.chat/shadow
Mailing archives
- the general discussion mailing list archive
- the commit mailing list archive, only used for historical purposes
Contributions
Contributions are welcome. Follow the guidelines before posting any patches.
Authors and maintainers
Authors and maintainers are listed in AUTHORS.md.