VesperOS/shadow
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid usage of sprintf

Browse Source 
sprintf(3) does not take the destination buffer into account. Although
the destination in these case is large enough, sprintf(3) indicates a
code smell.

Use snprintf(3).
This commit is contained in:
Christian Göttsche
2023-08-21 16:04:09 -05:00
committed by Serge Hallyn
parent e0d3ba6934
commit f76c31f50e
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/subordinateio.c
+5 -2
View File
@@ -222,7 +222,8 @@ static const struct subordinate_range *find_range(struct commonio_db *db,
*/
struct passwd *pwd;
uid_t owner_uid;
char owner_uid_string[33] = "";
char owner_uid_string[33];
int ret;
/* Get UID of the username we are looking for */
@@ -232,7 +233,9 @@ static const struct subordinate_range *find_range(struct commonio_db *db,
return NULL;
}
owner_uid = pwd->pw_uid;
sprintf(owner_uid_string, "%lu", (unsigned long int)owner_uid);
ret = snprintf(owner_uid_string, sizeof (owner_uid_string), "%lu", (unsigned long int)owner_uid);
if (ret < 0 || (size_t)ret >= sizeof (owner_uid_string))
return NULL;
commonio_rewind(db);
while ((range = commonio_next(db)) != NULL) {