VesperOS/shadow
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

src/sulogin.c: Use a do-while loop

Browse Source 
Clarify how this endless while(true) loop can be stopped by using a
boolean variable as condition and turn it into a do-while loop.

Suggested-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Samanta Navarro <ferivoz@riseup.net>
This commit is contained in:
Samanta Navarro
2024-01-19 11:53:53 +00:00
committed by Alejandro Colomar
parent f98e43ee11
commit cb42ee620e
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/sulogin.c
View File

@@ -64,6 +64,7 @@ main(int argc, char **argv)
char **envp = environ;
TERMIO termio;
struct passwd pwent = {};
bool done;
#ifndef USE_PAM
const char *env;
#endif
@@ -133,7 +134,7 @@ main(int argc, char **argv)
(void) signal (SIGALRM, catch_signals); /* exit if the timer expires */
(void) alarm (ALARM); /* only wait so long ... */
while (true) { /* repeatedly get login/password pairs */
do { /* repeatedly get login/password pairs */
char *cp;
if (pw_entry("root", &pwent) == -1) { /* get entry from password file */
/*
@@ -170,13 +171,13 @@ main(int argc, char **argv)
STRTCPY(pass, cp);
erase_pass (cp);
if (valid (pass, &pwent)) { /* check encrypted passwords ... */
break; /* ... encrypted passwords matched */
done = valid(pass, &pwent);
if (!done) { /* check encrypted passwords ... */
/* ... encrypted passwords did not match */
sleep (2);
(void) puts (_("Login incorrect"));
}
sleep (2);
(void) puts (_("Login incorrect"));
}
} while (!done);
MEMZERO(pass);
(void) alarm (0);
(void) signal (SIGALRM, SIG_DFL);