Use temporary variable
- Use the temporary variable more, as it helps readability: it removes a derefecence, which itself allows removing some parentheses. - Use a shorter name, which is more common with temporaries, and so there's less to read. - Assign to *ranges at the end of the function. It's the same, but with the other changes, I think this makes it slightly clearer. Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
committed by
Serge Hallyn
parent
f2ac1e2540
commit
787ea57a18
+7
-6
@@ -315,15 +315,16 @@ static bool have_range(struct commonio_db *db,
|
||||
|
||||
static bool append_range(struct subid_range **ranges, const struct subordinate_range *new, int n)
|
||||
{
|
||||
struct subid_range *alloced;
|
||||
struct subid_range *sr;
|
||||
|
||||
alloced = REALLOC(*ranges, n + 1, struct subid_range);
|
||||
if (!alloced)
|
||||
sr = REALLOC(*ranges, n + 1, struct subid_range);
|
||||
if (!sr)
|
||||
return false;
|
||||
*ranges = alloced;
|
||||
|
||||
(*ranges)[n].start = new->start;
|
||||
(*ranges)[n].count = new->count;
|
||||
sr[n].start = new->start;
|
||||
sr[n].count = new->count;
|
||||
*ranges = sr;
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user