src/usermod.c: update_group_file(): Fix RESOURCE_LEAK (CWE-772)
Report: > shadow-4.15.0/src/usermod.c:734:3: alloc_fn: Storage is returned from allocation function "__gr_dup". > shadow-4.15.0/src/usermod.c:734:3: var_assign: Assigning: "ngrp" = storage returned from "__gr_dup(grp)". > shadow-4.15.0/src/usermod.c:815:1: leaked_storage: Variable "ngrp" going out of scope leaks the storage it points to. > 813| gr_free(ngrp); > 814| } > 815|-> } > 816| > 817| #ifdef SHADOWGRP Link: https://issues.redhat.com/browse/RHEL-35383 Reported-by: Iker Pedrosa <ipedrosa@redhat.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
committed by
Iker Pedrosa
parent
81bc78ec5c
commit
61964aa06b
+3
-3
@@ -780,9 +780,8 @@ update_group_file(void)
|
||||
SYSLOG ((LOG_INFO, "add '%s' to group '%s'",
|
||||
user_newname, ngrp->gr_name));
|
||||
}
|
||||
if (!changed) {
|
||||
continue;
|
||||
}
|
||||
if (!changed)
|
||||
goto free_ngrp;
|
||||
|
||||
changed = false;
|
||||
if (gr_update (ngrp) == 0) {
|
||||
@@ -793,6 +792,7 @@ update_group_file(void)
|
||||
fail_exit (E_GRP_UPDATE);
|
||||
}
|
||||
|
||||
free_ngrp:
|
||||
gr_free(ngrp);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user