VesperOS/shadow
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

src/sulogin.c: Free previously allocated memory

Browse Source 
The sulogin program calls pw_entry in a loop while incorrect root
passwords are entered.

Free the previously allocated memory to avoid memory exhaustion.

Co-developed-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Samanta Navarro <ferivoz@riseup.net>
This commit is contained in:
Samanta Navarro
2024-01-18 11:53:41 +00:00
committed by Serge Hallyn
parent 08ae7af111
commit 4d835c7ea4
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/sulogin.c
View File

@@ -199,22 +199,29 @@ pw_entry(const char *name, struct passwd *pwent)
struct passwd *passwd;
if (!(passwd = getpwnam(name))) { /* local, no need for xgetpwnam */
free(pwent->pw_name);
pwent->pw_name = NULL;
return;
}
free(pwent->pw_name);
pwent->pw_name = xstrdup(passwd->pw_name);
pwent->pw_uid = passwd->pw_uid;
pwent->pw_gid = passwd->pw_gid;
free(pwent->pw_gecos);
pwent->pw_gecos = xstrdup(passwd->pw_gecos);
free(pwent->pw_dir);
pwent->pw_dir = xstrdup(passwd->pw_dir);
free(pwent->pw_shell);
pwent->pw_shell = xstrdup(passwd->pw_shell);
#if !defined(AUTOSHADOW)
/* local, no need for xgetspnam */
if ((spwd = getspnam(name))) {
free(pwent->pw_passwd);
pwent->pw_passwd = xstrdup(spwd->sp_pwdp);
return;
}
#endif
free(pwent->pw_passwd);
pwent->pw_passwd = xstrdup(passwd->pw_passwd);
}