VesperOS/shadow
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/getdef.c: getdef_unum(): Fix wrong limit check

Browse Source 
The limit, since it's an unsigned int, should have been UINT_MAX, not
INT_MAX.  By calling a2ui() we can fix that and simplify too.

Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
Alejandro Colomar
2024-07-02 22:52:31 +02:00
parent 9415ce4a14
commit 45d4472c92
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/getdef.c
+5 -6
View File
@@ -268,10 +268,11 @@ getdef_num(const char *item, int dflt)
* values are handled.
*/
unsigned int getdef_unum (const char *item, unsigned int dflt)
unsigned int
getdef_unum(const char *item, unsigned int dflt)
{
struct itemdef *d;
long val;
unsigned int val;
struct itemdef *d;
if (!def_loaded) {
def_load ();
@@ -282,9 +283,7 @@ unsigned int getdef_unum (const char *item, unsigned int dflt)
return dflt;
}
if ( (str2sl(&val, d->value) == -1)
|| (val < 0)
|| (val > INT_MAX)) {
if (a2ui(&val, d->value, NULL, 0, 0, UINT_MAX) == -1) {
fprintf (shadow_logfd,
_("configuration error - cannot parse %s value: '%s'"),
item, d->value);