VesperOS/shadow
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/pwauth.c: Simplify empty string

Browse Source 
And do not set 'clear' to point to the empty string.  After this commit,
'clear' only stores the result of getpass(3).  This will be useful to
change the code to use agetpass().

$ grep '\<clear\>' lib/pwauth.c;
	char *clear = NULL;
		clear = getpass (prompt);
		input = (clear == NULL) ? "" : clear;
		clear = getpass (prompt);
		input = (clear == NULL) ? "" : clear;
	if (NULL != clear) {
		strzero (clear);

Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
Alejandro Colomar
2023-09-04 08:57:18 -05:00
committed by Serge Hallyn
parent adbdd086a2
commit 158866bfdc
1 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/pwauth.c
+2 -14
View File
@@ -138,13 +138,7 @@ int pw_auth (const char *cipher,
snprintf (prompt, sizeof prompt, cp, user);
clear = getpass (prompt);
if (NULL == clear) {
static char c[1];
c[0] = '\0';
clear = c;
}
input = clear;
input = (clear == NULL) ? "" : clear;
}
/*
@@ -171,13 +165,7 @@ int pw_auth (const char *cipher,
*/
if ((0 != retval) && ('\0' == input[0]) && use_skey) {
clear = getpass (prompt);
if (NULL == clear) {
static char c[1];
c[0] = '\0';
clear = c;
}
input = clear;
input = (clear == NULL) ? "" : clear;
}
if ((0 != retval) && use_skey) {