VesperOS/gnome-shell-extensions
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

window-list: Minor clean-up

Browse Source 
Modern javascript has explicit methods for locating the first
element of an array that meets a certain condition, use those
instead of manually looping over the array.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/78
This commit is contained in:
Florian Müllner
2018-10-06 17:43:23 +02:00
committed by Florian Müllner
parent c0454db0c6
commit d424b0f645
1 changed files with 11 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
extensions/window-list/extension.js
View File

@@ -899,16 +899,9 @@ class WindowList {
return;
let children = this._windowList.get_children().map(a => a._delegate);
let active = 0;
for (let i = 0; i < children.length; i++) {
if (children[i].active) {
active = i;
break;
}
}
active = Math.max(0, Math.min(active + diff, children.length-1));
children[active].activate();
let active = children.findIndex(c => c.active);
let newActive = Math.max(0, Math.min(active + diff, children.length-1));
children[newActive].activate();
}
_updatePosition() {
@@ -1023,12 +1016,9 @@ class WindowList {
_removeApp(app) {
let children = this._windowList.get_children();
for (let i = 0; i < children.length; i++) {
if (children[i]._delegate.app == app) {
children[i].destroy();
return;
}
}
let child = children.find(c => c._delegate.app == app);
if (child)
child.destroy();
}
_onWindowAdded(ws, win) {
@@ -1042,10 +1032,8 @@ class WindowList {
return;
let children = this._windowList.get_children();
for (let i = 0; i < children.length; i++) {
if (children[i]._delegate.metaWindow == win)
return;
}
if (children.find(c => c._delegate.metaWindow == win))
return;
let button = new WindowButton(win, this._perMonitor, this._monitor.index);
this._windowList.layout_manager.pack(button.actor,
@@ -1065,12 +1053,9 @@ class WindowList {
return; // not actually removed, just moved to another workspace
let children = this._windowList.get_children();
for (let i = 0; i < children.length; i++) {
if (children[i]._delegate.metaWindow == win) {
children[i].destroy();
return;
}
}
let child = children.find(c => c._delegate.metaWindow == win);
if (child)
child.destroy();
}
_onWorkspacesChanged() {