Don't change status when cancelled downloads fail

It takes a bit of time to actually pause (i.e. cancel) a download. If
we change the update status once the download is actually cancelled,
we might override any status change that happened between the user
request and its completion. For example, the following can happen when
the user deletes an ongoing downloads:

 - pauseDownload(): DOWNLOADING -> PAUSED
 - deleteUpdate(): PAUSED -> DELETED
 - onFailure(): DELETED -> PAUSED

Don't change the status of cancelled downloads from the onFailure()
callback not to have an incorrect final status.

Change-Id: Iee90482d82df984672c59d7c508ad834fa08061f
This commit is contained in:
Gabriele M
2017-08-18 14:31:54 +02:00
parent 4c5dd9c391
commit 87202371de

View File

@@ -195,7 +195,6 @@ public class UpdaterController implements Controller {
Update update = mDownloads.get(downloadId).mUpdate;
if (cancelled) {
Log.d(TAG, "Download cancelled");
update.setStatus(UpdateStatus.PAUSED);
// Already notified
} else {
Log.e(TAG, "Download failed");