33dd4fab9d
The Extensible and Extensible::Private classes contain pointers to each other. These pointers are initialized in the respective class's constructor, by passing a pointer to the other class to each constructor. This particular construct reduces the flexibility of the Extensible pattern, as the Private class instance has to be allocated and constructed in the members initializer list of the Extensible class's constructor. It is thus impossible to perform any operation on the Private class between its construction and the construction of the Extensible class, or to subclass the Private class without subclassing the Extensible class. To make the design pattern more flexible, don't pass the pointer to the Extensible class to the Private class's constructor, but initialize the pointer manually in the Extensible class's constructor. This requires a const_cast as the o_ member of the Private class is const. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
66 lines
1.2 KiB
C++
66 lines
1.2 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2020, Google Inc.
|
|
*
|
|
* framebuffer.h - Internal frame buffer handling
|
|
*/
|
|
#ifndef __LIBCAMERA_INTERNAL_FRAMEBUFFER_H__
|
|
#define __LIBCAMERA_INTERNAL_FRAMEBUFFER_H__
|
|
|
|
#include <sys/mman.h>
|
|
#include <vector>
|
|
|
|
#include <libcamera/base/class.h>
|
|
#include <libcamera/base/span.h>
|
|
|
|
#include <libcamera/framebuffer.h>
|
|
|
|
namespace libcamera {
|
|
|
|
class MappedBuffer
|
|
{
|
|
public:
|
|
using Plane = Span<uint8_t>;
|
|
|
|
~MappedBuffer();
|
|
|
|
MappedBuffer(MappedBuffer &&other);
|
|
MappedBuffer &operator=(MappedBuffer &&other);
|
|
|
|
bool isValid() const { return error_ == 0; }
|
|
int error() const { return error_; }
|
|
const std::vector<Plane> &maps() const { return maps_; }
|
|
|
|
protected:
|
|
MappedBuffer();
|
|
|
|
int error_;
|
|
std::vector<Plane> maps_;
|
|
|
|
private:
|
|
LIBCAMERA_DISABLE_COPY(MappedBuffer)
|
|
};
|
|
|
|
class MappedFrameBuffer : public MappedBuffer
|
|
{
|
|
public:
|
|
MappedFrameBuffer(const FrameBuffer *buffer, int flags);
|
|
};
|
|
|
|
class FrameBuffer::Private : public Extensible::Private
|
|
{
|
|
LIBCAMERA_DECLARE_PUBLIC(FrameBuffer)
|
|
|
|
public:
|
|
Private();
|
|
|
|
void setRequest(Request *request) { request_ = request; }
|
|
|
|
private:
|
|
Request *request_;
|
|
};
|
|
|
|
} /* namespace libcamera */
|
|
|
|
#endif /* __LIBCAMERA_INTERNAL_FRAMEBUFFER_H__ */
|